Image_Transform_Driver_Imagick3 - Code Metrics - Inspection of "update for PayPal" - mambax7/extgallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 603564...3d1dbb )

by Michael

created 2017-03-29 08:32 UTC

Image_Transform_Driver_Imagick3 B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	392
Duplicated Lines	22.96 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	90
loc	392
rs	8.3999
c	0
b	0
f	0
wmc	46
lcom	1
cbo	2

15 Methods

Rating	Name	Duplication	Size	Complexity
A	Image_Transform_Driver_Imagick3()	0	4	1
A	__construct()	0	9	2
A	load()	0	21	3
A	_resize()	0	18	3
B	rotate()	0	23	4
B	addText()	5	32	5
C	save()	34	34	8
C	display()	30	30	7
A	gamma()	0	6	2
A	crop()	21	21	3
A	greyscale()	0	8	1
A	mirror()	0	10	2
A	flip()	0	11	2
A	free()	0	7	2
A	raiseError()	0	4	1

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Image_Transform_Driver_Imagick3 often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Image_Transform_Driver_Imagick3, and based on these observations, apply Extract Interface, too.

<?php


/* vim: set expandtab tabstop=4 shiftwidth=4: */

/**
 * imagick PECL extension implementation for Image_Transform package
 *
 * PHP version 5
 *
 * LICENSE: This source file is subject to version 3.0 of the PHP license
 * that is available through the world-wide-web at the following URI:
 * http://www.php.net/license/3_0.txt.  If you did not receive a copy of
 * the PHP License and are unable to obtain it through the web, please
 * send a note to [email protected] so we can mail you a copy immediately.
 *
 * @category   Image
 * @package    Image_Transform
 * @subpackage Image_Transform_Driver_Imagick3
 * @author     Philippe Jausions <[email protected]>
 * @copyright  2007 The PHP Group
 * @license    http://www.php.net/license/3_0.txt  PHP License 3.0
 * @version    CVS: $Id: Imagick3.php 266908 2008-10-01 21:11:07Z dufuz $
 * @link       http://pear.php.net/package/Image_Transform
 */

require_once 'Image/Transform.php';

/**
 * imagick PECL extension implementation for Image_Transform package
 *
 * For use of version 2+ of the extension. For version 0.9.* use Imagick2 driver
 * instead
 *
 * @category   Image
 * @package    Image_Transform
 * @subpackage Image_Transform_Driver_Imagick3
 * @author     Philippe Jausions <[email protected]>
 * @copyright  2007 The PHP Group
 * @license    http://www.php.net/license/3_0.txt  PHP License 3.0
 * @version    Release: @package_version@
 * @link       http://pear.php.net/package/Image_Transform
 * @since      0.9.2
 * @since      PHP 5.1.3
 * @since      PECL Imagick 2.0.0a1
 */
class Image_Transform_Driver_Imagick3 extends Image_Transform
namespace YourVendor;

class YourClass { }
{
    /**
     * Instance of imagick
     * @var Imagick
     */
    var $imagick = null;
class A {
    var $property;
}

    /**
     * Handler of the image resource before
     * the last transformation
     * @var array
     */
    var $oldImage;
class A {
    var $property;
}

    /**
     * @see __construct()
     */
    function Image_Transform_Driver_Imagick3()

    {
        $this->__construct();
    }

    /**
     * @see http://www.imagemagick.org/www/formats.html
     */
    function __construct()

    {
        if (PEAR::loadExtension('imagick')) {
            include 'Image/Transform/Driver/Imagick/ImageTypes.php';
        } else {
            $this->isError(PEAR::raiseError('Could not find the imagick extension.',

                IMAGE_TRANSFORM_ERROR_UNSUPPORTED));
        }
    }

    /**
     * Loads an image
     *
     * @param string $image filename
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error
     * @access public
     */
    function load($image)

    {
        $this->free();
        $this->imagick = new Imagick();
        try {
            $this->imagick->readImage($image);

        } catch (ImagickException $e) {
            $this->free();
            return $this->raiseError('Could not load image:'.$e->getMessage(),
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_IO);
        }

        $this->image = $image;
        $result = $this->_get_image_details($image);
        if (PEAR::isError($result)) {
            return $result;
        }

        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Resizes the image
     *
     * @param integer $new_x   New width
     * @param integer $new_y   New height
     * @param mixed $options Optional parameters
     * <ul>
     *  <li>'scaleMethod': "pixel" or "smooth"</li>
     * </ul>
     *
     * @return bool|PEAR_Error TRUE or PEAR_Error object on error

     * @access protected
     */
    function _resize($new_x, $new_y, $options = null)

    {
        try {
            $scaleMethod = $this->_getOption('scaleMethod', $options, 'smooth');
            $blur = ($scaleMethod == 'pixel') ? 0 : 1;
            $this->imagick->resizeImage($new_x, $new_y,
                                        imagick::FILTER_UNDEFINED, $blur);

        } catch (ImagickException $e) {
            return $this->raiseError('Could not resize image.',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
        }

        $this->new_x = $new_x;
        $this->new_y = $new_y;
        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

    } // End resize

    /**
     * Rotates the current image
     *
     * @param float $angle Rotation angle in degree
     * @param array $options Supported options:

     * <ul>
     *  <li>'canvasColor' : array(r ,g, b), named color or #rrggbb</li>
     * </ul>
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function rotate($angle, $options = null)

    {
        if (($angle % 360) == 0) {
            return true;
        }
        $color = $this->_getColor('canvasColor', $options, array(255, 255, 255));

        if (is_array($color)) {
            $color = $this->colorarray2colorhex($color);
        }
        $pixel = new ImagickPixel($color);
        try {
            $this->imagick->rotateImage($pixel, $angle);

        } catch (ImagickException $e) {
            return $this->raiseError('Cannot create a new imagick image for the rotation: '.$e->getMessage(),
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
        }
        $info = $this->imagick->getImageGeometry();
        $this->new_x = $info['width'];
        $this->new_y = $info['height'];
        return true;

    } // End rotate

    /**
     * Adds text to the image
     *
     * @param   array   $params Array contains options:
     * <ul>
     *  <li>'text' (string) The string to draw</li>
     *  <li>'x'    (integer) Horizontal position</li>
     *  <li>'y'    (integer) Vertical Position</li>
     *  <li>'Color' (mixed) Font color</li>
     *  <li>'font' (string) Font to be used</li>
     *  <li>'size' (integer) Size of the fonts in pixel</li>
     * </ul>
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function addText($params)

    {
        $this->oldImage = clone $this->imagick;

        $params = array_merge($this->_get_default_text_params(), $params);

        if (is_array($params['color'])) {

            $params['color'] = $this->colorarray2colorhex($params['color']);
        } else {
            $params['color'] = strtolower($params['color']);
        }

        static $cmds = array(
            'setFillColor' => 'color',
            'setFontSize'  => 'size',
            'setFontFace'  => 'font'
        );
        $this->imagick->beginDraw();

        foreach ($cmds as $cmd => $v) {
            if (!$this->imagick->$cmd($params[$v])) {
                return $this->raiseError("Problem with adding Text::{$v} = {$params[$v]}",
                    IMAGE_TRANSFORM_ERROR_FAILED);
            }
        }
        if (!$this->imagick->drawAnnotation($params['x'], $params['y'], $params['text'])) {
            return $this->raiseError('Problem with adding Text',
                IMAGE_TRANSFORM_ERROR_FAILED);
        }

        return true;

    } // End addText


    /**
     * Saves the image to a file
     *
     * @param $filename string the name of the file to write to
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function save($filename, $type = '', $quality = null)

    {
        $options = (is_array($quality)) ? $quality : array();
        if (is_numeric($quality)) {
            $options['quality'] = $quality;
        }
        $quality = $this->_getOption('quality', $options, 75);
        $this->imagick->setImageCompression($quality);

        if ($type && strcasecmp($type, $this->type)) {
            try {
                $this->imagick->setImageFormat($type);

            } catch (ImagickException $e) {
                return $this->raiseError('Could not save image to file (conversion failed).',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
            }
        }

        try {
            $this->imagick->writeImage($filename);

        } catch (ImagickException $e) {
            return $this->raiseError('Could not save image to file: '.$e->getMessage(),
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_IO);
        }

        if (!$this->keep_settings_on_save) {
            $this->free();
        }

        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

    } // End save

    /**
     * Displays image without saving and lose changes
     *
     * This method adds the Content-type HTTP header
     *
     * @param string type (JPG,PNG...);
     * @param int quality 75
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function display($type = '', $quality = null)

    {
        $options = (is_array($quality)) ? $quality : array();
        if (is_numeric($quality)) {
            $options['quality'] = $quality;
        }
        $quality = $this->_getOption('quality', $options, 75);
        $this->imagick->setImageCompression($quality);

        if ($type && strcasecmp($type, $this->type)) {
            try {
                $this->imagick->setImageFormat($type);

            } catch (ImagickException $e) {
                return $this->raiseError('Could not save image to file (conversion failed).',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
            }
        }
        try {
            $image = $this->imagick->getImageBlob();

        } catch (ImagickException $e) {
            return $this->raiseError('Could not display image.',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_IO);
        }
        header('Content-type: ' . $this->getMimeType($type));
        echo $image;
        $this->free();
        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Adjusts the image gamma
     *
     * @param float $outputgamma
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error
     * @access public
     */
    function gamma($outputgamma = 1.0) {

        if ($outputgamma != 1.0) {
            $this->imagick->setImageGamma($outputgamma);
        }
        return true;
    }

    /**
     * Crops the image
     *
     * @param integer $width Cropped image width
     * @param integer $height Cropped image height
     * @param integer $x X-coordinate to crop at
     * @param integer $y Y-coordinate to crop at
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error
     * @access public
     */
    function crop($width, $height, $x = 0, $y = 0)

    {
        // Sanity check
        if (!$this->intersects($width, $height, $x, $y)) {
            return PEAR::raiseError('Nothing to crop', IMAGE_TRANSFORM_ERROR_OUTOFBOUND);

        }
        try {
            $this->imagick->cropImage($width, $height, $x, $y);

        } catch (ImagickException $e) {
            return $this->raiseError('Could not crop image',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
        }

        // I think that setting img_x/y is wrong, but scaleByLength() & friends
        // mess up the aspect after a crop otherwise.
        $this->new_x = $width;
        $this->new_y = $height;

        return true;
    }

    /**
     * Converts the image to greyscale
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error
     * @access public
     */
    function greyscale() {

        $this->imagick->setImageType(Imagick::IMGTYPE_GRAYSCALE);
        /*$this->imagick->setImageColorSpace(Imagick::COLORSPACE_GRAY);

        $this->imagick->setImageDepth(8);
        $this->imagick->separateImageChannel(Imagick::CHANNEL_GRAY);
        $this->imagick->setImageChannelDepth(Imagick::CHANNEL_GRAY, 8);*/
        return true;
    }

    /**
     * Horizontal mirroring
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function mirror()

    {
        try {
            $this->imagick->flopImage();
        } catch (ImagickException $e) {
            return $this->raiseError('Could not mirror the image.',
                IMAGE_TRANSFORM_ERROR_FAILED);
        }
        return true;
    }

    /**
     * Vertical mirroring
     *
     * @return bool|PEAR_Error TRUE or a PEAR_Error object on error

     * @access public
     */
    function flip()

    {
        try {
            $this->imagick->flipImage();

        } catch (ImagickException $e) {
            return $this->raiseError('Could not flip the image.',
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                IMAGE_TRANSFORM_ERROR_FAILED);
        }
        return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Destroy image handle
     *
     * @access public
     */
    function free()

    {
        if (isset($this->imagick)) {
            $this->imagick->destroy();
            $this->imagick = null;
        }
    }

    /**
     * RaiseError Method - shows imagick Raw errors.
     *
     * @param string $message message = prefixed message..
     * @param int    $code error code
     * @return PEAR error object
     * @access protected
     */
    function raiseError($message, $code = 0)

    {
        return PEAR::raiseError($message, $code);

    }
}

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-03-29 08:35 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 46 and the first side effect is on line 26. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3			/* vim: set expandtab tabstop=4 shiftwidth=4: */
4
5			/**
6			* imagick PECL extension implementation for Image_Transform package
7			*
8			* PHP version 5
9			*
10			* LICENSE: This source file is subject to version 3.0 of the PHP license
11			* that is available through the world-wide-web at the following URI:
12			* http://www.php.net/license/3_0.txt. If you did not receive a copy of
13			* the PHP License and are unable to obtain it through the web, please
14			* send a note to [email protected] so we can mail you a copy immediately.
15			*
16			* @category Image
17			* @package Image_Transform
18			* @subpackage Image_Transform_Driver_Imagick3
19			* @author Philippe Jausions <[email protected]>
20			* @copyright 2007 The PHP Group
21			* @license http://www.php.net/license/3_0.txt PHP License 3.0
22			* @version CVS: $Id: Imagick3.php 266908 2008-10-01 21:11:07Z dufuz $
23			* @link http://pear.php.net/package/Image_Transform
24			*/
25
26			require_once 'Image/Transform.php';
27
28			/**
29			* imagick PECL extension implementation for Image_Transform package
30			*
31			* For use of version 2+ of the extension. For version 0.9.* use Imagick2 driver
32			* instead
33			*
34			* @category Image
35			* @package Image_Transform
36			* @subpackage Image_Transform_Driver_Imagick3
37			* @author Philippe Jausions <[email protected]>
38			* @copyright 2007 The PHP Group
39			* @license http://www.php.net/license/3_0.txt PHP License 3.0

mambax7 / extgallery