ExtgalleryPhotoHandler::_mediumPhotoTreatment() - Code Metrics - Inspection of "/>" - mambax7/extgallery - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f87886...b3b862 )

by Michael

created 2017-07-22 00:33 UTC

ExtgalleryPhotoHandler::_mediumPhotoTreatment() C

↳ Parent: ExtgalleryPhotoHandler

Complexity

Conditions	10
Paths	80

Size

Total Lines	47
Code Lines	27

Duplication

Lines	3
Ratio	6.38 %

Importance

Changes

Metric	Value
cc	10
eloc	27
nc	80
nop	3
dl	3
loc	47
rs	5.1578
c	0
b	0
f	0

How to fix Complexity

<?php

/**
 * ExtGallery Class Manager
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright   {@link https://xoops.org/ XOOPS Project}
 * @license     GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
 * @author      Zoullou (http://www.zoullou.net)
 * @package     ExtGallery
 */

// defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');


require_once __DIR__ . '/publicPerm.php';
require_once __DIR__ . '/ExtgalleryPersistableObjectHandler.php';

/**
 * Class ExtgalleryPhoto
 */
class ExtgalleryPhoto extends XoopsObject
namespace YourVendor;

class YourClass { }
{
    public $externalKey = array();

    /**
     * ExtgalleryPhoto constructor.
     */
    public function __construct()
    {
        parent::__construct();
        $this->initVar('photo_id', XOBJ_DTYPE_INT, null, false);
        $this->initVar('cat_id', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_title', XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar('photo_desc', XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar('photo_serveur', XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar('photo_name', XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar('photo_orig_name', XOBJ_DTYPE_TXTBOX, '', false, 255);
        $this->initVar('uid', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_size', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_res_x', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_res_y', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_hits', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_comment', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_rating', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_nbrating', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_download', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_ecard', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_date', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_havelarge', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_approved', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('photo_extra', XOBJ_DTYPE_TXTAREA, '', false);
        $this->initVar('photo_weight', XOBJ_DTYPE_INT, 0, false);
        $this->initVar('dohtml', XOBJ_DTYPE_INT, 0, false);

        $this->externalKey['cat_id'] = array(
            'className'      => 'publiccat',
            'getMethodeName' => 'getCat',
            'keyName'        => 'cat',
            'core'           => false
        );
        $this->externalKey['uid']    = array(
            'className'      => 'user',
            'getMethodeName' => 'get',
            'keyName'        => 'user',
            'core'           => true
        );
    }

    /**
     * @param $key
     *
     * @return mixed
     */
    public function getExternalKey($key)
    {
        return $this->externalKey[$key];
    }
}

/**
 * Class ExtgalleryPhotoHandler
 */
class ExtgalleryPhotoHandler extends ExtgalleryPersistableObjectHandler
namespace YourVendor;

class YourClass { }
{
    public $photoUploader = null;

    /**
     * @param $db
     * @param $type
     */
    public function __construct(XoopsDatabase $db, $type)
    {
        parent::__construct($db, 'extgallery_' . $type . 'photo', 'Extgallery' . ucfirst($type) . 'Photo', 'photo_id');
    }

    /**
     * @param $data
     *
     * @return bool
     */
    public function createPhoto($data)
    {
        $photo = $this->create();
        $photo->setVars($data);

        return $this->insert($photo, true);
    }

    /**
     * @param $photoId
     * @param $data
     *
     * @return bool
     */
    public function modifyPhoto($photoId, $data)
    {
        $photo = $this->get($photoId);
        $photo->setVars($data);

        return $this->insert($photo, true);
    }

    /**
     * @param $photo
     */
    public function deletePhoto(&$photo)
    {
        if ($photo->getVar('photo_serveur') == '') {
            $this->deleteFile($photo);
        }
        $this->deleteById($photo->getVar('photo_id'), true);
    }

    /**
     * @param $catId
     */
    public function deletePhotoByCat($catId)
    {
        $criteria = new Criteria('cat_id', $catId);
        $photos   = $this->getObjects($criteria);
        foreach ($photos as $photo) {
            $this->deletePhoto($photo);
        }
    }

    public function deleteFile()
    {
        exit('deleteFile() method must be defined on sub classes');

    }

    /**
     * @param $photoId
     *
     * @return bool
     */
    public function getPhoto($photoId)

    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('photo_id', $photoId));
        $criteria->add(new Criteria('photo_approved', 1));

        $photo = $this->getObjects($criteria);
        if (count($photo) != 1) {
            return false;
        }

        return $photo[0];
    }

    /**
     * @param $cat
     *
     * @return int
     */
    public function nbPhoto(&$cat)
    {
        $criteria = new Criteria('cat_id', $cat->getVar('cat_id'));

        return $this->getCount($criteria);
    }

    /**
     * @param $catId
     * @param $start
     * @param $sortby
     * @param $orderby
     *
     * @return array
     */
    public function getAlbumPhotoPage($catId, $start, $sortby, $orderby)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->setStart($start);
        $criteria->setLimit($GLOBALS['xoopsModuleConfig']['nb_column'] * $GLOBALS['xoopsModuleConfig']['nb_line']);
        if ($criteria->getSort() == '') {
            $criteria->setSort($sortby);
            $criteria->setOrder($orderby);
        }

        return $this->getObjects($criteria);
    }

    /**
     * @param $catId
     * @param $start
     *
     * @return array
     */
    public function getAlbumPhotoAdminPage($catId, $start)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->setStart($start);
        $criteria->setLimit($GLOBALS['xoopsModuleConfig']['admin_nb_photo']);
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder($GLOBALS['xoopsModuleConfig']['display_set_order']);

        return $this->getObjects($criteria);
    }

    /**
     * @param $catId
     *
     * @return array
     */
    public function getSlideshowAlbumPhoto($catId)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder($GLOBALS['xoopsModuleConfig']['display_set_order']);

        return $this->getObjects($criteria, false, false);
    }

    /**
     * @param $catId
     *
     * @return array
     */
    public function getPhotoAlbumId($catId)

    {
        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_approved', 1));

        $sql = 'SELECT photo_id FROM ' . $this->db->prefix('extgallery_publicphoto') . ' ' . $criteria->renderWhere()
               . ' ORDER BY photo_weight, photo_id ASC;';

        $result = $this->db->query($sql);
        $ret    = array();
        while (false !== ($myrow = $this->db->fetchArray($result))) {
            $ret[] = $myrow['photo_id'];
        }

        return $ret;
    }

    /**
     * @param $catId
     * @param $photoId
     *
     * @return array
     */
    public function getAlbumPrevPhoto($catId, $photoId)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_id', $photoId, '<'));
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder('DESC');
        $criteria->setLimit(1);

        return $this->getObjects($criteria);
    }

    /**
     * @param $catId
     * @param $photoId
     *
     * @return array
     */
    public function getAlbumNextPhoto($catId, $photoId)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_id', $photoId, '>'));
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder('ASC');
        $criteria->setLimit(1);

        return $this->getObjects($criteria);
    }

    /**
     * @param $catId
     * @param $photoId
     *
     * @return int
     */
    public function getAlbumCurrentPhotoPlace($catId, $photoId)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $criteria->add(new Criteria('cat_id', $catId));
        $criteria->add(new Criteria('photo_id', $photoId, '<='));
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder('DESC');

        return $this->getCount($criteria);
    }

    /**
     * @param $catId
     *
     * @return array
     */
    public function getAlbumPhoto($catId)
    {
        $criteria = new Criteria('cat_id', $catId);
        $criteria->setSort('photo_weight, photo_id');
        $criteria->setOrder('ASC');

        return $this->getObjects($criteria);
    }

    /**
     * @param $category
     *
     * @return array
     */
    public function getCatPhoto(&$category)
    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('nleft', $category->getVar('nleft'), '>='));
        $criteria->add(new Criteria('nright', $category->getVar('nright'), '<='));

        $cats = $catHandler->getObjects($criteria);

        $count = count($cats);
        if ($count > 0) {

            $in = '(' . $cats[0]->getVar('cat_id');
            array_shift($cats);
            /** @var ExtgalleryCat $cat */
            foreach ($cats as $cat) {
                $in .= ',' . $cat->getVar('cat_id');
            }
            $in .= ')';
            $criteria = new Criteria('cat_id', $in, 'IN');
        } else {
            $criteria = new Criteria('cat_id', '(0)', 'IN');
        }

        return $this->getObjects($criteria);
    }

    /**
     * @param $catId
     *
     * @return int
     */
    public function getAlbumCount($catId)
    {
        $criteria = new Criteria('cat_id', $catId);

        return $this->getCount($criteria);
    }

    /**
     * @param $photoId
     *
     * @return bool
     */
    public function updateHits($photoId)
    {
        $criteria = new Criteria('photo_id', $photoId);

        return $this->updateCounter('photo_hits', $criteria);
    }

    /**
     * @param $photoId
     *
     * @return bool
     */
    public function updateNbRating($photoId)
    {
        $criteria = new Criteria('photo_id', $photoId);

        return $this->updateCounter('photo_nbrating', $criteria);
    }

    /**
     * @param $photoId
     *
     * @return bool
     */
    public function updateDownload($photoId)
    {
        $criteria = new Criteria('photo_id', $photoId);

        return $this->updateCounter('photo_download', $criteria);
    }

    /**
     * @param $photoId
     *
     * @return bool
     */
    public function updateEcard($photoId)
    {
        $criteria = new Criteria('photo_id', $photoId);

        return $this->updateCounter('photo_ecard', $criteria);
    }

    public function getAllSize()
    {
        exit('getAllSize() method must be defined on sub classes');

    }

    /**
     * @param $imageTransform
     */
    public function _makeWatermark(&$imageTransform)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (!function_exists('imagettfbbox')) {
            return;
        }

        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        /*  Text position param
        /
        /   0 : orig
        /   -1 : opposit
        /   1 : center
        /
        */
        if ($xoopsModuleConfig['watermark_position'] === 'tl') {

            $x = 0;
            $y = 0;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'tr') {
            $x = -1;
            $y = 0;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'bl') {
            $x = 0;
            $y = -1;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'br') {
            $x = -1;
            $y = -1;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'tc') {
            $x = 1;
            $y = 0;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'bc') {
            $x = 1;
            $y = -1;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'lc') {
            $x = 0;
            $y = 1;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'rc') {
            $x = -1;
            $y = 1;
        } elseif ($xoopsModuleConfig['watermark_position'] === 'cc') {
            $x = 1;
            $y = 1;
        }

        $text = ($xoopsModuleConfig['watermark_type']
                 == 0) ? $GLOBALS['xoopsUser']->getVar('uname') : $xoopsModuleConfig['watermark_text'];

        $watermarkParams = array(
            'text'         => $text,
            'x'            => $x,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'y'            => $y,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'color'        => $xoopsModuleConfig['watermark_color'],
            'font'         => XOOPS_ROOT_PATH . '/modules/extgallery/fonts/' . $xoopsModuleConfig['watermark_font'],
            'size'         => $xoopsModuleConfig['watermark_fontsize'],
            'resize_first' => false,
            'padding'      => $xoopsModuleConfig['watermark_padding']
        );
        $imageTransform->addText($watermarkParams);
    }

    /**
     * @param $imageTransform
     */
    public function _makeBorder(&$imageTransform)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        $borders   = array();
        $borders[] = array(
            'borderWidth' => $xoopsModuleConfig['inner_border_size'],
            'borderColor' => $xoopsModuleConfig['inner_border_color']
        );
        $borders[] = array(
            'borderWidth' => $xoopsModuleConfig['outer_border_size'],
            'borderColor' => $xoopsModuleConfig['outer_border_color']
        );
        $imageTransform->addBorders($borders);
    }

    public function _getUploadPhotoPath()
    {
        exit('_getUploadPhotoPath() method must be defined on sub classes');

    }

    /**
     * @param $photoName
     */
    public function _largePhotoTreatment($photoName)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        // Check if must save large photo
        if ($xoopsModuleConfig['save_large']) {

            // Define Graphical library path
            if (!defined('IMAGE_TRANSFORM_IM_PATH') && $xoopsModuleConfig['graphic_lib'] === 'imagick') {

                define('IMAGE_TRANSFORM_IM_PATH', $xoopsModuleConfig['graphic_lib_path']);
            }
            $imageFactory = new Image_Transform;
            $imageTransform = $imageFactory->factory($xoopsModuleConfig['graphic_lib']);

            $filePath = $this->_getUploadPhotoPath();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
            $imageTransform->load($filePath . $photoName);

            // Save large photo only if it's bigger than medium size
            if ($imageTransform->getImageWidth() > $xoopsModuleConfig['medium_width']
                || $imageTransform->getImageHeight() > $xoopsModuleConfig['medium_heigth']
            ) {

                // Make watermark
                if ($xoopsModuleConfig['enable_large_watermark']) {
                    $this->_makeWatermark($imageTransform);
                }

                // Make border
                if ($xoopsModuleConfig['enable_large_border']) {
                    $this->_makeBorder($imageTransform);
                }

                $largeFilePath = $filePath . 'large/large_' . $photoName;
                $imageTransform->save($largeFilePath, '', 100);
                $imageTransform->free();
            }
        }
    }

    /**
     * @param             $photoName
     * @param null|string $filePath
     * @param null        $mediumFilePath
     */
    public function _mediumPhotoTreatment($photoName, $filePath = null, $mediumFilePath = null)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        // Define Graphical library path
        if (!defined('IMAGE_TRANSFORM_IM_PATH') && $xoopsModuleConfig['graphic_lib'] === 'imagick') {

            define('IMAGE_TRANSFORM_IM_PATH', $xoopsModuleConfig['graphic_lib_path']);
        }
        $imageFactory = new Image_Transform;
        $imageTransform = $imageFactory->factory($xoopsModuleConfig['graphic_lib']);

        if (null === $filePath) {
            $filePath = $this->_getUploadPhotoPath();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }
        if (null === $mediumFilePath) {
            $mediumFilePath = $filePath . 'medium/' . $photoName;
        }
        $imageTransform->load($filePath . $photoName);

        // Fitting image to desired size
        if ($xoopsModuleConfig['enable_medium_border']) {
            $borderSize = ($xoopsModuleConfig['inner_border_size'] * 2) + ($xoopsModuleConfig['outer_border_size'] * 2);
        } else {
            $borderSize = 0;
        }
        $imageTransform->fit($xoopsModuleConfig['medium_width'] - $borderSize,
                             $xoopsModuleConfig['medium_heigth'] - $borderSize);
        $imageTransform->save($mediumFilePath, '', $xoopsModuleConfig['medium_quality']);
        $imageTransform->free();

        if ($xoopsModuleConfig['enable_medium_watermark'] || $xoopsModuleConfig['enable_medium_border']) {
            $imageTransform->load($mediumFilePath);

            // Make watermark
            if ($xoopsModuleConfig['enable_medium_watermark']) {
                $this->_makeWatermark($imageTransform);
            }

            // Make border
            if ($xoopsModuleConfig['enable_medium_border']) {
                $this->_makeBorder($imageTransform);
            }

            $imageTransform->save($mediumFilePath, '', $xoopsModuleConfig['medium_quality']);
            $imageTransform->free();
        }
    }

    /**
     * @param $photoName
     */
    public function _makeThumb($photoName)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        // Define Graphical library path
        if (!defined('IMAGE_TRANSFORM_IM_PATH') && $xoopsModuleConfig['graphic_lib'] === 'imagick') {

            define('IMAGE_TRANSFORM_IM_PATH', $xoopsModuleConfig['graphic_lib_path']);
        }
        $imageFactory = new Image_Transform;
        $imageTransform = $imageFactory->factory($xoopsModuleConfig['graphic_lib']);

        $filePath  = $this->_getUploadPhotoPath() . 'medium/' . $photoName;
        $thumbPath = $this->_getUploadPhotoPath() . 'thumb/thumb_' . $photoName;

        $imageTransform->load($filePath);
        $imageTransform->fit($xoopsModuleConfig['thumb_width'], $xoopsModuleConfig['thumb_heigth']);
        $imageTransform->save($thumbPath, '', $xoopsModuleConfig['thumb_quality']);
        $imageTransform->free();
    }

    /**
     * @param $photoName
     *
     * @return bool
     */
    public function _haveLargePhoto($photoName)
    {
        return file_exists($this->_getUploadPhotoPath() . 'large/large_' . $photoName);
    }

    /**
     * @param $photoName
     *
     * @return array
     */
    public function _getImageDimension($photoName)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        // Define Graphical library path
        if (!defined('IMAGE_TRANSFORM_IM_PATH') && $xoopsModuleConfig['graphic_lib'] === 'imagick') {

            define('IMAGE_TRANSFORM_IM_PATH', $xoopsModuleConfig['graphic_lib_path']);
        }
        $imageFactory = new Image_Transform;
        $imageTransform = $imageFactory->factory($xoopsModuleConfig['graphic_lib']);

        $ret = array();
        if ($this->_haveLargePhoto($photoName)) {
            $imageTransform->load($this->_getUploadPhotoPath() . 'large/large_' . $photoName);
            $ret['width']  = $imageTransform->getImageWidth();
            $ret['height'] = $imageTransform->getImageHeight();
        } else {
            $imageTransform->load($this->_getUploadPhotoPath() . 'medium/' . $photoName);
            $ret['width']  = $imageTransform->getImageWidth();
            $ret['height'] = $imageTransform->getImageHeight();
        }
        $imageTransform->free();

        return $ret;
    }

    /**
     * @param $photoName
     *
     * @return string
     */
    public function _getAutoDescription($photoName)
    {
        global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

        //DNPROSSI
        /*if ($xoopsModuleConfig['enable_longdesc']) {

            $newphotoname = '';
            $newnewphotoname = '';
            $patterns = array();
            $patterns[0] = "/-/";
            $patterns[1] = "/_/";
            $replacements = array();
            $replacements[0] = " ";
            $replacements[1] = "'";
            $newphotoName = substr($photoName, strpos($photoName, "-") + 1);
            $newphotoName = substr($newphotoName, strpos($newphotoName, "-") + 1);

            return preg_replace($patterns, $replacements, substr($newphotoName,0,-12));
        } else { */
        $matches = array();
        preg_match_all($xoopsModuleConfig['photoname_pattern'], substr($photoName, 0, -12), $matches);
        preg_match_all($xoopsModuleConfig['photoname_pattern'], $photoName, $matches);

        return implode(' ', $matches[1]);
        //}
    }

    /**
     * @param $fileName
     *
     * @return string
     */
    public function _makeFileName($fileName)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        //DNPROSSI
        //$fileName = preg_replace("/[^a-zA-Z0-9()_\.-]/", "-", $fileName);

        $fileName = preg_replace("/[^a-zA-Z0-9_\.-]/", '-', $fileName);

        $fileName = explode('.', $fileName);
        $userId   = is_object($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser']->getVar('uid') : 0;

        return $fileName[0] . '_' . $userId . '_' . substr(md5(uniqid(mt_rand(), true)), 27) . '.' . $fileName[1];
    }

    /**
     * @param $photoName
     *
     * @return float
     */
    public function _getPhotoSize($photoName)
    {
        if ($this->_haveLargePhoto($photoName)) {
            return $this->_getFileSize('large/large_' . $photoName);
        } else {
            return $this->_getFileSize($photoName);
        }
    }

    /**
     * @param $fileName
     *
     * @return float
     */
    public function _getFileSize($fileName)
    {
        return round(filesize($this->_getUploadPhotoPath() . $fileName) / 1024, 2);
    }

    /**
     * @param $catId
     */
    public function rebuildThumbnail($catId)
    {
        $photos = $this->getAlbumPhoto($catId);
        foreach ($photos as $photo) {
            $this->_makeThumb($photo->getVar('photo_name'));
        }
    }

    /* Return Code :
        0 : Photo added
        1 : Photo pending
        2 : This is not an album
        3 : HTTP Upload error
        4 : File rejected
        5 : File chunk receive
        */
    /**
     * @param      $file
     * @param bool $checkMd5
     *
     * @return int
     */
    public function postPhotoTraitement($file, $checkMd5 = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        //        require_once XOOPS_ROOT_PATH.'/modules/extgallery/class/photoUploader.php';


        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $catId = (int)$_POST['cat_id'];

        // If isn't an album when stop the traitment
        $cat = $catHandler->getCat($catId);
        if (null !== $cat && ($cat->getVar('nright') - $cat->getVar('nleft') != 1)) {
            return 2;
        }

        $allowedMimeTypes = array('image/jpeg', 'image/jpg', 'image/pjpeg', 'image/gif', 'image/png', 'image/x-png');
        //        $allowedMimeTypes = array('jpg/jpeg', 'image/bmp', 'image/gif', 'image/jpeg', 'image/jpg', 'image/x-png', 'image/png');


        $uploadDir = XOOPS_ROOT_PATH . '/uploads/extgallery/public-photo/';

        //        $this->photoUploader = new ExtgalleryPhotoUploader($uploadDir,  50000000, 5000, 5000);

        //        $this->photoUploader->checkMd5 = $checkMd5;

        //        $this->photoUploader->fetchPhoto($_FILES[$file]);


        //------------------------
        require_once XOOPS_ROOT_PATH . '/class/uploader.php';
        $this->photoUploader = new XoopsMediaUploader($uploadDir, $allowedMimeTypes, 50000000, 5000, 5000);

        $jupart  = isset($_POST['jupart']) ? (int)$_POST['jupart'] : 0;
        $jufinal = isset($_POST['jufinal']) ? (int)$_POST['jufinal'] : 1;

        if ($this->photoUploader->fetchMedia($file) && $this->photoUploader->upload()) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
        } else {
            // We got a chunk, so we don't add photo to database
            if ($jupart && !$jufinal) {
                return 5;
            } else {
                return 4;
            }
        }

        //---------------------------

        /*

                $jupart = (isset($_POST['jupart'])) ? (int) $_POST['jupart'] : 0;
                $jufinal = (isset($_POST['jufinal'])) ? (int) $_POST['jufinal'] : 1;

                if ($this->photoUploader->isError()) {
                    return 4;
                // We got a chunk, so we don't add photo to database
                } elseif ($jupart && !$jufinal) {
                    return 5;
                }
        */

        //DNPROSSI - add missing title and description on upload
        $photoTitle = '';
        $photoDesc  = '';
        $photoExtra = '';
        $photoTag   = '';

        if (isset($_POST['photo_title'])) {
            $photoTitle = $_POST['photo_title'];
        }
        if (isset($_POST['photo_desc'])) {
            $photoDesc = $_POST['photo_desc'];
        }
        if (isset($_POST['photo_extra'])) {
            $photoExtra = $_POST['photo_extra'];
        }
        if (isset($_POST['tag'])) {
            $photoTag = $_POST['tag'];
        }

        $photoStatus = $this->addLocalPhoto($catId, $this->photoUploader->getSavedFileName(), $photoTitle, $photoDesc,
                                            $photoExtra, $photoTag);
        /** @var ExtgalleryCat $cat */
        $cat         = $catHandler->getCat($catId);
        $cat->setVar('cat_isalbum', 1);
        $catHandler->insert($cat);

        /** @var XoopsNotificationHandler $notificationHandler */
        $notificationHandler = xoops_getHandler('notification');
        $extraTags           = array(
            'X_ITEM_CAT'     => $cat->getVar('cat_name'),
            'X_ITEM_NBPHOTO' => 1
        );

        if ($photoStatus == 1) {
            $extraTags['X_ITEM_URL'] = XOOPS_URL . '/modules/extgallery/public-album.php?id=' . $cat->getVar('cat_id');
            $notificationHandler->triggerEvent('global', 0, 'new_photo', $extraTags);
            $notificationHandler->triggerEvent('album', $cat->getVar('cat_id'), 'new_photo_album', $extraTags);

            // Update album count
            if ($cat->getVar('cat_nb_photo') == 0) {

                $criteria = new CriteriaCompo();
                $criteria->add(new Criteria('nleft', $cat->getVar('nleft'), '<'));
                $criteria->add(new Criteria('nright', $cat->getVar('nright'), '>'));
                $catHandler->updateFieldValue('cat_nb_album', 'cat_nb_album + 1', $criteria);
            }

            // Update photo count
            $criteria = new CriteriaCompo();
            $criteria->add(new Criteria('nleft', $cat->getVar('nleft'), '<='));
            $criteria->add(new Criteria('nright', $cat->getVar('nright'), '>='));
            $catHandler->updateFieldValue('cat_nb_photo', 'cat_nb_photo + 1', $criteria);

            return 0;
        } else {

            $extraTags['X_ITEM_URL'] = XOOPS_URL . '/modules/extgallery/admin/photo.php';
            $notificationHandler->triggerEvent('global', 0, 'new_photo_pending', $extraTags);

            return 1;
        }
    }

    /**
     * @param        $catId
     * @param        $dirtyPhotoName
     * @param string $photoTitle
     * @param string $photoDesc
     * @param string $photoExtra
     * @param string $photoTag
     *
     * @return mixed
     */
    public function addLocalPhoto(
        $catId,
        $dirtyPhotoName,
        $photoTitle = '',
        $photoDesc = '',
        $photoExtra = '',
        $photoTag = ''
    ) {
        require_once XOOPS_ROOT_PATH . '/modules/extgallery/class/pear/Image/Transform.php';

        global $xoopsUser, $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
        $permHandler = ExtgalleryPublicPermHandler::getInstance();

        // Replace all bad file name character
        $photoName = $this->_makeFileName($dirtyPhotoName);
        rename($this->_getUploadPhotoPath() . $dirtyPhotoName, $this->_getUploadPhotoPath() . $photoName);

        //DNPROSSI - changed photo_desc to photo_title
        // Making auto description
        if ($photoTitle === '') {
            $photoTitle = $this->_getAutoDescription($photoName);
        }

        $originalName = '';
        // Save original photo
        if ($xoopsModuleConfig['save_large'] && $xoopsModuleConfig['save_original']) {
            $fileName     = explode('.', $photoName);
            $originalName = md5(uniqid(mt_rand(), true)) . '.' . $fileName[1];
            copy($this->_getUploadPhotoPath() . $photoName, $this->_getUploadPhotoPath() . 'original/' . $originalName);
        }

        $this->_largePhotoTreatment($photoName);

        $this->_mediumPhotoTreatment($photoName);

        $this->_makeThumb($photoName);

        $imageDimension = $this->_getImageDimension($photoName);

        $userId = is_object($xoopsUser) ? $xoopsUser->getVar('uid') : 0;
        $data   = array(
            'cat_id'          => $catId,
            'photo_title'     => $photoTitle,
            'photo_desc'      => $photoDesc,
            'photo_name'      => $photoName,
            'photo_orig_name' => $originalName,
            'uid'             => $userId,
            'photo_size'      => $this->_getPhotoSize($photoName),
            'photo_res_x'     => $imageDimension['width'],
            'photo_res_y'     => $imageDimension['height'],
            'photo_date'      => time(),
            'photo_havelarge' => $this->_haveLargePhoto($photoName),
            'photo_approved'  => $permHandler->isAllowed($xoopsUser, 'public_autoapprove', $catId),
            'photo_extra'     => $photoExtra,
            'dohtml'          => $xoopsModuleConfig['allow_html']
        );

        // Deleting working photo
        unlink($this->_getUploadPhotoPath() . $photoName);

        $this->createPhoto($data);

        if ($xoopsModuleConfig['usetag'] == 1 || (is_dir('../tag') || is_dir('../../tag'))) {
            $newid      = $this->db->getInsertId();
            $tagHandler = xoops_getModuleHandler('tag', 'tag');
            $tagHandler->updateByItem($photoTag, $newid, 'extgallery', 0);
        }

        return $data['photo_approved'];
    }

    /**
     * @param $queryArray
     * @param $condition
     * @param $limit
     * @param $start
     * @param $userId
     *
     * @return array
     */
    public function getSearchedPhoto($queryArray, $condition, $limit, $start, $userId)
    {
        $criteria = new CriteriaCompo();
        if ($userId > 0) {
            $criteria->add(new Criteria('uid', $userId));
        }
        $criteria->add(new Criteria('photo_approved', 1));
        if (is_array($queryArray) && count($queryArray) > 0) {
            $subCriteria = new CriteriaCompo();
            foreach ($queryArray as $keyWord) {
                $keyWordCriteria = new CriteriaCompo();
                $keyWordCriteria->add(new Criteria('photo_title', '%' . $keyWord . '%', 'LIKE'));
                $keyWordCriteria->add(new Criteria('photo_desc', '%' . $keyWord . '%', 'LIKE'), 'OR');
                $keyWordCriteria->add(new Criteria('photo_name', '%' . $keyWord . '%', 'LIKE'), 'OR');
                $subCriteria->add($keyWordCriteria, $condition);
                unset($keyWordCriteria);
            }
            $criteria->add($subCriteria);
        }
        $criteria->setStart($start);
        $criteria->setLimit($limit);
        $criteria->setSort('photo_date');

        $photos = $this->getObjects($criteria);

        $ret = array();
        foreach ($photos as $photo) {
            if ($photo->getVar('photo_title')) {
                $title = $photo->getVar('photo_title');
            } else {
                $title = $photo->getVar('photo_desc');
            }
            $data  = array(
                'image' => 'assets/images/extgallery-posticon.gif',
                'link'  => 'public-photo.php?photoId=' . $photo->getVar('photo_id'),
                'title' => $title,
                'time'  => $photo->getVar('photo_date'),
                'uid'   => $photo->getVar('uid')
            );
            $ret[] = $data;
        }

        return $ret;
    }

    /**
     * @return array
     */
    public function getPendingPhoto()
    {
        $criteria = new Criteria('photo_approved', 0);

        return $this->getObjects($criteria);
    }

    /**
     * @param $criteria
     * @param $data
     */
    public function _addInCriteria(&$criteria, $data)
    {
        $count = count($data);
        if ($count > 0) {
            $in = '(' . $data[0];
            array_shift($data);
            foreach ($data as $elmt) {
                $in .= ',' . $elmt;
            }
            $in .= ')';
            $criteria->add(new Criteria('cat_id', $in, 'IN'));
        }
    }

    /**
     * @param $param
     *
     * @return array
     */
    public function getRandomPhoto($param)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');
        if (null !== $catHandler->getCatRestrictCriteria()) {
            $criteria = new CriteriaCompo();
            $criteria->add($catHandler->getCatRestrictCriteria());
            $criteria->add(new Criteria('photo_approved', 1));
            $this->_addInCriteria($criteria, $param['cat']);
            $criteria->setSort('RAND()');
            $criteria->setLimit($param['limit']);
        }

        return $this->getObjects($criteria);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    /**
     * @param $param
     *
     * @return array
     */
    public function getLastPhoto($param)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $this->_addInCriteria($criteria, $param['cat']);
        $criteria->setSort('photo_date');
        $criteria->setOrder('DESC');
        $criteria->setLimit($param['limit']);

        return $this->getObjects($criteria);
    }

    /**
     * @param $param
     *
     * @return array
     */
    public function getTopViewPhoto($param)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $this->_addInCriteria($criteria, $param['cat']);
        $criteria->setSort('photo_hits');
        $criteria->setOrder('DESC');
        $criteria->setLimit($param['limit']);

        return $this->getObjects($criteria);
    }

    /**
     * @param $param
     *
     * @return array
     */
    public function getTopRatedPhoto($param)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $this->_addInCriteria($criteria, $param['cat']);
        $criteria->setSort('photo_rating');
        $criteria->setOrder('DESC');
        $criteria->setLimit($param['limit']);

        return $this->getObjects($criteria);
    }

    /**
     * @param $param
     *
     * @return array
     */
    public function getTopEcardPhoto($param)

    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');

        $criteria = new CriteriaCompo();
        $criteria->add($catHandler->getCatRestrictCriteria());
        $criteria->add(new Criteria('photo_approved', 1));
        $this->_addInCriteria($criteria, $param['cat']);
        $criteria->setSort('photo_ecard');
        $criteria->setOrder('DESC');
        $criteria->setLimit($param['limit']);

        return $this->getObjects($criteria);
    }

    /**
     * @param $param
     */
    public function getTopSubmitter($param)
    {
        $catHandler = xoops_getModuleHandler('publiccat', 'extgallery');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $criteria = new Criteria();
        $this->_addInCriteria($criteria, $param['cat']);

        echo $criteria->renderWhere();
    }

    /**
     * @return mixed
     */
    public function getInsertId()
    {
        return $this->db->getInsertId();
    }
}


Push — master ( f87886...b3b862 )

ExtgalleryPhotoHandler::_mediumPhotoTreatment() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 26 and the first side effect is on line 20. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* ExtGallery Class Manager
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright {@link https://xoops.org/ XOOPS Project}
13			* @license GNU GPL 2 (http://www.gnu.org/licenses/old-licenses/gpl-2.0.html)
14			* @author Zoullou (http://www.zoullou.net)
15			* @package ExtGallery
16			*/
17
18			// defined('XOOPS_ROOT_PATH') \|\| exit('XOOPS root path not defined');
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report `70%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
19
20			require_once __DIR__ . '/publicPerm.php';
21			require_once __DIR__ . '/ExtgalleryPersistableObjectHandler.php';
22
23			/**
24			* Class ExtgalleryPhoto
25			*/
26			class ExtgalleryPhoto extends XoopsObject
			0 ignored issues – show Coding Style Compatibility introduced 2016-03-22 05:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
27			{
28			public $externalKey = array();
29
30			/**
31			* ExtgalleryPhoto constructor.
32			*/
33			public function __construct()
34			{
35			parent::__construct();
36			$this->initVar('photo_id', XOBJ_DTYPE_INT, null, false);
37			$this->initVar('cat_id', XOBJ_DTYPE_INT, 0, false);

mambax7 / extgallery

Push — master ( f87886...b3b862 )

ExtgalleryPhotoHandler::_mediumPhotoTreatment() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Available Fixes

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Available Fixes

Duplication Side-by-Side

Filter issues like