Image_Transform_Driver_GD1

Complexity

Total Complexity

35

Size/Duplication

Total Lines	219
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
F	rotate()	0	162	31
A	_resize()	0	15	2
A	Image_Transform_Driver_GD1()	0	3	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 31 and the first side effect is on line 20.

// +----------------------------------------------------------------------+
// | PHP Version 4                                                        |
// +----------------------------------------------------------------------+
// | Copyright (c) 1997-2003 The PHP Group                                |
// +----------------------------------------------------------------------+
// | This source file is subject to version 2.02 of the PHP license,      |
// | that is bundled with this package in the file LICENSE, and is        |
// | available at through the world-wide-web at                           |
// | http://www.php.net/license/2_02.txt.                                 |
// | If you did not receive a copy of the PHP license and are unable to   |
// | obtain it through the world-wide-web, please send a note to          |
// | license@php.net so we can mail you a copy immediately.               |
// +----------------------------------------------------------------------+
// | Authors: Peter Bowyer <peter@mapledesign.co.uk>                      |
// |          Alan Knowles <alan@akbkhome.com>                            |
// +----------------------------------------------------------------------+

//require_once 'Image/Transform/Driver/GD.php';
require_once XOOPS_ROOT_PATH . '/modules/extgallery/class/pear/Image/Transform/Driver/GD.php';

The constant XOOPS_ROOT_PATH was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * This driver is for GD1 or the non-bundled version of GD2
 *
 * @package
 * @author    NAWAL ASWAN
 * @copyright Copyright (c) 2003
 * @version   $Id: GD1.php 234123 2007-04-19 16:36:09Z dufuz $
 * @access    public
 **/
class Image_Transform_Driver_GD1 extends Image_Transform_Driver_GD

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * Check settings
     *
     * @return mixed true or  or a PEAR error object on error
     *
     * @see PEAR::isError()
     */
    public function Image_Transform_Driver_GD1()
    {
        $this->__construct();
    } // End function Image

    /**
     * Check settings
     *
     * @return mixed true or  or a PEAR error object on error
     *
     * @see PEAR::isError()
     */
    public function __construct()
    {
        parent::__construct();
    } // End function Image

    /**
     * Resize Action
     *
     * For GD 2.01+ the new copyresampled function is used
     * It uses a bicubic interpolation algorithm to get far
     * better result.
     *
     * @param       $new_x   int  new width
     * @param       $new_y   int  new height
     * @param mixed $options Optional parameters
     *
     * @return true on success or PEAR Error object on error
     * @see PEAR::isError()
     */
    public function _resize($new_x, $new_y, $options = null)
    {
        if (true === $this->resized) {
            return PEAR::raiseError('You have already resized the image without saving it.  Your previous resizing will be overwritten', null, PEAR_ERROR_TRIGGER, E_USER_NOTICE);

The method raiseError() does not exist on PEAR. Since you implemented __callStatic, consider adding a @method annotation.

        }
        $new_img = ImageCreate($new_x, $new_y);
        ImageCopyResized($new_img, $this->imageHandle, 0, 0, 0, 0, $new_x, $new_y, $this->img_x, $this->img_y);
        $this->old_image   = $this->imageHandle;

The property old_image does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->imageHandle = $new_img;
        $this->resized     = true;

        $this->new_x = $new_x;
        $this->new_y = $new_y;

        return true;
    }

    public function rotate($angle, $options = null)
    {
        if (null == $options) {
            $autoresize = true;
            $color_mask = array(255, 255, 0);
        } else {
            extract($options);
        }

        while ($angle <= -45) {
            $angle += 360;
        }
        while ($angle > 270) {
            $angle -= 360;
        }

        $t = deg2rad($angle);

        if (!is_array($color_mask)) {
            // Not already in numberical format, so we convert it.
            if ('#' == $color_mask{0}) {
                $color_mask = $this->colorhex2colorarray($color_mask);
            } else {
                require_once 'Image/Transform/Driver/ColorsDefs.php';
                $color_mask = isset($colornames[$color_mask]) ? $colornames[$color_mask] : false;
            }
        }

        // Do not round it, too much lost of quality
        $cosT = cos($t);
        $sinT = sin($t);

        $img =& $this->imageHandle;

        $width  = $max_x = $this->img_x;
        $height = $max_y = $this->img_y;
        $min_y  = 0;
        $min_x  = 0;

        $x1 = round($max_x / 2, 0);
        $y1 = round($max_y / 2, 0);

        if ($autoresize) {
            $t = abs($t);
            $a = round($angle, 0);

The assignment to $a is dead and can be removed.

            switch ((int)($angle)) {
                case 0:
                    $width2  = $width;
                    $height2 = $height;
                    break;
                case 90:
                    $width2  = $height;
                    $height2 = $width;
                    break;
                case 180:
                    $width2  = $width;
                    $height2 = $height;
                    break;
                case 270:
                    $width2  = $height;
                    $height2 = $width;
                    break;
                default:
                    $width2  = (int)(abs(sin($t) * $height + cos($t) * $width));
                    $height2 = (int)(abs(cos($t) * $height + sin($t) * $width));
            }

            $width2  -= $width2 % 2;
            $height2 -= $height2 % 2;

            $d_width  = abs($width - $width2);
            $d_height = abs($height - $height2);
            $x_offset = $d_width / 2;
            $y_offset = $d_height / 2;
            $min_x2   = -abs($x_offset);
            $min_y2   = -abs($y_offset);
            $max_x2   = $width2;
            $max_y2   = $height2;
        }

        $img2 = @imagecreateTrueColor($width2, $height2);

        if (!is_resource($img2)) {
            return PEAR::raiseError('Cannot create buffer for the rotataion.', null, PEAR_ERROR_TRIGGER, E_USER_NOTICE);
        }

        $this->img_x = $width2;
        $this->img_y = $height2;

        imagepalettecopy($img2, $img);

        $mask = imagecolorresolve($img2, $color_mask[0], $color_mask[1], $color_mask[2]);

        // use simple lines copy for axes angles
        switch ((int)($angle)) {
            case 0:
                imagefill($img2, 0, 0, $mask);
                for ($y = 0; $y < $max_y; $y++) {
                    for ($x = $min_x; $x < $max_x; $x++) {
                        $c = @imagecolorat($img, $x, $y);
                        imagesetpixel($img2, $x + $x_offset, $y + $y_offset, $c);
                    }
                }
                break;
            case 90:
                imagefill($img2, 0, 0, $mask);
                for ($x = $min_x; $x < $max_x; $x++) {
                    for ($y = $min_y; $y < $max_y; $y++) {
                        $c = imagecolorat($img, $x, $y);
                        imagesetpixel($img2, $max_y - $y - 1, $x, $c);
                    }
                }
                break;
            case 180:
                imagefill($img2, 0, 0, $mask);
                for ($y = 0; $y < $max_y; $y++) {
                    for ($x = $min_x; $x < $max_x; $x++) {
                        $c = @imagecolorat($img, $x, $y);
                        imagesetpixel($img2, $max_x2 - $x - 1, $max_y2 - $y - 1, $c);
                    }
                }
                break;
            case 270:
                imagefill($img2, 0, 0, $mask);
                for ($y = 0; $y < $max_y; $y++) {
                    for ($x = $max_x; $x >= $min_x; $x--) {
                        $c = @imagecolorat($img, $x, $y);
                        imagesetpixel($img2, $y, $max_x - $x - 1, $c);
                    }
                }
                break;
            // simple reverse rotation algo
            default:
                $i = 0;

The assignment to $i is dead and can be removed.

                for ($y = $min_y2; $y < $max_y2; $y++) {

                    // Algebra :)
                    $x2 = round((($min_x2 - $x1) * $cosT) + (($y - $y1) * $sinT + $x1), 0);
                    $y2 = round((($y - $y1) * $cosT - ($min_x2 - $x1) * $sinT + $y1), 0);

                    for ($x = $min_x2; $x < $max_x2; $x++) {

                        // Check if we are out of original bounces, if we are
                        // use the default color mask
                        if ($x2 >= 0 && $x2 < $max_x && $y2 >= 0 && $y2 < $max_y) {
                            $c = imagecolorat($img, $x2, $y2);

$y2 of type double is incompatible with the type integer expected by parameter $y of imagecolorat().

$x2 of type double is incompatible with the type integer expected by parameter $x of imagecolorat().

                        } else {
                            $c = $mask;
                        }
                        imagesetpixel($img2, $x + $x_offset, $y + $y_offset, $c);

                        // round verboten!
                        $x2 += $cosT;
                        $y2 -= $sinT;
                    }
                }
                break;
        }

        $this->imageHandle = $img2;

        return true;
    }
} // End class ImageGD