XoopsModules\Extgallery\GroupPermForm::render()

Complexity

Conditions	11
Paths	84

Size

Total Lines	55
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function render()
    {
        // load all child ids for javascript codes
        foreach (\array_keys($this->_itemTree) as $item_id) {
            $this->_itemTree[$item_id]['allchild'] = [];
            $this->_loadAllChildItemIds($item_id, $this->_itemTree[$item_id]['allchild']);
        }
        /** @var \XoopsGroupPermHandler $grouppermHandler */
        $grouppermHandler = \xoops_getHandler('groupperm');
        /** @var \XoopsMemberHandler $memberHandler */
        $memberHandler = \xoops_getHandler('member');
        $glist         = $memberHandler->getGroupList();
        foreach (\array_keys($glist) as $i) {
            if (XOOPS_GROUP_ANONYMOUS == $i && !$this->_showAnonymous) {
                continue;
            }
            // get selected item id(s) for each group
            $selected = $grouppermHandler->getItemIds($this->_permName, $i, $this->_modid);
            $ele      = new Extgallery\GroupFormCheckBox($glist[$i], 'perms[' . $this->_permName . ']', $i, $selected);
            $ele->setOptionTree($this->_itemTree);
            $this->addElement($ele);
            unset($ele);
        }
        $tray = new \XoopsFormElementTray('');
        $tray->addElement(new \XoopsFormButton('', 'submit', _SUBMIT, 'submit'));
        $tray->addElement(new \XoopsFormButton('', 'reset', _CANCEL, 'reset'));
        $this->addElement($tray);
        echo '<h4>' . $this->getTitle() . '</h4>';
        if ($this->_permDesc) {
            echo $this->_permDesc . '<br><br>';
        }
        echo "<form name='" . $this->getName() . '\' id=\'' . $this->getName() . '\' action=\'' . $this->getAction() . '\' method=\'' . $this->getMethod() . '\'' . $this->getExtra() . ">\n<table width='100%' class='outer' cellspacing='1' valign='top'>\n";
        $elements = &$this->getElements();
        $hidden   = '';
        foreach (\array_keys($elements) as $i) {
            if (!\is_object($elements[$i])) {
                echo $elements[$i];

Are you sure $elements[$i] of type XoopsFormElement can be used in echo? Consider adding a __toString()-method.

            } elseif (!$elements[$i]->isHidden()) {
                echo "<tr valign='top' align='left'><td class='head'>" . $elements[$i]->getCaption();
                if ('' != $elements[$i]->getDescription()) {
                    echo '<br><br><span style="font-weight: normal;">' . $elements[$i]->getDescription() . '</span>';
                }
                echo "</td>\n<td class='even'>\n";
                if (\is_a($elements[$i], 'Extgallery\GroupFormCheckBox')) {
                    $elements[$i]->render();
                } else {
                    echo $elements[$i]->render();

Are you sure the usage of $elements[$i]->render() targeting XoopsFormElement::render() seems to always return null.

                }
                echo "\n</td></tr>\n";
            } else {
                $hidden .= $elements[$i]->render();

Are you sure the usage of $elements[$i]->render() targeting XoopsFormElement::render() seems to always return null.

            }
        }
        echo "</table>$hidden</form>";
        echo $this->renderValidationJS(true);
    }