Issues in TableForm.php (master) - Issues in master - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Issues (733)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

class/TableForm.php (4 issues)

Labels

Severity

Minor 4

<?php

namespace XoopsModules\Extcal;

\xoops_load('XoopsForm');

/**
 * Form that will output as a theme-enabled HTML table.
 *
 * Also adds JavaScript to validate required fields
 */
class TableForm extends \XoopsForm
{
    /**
     * ad the balise html "table" to render.
     *
     * @var bool|string
     */
    public $_addBaliseTable = '';

    /**
     * Gets the "value" attribute of a form element.
     *
     * @param $addBaliseTable
     *
     * @return string the "value" attribute assigned to a form element, null if not set
     * @internal param bool $encode To sanitizer the text?
     *
     * @internal param string $name the "name" attribute of a form element
     */
    public function setAddBaliseTable($addBaliseTable)
    {
        $this->_addBaliseTable = $addBaliseTable;
    }

    /**
     * gets the "value" attribute of all form elements.
     *
     * @return bool|string array of name/value pairs assigned to form elements
     * @internal param bool $encode To sanitizer the text?
     *
     */
    public function getAddBaliseTable()
    {
        return $this->_addBaliseTable;
    }

    /**
     * Insert an empty row in the table to serve as a seperator.
     *
     * @param string $extra HTML to be displayed in the empty row.
     * @param string $class CSS class name for <td> tag
     */
    public function insertBreak($extra = '', $class = '')
    {
        $class = ('' != $class) ? " class='" . \preg_replace('/[^A-Za-z0-9\s\s_-]/i', '', $class) . "'" : '';
        // Fix for $extra tag not showing
        if ($extra) {
            $extra = '<tr><td colspan="2" ' . $class . '>' . $extra . '</td></tr>';
            $this->addElement($extra);
        } else {
            $extra = '<tr><td colspan="2" ' . $class . '>&nbsp;</td></tr>';
            $this->addElement($extra);
        }
    }

    /**
     * create HTML to output the form as a theme-enabled table with validation.
     *
     * YOU SHOULD AVOID TO USE THE FOLLOWING Nocolspan METHOD, IT WILL BE REMOVED
     *
     * To use the noColspan simply use the following example:
     *
     * $colspan = new \XoopsFormDhtmlTextArea( '', 'key', $value, '100%', '100%' );
     * $colspan->setNocolspan();
     * $form->addElement( $colspan );
     *
     * @return string
     */
    public function render()
    {
        $addBaliseTable = $this->_addBaliseTable;
        $title          = $this->getTitle();
        $ret            = '';

        if ($addBaliseTable) {
            $ret .= '<table width="100%" class="outer" cellspacing="1"> ';
        }

        if ('' != $title) {
            $ret .= '<tr><th colspan="2">' . $title . '</th></tr>';
        }

        $hidden = '';
        $class  = 'even';
        foreach ($this->getElements() as $ele) {
            if (!\is_object($ele)) {
                $ret .= $ele;
            } elseif (!$ele->isHidden()) {
                if (!$ele->getNocolspan()) {
                if (!/** @scrutinizer ignore-deprecated */ $ele->getNocolspan()) {
                    $ret .= '<tr valign="top" align="left"><td class="head">';
                    if ('' != ($caption = $ele->getCaption())) {
                        $ret .= '<div class="xoops-form-element-caption' . ($ele->isRequired() ? '-required' : '') . '">';
                        $ret .= '<span class="caption-text">' . $caption . '</span>';
                        $ret .= '<span class="caption-marker">*</span>';
                        $ret .= '</div>';
                    }
                    if ('' != ($desc = $ele->getDescription())) {
                        $ret .= '<div class="xoops-form-element-help">' . $desc . '</div>';
                    }
                    $ret .= '</td><td class="' . $class . '">' . $ele->render() . '</td></tr>' . NWLINE;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                } else {
                    $ret .= '<tr valign="top" align="left"><td class="head" colspan="2">';
                    if ('' != ($caption = $ele->getCaption())) {
                        $ret .= '<div class="xoops-form-element-caption' . ($ele->isRequired() ? '-required' : '') . '">';
                        $ret .= '<span class="caption-text">' . $caption . '</span>';
                        $ret .= '<span class="caption-marker">*</span>';
                        $ret .= '</div>';
                    }
                    $ret .= '</td></tr><tr valign="top" align="left"><td class="' . $class . '" colspan="2">' . $ele->render() . '</td></tr>';
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
                }
            } else {
                $hidden .= $ele->render();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
        }

        if ($addBaliseTable) {
            $ret .= '</table>';
        }

        $ret .= NWLINE . ' ' . $hidden . NWLINE;

        return $ret;
    }
} // fin de la classe


mambax7 / extcal

Issues (733)

Security Analysis not enabled

class/TableForm.php (4 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like