mambax7 / extcal

admin/upgrade.php

<?php

use Xmf\Request;

$step = 'default';
if (Request::hasVar('step', 'POST')) {
    $step = $_POST['step'];
}

require_once __DIR__ . '/admin_header.php';
require_once __DIR__ . '/function.php';

global $xoopsConfig;

// Change this variable if you use a cloned version of eXtGallery
$localModuleDir = 'extcal';

$moduleName     = 'extcal';
$versionFile    = 'http://www.zoullou.net/extcal.version';
$downloadServer = 'http://downloads.sourceforge.net/zoullou/';

$lastVersion       = @file_get_contents($versionFile);
$lastVersionString = mb_substr($lastVersion, 0, 1) . '.' . mb_substr($lastVersion, 1, 1) . '.' . mb_substr($lastVersion, 2, 1);

It seems like $lastVersion can also be of type false; however, parameter $string of mb_substr() does only seem to accept string, maybe add an additional type check?

$moduleFileName    = $moduleName . '-' . $lastVersionString . '.tar.gz';
$langFileName      = $moduleName . '-lang-' . $lastVersionString . '_' . $xoopsConfig['language'] . '.tar.gz';

switch ($step) {
    case 'download':
        xoops_cp_header();
        adminMenu();

The function adminMenu was not found. Maybe you did not declare it correctly or list all dependencies?

        if ($GLOBALS['xoopsModule']->getVar('version') >= $lastVersion) {
            echo _AM_EXTCAL_UPDATE_OK;
            xoops_cp_footer();
            break;
        }

        if (!$handle = @fopen($downloadServer . $moduleFileName, 'r')) {
            printf(_AM_EXTCAL_MD_FILE_DONT_EXIST, $downloadServer, $moduleFileName);
            xoops_cp_footer();
            break;
        }
        $localHandle = @fopen(XOOPS_ROOT_PATH . '/uploads/' . $moduleFileName, 'w+');

        // Downlad module archive
        if ($handle) {

$handle is of type resource, thus it always evaluated to false.

            while (!feof($handle)) {
                $buffer = fread($handle, 8192);
                fwrite($localHandle, $buffer);
            }
            fclose($localHandle);
            fclose($handle);
        }

        // English file are included on module package
        if ('english' !== $xoopsConfig['language']) {
            if (!$handle = @fopen($downloadServer . $langFileName, 'r')) {
                printf(_AM_EXTCAL_LG_FILE_DONT_EXIST, $downloadServer, $langFileName);
            } else {
                $localHandle = @fopen(XOOPS_ROOT_PATH . '/uploads/' . $langFileName, 'w+');
                // Download language archive
                if ($handle) {

$handle is of type resource, thus it always evaluated to false.

                    while (!feof($handle)) {
                        $buffer = fread($handle, 8192);
                        fwrite($localHandle, $buffer);
                    }
                    fclose($localHandle);
                    fclose($handle);
                }
            }
        }

        xoops_confirm(['step' => 'install'], 'upgrade.php', _AM_EXTCAL_DOWN_DONE, _AM_EXTCAL_INSTALL);

        xoops_cp_footer();

        break;
    case 'install':
        xoops_cp_header();
        adminMenu();

        if (!file_exists(XOOPS_ROOT_PATH . '/uploads/' . $moduleFileName)) {
            echo _AM_EXTCAL_MD_FILE_DONT_EXIST_SHORT;
            xoops_cp_footer();

            break;
        }

        $gPcltarLibDir = XOOPS_ROOT_PATH . '/modules/' . $localModuleDir . '/class';
        require_once dirname(__DIR__) . '/class/pcltar.lib.php';

        //TrOn(5);

        // Extract module files
        PclTarExtract(XOOPS_ROOT_PATH . '/uploads/' . $moduleFileName, XOOPS_ROOT_PATH . '/modules/' . $localModuleDir . '/', 'modules/' . $moduleName . '/');
        // Delete downloaded module's files
        unlink(XOOPS_ROOT_PATH . '/uploads/' . $moduleFileName);

        if (file_exists(XOOPS_ROOT_PATH . '/uploads/' . $langFileName)) {
            // Extract language files
            PclTarExtract(XOOPS_ROOT_PATH . '/uploads/' . $langFileName, XOOPS_ROOT_PATH . '/modules/' . $localModuleDir . '/', 'modules/' . $moduleName . '/');
            // Delete downloaded module's files
            unlink(XOOPS_ROOT_PATH . '/uploads/' . $langFileName);
        }

        // Delete template_c file
        $handle = opendir(XOOPS_ROOT_PATH . '/templates_c');
        if ($handle) {

$handle is of type resource, thus it always evaluated to false.

            while (false !== ($file = readdir($handle))) {
                if ('.' !== $file && '..' !== $file && 'index.html' !== $file) {
                    unlink(XOOPS_ROOT_PATH . '/templates_c/' . $file);
                }
            }

            closedir($handle);
        }
        //TrDisplay();

        xoops_confirm(['dirname' => $localModuleDir, 'op' => 'update_ok', 'fct' => 'modulesadmin'], XOOPS_URL . '/modules/system/admin.php', _AM_EXTCAL_INSTALL_DONE, _AM_EXTCAL_UPDATE);

        xoops_cp_footer();

        break;
    default:
    case 'default':
        redirect_header('index.php', 3, '');

        break;
}