mambax7 /
extcal
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 158 |
| Code Lines | 141 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php namespace XoopsModules\Extcal\Form; |
||
| 63 | public function render() |
||
| 64 | { |
||
| 65 | $ret = ''; |
||
| 66 | |||
| 67 | $formObject = new \XoopsFormRadio('', 'rrule_freq', $this->_rrule_freq); |
||
| 68 | $formObject->addOption('none', _MD_EXTCAL_NO_RECCUR_EVENT); |
||
| 69 | $ret .= $formObject->render(); |
||
| 70 | $ret .= '<br><br><fieldset><legend>' . _MD_EXTCAL_RECCUR_POLICY . '</legend><fieldset><legend>'; |
||
| 71 | |||
| 72 | $formObject = new \XoopsFormRadio('', 'rrule_freq', $this->_rrule_freq); |
||
| 73 | $formObject->addOption('daily', _MD_EXTCAL_DAILY); |
||
| 74 | $ret .= $formObject->render(); |
||
| 75 | $ret .= '</legend>' . _MD_EXTCAL_DURING . ' '; |
||
| 76 | |||
| 77 | $formObject = new \XoopsFormText('', 'rrule_daily_interval', 3, 2, $this->_rrule_daily_interval); |
||
| 78 | $ret .= $formObject->render(); |
||
| 79 | $ret .= ' ' . _MD_EXTCAL_DAYS . '</fieldset><br><fieldset><legend>'; |
||
| 80 | |||
| 81 | $formObject = new \XoopsFormRadio('', 'rrule_freq', $this->_rrule_freq); |
||
| 82 | $formObject->addOption('weekly', _MD_EXTCAL_WEEKLY); |
||
| 83 | $ret .= $formObject->render(); |
||
| 84 | $ret .= '</legend>' . _MD_EXTCAL_DURING . ' '; |
||
| 85 | |||
| 86 | $formObject = new \XoopsFormText('', 'rrule_weekly_interval', 3, 2, $this->_rrule_weekly_interval); |
||
| 87 | $ret .= $formObject->render(); |
||
| 88 | $ret .= ' ' . _MD_EXTCAL_WEEKS . '<br>'; |
||
| 89 | |||
| 90 | $formObject = new \XoopsFormCheckBox('', 'rrule_weekly_bydays', $this->_rrule_weekly_bydays); |
||
| 91 | $formObject->addOption('MO', _MD_EXTCAL_MO2 . ' '); |
||
| 92 | $formObject->addOption('TU', _MD_EXTCAL_TU2 . ' '); |
||
| 93 | $formObject->addOption('WE', _MD_EXTCAL_WE2 . ' '); |
||
| 94 | $formObject->addOption('TH', _MD_EXTCAL_TH2 . ' '); |
||
| 95 | $formObject->addOption('FR', _MD_EXTCAL_FR2 . ' '); |
||
| 96 | $formObject->addOption('SA', _MD_EXTCAL_SA2 . ' '); |
||
| 97 | $formObject->addOption('SU', _MD_EXTCAL_SU2 . ' '); |
||
| 98 | $ret .= $formObject->render(); |
||
| 99 | $ret .= '</fieldset><br><fieldset><legend>'; |
||
| 100 | |||
| 101 | $formObject = new \XoopsFormRadio('', 'rrule_freq', $this->_rrule_freq); |
||
| 102 | $formObject->addOption('monthly', _MD_EXTCAL_MONTHLY); |
||
| 103 | $ret .= $formObject->render(); |
||
| 104 | $ret .= '</legend>' . _MD_EXTCAL_DURING . ' '; |
||
| 105 | |||
| 106 | $formObject = new \XoopsFormText('', 'rrule_monthly_interval', 3, 2, $this->_rrule_monthly_interval); |
||
| 107 | $ret .= $formObject->render(); |
||
| 108 | $ret .= ' ' . _MD_EXTCAL_MONTH . ', ' . _MD_EXTCAL_ON . ' '; |
||
| 109 | |||
| 110 | $formObject = new \XoopsFormSelect('', 'rrule_monthly_byday', $this->_rrule_monthly_byday); |
||
| 111 | $formObject->addOption('', ' '); |
||
| 112 | $formObject->addOption('1MO', _MD_EXTCAL_1_MO); |
||
| 113 | $formObject->addOption('1TU', _MD_EXTCAL_1_TU); |
||
| 114 | $formObject->addOption('1WE', _MD_EXTCAL_1_WE); |
||
| 115 | $formObject->addOption('1TH', _MD_EXTCAL_1_TH); |
||
| 116 | $formObject->addOption('1FR', _MD_EXTCAL_1_FR); |
||
| 117 | $formObject->addOption('1SA', _MD_EXTCAL_1_SA); |
||
| 118 | $formObject->addOption('1SU', _MD_EXTCAL_1_SU); |
||
| 119 | $formObject->addOption('2MO', _MD_EXTCAL_2_MO); |
||
| 120 | $formObject->addOption('2TU', _MD_EXTCAL_2_TU); |
||
| 121 | $formObject->addOption('2WE', _MD_EXTCAL_2_WE); |
||
| 122 | $formObject->addOption('2TH', _MD_EXTCAL_2_TH); |
||
| 123 | $formObject->addOption('2FR', _MD_EXTCAL_2_FR); |
||
| 124 | $formObject->addOption('2SA', _MD_EXTCAL_2_SA); |
||
| 125 | $formObject->addOption('2SU', _MD_EXTCAL_2_SU); |
||
| 126 | $formObject->addOption('3MO', _MD_EXTCAL_3_MO); |
||
| 127 | $formObject->addOption('3TU', _MD_EXTCAL_3_TU); |
||
| 128 | $formObject->addOption('3WE', _MD_EXTCAL_3_WE); |
||
| 129 | $formObject->addOption('3TH', _MD_EXTCAL_3_TH); |
||
| 130 | $formObject->addOption('3FR', _MD_EXTCAL_3_FR); |
||
| 131 | $formObject->addOption('3SA', _MD_EXTCAL_3_SA); |
||
| 132 | $formObject->addOption('3SU', _MD_EXTCAL_3_SU); |
||
| 133 | $formObject->addOption('4MO', _MD_EXTCAL_4_MO); |
||
| 134 | $formObject->addOption('4TU', _MD_EXTCAL_4_TU); |
||
| 135 | $formObject->addOption('4WE', _MD_EXTCAL_4_WE); |
||
| 136 | $formObject->addOption('4TH', _MD_EXTCAL_4_TH); |
||
| 137 | $formObject->addOption('4FR', _MD_EXTCAL_4_FR); |
||
| 138 | $formObject->addOption('4SA', _MD_EXTCAL_4_SA); |
||
| 139 | $formObject->addOption('4SU', _MD_EXTCAL_4_SU); |
||
| 140 | $formObject->addOption('-1MO', _MD_EXTCAL_LAST_MO); |
||
| 141 | $formObject->addOption('-1TU', _MD_EXTCAL_LAST_TU); |
||
| 142 | $formObject->addOption('-1WE', _MD_EXTCAL_LAST_WE); |
||
| 143 | $formObject->addOption('-1TH', _MD_EXTCAL_LAST_TH); |
||
| 144 | $formObject->addOption('-1FR', _MD_EXTCAL_LAST_FR); |
||
| 145 | $formObject->addOption('-1SA', _MD_EXTCAL_LAST_SA); |
||
| 146 | $formObject->addOption('-1SU', _MD_EXTCAL_LAST_SU); |
||
| 147 | $ret .= $formObject->render(); |
||
| 148 | $ret .= ' ' . _MD_EXTCAL_OR_THE . ' '; |
||
| 149 | |||
| 150 | $formObject = new \XoopsFormText('', 'rrule_bymonthday', 3, 2, $this->_rrule_bymonthday); |
||
| 151 | $ret .= $formObject->render(); |
||
| 152 | $ret .= ' ' . _MD_EXTCAL_DAY_NUM_MONTH . '</fieldset><br><fieldset><legend>'; |
||
| 153 | |||
| 154 | $formObject = new \XoopsFormRadio('', 'rrule_freq', $this->_rrule_freq); |
||
| 155 | $formObject->addOption('yearly', _MD_EXTCAL_YEARLY); |
||
| 156 | $ret .= $formObject->render(); |
||
| 157 | $ret .= '</legend>' . _MD_EXTCAL_DURING . ' '; |
||
| 158 | |||
| 159 | $formObject = new \XoopsFormText('', 'rrule_yearly_interval', 3, 2, $this->_rrule_yearly_interval); |
||
| 160 | $ret .= $formObject->render(); |
||
| 161 | $ret .= ' ' . _MD_EXTCAL_YEARS . '<br>'; |
||
| 162 | |||
| 163 | $formObject = new Extcal\Form\FormRRuleCheckBox('', 'rrule_yearly_bymonths', $this->_rrule_yearly_bymonths); |
||
| 164 | $formObject->addOption('1', _MD_EXTCAL_JAN); |
||
| 165 | $formObject->addOption('2', _MD_EXTCAL_FEB); |
||
| 166 | $formObject->addOption('3', _MD_EXTCAL_MAR); |
||
| 167 | $formObject->addOption('4', _MD_EXTCAL_APR); |
||
| 168 | $formObject->addOption('5', _MD_EXTCAL_MAY); |
||
| 169 | $formObject->addOption('6', _MD_EXTCAL_JUN); |
||
| 170 | $formObject->addOption('7', _MD_EXTCAL_JUL); |
||
| 171 | $formObject->addOption('8', _MD_EXTCAL_AUG); |
||
| 172 | $formObject->addOption('9', _MD_EXTCAL_SEP); |
||
| 173 | $formObject->addOption('10', _MD_EXTCAL_OCT); |
||
| 174 | $formObject->addOption('11', _MD_EXTCAL_NOV); |
||
| 175 | $formObject->addOption('12', _MD_EXTCAL_DEC); |
||
| 176 | $ret .= $formObject->render(); |
||
| 177 | $ret .= '<br>'; |
||
| 178 | |||
| 179 | $formObject = new \XoopsFormSelect('', 'rrule_yearly_byday', $this->_rrule_yearly_byday); |
||
| 180 | $formObject->addOption('', _MD_EXTCAL_SAME_ST_DATE); |
||
| 181 | $formObject->addOption('1MO', _MD_EXTCAL_1_MO); |
||
| 182 | $formObject->addOption('1TU', _MD_EXTCAL_1_TU); |
||
| 183 | $formObject->addOption('1WE', _MD_EXTCAL_1_WE); |
||
| 184 | $formObject->addOption('1TH', _MD_EXTCAL_1_TH); |
||
| 185 | $formObject->addOption('1FR', _MD_EXTCAL_1_FR); |
||
| 186 | $formObject->addOption('1SA', _MD_EXTCAL_1_SA); |
||
| 187 | $formObject->addOption('1SU', _MD_EXTCAL_1_SU); |
||
| 188 | $formObject->addOption('2MO', _MD_EXTCAL_2_MO); |
||
| 189 | $formObject->addOption('2TU', _MD_EXTCAL_2_TU); |
||
| 190 | $formObject->addOption('2WE', _MD_EXTCAL_2_WE); |
||
| 191 | $formObject->addOption('2TH', _MD_EXTCAL_2_TH); |
||
| 192 | $formObject->addOption('2FR', _MD_EXTCAL_2_FR); |
||
| 193 | $formObject->addOption('2SA', _MD_EXTCAL_2_SA); |
||
| 194 | $formObject->addOption('2SU', _MD_EXTCAL_2_SU); |
||
| 195 | $formObject->addOption('3MO', _MD_EXTCAL_3_MO); |
||
| 196 | $formObject->addOption('3TU', _MD_EXTCAL_3_TU); |
||
| 197 | $formObject->addOption('3WE', _MD_EXTCAL_3_WE); |
||
| 198 | $formObject->addOption('3TH', _MD_EXTCAL_3_TH); |
||
| 199 | $formObject->addOption('3FR', _MD_EXTCAL_3_FR); |
||
| 200 | $formObject->addOption('3SA', _MD_EXTCAL_3_SA); |
||
| 201 | $formObject->addOption('3SU', _MD_EXTCAL_3_SU); |
||
| 202 | $formObject->addOption('4MO', _MD_EXTCAL_4_MO); |
||
| 203 | $formObject->addOption('4TU', _MD_EXTCAL_4_TU); |
||
| 204 | $formObject->addOption('4WE', _MD_EXTCAL_4_WE); |
||
| 205 | $formObject->addOption('4TH', _MD_EXTCAL_4_TH); |
||
| 206 | $formObject->addOption('4FR', _MD_EXTCAL_4_FR); |
||
| 207 | $formObject->addOption('4SA', _MD_EXTCAL_4_SA); |
||
| 208 | $formObject->addOption('4SU', _MD_EXTCAL_4_SU); |
||
| 209 | $formObject->addOption('-1MO', _MD_EXTCAL_LAST_MO); |
||
| 210 | $formObject->addOption('-1TU', _MD_EXTCAL_LAST_TU); |
||
| 211 | $formObject->addOption('-1WE', _MD_EXTCAL_LAST_WE); |
||
| 212 | $formObject->addOption('-1TH', _MD_EXTCAL_LAST_TH); |
||
| 213 | $formObject->addOption('-1FR', _MD_EXTCAL_LAST_FR); |
||
| 214 | $formObject->addOption('-1SA', _MD_EXTCAL_LAST_SA); |
||
| 215 | $formObject->addOption('-1SU', _MD_EXTCAL_LAST_SU); |
||
| 216 | $ret .= $formObject->render(); |
||
| 217 | $ret .= '</fieldset></fieldset>'; |
||
| 218 | |||
| 219 | return $ret; |
||
| 220 | } |
||
| 221 | } |
||
| 222 |
Loading history...