mambax7 /
extcal
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 73 | class Calendar_Minute extends Calendar |
||
| 74 | { |
||
| 75 | /** |
||
| 76 | * Constructs Minute. |
||
| 77 | * |
||
| 78 | * @param int $y year e.g. 2003 |
||
| 79 | * @param int $m month e.g. 5 |
||
| 80 | * @param int $d day e.g. 11 |
||
| 81 | * @param int $h hour e.g. 13 |
||
| 82 | * @param int $i minute e.g. 31 |
||
| 83 | */ |
||
| 84 | public function __construct($y, $m, $d, $h, $i) |
||
| 85 | { |
||
| 86 | parent::__construct($y, $m, $d, $h, $i); |
||
| 87 | } |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Builds the Calendar_Second objects. |
||
| 91 | * |
||
| 92 | * @param array $sDates (optional) Calendar_Second objects representing selected dates |
||
| 93 | * |
||
| 94 | * @return bool |
||
| 95 | */ |
||
| 96 | public function build($sDates = []) |
||
| 97 | { |
||
| 98 | require_once CALENDAR_ROOT . 'Second.php'; |
||
| 99 | $sIM = $this->cE->getSecondsInMinute($this->year, $this->month, $this->day, $this->hour, $this->minute); |
||
| 100 | for ($i = 0; $i < $sIM; ++$i) { |
||
| 101 | $this->children[$i] = new Calendar_Second($this->year, $this->month, $this->day, $this->hour, $this->minute, $i); |
||
| 102 | } |
||
| 103 | if (count($sDates) > 0) { |
||
| 104 | $this->setSelection($sDates); |
||
| 105 | } |
||
| 106 | |||
| 107 | return true; |
||
| 108 | } |
||
| 109 | |||
| 110 | /** |
||
| 111 | * Called from build(). |
||
| 112 | * |
||
| 113 | * @param array $sDates Calendar_Second objects representing selected dates |
||
| 114 | * @return bool|void |
||
| 115 | */ |
||
| 116 | public function setSelection($sDates) |
||
| 128 | } |
||
| 129 | } |
||
| 130 | } |
||
| 131 | } |
||
| 132 | } |
||
| 133 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.