bExtcalUpcomingShow()

Complexity

Conditions	6
Paths	5

Size

Total Lines	76
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function bExtcalUpcomingShow($options)
{
    /** @var Helper $helper */
    if (!class_exists(Helper::class)) {
        return false;

The expression return false returns the type false which is incompatible with the documented return type array.

    }

    $helper = Helper::getInstance();
    $helper->loadLanguage('main');
    $helper->loadLanguage('blocks');

    $eventHandler = $helper->getHandler(_EXTCAL_CLN_EVENT);

    $nbEvent     = $options[0];
    $titleLenght = $options[1];

The assignment to $titleLenght is dead and can be removed.

    $nbDays      = $options[2];

    array_shift($options);
    array_shift($options);
    array_shift($options);

    // Checking if no cat is selected
    if (isset($options[0]) && 0 == $options[0] && 1 == count($options)) {
        $options = 0;

The assignment to $options is dead and can be removed.

    }

    //-------------------
    /* ========================================================================== */
    $year  = \Xmf\Request::getInt('year', date('Y'), 'GET');

date('Y') of type string is incompatible with the type integer expected by parameter $default of Xmf\Request::getInt().

    $month = \Xmf\Request::getInt('month', date('n'), 'GET');
    $day   = \Xmf\Request::getInt('day', date('j'), 'GET');
    $cat   = \Xmf\Request::getInt('cat', 0, 'GET');
    /* ========================================================================== */

    // Validate the date (day, month and year)
    $dayTS = mktime(0, 0, 0, $month, $day, $year);

    //$offset = $helper->getConfig('week_start_day') - date('w', $dayTS);

    //------- mb --------------
    //   let's make sure that the upcoming events start tomorrow
    //    $offset = date('w', $dayTS) + 7-$helper->getConfig('week_start_day')<7 ? date('w', $dayTS) + 7-$helper->getConfig('week_start_day') : 0;
    //    $dayTS = $dayTS - ($offset * _EXTCAL_TS_DAY);

    $dayTS += _EXTCAL_TS_DAY;
    //------- mb -----------------

    $year  = date('Y', $dayTS);
    $month = date('n', $dayTS);
    $day   = date('j', $dayTS);

    // Retriving events and formatting them
    //$events = $eventHandler->objectToArray($eventHandler->getEventWeek($day, $month, $year, $cat), array('cat_id'));
    $criteres = [
        'periode'      => _EXTCAL_EVENTS_UPCOMING,
        //        'periode'      => _EXTCAL_EVENTS_CALENDAR_WEEK,
        'day'          => $day,
        'month'        => $month,
        'year'         => $year,
        'cat'          => $cat,
        'externalKeys' => 'cat_id',
        'nbEvent'      => $nbEvent,
        'nbDays'       => $nbDays,
    ];
    $events   = $eventHandler->getEventsOnPeriode($criteres);

The method getEventsOnPeriode() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    //----------------------------

    //$eventHandler->serverTimeToUserTimes($events);
    $eventHandler->formatEventsDate($events, $helper->getConfig('event_date_month'));

The method formatEventsDate() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    if (count($events) > $nbEvent) {
        $events = array_slice($events, 0, $nbEvent);

It seems like $events can also be of type null; however, parameter $array of array_slice() does only seem to accept array, maybe add an additional type check?

    }

    return $events;
}