ExtcalFormRRuleCheckBox

Complexity

Total Complexity

8

Size/Duplication

Total Lines	40
Duplicated Lines	10 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	render()	4	22	7

<?php
/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      extcal
 * @since
 * @author       XOOPS Development Team,
 */

/**
 * Class ExtcalFormRRuleCheckBox.
 */
class ExtcalFormRRuleCheckBox extends XoopsFormCheckBox

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @param      $caption
     * @param      $name
     * @param null $value
     */
    public function __construct($caption, $name, $value = null)
    {
        parent::__construct($caption, $name, $value);
    }

    /**
     * prepare HTML for output.
     *
     * @return string
     */
    public function render()
    {
        $ret = '<table><tr>';
        $i   = 0;
        if (count($this->getOptions()) > 1 && '[]' !== substr($this->getName(), -2, 2)) {

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

This code seems to be duplicated across your project.

            $newname = $this->getName() . '[]';

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            $this->setName($newname);
        }
        foreach ($this->getOptions() as $value => $name) {
            if (0 == (++$i) % 6) {
                $ret .= '</tr><tr>';
            }
            $ret .= "<td><input type='checkbox' name='" . $this->getName() . "' value='" . $value . "'";

Consider using $this->name. There is an issue with getName() and APC-enabled PHP versions.

            if (count($this->getValue()) > 0 && in_array($value, $this->getValue())) {
                $ret .= ' checked';
            }
            $ret .= $this->getExtra() . '>' . $name . "</td>\n";
        }
        $ret .= '</tr></table>';

        return $ret;
    }
}