mail_fnc.php ➔ extcal_SendMail() - Code Metrics - Inspection of "cosmetics" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9decc...a21b67 )

by Michael

created 2017-07-21 23:45 UTC

mail_fnc.php ➔ extcal_SendMail() B

↳ Parent: Project

Complexity

Conditions	5
Paths	16

Size

Total Lines	78
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	29
nc	16
nop	8
dl	0
loc	78
rs	8.4316
c	0
b	0
f	0

How to fix Long Method Many Parameters

<?php

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      extcal
 * @since
 * @author       XOOPS Development Team,
 *
 * L'utilisation de ce formulaire d'adminitration suppose
 * que la classe correspondante de la table a été générées avec classGenerator
 **/

require_once __DIR__ . '/../../../class/uploader.php';
require_once __DIR__ . '/../../../class/mail/phpmailer/class.phpmailer.php'; // First we require the PHPMailer libary in our script
require_once __DIR__ . '/../class/utility.php';
require_once __DIR__ . '/constantes.php';
require_once __DIR__ . '/../../../class/template.php';

/********************************************************************
 *
 *******************************************************************
 * @param $mode
 * @param $event_id
 * @param $member_uid
 * @param $subject
 * @param $tplMessage
 */
function sendMail2member($mode, $event_id, $member_uid, $subject, $tplMessage)

{
    //mode = 0 pas d'entete
    //mode = 1 format text
    //mode = 2: format html

    global $xoopsConfig, $xoopsDB;
function myFunction($a, $b) {
    // Do something
}
    // $t = print_r($xoopsConfig, true);

    // echo "<pre>{$t}</pre>";
    /*

    $member_uid = 1;
    $event_id = 393;
    $message = "Bonne journée à tous";
    $newStatus = 1;
    $oldStatus = 0;

    */

    //l'utilisateur ne pas etre notifié par mail
    //if ($mode == 0) exit;

    //-------------------------------------------------------
    $tblMember    = $xoopsDB->prefix('extcal_eventmember');
    $tblNotMember = $xoopsDB->prefix('extcal_eventnotmember');
    $tblUsers     = $xoopsDB->prefix('users');
    $tblEvent     = $xoopsDB->prefix('extcal_event');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    //--------------------------------------------------------------
    //Recuperation des données event,user et member
    //Recuperation des données de l'evennement
    $eventHandler = xoops_getModuleHandler(_EXTCAL_CLS_EVENT, _EXTCAL_MODULE);
    $obj          = $eventHandler->getEvent($event_id);
    $event        = $eventHandler->objectToArray($obj);
    $eventHandler->formatEventDate($event, _MD_EXTCAL_FORMAT_DATE);

    $submiter_uid = $event['event_submitter'];
    // ext_echoArray($event,'event');

    //--------------------------------------------------------------
    //Recuperation des données du user createur de l'evennement
    $sql = <<<__sql__
  SELECT if(tu.name='', tu.uname, tu.name) AS name,     tu.uname,   tu.email
  FROM {$tblUsers} tu
  WHERE tu.uid = {$submiter_uid};
__sql__;

    $rst      = $xoopsDB->query($sql);
    $submiter = $xoopsDB->fetchArray($rst);
    // echo "{$sql}<br>";
    // ext_echoArray($submiter,'submiter');

    //--------------------------------------------------------------
    //Recuperation des données du membre inscrit
    $sql = <<<__sql__
  SELECT if(tu.name='', tu.uname, tu.name) AS name,     tu.uname,   tu.email
  FROM {$tblUsers} tu
  WHERE tu.uid = {$member_uid};
__sql__;

    $rst    = $xoopsDB->query($sql);
    $acteur = $xoopsDB->fetchArray($rst);
    //echo "{$sql}<br>";
    // ext_echoArray($acteur,'acteur');

    //--------------------------------------------------------------
    //Recuperation des données des membres présents
    $sql = <<<__sql__
SELECT tu.uid, if(tu.name='', tu.uname, tu.name) AS name,   tu.uname,   tu.email,
        tm.status
FROM {$tblMember} tm,
     {$tblUsers}  tu
WHERE tm.uid = tu.uid
  AND tm.event_id = {$event_id}
__sql__;

    $rst     = $xoopsDB->query($sql);
    $members = array();
    while ($row = $xoopsDB->fetchArray($rst)) {

        $row['status']        = _MD_EXTCAL_PRESENT;
        $members[$row['uid']] = $row;
    }

    //--------------------------------------------------------------
    //Recuperation des données des membres absents
    $sql = <<<__sql__
SELECT tu.uid, if(tu.name='', tu.uname, tu.name) AS name,   tu.uname,   tu.email,
        tm.status
FROM {$tblNotMember} tm,
     {$tblUsers}  tu
WHERE tm.uid = tu.uid
  AND tm.event_id = {$event_id}
__sql__;

    $rst = $xoopsDB->query($sql);
    while ($row = $xoopsDB->fetchArray($rst)) {

        $row['status']        = _MD_EXTCAL_ABSENT;
        $members[$row['uid']] = $row;
    }

    // ext_echoArray($members,'members');

    // exit;

    //--------------------------------------------------------------
    //Message et sujet du mail
    $action  = ''; //a voir   JJD
    $message = sprintf($tplMessage, $acteur['name']);
    //$subject .= ' (' . rand(1, 100) . ')';

    $subject .= ' - ' . $acteur['name'];
    //--------------------------------------------------------------
    //Chargement du template dans le dossier de langue
    //$f = _EXTCAL_PATH_LG . $xoopsConfig['language'] . '\mail_inscription.html';

    //$tpl = new tpl($f);

    $tpl = new XoopsTpl();

    $tpl->assign('dateAction', date(_MD_EXTCAL_FORMAT_DATE));
    $tpl->assign('submiter', $submiter);
    $tpl->assign('event', $event);
    $tpl->assign('acteur', $acteur);
    $tpl->assign('members', $members);
    $tpl->assign('action', $action);
    $tpl->assign('subject', $subject);
    $tpl->assign('message', $message);
    $tpl->assign('xoopsConfig', $xoopsConfig);
    $tpl->assign('br', '<br>');

    //--------------------------------------------------------------
    $destinataires                     = array();
    $destinataires[$submiter['email']] = $submiter['email'];
    $destinataires[$acteur['email']]   = $acteur['email'];
//    while (list($k, $row) = each($members)) {

    foreach ($members as $k => $row) {
        $destinataires[$row['email']] = $row['email'];
    }

    // ext_echoArray($destinataires);

    // exit;

    $mail_fromName  = $xoopsConfig['sitename'];
    $mail_fromemail = $xoopsConfig['adminmail'];
    $mail_subject   = $subject;

    $bEcho = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $mode  = _EXTCAL_HEADER_HTML;
    $sep   = '|';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    $template = 'extcal_mail_member_text.tpl';
    if ($mode == _EXTCAL_HEADER_HTML) {
        $template = 'extcal_mail_member_html.tpl';
    }
    $mail_body = $tpl->fetch('db:' . $template);

    extcal_SendMail($destinataires, $mail_fromName, $mail_fromemail, $mail_subject, $mail_body, $bEcho = false, $mode = 0, $sep = '|');

    //Prépartion de l'envoi

    //--------------------------------------------------------------
}

/*****************************************************************
 ****************************************************************
 * @param        $destinataires
 * @param        $mail_fromname
 * @param        $mail_fromemail
 * @param        $mail_subject
 * @param        $mail_body
 * @param bool   $bEcho
 * @param int    $mode
 * @param string $sep
 */
function extcal_SendMail(
    $destinataires,
    $mail_fromname,
    $mail_fromemail,
    $mail_subject,
    $mail_body,
    $bEcho = false,
    $mode = 0,

    $sep = '|'
) {
    global $ModName, $signature, $mail_admin, $xoopsConfig, $xoopsDB, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}

    //$bEcho=false;
    //echo "<hr>function hermesMail<hr>";

    // $destinataires = array('[email protected]','[email protected]','[email protected]');

    //$mail_fromname = "test jjd hermes";

    if ($mail_fromname == '') {
        $mail_fromname = $mail_fromemail;
    }

    //$mail_fromemail = "[email protected]";

    //$mail_subject = "test hemes";

    //$mail_body = getContentTestMail();

    //-----------------------------
    if (!is_array($destinataires)) {
        $destinataires = explode($sep, $destinataires);
    }
    $header = extcal_getHeader(1, $mail_fromemail);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    //-----------------------------
    $myts = MyTextSanitizer::getInstance();
    //$xoopsMailer = getMailer();

    $xoopsMailer = xoops_getMailer();

    //$xoopsMailer->setToUsers($destinataires[$i]);


//    while (list($k, $v) = each($destinataires)) {

    foreach ($destinataires as $k => $v) {
        //for ( $i = 0, $iMax = count($destinataires); $i < $iMax; ++$i) {

        //$xoopsMailer->setToUsers($destinataires[$i]);

        $xoopsMailer->setToEmails($v);
        //echo "setToUsers : {$destinataires[$i]}<br>";
    }

    $xoopsMailer->multimailer->isHTML(true);
    $xoopsMailer->setFromName($myts->oopsStripSlashesGPC($mail_fromname));

    $xoopsMailer->setFromEmail($myts->oopsStripSlashesGPC($mail_fromemail));

    $xoopsMailer->setSubject($myts->oopsStripSlashesGPC($mail_subject));
    $xoopsMailer->setBody($myts->oopsStripSlashesGPC($mail_body));
    //$xoopsMailer->encodeBody($mail_body);


    $xoopsMailer->useMail();

    //function $xoopsMailer->sendMail($email, $subject, $body, $headers)

    $xoopsMailer->send($bEcho);

    if ($bEcho) {
        ExtcalUtility::ext_echo($xoopsMailer->getSuccess());
        ExtcalUtility::ext_echo($xoopsMailer->getErrors());
    }
    /*


     echo "<hr>mail_fromname : {$mail_fromname}<br>"
          ."mail_fromemail : {$mail_fromemail}<br>"
          ."mail_subject : {$mail_subject}<br>"
          ."mail_body : {$mail_body}<br><hr>";
    */
    //---------------------------
    /*


      $adresse = "[email protected]";
      $bolOk = mail($adresse, "test envoi mail", "test envoi envoi mail via php");
      $r= (($bolOk) ? " => Succés" : "Echec");
      echo "<hr>==> <b>{$r}</b> de l'envoi du mail a: ==> {$adresse}<br>" ;
    */
}

/****************************************************************************
 *
 ***************************************************************************
 * @param $mode
 * @param $emailSender
 *
 * @return string
 */
function extcal_getHeader($mode, $emailSender)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    //mode = 0 pas d'entete
    //mode = 1 format text
    //mode = 2: format html

    global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}

    // $t = print_r($xoopsConfig, true);

    // echo "<pre>{$t}</pre>";

    //------------------------------------------------------
    $d = date('d-m-Y h:m:h', time());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    //-----------------------------------------------------------
    //defini l'expediteur du mail
    if ($emailSender == '') {
        if ($xoopsConfig['adminmail'] == '') {
            $emailSender = "webmaster@{$_SERVER['SERVER_NAME']}";
        } else {
            $emailSender = $xoopsConfig['adminmail'];
        }
    }
    //-----------------------------------------------------------
    $header   = array();
    $header[] = "From: {$emailSender}";
    $header[] = "Reply-To: {$emailSender}";
    $header[] = 'X-Mailer: PHP/' . PHP_VERSION;

    if ($mode == _EXTCAL_HEADER_HTML) {
        $header[] = 'MIME-Version: 1.0';
        $header[] = 'Content-type: text/html; charset=iso-8859-1';
    } else {
if (rand(1, 6) > 3) {
print "Check failed";
} else {
    //print "Check succeeded";
}
        //bin rien a prori
    }
    $header[] = '';

    //$sHeader = implode("\r\n", $header);

    $sHeader = implode("\r\n", $header);

    return $sHeader;
}


Push — master ( a9decc...a21b67 )

mail_fnc.php ➔ extcal_SendMail() B

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-07-21 23:48 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 38 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			* You may not change or alter any portion of this comment or credits
4			* of supporting developers from this source code or any supporting source code
5			* which is considered copyrighted (c) material of the original comment or credit authors.
6			*
7			* This program is distributed in the hope that it will be useful,
8			* but WITHOUT ANY WARRANTY; without even the implied warranty of
9			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* @copyright {@link https://xoops.org/ XOOPS Project}
14			* @license {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
15			* @package extcal
16			* @since
17			* @author XOOPS Development Team,
18			*
19			* L'utilisation de ce formulaire d'adminitration suppose
20			* que la classe correspondante de la table a été générées avec classGenerator
21			**/
22
23			require_once __DIR__ . '/../../../class/uploader.php';
24			require_once __DIR__ . '/../../../class/mail/phpmailer/class.phpmailer.php'; // First we require the PHPMailer libary in our script
25			require_once __DIR__ . '/../class/utility.php';
26			require_once __DIR__ . '/constantes.php';
27			require_once __DIR__ . '/../../../class/template.php';
28
29			/********************************************************************
30			*
31			*******************************************************************
32			* @param $mode
33			* @param $event_id
34			* @param $member_uid
35			* @param $subject
36			* @param $tplMessage
37			*/
38			function sendMail2member($mode, $event_id, $member_uid, $subject, $tplMessage)
			0 ignored issues – show Unused Code introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report The parameter `$mode` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...

mambax7 / extcal

Push — master ( a9decc...a21b67 )

mail_fnc.php ➔ extcal_SendMail() B

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like