agenda_fnc.php ➔ getNavBarTabs() - Code Metrics - Inspection of "cosmetics" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9decc...a21b67 )

by Michael

created 2017-07-21 23:45 UTC

agenda_fnc.php ➔ getNavBarTabs() F

↳ Parent: Project

Complexity

Conditions	25
Paths	> 20000

Size

Total Lines	140
Code Lines	91

Duplication

Lines	80
Ratio	57.14 %

Importance

Changes

Metric	Value
cc	25
eloc	91
nc	354294
nop	1
dl	80
loc	140
rs	2
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

/**
 * classGenerator
 * walls_watermarks.
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 *
 *
 * L'utilisation de ce formulaire d'adminitration suppose
 * que la classe correspondante de la table a été générées avec classGenerator
 **/
define('_EXTCAL_FORMAT_AGENDA_KEYD', 'Y-m-d');
define('_EXTCAL_FORMAT_AGENDA_KEYT', 'H:i');

require_once __DIR__ . '/constantes.php';
require_once __DIR__ . '/../class/utility.php';

$moduleDirName = basename(dirname(__DIR__));
xoops_loadLanguage('main', $moduleDirName);

/*******************************************************************
 *
 ******************************************************************
 * @param        $ts
 * @param        $hStart
 * @param        $hEnd
 * @param int    $mPlage
 * @param int    $nbJours
 * @param        $formatDate
 * @param string $formatJour
 *
 * @return array
 */

function agenda_getCanevas($ts, $hStart, $hEnd, $mPlage = 15, $nbJours = 1, $formatDate, $formatJour = 'H:i')
{
    global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}
    $jour = date('d', $ts);
    $mois = date('m', $ts);
    $an   = date('Y', $ts);
    if (!isset($formatDate)) {
        $formatDate = $xoopsModuleConfig['event_date_week'];
    }

    //echo "agenda_getCanevas : {$jour}-{$mois}-{$an}-{$ts}<br>";
    //$tsStart = mktime($heure, $minute, $seconde, $mois, $jour, $an);

    $jName = array(
        _MD_EXTCAL_DAY_SUNDAY,
        _MD_EXTCAL_DAY_MONDAY,
        _MD_EXTCAL_DAY_TUESDAY,
        _MD_EXTCAL_DAY_WEDNESDAY,
        _MD_EXTCAL_DAY_THURSDAY,
        _MD_EXTCAL_DAY_FRIDAY,
        _MD_EXTCAL_DAY_SATURDAY
    );

    $tj = array();
    for ($j = 0; $j < $nbJours; ++$j) {
        $tsj                = mktime(0, 0, 0, $mois, $jour + $j, $an);
        $kj                 = date(_EXTCAL_FORMAT_AGENDA_KEYD, $tsj);
        $tj[$kj]['caption'] = date($formatDate, $tsj);

        $tj[$kj]['events'] = array();

        $tj[$kj]['dayWeek'] = date('w', $tsj);
        $tj[$kj]['jour']    = $jName[$tj[$kj]['dayWeek']]; //date('l', $tsj);

        if ($tj[$kj]['dayWeek'] == 0) {
            $tj[$kj]['bg'] = "background='" . XOOPS_URL . "/modules/extcal/assets/images/trame.png'";
        } else {
            $tj[$kj]['bg'] = '';
        }
    }

    //echo "{$hStart}-{$hEnd}-{$mPlage}<br>";
    $sPlage  = $mPlage * _EXTCAL_TS_MINUTE; // en secondes
    $tsStart = mktime($hStart, 0, 0, 1, 1, 2000);
    $tsEnd   = mktime($hEnd + 1, 0, 0, 1, 1, 2000);

    $ta = array();
    if ($hStart > 0) {

        $tsCurent          = mktime(0, 0, 0, 1, 1, 2000);
        $k                 = date(_EXTCAL_FORMAT_AGENDA_KEYT, $tsCurent);
        $ta[$k]['caption'] = date($formatJour, $tsCurent);
        $ta[$k]['jours']   = $tj;
        $ta[$k]['class']   = 'head';
    }

    $tsCurent = $tsStart;
    $h        = 0;
    while ($tsCurent < $tsEnd) {
        $k = date(_EXTCAL_FORMAT_AGENDA_KEYT, $tsCurent);
        //echo "{$k}-$tsCurent-";
        $ta[$k]['caption'] = date($formatJour, $tsCurent);
        $ta[$k]['jours']   = $tj;
        $ta[$k]['class']   = ((($h % 2) == 0) ? 'odd' : 'even');

        //----------------------------------------------
        ++$h;
        $tsCurent += $sPlage;
    }

    if ($hEnd < 23) {

        $tsCurent          = mktime($hEnd + 1, 0, 0, 1, 1, 2000);
        $k                 = date(_EXTCAL_FORMAT_AGENDA_KEYT, $tsCurent);
        $ta[$k]['caption'] = date($formatJour, $tsCurent);
        $ta[$k]['jours']   = $tj;
        $ta[$k]['class']   = 'foot';
    }

    return $ta;
}

/*******************************************************************
 *
 ******************************************************************
 * @param        $eventsArray
 * @param        $ts
 * @param        $hStart
 * @param        $hEnd
 * @param int    $mPlage
 * @param int    $nbJours
 * @param string $formatDate
 * @param string $formatJour
 * @return array
 */
function agenda_getEvents(
    $eventsArray,
    $ts,
    $hStart,
    $hEnd,
    $mPlage = 15,
    $nbJours = 1,
    $formatDate = 'd-m-Y',
    $formatJour = 'H:i'
) {

    //    $tAgenda = agenda_getCanevas($ts, 8, 20, $mPlage, $nbJours);

    $tAgenda = agenda_getCanevas($ts, $hStart, $hEnd - 1, $mPlage, $nbJours, $formatDate, $formatJour);
    $tk      = array_keys($tAgenda);
    $tk0     = $tk[0];
    $tk1     = $tk[count($tk) - 1];

    foreach ($eventsArray as $e) {
        $ts     = $e['event_start'];
        $kd     = date(_EXTCAL_FORMAT_AGENDA_KEYD, $ts);
        $hour   = date('H', $ts);
        $minute = date('i', $ts);
        $m      = (int)($minute / $mPlage) * $mPlage;
        //      echo "--->{$minute} / {$mPlage} = {$m}<br>";
        $sMinute = (($m < 10) ? '0' . $m : $m);
        //$kt = date(_EXTCAL_FORMAT_AGENDA_KEYT, $ts);

        if ($hour < $hStart) {
            $kt = $tk0;
        } elseif ($hour >= ($hEnd + 1)) {
            $kt = $tk1;
        } else {
            $kt = $hour . ':' . $sMinute;
        }

        $tAgenda[$kt]['jours'][$kd]['events'][] = $e;
    }

    return $tAgenda;
}

/*******************************************************************
 *
 *******************************************************************/
function test_getAgenda()
{
    $tsD1 = mktime(0, 0, 0, 01, 25, 1954);
    $t    = getAgenda($tsD1, 8, 21, 30, 7);

    $t['10:30']['jours']['1954-01-25']['events'][1]['lib'] = 'Jean';
    $t['10:30']['jours']['1954-01-25']['events'][1]['dsc'] = 'bobo';

    $t['10:30']['jours']['1954-01-25']['events'][7]['lib'] = 'polo';
    $t['10:30']['jours']['1954-01-25']['events'][7]['dsc'] = 'haribo';

    $t['11:30']['jours']['1954-01-28']['events'][5]['lib'] = 'Jean';
    $t['11:30']['jours']['1954-01-28']['events'][5]['dsc'] = 'bibi';

    $exp = print_r($t, true);
    echo "<pre>{$exp}</pre>";
}

/*******************************************************************
 *
 ******************************************************************
 * @param $event1
 * @param $event2
 * @return int
 */
function orderEvents($event1, $event2)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    if ($event1['event_start'] == $event2['event_start']) {
        return 0;
    }
    if ($GLOBALS['xoopsModuleConfig']['sort_order'] === 'ASC') {
        $opt1 = -1;
        $opt2 = 1;
    } else {
        $opt1 = 1;
        $opt2 = -1;
    }

    return ($event1['event_start'] < $event2['event_start']) ? $opt1 : $opt2;
}

/*******************************************************************
 *
 ******************************************************************
 * @param        $year
 * @param int    $nbYearsBefore
 * @param int    $nbYearsAfter
 * @param bool   $addNone
 * @param string $name
 * @return \XoopsFormSelect
 */
function getListYears($year, $nbYearsBefore = 0, $nbYearsAfter = 5, $addNone = false, $name = 'year')
{
    // Year selectbox
    $select = new XoopsFormSelect('', $name, $year);
    if ($addNone) {
        $select->addOption(0, ' ');
    }
    if ($year == 0) {
        $year = date('Y');
    }

    for ($i = $year - $nbYearsBefore; $i < ($year + $nbYearsAfter); ++$i) {
        $select->addOption($i);
    }

    return $select;
}

/*******************************************************************
 *
 ******************************************************************
 * @param        $month
 * @param bool   $addNone
 * @param string $name
 * @return \XoopsFormSelect
 */
function getListMonths($month, $addNone = false, $name = 'month')
{
    // Month selectbox
    $extcalTimeHandler = ExtcalTime::getHandler();

    $select = new XoopsFormSelect('', $name, $month);
    if ($addNone) {
        $select->addOption(0, ' ');
    }

    for ($i = 1; $i < 13; ++$i) {
        $select->addOption($i, $extcalTimeHandler->getMonthName($i));
    }

    return $select;
}

/*******************************************************************
 *
 ******************************************************************
 * @param      $day
 * @param bool $addNone
 * @return \XoopsFormSelect
 */
function getListDays($day, $addNone = false)
{
    // Day selectbox
    $select = new XoopsFormSelect('', 'day', $day);
    if ($addNone) {
        $select->addOption(0, ' ');
    }

    for ($i = 1; $i < 32; ++$i) {
        $select->addOption($i);
    }

    return $select;
}

/*******************************************************************
 *
 ******************************************************************
 * @param $name
 * @return bool

 */
function ext_loadLanguage($name)
{
    global $xoopsConfig;
function myFunction($a, $b) {
    // Do something
}
    $prefix = substr($name, 4);
    switch ($prefix) {
        case '_MI_':
            $f = '';
            break;
        case '_MD_':
            $f = '';
            break;
        default:
            return false;
    }

    $file   = XOOPS_ROOT_PATH . '/language/' . $xoopsConfig['language'] . '/' . $f;
    $prefix = (defined($name) ? '_MI' : '_MD');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    require_once $file;
}

/*******************************************************************
 *
 ******************************************************************
 * @param string $currentTab
 * @return array
 */

function getNavBarTabs($currentTab = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsModuleConfig;
function myFunction($a, $b) {
    // Do something
}

    ext_loadLanguage('_MD_');

    $visibleTabs = $xoopsModuleConfig['visible_tabs'];
    $tNavBar     = $ordre = array();

    $sep     = '=';
    $tabs    = str_replace("\n", $sep, $xoopsModuleConfig['weight_tabs']);
    $tabs    = str_replace("\r", '', $tabs);
    $tabs    = str_replace(' ', '', $tabs);
    $t       = explode($sep, $tabs);
    $tWeight = array_flip($t);

    //-----------------------------------------------------------------
    $view = _EXTCAL_NAV_CALMONTH;
    //   echo "{$view} - {$currentTab}<br>";
    //   echoArray($visibleTabs,true);

    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_CALMONTH,
            'name'    => _MD_EXTCAL_NAV_CALMONTH,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 110
        );
    }

    $view = _EXTCAL_NAV_CALWEEK;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_CALWEEK,
            'name'    => _MD_EXTCAL_NAV_CALWEEK,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 120
        );
    }

    $view = _EXTCAL_NAV_YEAR;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_YEAR,
            'name'    => _MD_EXTCAL_NAV_YEAR,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 130
        );
    }

    $view = _EXTCAL_NAV_MONTH;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_MONTH,
            'name'    => _MD_EXTCAL_NAV_MONTH,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 140
        );
    }

    $view = _EXTCAL_NAV_WEEK;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_WEEK,
            'name'    => _MD_EXTCAL_NAV_WEEK,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 150
        );
    }

    $view = _EXTCAL_NAV_DAY;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_DAY,
            'name'    => _MD_EXTCAL_NAV_DAY,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 160
        );
    }

    $view = _EXTCAL_NAV_AGENDA_WEEK;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_AGENDA_WEEK,
            'name'    => _MD_EXTCAL_NAV_AGENDA_WEEK,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 170
        );
    }

    $view = _EXTCAL_NAV_AGENDA_DAY;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_AGENDA_DAY,
            'name'    => _MD_EXTCAL_NAV_AGENDA_DAY,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 180
        );
    }

    $view = _EXTCAL_NAV_SEARCH;
    if (in_array($view, $visibleTabs)) {

        $tNavBar[$view] = array(
            'href'    => _EXTCAL_FILE_SEARCH,
            'name'    => _MD_EXTCAL_NAV_SEARCH,
            'current' => ($view == $currentTab) ? 1 : 0,
            'weight'  => 200
        );
    }

    $user = isset($GLOBALS['xoopsUser']) ? $GLOBALS['xoopsUser'] : null;
    /** @var ExtcalCatHandler $catHandler */
    $catHandler = xoops_getModuleHandler(_EXTCAL_CLS_CAT, _EXTCAL_MODULE);
    if ($catHandler->haveSubmitRight($user)) {
        $view = _EXTCAL_NAV_NEW_EVENT;
        if (in_array($view, $visibleTabs)) {

            $tNavBar[$view] = array(
                'href'    => _EXTCAL_FILE_NEW_EVENT,
                'name'    => _MD_EXTCAL_NAV_NEW_EVENT,
                'current' => ($view == $currentTab) ? 1 : 0,
                'weight'  => 100
            );
        }
    }
    //----------------------------------------------------------------
    //    $ordre = array();

    //    while (list($k, $v) = each($tNavBar)) {

    foreach ($tNavBar as $k => $v) {
        if (isset($tWeight[$k])) {
            $ordre[] = (int)$tWeight[$k]; //ordre defini dans les option du module
        } else {
            $ordre[] = $v['weight']; // ordre par defaut ddefini dans le tableau $tNavBar
        }
    }

    array_multisort($tNavBar, SORT_ASC, SORT_NUMERIC, $ordre, SORT_ASC, SORT_NUMERIC);

    //    ext_echoArray($tNavBar);

    //    ext_echoArray($ordre);

    return $tNavBar;
}

/*----------------------------------------------------------------------*/


Push — master ( a9decc...a21b67 )

agenda_fnc.php ➔ getNavBarTabs() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-09 09:17 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 18 and the first side effect is on line 21. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/**
3			* classGenerator
4			* walls_watermarks.
5			*
6			* You may not change or alter any portion of this comment or credits
7			* of supporting developers from this source code or any supporting source code
8			* which is considered copyrighted (c) material of the original comment or credit authors.
9			* This program is distributed in the hope that it will be useful,
10			* but WITHOUT ANY WARRANTY; without even the implied warranty of
11			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
12			*
13			*
14			*
15			* L'utilisation de ce formulaire d'adminitration suppose
16			* que la classe correspondante de la table a été générées avec classGenerator
17			**/
18			define('_EXTCAL_FORMAT_AGENDA_KEYD', 'Y-m-d');
19			define('_EXTCAL_FORMAT_AGENDA_KEYT', 'H:i');
20
21			require_once __DIR__ . '/constantes.php';
22			require_once __DIR__ . '/../class/utility.php';
23
24			$moduleDirName = basename(dirname(__DIR__));
25			xoops_loadLanguage('main', $moduleDirName);
26
27			/*******************************************************************
28			*
29			******************************************************************
30			* @param $ts
31			* @param $hStart
32			* @param $hEnd
33			* @param int $mPlage
34			* @param int $nbJours
35			* @param $formatDate
36			* @param string $formatJour
37			*
38			* @return array
39			*/

mambax7 / extcal

Push — master ( a9decc...a21b67 )

agenda_fnc.php ➔ getNavBarTabs() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like