minical.php ➔ bExtcalMinicalAddEventToArray() - Code Metrics - Inspection of "cosmetics" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a9decc...a21b67 )

by Michael

created 2017-07-21 23:45 UTC

minical.php ➔ bExtcalMinicalAddEventToArray() C

↳ Parent: Project

Complexity

Conditions	7
Paths	15

Size

Total Lines	76
Code Lines	26

Duplication

Lines	23
Ratio	30.26 %

Importance

Changes

Metric	Value
cc	7
eloc	26
nc	15
nop	6
dl	23
loc	76
rs	6.5808
c	0
b	0
f	0

How to fix Long Method

<?php

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    {@link https://xoops.org/ XOOPS Project}
 * @license      {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
 * @package      extcal
 * @since
 * @author       XOOPS Development Team,
 */

global $extcalConfig, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}
require_once __DIR__ . '/../include/constantes.php';
require_once __DIR__ . '/../class/utility.php';
require_once __DIR__ . '/../class/tableForm.php';
//---------------------------------------------------------------------------
/**
 * @param $options
 *
 * @return array
 */
function bExtcalMinicalShow($options)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $extcalConfig, $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

    extcal_getDefautminicalOption($options);

    require_once __DIR__ . '/../class/config.php';

    require_once _EXTCAL_PEAR_CALENDAR_ROOT . '/Util/Textual.php';
    require_once _EXTCAL_PEAR_CALENDAR_ROOT . '/Month/Weeks.php';
    require_once _EXTCAL_PEAR_CALENDAR_ROOT . '/Day.php';
    //     require_once CALENDAR_ROOT . 'Month/Weeks.php';
    //     require_once CALENDAR_ROOT . 'Day.php';

    // Retriving Image for block if enabled
    if ($options[0] == 1) {
        $imageHandler = xoops_getHandler('image');
        $criteria     = new Criteria('imgcat_id', $options[1]);
        $criteria->setSort('RAND()');
        $criteria->setLimit($options[6]);
        $images         = $imageHandler->getObjects($criteria);
        $slideShowParam = array(
            'images'      => $images,
            'frameHeight' => $options[3],
            'frameWidth'  => $options[2],
            'transTime'   => $options[4],
            'pauseTime'   => $options[5],
        );
        if (count($images) > 0) {
            _makeXMLSlideshowConf($slideShowParam);
            $imageParam = array('displayImage' => true);
        } else {
            $imageParam = array('displayImage' => false);
        }
    } else {
        $imageParam = array('displayImage' => false);
    }
    $imageParam['frameHeight'] = $options[3];
    $imageParam['frameWidth']  = $options[2];

    // Retriving module config
    //     $extcalConfig = ExtcalConfig::getHandler();

    //$xoopsModuleConfig = $extcalConfig->getModuleConfig();

    //----------------------------------------------------
    //recupe de xoopsmoduleConfig
    /** @var XoopsModuleHandler $moduleHandler */
    $moduleHandler = xoops_getHandler('module');
    $module        = $moduleHandler->getByDirname('extcal');
    $configHandler = xoops_getHandler('config');
    if ($module) {
        $extcalConfig = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
    }
    //----------------------------------------------------
    // Getting eXtCal object's handler
    $catHandler = xoops_getModuleHandler(_EXTCAL_CLS_CAT, _EXTCAL_MODULE);
    $cats       = $catHandler->getAllCatById($xoopsUser);
    // $t = print_r($cats,true);

    // echo "zzz<pre>{$t}</pre>";

    $eventHandler      = xoops_getModuleHandler(_EXTCAL_CLS_EVENT, _EXTCAL_MODULE);
    $extcalTimeHandler = ExtcalTime::getHandler();

    // Retriving month and year value according to block options
    //modif JJD
    $offset      = $extcalConfig['offsetMinical'];
    $monthToShow = mktime(0, 0, 0, date('m') + $offset, date('d'), date('Y'));
    $month       = date('n', $monthToShow);
    $year        = date('Y', $monthToShow);

    //----------------------------------------------------
    $month += $options[7]; //ajout  ou retrait du nombre de mois de décalage
    if ($month < 1) {
        $month = 12;
        --$year;
    } elseif ($month > 12) {
        $month = 1;
        ++$year;
    }
    //----------------------------------------------------

    // Saving display link preference
    $displayLink = $options[8];

    // Delete options to keep only categorie data
    $tCatSelected = explode(',', $options[9]);

    /***************************************************************/
    // Retriving events and formatting them
    //$events = $eventHandler->objectToArray($eventHandler->getEventCalendarMonth($month, $year, $tCatSelected));

    if (true) {

        $criteres = array(
            'periode'      => _EXTCAL_EVENTS_MONTH,
            'month'        => $month,
            'year'         => $year,
            'cat'          => $tCatSelected,
            'externalKeys' => 'cat_id',
        );
        $events   = $eventHandler->getEventsOnPeriode($criteres);
    } else {
        $events = array();
    }
    //ext_echoArray($events, 'minical');

    /***************************************************************/
    //$eventHandler->formatEventDate($events, "l dS \of F Y h:i A");


    // Calculating timestamp for the begin and the end of the month
    $startMonth = mktime(0, 0, 0, $month, 1, $year);
    $endMonth   = mktime(23, 59, 59, $month + 1, 0, $year);

    /*
     *  Adding all event occuring during this month to an array indexed by day number
     */
    $eventsArray = array();
    foreach ($events as $event) {
        //echo "id->{$event['event_id']}<br>";
        bExtcalMinicalAddEventToArray($event, $eventsArray, $extcalTimeHandler, $startMonth, $endMonth, $cats);
        //         if (!$event['event_isrecur']) {

        //             bExtcalMinicalAddEventToArray($event, $eventsArray, $extcalTimeHandler, $startMonth, $endMonth, $cats);

        //         } else {

        //
        //             $recurEvents = $eventHandler->getRecurEventToDisplay($event, $startMonth, $endMonth);

        //             foreach ($recurEvents as $recurEvent)

        //             {
        //                 bExtcalMinicalAddEventToArray($recurEvent, $eventsArray, $extcalTimeHandler, $startMonth, $endMonth, $cats);

        //             }
        //         }
    }
    //ext_echoArray($eventsArray);

    /*
     *  Making an array to create tabbed output on the template
     */
    // Flag current day
    $selectedDays = array(
        new Calendar_Day(date('Y', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($GLOBALS['xoopsUser']))),
                         date('n', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($GLOBALS['xoopsUser']))),
                         date('j', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($GLOBALS['xoopsUser'])))),
    );

    // Build calendar object
    $monthCalObj = new Calendar_Month_Weeks($year, $month, $extcalConfig['week_start_day']);
    $monthCalObj->build();

    $tableRows = array();
    $rowId     = 0;
    $cellId    = 0;
    while ($weekCalObj = $monthCalObj->fetch()) {
        $weekCalObj->build($selectedDays);
        $tableRows[$rowId]['weekInfo'] = array(
            'week'  => $weekCalObj->thisWeek('n_in_year'),
            'day'   => $weekCalObj->thisDay(),
            'month' => $monthCalObj->thisMonth(),
            'year'  => $monthCalObj->thisYear(),
        );
        while ($dayCalObj = $weekCalObj->fetch()) {
            $tableRows[$rowId]['week'][$cellId] = array(
                'isEmpty'    => $dayCalObj->isEmpty(),
                'number'     => $dayCalObj->thisDay(),
                'isSelected' => $dayCalObj->isSelected(),
            );
            $day                                = $dayCalObj->thisDay();
            if (isset($eventsArray[$day]) && !$dayCalObj->isEmpty()) {
                $tableRows[$rowId]['week'][$cellId]['haveEvents'] = true;
                $tableRows[$rowId]['week'][$cellId]['color']      = $eventsArray[$day]['color'];
            } else {
                $tableRows[$rowId]['week'][$cellId]['haveEvents'] = false;
            }
            ++$cellId;
        }
        $cellId = 0;
        ++$rowId;
    }

    // Retriving weekdayNames
    //$loc_de = setlocale (LC_ALL, 'Fr');


    $weekdayNames = Calendar_Util_Textual::weekdayNames('one');
    //$weekdayNames=array('D','L','M','M','J','V','S');


    //     echo "<hr>L'identifiant de l'allemand sur ce système est '$loc_de'";
    //     echoArray($weekdayNames,true);


    for ($i = 0; $i < $extcalConfig['week_start_day']; ++$i) {

        $weekdayName    = array_shift($weekdayNames);
        $weekdayNames[] = $weekdayName;
    }

    // Making navig data
    $navig = array(
        'page' => $extcalConfig['start_page'],
        'uri'  => 'year=' . $monthCalObj->thisYear() . '&amp;month=' . $monthCalObj->thisMonth(),
        'name' => $extcalTimeHandler->getFormatedDate($extcalConfig['nav_date_month'], $monthCalObj->getTimestamp()),
    );

    $horloge             = array();
    $horloge['display']  = (trim($options[11]) != '');
    $horloge['fullName'] = XOOPS_URL . _EXTCAL_PATH_HORLOGES . $options[11];
    $horloge['width']    = $options[12] . 'px';
    $horloge['height']   = $options[13] . 'px';

    $ret = array(
        'imageParam'   => $imageParam,
        'displayLink'  => $displayLink,
        'submitText'   => _MB_EXTCAL_SUBMIT_LINK_TEXT,
        'tableRows'    => $tableRows,
        'weekdayNames' => $weekdayNames,
        'navig'        => $navig,
        'horloge'      => $horloge,
        'bgColor'      => $options[10],
    );

    // $t = print_r($horloge,true);

    // echo "<pre>{$t}</pre>";
    return $ret;
}

//---------------------------------------------------------------------------
/**
 * @param $options
 *
 * @return string
 */
function bExtcalMinicalEdit($options)
{
    require_once __DIR__ . '/../class/form/spin/formspin.php';
    global $xoopsUser;
function myFunction($a, $b) {
    // Do something
}

    //  $t = print_r(get_defined_vars(),true);

    // // $t = print_r($options,true);
    //  echo "<pre>{$t}</pre>";

    extcal_getDefautminicalOption($options);

    $xfValue = array();

    $form = new XoopsTableForm(_OPTIONS, '', '');
    //$form->setExtra('enctype="multipart/form-data"');


    //============================================================

    $catHandler      = xoops_getModuleHandler(_EXTCAL_CLS_CAT, _EXTCAL_MODULE);
    $cats            = $catHandler->getAllCat($xoopsUser, 'extcal_cat_view');
    $imageCatHandler = xoops_getHandler('imagecategory');

    //=====================================================================
    $form->insertBreak('<div style="text-align: center;font-weight: bold;">' . _MB_EXTCAL_OPT_SLIDE_SHOW . '</div>', 'head');

    $k           = 0;
    $xfValue[$k] = new XoopsFormRadio(_MB_EXTCAL_DISPLAY_IMG, "options[{$k}]", $options[$k]);
    $xfValue[$k]->addOption(1, _YES);
    $xfValue[$k]->addOption(0, _NO);

    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $imageCats = $imageCatHandler->getObjects();
    $t         = array();
    $t[0]      = _NONE;
    foreach ($imageCats as $cat) {
        $t[$cat->getVar('imgcat_id')] = $cat->getVar('imgcat_name');
    }

    $k           = 1;
    $xfValue[$k] = new XoopsFormSelect(_MB_EXTCAL_IMG_CAT, "options[{$k}]", $options[$k], 1, false);
    $xfValue[$k]->addOptionArray($t);
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 2;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_SS_WIDTH, "options[{$k}]", $options[$k], 100, 250, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 3;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_SS_HEIGHT, "options[{$k}]", $options[$k], 100, 250, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 4;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_SS_TRANS_TIME, "options[{$k}]", $options[$k], 0, 12, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 5;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_SS_PAUSE_TIME, "options[{$k}]", $options[$k], 0, 12, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 6;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_SS_NB_PHOTOS, "options[{$k}]", $options[$k], 0, 50, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //=====================================================================
    $form->insertBreak('<div style="text-align: center;font-weight: bold;">' . _MB_EXTCAL_OPT_SHOW . '</div>', 'head');

    $t = array(
        -1 => _MB_EXTCAL_PREVIEW,
        0  => _MB_EXTCAL_CURRENT,
        1  => _MB_EXTCAL_NEXT,
    );

    $k           = 7;
    $xfValue[$k] = new XoopsFormSelect(_MB_EXTCAL_DISPLAY_MONTH, "options[{$k}]", $options[$k], 1, false);
    $xfValue[$k]->addOptionArray($t);
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 8;
    $xfValue[$k] = new XoopsFormRadio(_MB_EXTCAL_DISPLAY_SUBMIT_LINK, "options[{$k}]", $options[$k]);
    $xfValue[$k]->addOption(1, _YES);
    $xfValue[$k]->addOption(0, _NO);

    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    //for ($h=0;$h<8;++$h) array_shift($options);

    $t = array();
    foreach ($cats as $cat) {
        $t[$cat->getVar('cat_id')] = $cat->getVar('cat_name');
    }

    //function XoopsFormSelect($caption, $name, $value = null, $size = 1, $multiple = false)


    $k           = 9;
    $xfValue[$k] = new XoopsFormSelect(_MB_EXTCAL_CAT_TO_USE, "options[{$k}]", explode(',', $options[$k]), 8, true);
    $xfValue[$k]->setDescription(_MB_EXTCAL_CAT_TO_USE_DESC);
    $xfValue[$k]->addOptionArray($t);
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 10;
    $xfValue[$k] = new XoopsFormColorPicker(_MB_EXTCAL_BGCOLOR, "options[{$k}]", $options[$k]);
    $form->addElement($xfValue[$k], false);

    //=====================================================================
    $form->insertBreak('<div style="text-align: center;font-weight: bold;">' . _MB_EXTCAL_HORLOGE_OPT . '</div>', 'head');
    //---------------------------------------------------------------------
    $t = XoopsLists::getFileListAsArray(XOOPS_ROOT_PATH . _EXTCAL_PATH_HORLOGES);
    $t = array_merge(array(' ' => _NONE), $t);

    $k           = 11;
    $xfValue[$k] = new XoopsFormSelect(_MB_EXTCAL_HORLOGE, "options[{$k}]", $options[$k], 1, false);
    $xfValue[$k]->addOptionArray($t);
    $form->addElement($xfValue[$k], false);

    //---------------------------------------------------------------------
    $k           = 12;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_WIDTH, "options[{$k}]", $options[$k], 50, 250, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    $k           = 13;
    $xfValue[$k] = new ExtcalFormSpin(_MB_EXTCAL_HEIGHT, "options[{$k}]", $options[$k], 50, 250, 1, 0, 8, _MB_EXTCAL_PX, $imgFolder = '');
    $form->addElement($xfValue[$k], false);
    //---------------------------------------------------------------------
    //=====================================================================
    return $form->render();

    //      $t = array();

    //      while (list($key,$val) = each($xfValue)) {

    //       $t[] = $val->render();

    //      }
    //     return implode("\n", $t);


    //    return extcal_buildHtmlArray($xfValue, _OPTIONS);

}

/**************************************************************************/
/**
 * @param $options
 */
function _makeXMLSlideshowConf($options)
{

    // create a new XML document
    $doc               = new DomDocument('1.0');
    $doc->formatOutput = true;

    // create root node
    $root = $doc->createElement('slideshow');
    $root = $doc->appendChild($root);

    // Create config node
    $config = $doc->createElement('config');
    $config = $root->appendChild($config);

    // Add config param
    $frameHeight = $doc->createElement('frameHeight');
    $frameHeight = $config->appendChild($frameHeight);
    $value       = $doc->createTextNode($options['frameHeight']);
    $frameHeight->appendChild($value);

    $frameWidth = $doc->createElement('frameWidth');
    $frameWidth = $config->appendChild($frameWidth);
    $value      = $doc->createTextNode($options['frameWidth']);
    $frameWidth->appendChild($value);

    $transTime = $doc->createElement('transTime');
    $transTime = $config->appendChild($transTime);
    $value     = $doc->createTextNode($options['transTime']);
    $transTime->appendChild($value);

    $pauseTime = $doc->createElement('pauseTime');
    $pauseTime = $config->appendChild($pauseTime);
    $value     = $doc->createTextNode($options['pauseTime']);
    $pauseTime->appendChild($value);

    // Add photos node
    $photos = $doc->createElement('photos');
    $photos = $root->appendChild($photos);

    $tempPhoto = $doc->createElement('photo');
    $tempSrc   = $doc->createElement('src');
    foreach ($options['images'] as $images) {
        // $photo = $doc->createElement('photo');

        $photo = clone $tempPhoto;
        $photo = $photos->appendChild($photo);

        // $src   = $doc->createElement('src');

        $src   = clone $tempSrc;
        $src   = $photo->appendChild($src);
        $value = $doc->createTextNode(XOOPS_URL . '/uploads/' . $images->getVar('image_name'));
        $src->appendChild($value);
    }

    // get completed xml document
    $xml_string = $doc->save(XOOPS_ROOT_PATH . '/cache/extcalSlideShowParam.xml');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
}

/**************************************************************************/
/**
 * @param array      $event
 * @param array      $eventsArray
 * @param ExtcalTime $extcalTimeHandler
 * @param            $startMonth
 * @param            $endMonth
 * @param            $cats
 *
 * @return bool

 */
function bExtcalMinicalAddEventToArray($event, &$eventsArray, $extcalTimeHandler, $startMonth, $endMonth, $cats)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    // ext_echoArray($event);

    // exit;
    // $d1 = date("j, m, Y", $startMonth);

    // $d2 = date("j, m, Y", $endMonth);

    // echo "bExtcalMinicalAddEventToArray : {$d1} - {$d2}<br>";
    // $d1 = date("j, m, Y", $event['event_start']);

    // $d2 = date("j, m, Y", $event['event_end']);

    // echo "bExtcalMinicalAddEventToArray : {$d1} - {$d2}<br>";

    //     $color  = $cats[$event['cat_id']]['cat_color'];

    //     $weight = $cats[$event['cat_id']]['cat_weight'];

    $color  = $event['cat']['cat_color'];
    $weight = $event['cat']['cat_weight'];

    // Calculating the start and the end of the event
    $startEvent = xoops_getUserTimestamp($event['event_start'], $extcalTimeHandler->_getUserTimeZone($GLOBALS['xoopsUser']));
    $endEvent   = xoops_getUserTimestamp($event['event_end'], $extcalTimeHandler->_getUserTimeZone($GLOBALS['xoopsUser']));
    // ext_echoTSU($event['event_start'],"event['event_start']");

    // ext_echoTSU($event['event_end'],"event['event_end']");


    //---------------------------------------------------------------
    if ($startEvent < $startMonth) {

        $firstDay = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    } elseif ($startEvent > $endEvent) {
        return false;
    } else {
        $firstDay = date('j', $startEvent);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    if ($endEvent < $startMonth) {

        return false;
    } elseif ($endEvent > $endMonth) {
        $lastDay = date('j', $endMonth);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    } else {
        $lastDay = date('j', $endEvent);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    //echo "first dat - last day : {$firstDay} - {$lastDay}<br>";
    //echo $event['event_id'] . '-' . $weight .'<br>';


    $d = date('j', $event['event_start']);
    if (isset($eventsArray[$d])) {
        if ($weight > $eventsArray[$d]['weight']) {

            $eventsArray[$d]['weight'] = $weight;
            $eventsArray[$d]['color']  = $color;
        }
    } else {

        $eventsArray[$d]['hasEvent'] = true;
        $eventsArray[$d]['weight']   = $weight;
        $eventsArray[$d]['color']    = $color;
    }
    /*

            for ($i = $firstDay; $i <= $lastDay; ++$i) {
                }

                $eventsArray[$i]['hasEvent'] = true;
                if (isset($eventsArray[$i]['weight'])) {
                  if ($weight > $eventsArray[$i]['weight']) {
                    $eventsArray[$i]['weight'] = $weight;
                    $eventsArray[$i]['color'] = $color;
                  }
                } else {
                  $eventsArray[$i]['weight'] = $weight;
                  $eventsArray[$i]['color'] = $color;
              }
            }
    */

    // $t = print_r($cats,true);

    // echo "<pre>{$t}</pre><hr>";
    //
    // $t = print_r($eventsArray,true);

    // echo "event id = {$event['event_id']} - weight = {$weight}<br>color = {$color}<br><pre>{$t}</pre><hr>";
}

/**
 * @param $options
 */
function extcal_getDefautminicalOption(&$options)
{
    // 0|0|150|225|1|3|10|0|1|1,2|| |120|120

    for ($h = 0; $h <= 13; ++$h) {
        if (!isset($options[$h])) {
            switch ($h) {
                case  0:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '0';
                    break;
                case  1:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = 0;
                    break;
                case  2:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '150';
                    break;
                case  3:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '255';
                    break;
                case  4:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '1';
                    break;
                case  5:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '3';
                    break;
                case  6:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '10';
                    break;
                case  7:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '0';
                    break;
                case  8:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '1';
                    break;
                case  9:
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                    $options[$h] = '1,2,3,4,5';
                    break;
                case 10:
                    $options[$h] = '';
                    break;
                case 11:
                    $options[$h] = '';
                    break;
                case 12:
                    $options[$h] = 120;
                    break;
                case 13:
                    $options[$h] = 120;
                    break;
            }
        }
    }
}


Push — master ( a9decc...a21b67 )

minical.php ➔ bExtcalMinicalAddEventToArray() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2017-07-21 23:48 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 30 and the first side effect is on line 20. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			* You may not change or alter any portion of this comment or credits
4			* of supporting developers from this source code or any supporting source code
5			* which is considered copyrighted (c) material of the original comment or credit authors.
6			*
7			* This program is distributed in the hope that it will be useful,
8			* but WITHOUT ANY WARRANTY; without even the implied warranty of
9			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* @copyright {@link https://xoops.org/ XOOPS Project}
14			* @license {@link http://www.gnu.org/licenses/gpl-2.0.html GNU GPL 2 or later}
15			* @package extcal
16			* @since
17			* @author XOOPS Development Team,
18			*/
19
20			global $extcalConfig, $xoopsUser;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
21			require_once __DIR__ . '/../include/constantes.php';
22			require_once __DIR__ . '/../class/utility.php';
23			require_once __DIR__ . '/../class/tableForm.php';
24			//---------------------------------------------------------------------------
25			/**
26			* @param $options
27			*
28			* @return array
29			*/
30			function bExtcalMinicalShow($options)
			0 ignored issues – show Coding Style introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report `bExtcalMinicalShow` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
31			{
32			global $extcalConfig, $xoopsUser;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
33
34			extcal_getDefautminicalOption($options);
35
36			require_once __DIR__ . '/../class/config.php';

mambax7 / extcal

Push — master ( a9decc...a21b67 )

minical.php ➔ bExtcalMinicalAddEventToArray() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like