mambax7 /
extcal
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 35 | class ExtcalFormSpin extends XoopsFormElement |
||
| 36 | { |
||
| 37 | /** |
||
| 38 | * Value. |
||
| 39 | * |
||
| 40 | * @var int |
||
| 41 | */ |
||
| 42 | protected $_value = 0; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * Value minimum. |
||
| 46 | * |
||
| 47 | * @var int |
||
| 48 | */ |
||
| 49 | protected $_min = 0; |
||
| 50 | |||
| 51 | /** |
||
| 52 | * Value maximum. |
||
| 53 | * |
||
| 54 | * @var int |
||
| 55 | */ |
||
| 56 | protected $_max = 100; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * Small increment. |
||
| 60 | * |
||
| 61 | * @var int |
||
| 62 | */ |
||
| 63 | protected $_smallIncrement = 1; |
||
| 64 | |||
| 65 | /** |
||
| 66 | * Large increment. |
||
| 67 | * |
||
| 68 | * @var int |
||
| 69 | */ |
||
| 70 | protected $_largeIncrement = 10; |
||
| 71 | |||
| 72 | /** |
||
| 73 | * unite for information on value. |
||
| 74 | * |
||
| 75 | * @var string |
||
| 76 | */ |
||
| 77 | protected $_unite = ''; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * Folder of arrow image. |
||
| 81 | * |
||
| 82 | * @var string |
||
| 83 | */ |
||
| 84 | protected $_imgFolder = 'default'; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * size of input text in nb car. |
||
| 88 | * |
||
| 89 | * @var int |
||
| 90 | */ |
||
| 91 | protected $_size = 2; |
||
| 92 | |||
| 93 | /** |
||
| 94 | * minMaxVisible show buttons to go minimum and maximum. |
||
| 95 | * |
||
| 96 | * @var int |
||
| 97 | */ |
||
| 98 | protected $_minMaxVisible = true; |
||
| 99 | |||
| 100 | /** |
||
| 101 | * tyleBordure ; style CSS of frame control. |
||
| 102 | * |
||
| 103 | * @var string |
||
| 104 | */ |
||
| 105 | protected $_styleBordure = 'color: #FFFFFF; background-color: #CCCCCC; line-height: 100%;border-width:1px; border-style: solid; border-color: #000000; margin-top: 0; margin-bottom: 0; padding: 0'; |
||
| 106 | |||
| 107 | /** |
||
| 108 | * tyleText : style CSS of input text. |
||
| 109 | * |
||
| 110 | * @var string |
||
| 111 | */ |
||
| 112 | protected $_styleText = 'color: #000000; text-align: right; margin-left: 1; margin-right: 2; padding-right: 8'; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Allow loading of javascript. |
||
| 116 | * |
||
| 117 | * @var bool |
||
| 118 | */ |
||
| 119 | protected $_loadJS = true; |
||
| 120 | |||
| 121 | /*---------------------------------------------------------------*/ |
||
| 122 | /** |
||
| 123 | * Constructor. |
||
| 124 | * |
||
| 125 | * @param string $caption Caption |
||
| 126 | * @param string $name "name" attribute |
||
| 127 | * @param int $value Pre-selected value. |
||
| 128 | * @param int $min value |
||
| 129 | * @param int $max value |
||
| 130 | * @param int $smallIncrement Increment when click on button |
||
| 131 | * @param int $largeIncrement Increment when click on button |
||
| 132 | * @param int $size Number caractere of inputtext |
||
| 133 | * @param string $unite of the value |
||
| 134 | * @param string $imgFolder of image gif for button |
||
| 135 | * @param string $styleText style CSs of text |
||
| 136 | * @param string $styleBordure style CSs of frame |
||
| 137 | * @param bool $minMaxVisible show min and mas buttons |
||
| 138 | */ |
||
| 139 | public function __construct( |
||
| 168 | |||
| 169 | /*-----------------------------------------------------------------*/ |
||
| 170 | /** |
||
| 171 | * Get the values. |
||
| 172 | */ |
||
| 173 | public function getValue() |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Set the value. |
||
| 180 | * |
||
| 181 | * @param $value int |
||
| 182 | */ |
||
| 183 | public function setValue($value) |
||
| 187 | |||
| 188 | /*-----------------------------------------------------------------*/ |
||
| 189 | /** |
||
| 190 | * Get the min value. |
||
| 191 | */ |
||
| 192 | public function getMin() |
||
| 196 | |||
| 197 | /** |
||
| 198 | * Set the min value. |
||
| 199 | * |
||
| 200 | * @param $min int |
||
| 201 | */ |
||
| 202 | public function setMin($min) |
||
| 206 | /*-----------------------------------------------------------------*/ |
||
| 207 | /** |
||
| 208 | * Get the max value - must be more great then min. |
||
| 209 | */ |
||
| 210 | public function getMax() |
||
| 214 | |||
| 215 | /** |
||
| 216 | * Set the max value - must be more great then min. |
||
| 217 | * |
||
| 218 | * @param $max int |
||
| 219 | */ |
||
| 220 | public function setMax($max) |
||
| 224 | |||
| 225 | /*-----------------------------------------------------------------*/ |
||
| 226 | /** |
||
| 227 | * Get the small increment when click a short time on up down nutton. |
||
| 228 | */ |
||
| 229 | public function getSmallIncrement() |
||
| 233 | |||
| 234 | /** |
||
| 235 | * Set the small increment when click a short time on up down nutton |
||
| 236 | * must be " > 0 ". |
||
| 237 | * |
||
| 238 | * @param $smallIncrement |
||
| 239 | * |
||
| 240 | * @internal param int $value |
||
| 241 | */ |
||
| 242 | public function setSmallIncrement($smallIncrement) |
||
| 249 | |||
| 250 | /*-----------------------------------------------------------------*/ |
||
| 251 | /** |
||
| 252 | * Get the large increment when click a long time on up down nutton. |
||
| 253 | */ |
||
| 254 | public function getLargeIncrement() |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Set the large increment when click a long time on up down nutton. |
||
| 261 | * |
||
| 262 | * @param $largeIncrement int |
||
| 263 | */ |
||
| 264 | public function setLargeIncrement($largeIncrement) |
||
| 271 | |||
| 272 | /*-----------------------------------------------------------------*/ |
||
| 273 | /** |
||
| 274 | * Get the size in nb car of the input text for the value. |
||
| 275 | */ |
||
| 276 | public function getSize() |
||
| 280 | |||
| 281 | /** |
||
| 282 | * Set the size in nb car of the input text for the value |
||
| 283 | * must be 2 car min. |
||
| 284 | * |
||
| 285 | * @param $size mixed |
||
| 286 | */ |
||
| 287 | public function setSize($size) |
||
| 294 | |||
| 295 | /*-----------------------------------------------------------------*/ |
||
| 296 | /** |
||
| 297 | * @return string |
||
| 298 | */ |
||
| 299 | public function getImgFolder() |
||
| 306 | |||
| 307 | /** |
||
| 308 | * Set the shortname of the folder images. |
||
| 309 | * |
||
| 310 | * @param $folder string |
||
| 311 | */ |
||
| 312 | public function setImgFolder($folder) |
||
| 318 | /*-----------------------------------------------------------------*/ |
||
| 319 | /** |
||
| 320 | * Get the label of unites between value and buttons. |
||
| 321 | */ |
||
| 322 | public function getUnite() |
||
| 326 | |||
| 327 | /** |
||
| 328 | * Set the label of unites between value and buttons. |
||
| 329 | * |
||
| 330 | * @param $unite string |
||
| 331 | */ |
||
| 332 | public function setUnite($unite) |
||
| 336 | /*-----------------------------------------------------------------*/ |
||
| 337 | /** |
||
| 338 | * Get the style CSS of the text. |
||
| 339 | */ |
||
| 340 | public function getStyleText() |
||
| 344 | |||
| 345 | /** |
||
| 346 | * Set the style CSS of the text. |
||
| 347 | * |
||
| 348 | * @param $style string |
||
| 349 | */ |
||
| 350 | public function setStyleText($style) |
||
| 356 | /*-----------------------------------------------------------------*/ |
||
| 357 | /** |
||
| 358 | * Get the style CSS of the frame. |
||
| 359 | */ |
||
| 360 | public function getStyleBordure() |
||
| 364 | |||
| 365 | /** |
||
| 366 | * Set the style CSS of the frame. |
||
| 367 | * |
||
| 368 | * @param $style string |
||
| 369 | */ |
||
| 370 | public function setStyleBordure($style) |
||
| 376 | /*-----------------------------------------------------------------*/ |
||
| 377 | /** |
||
| 378 | * Get MinMaxVisible : show the button to go min and max value. |
||
| 379 | */ |
||
| 380 | public function getMinMaxVisible() |
||
| 384 | |||
| 385 | /** |
||
| 386 | * Set MinMaxVisible : show the button to go min and max value. |
||
| 387 | * |
||
| 388 | * @param $visible bool |
||
| 389 | */ |
||
| 390 | public function setMinMaxVisible($visible) |
||
| 394 | /**********************************************************************/ |
||
| 395 | |||
| 396 | /** |
||
| 397 | * Prepare HTML for output. |
||
| 398 | * |
||
| 399 | * @return string HTML |
||
| 400 | */ |
||
| 401 | public function render() |
||
| 478 | |||
| 479 | /************************************************************************** |
||
| 480 | * calcul du dossier du composant |
||
| 481 | *************************************************************************/ |
||
| 482 | public function getFolder() |
||
| 488 | |||
| 489 | /******************************************************************** |
||
| 490 | * |
||
| 491 | ******************************************************************** |
||
| 492 | * @param $attribut |
||
| 493 | * @param $value |
||
| 494 | * @param string $default |
||
| 495 | * @return string |
||
| 496 | */ |
||
| 497 | public function htmlAddAttribut($attribut, $value, $default = '') |
||
| 516 | } |
||
| 517 |
Loading history...
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.