Inspection of "2.39 RC2" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (c921ab)

by Michael

created 2016-09-09 09:18 UTC

Status

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -71,13 +71,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 10,
-                               'day' => 8,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 10,
+                                'day' => 8,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 
     public function testThisDay()

Please login to merge, or discard this patch.

class/pear/Calendar/tests/calendar_test.php 1 patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -37,13 +37,13 @@  discard block
 block discarded – undo
     public function testPrevYear_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2002,
-                               'month' => 1,
-                               'day' => 1,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevYear('array'));
+                                'year' => 2002,
+                                'month' => 1,
+                                'day' => 1,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevYear('array'));
     }
 
     public function testThisYear()
@@ -64,13 +64,13 @@  discard block
 block discarded – undo
     public function testPrevMonth_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 9,
-                               'day' => 1,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevMonth('array'));
+                                'year' => 2003,
+                                'month' => 9,
+                                'day' => 1,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevMonth('array'));
     }
 
     public function testThisMonth()
@@ -91,13 +91,13 @@  discard block
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 10,
-                               'day' => 24,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 10,
+                                'day' => 24,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 
     public function testThisDay()

Please login to merge, or discard this patch.

class/pear/Calendar/tests/month_weekdays_test.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -32,13 +32,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 9,
-                               'day' => 30,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 9,
+                                'day' => 30,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 
     public function testThisDay()

Please login to merge, or discard this patch.

class/pear/Calendar/tests/second_test.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -27,13 +27,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 10,
-                               'day' => 24,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 10,
+                                'day' => 24,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 }
 

Please login to merge, or discard this patch.

view_calendar-week.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -65,8 +65,8 @@
 block discarded – undo
 // Flag current day
 $selectedDays = array(
     new Calendar_Day(date('Y', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
-                     date('n', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
-                     date('j', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser)))),
+                        date('n', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
+                        date('j', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser)))),
 );
 
 // Build calendar object

Please login to merge, or discard this patch.

class/pear/Calendar/docs/examples/1.php 1 patch

Switch Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

@@ -39,32 +39,32 @@
 block discarded – undo
 }
 
 switch (@$_GET['view']) {
-    default:
-        $_GET['view'] = 'calendar_year';
-    case 'calendar_year':
-        require_once CALENDAR_ROOT.'Year.php';
-        $c = new Calendar_Year($_GET['y']);
-        break;
-    case 'calendar_month':
-        require_once CALENDAR_ROOT.'Month.php';
-        $c = new Calendar_Month($_GET['y'], $_GET['m']);
-        break;
-    case 'calendar_day':
-        require_once CALENDAR_ROOT.'Day.php';
-        $c = new Calendar_Day($_GET['y'], $_GET['m'], $_GET['d']);
-        break;
-    case 'calendar_hour':
-        require_once CALENDAR_ROOT.'Hour.php';
-        $c = new Calendar_Hour($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h']);
-        break;
-    case 'calendar_minute':
-        require_once CALENDAR_ROOT.'Minute.php';
-        $c = new Calendar_Minute($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i']);
-        break;
-    case 'calendar_second':
-        require_once CALENDAR_ROOT.'Second.php';
-        $c = new Calendar_Second($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i'], $_GET['s']);
-        break;
+        default:
+            $_GET['view'] = 'calendar_year';
+        case 'calendar_year':
+            require_once CALENDAR_ROOT.'Year.php';
+            $c = new Calendar_Year($_GET['y']);
+            break;
+        case 'calendar_month':
+            require_once CALENDAR_ROOT.'Month.php';
+            $c = new Calendar_Month($_GET['y'], $_GET['m']);
+            break;
+        case 'calendar_day':
+            require_once CALENDAR_ROOT.'Day.php';
+            $c = new Calendar_Day($_GET['y'], $_GET['m'], $_GET['d']);
+            break;
+        case 'calendar_hour':
+            require_once CALENDAR_ROOT.'Hour.php';
+            $c = new Calendar_Hour($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h']);
+            break;
+        case 'calendar_minute':
+            require_once CALENDAR_ROOT.'Minute.php';
+            $c = new Calendar_Minute($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i']);
+            break;
+        case 'calendar_second':
+            require_once CALENDAR_ROOT.'Second.php';
+            $c = new Calendar_Second($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i'], $_GET['s']);
+            break;
 }
 
 // Convert timestamp to human readable date

Please login to merge, or discard this patch.

class/pear/Calendar/tests/minute_test.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -27,13 +27,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 10,
-                               'day' => 24,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 10,
+                                'day' => 24,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 }
 

Please login to merge, or discard this patch.

class/pear/Calendar/tests/day_test.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -27,13 +27,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 10,
-                               'day' => 24,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 10,
+                                'day' => 24,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 }
 

Please login to merge, or discard this patch.

class/pear/Calendar/tests/month_test.php 1 patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -32,13 +32,13 @@
 block discarded – undo
     public function testPrevDay_Array()
     {
         $this->assertEqual(array(
-                               'year' => 2003,
-                               'month' => 9,
-                               'day' => 30,
-                               'hour' => 0,
-                               'minute' => 0,
-                               'second' => 0,
-                           ), $this->cal->prevDay('array'));
+                                'year' => 2003,
+                                'month' => 9,
+                                'day' => 30,
+                                'hour' => 0,
+                                'minute' => 0,
+                                'second' => 0,
+                            ), $this->cal->prevDay('array'));
     }
 
     public function testThisDay()

Please login to merge, or discard this patch.

		@@ -71,13 +71,13 @@
		block discarded – undo
71	71	public function testPrevDay_Array()
72	72	{
73	73	$this->assertEqual(array(
74		- 'year' => 2003,
75		- 'month' => 10,
76		- 'day' => 8,
77		- 'hour' => 0,
78		- 'minute' => 0,
79		- 'second' => 0,
80		- ), $this->cal->prevDay('array'));
	74	+ 'year' => 2003,
	75	+ 'month' => 10,
	76	+ 'day' => 8,
	77	+ 'hour' => 0,
	78	+ 'minute' => 0,
	79	+ 'second' => 0,
	80	+ ), $this->cal->prevDay('array'));
81	81	}
82	82
83	83	public function testThisDay()

		@@ -37,13 +37,13 @@ discard block
		block discarded – undo
37	37	public function testPrevYear_Array()
38	38	{
39	39	$this->assertEqual(array(
40		- 'year' => 2002,
41		- 'month' => 1,
42		- 'day' => 1,
43		- 'hour' => 0,
44		- 'minute' => 0,
45		- 'second' => 0,
46		- ), $this->cal->prevYear('array'));
	40	+ 'year' => 2002,
	41	+ 'month' => 1,
	42	+ 'day' => 1,
	43	+ 'hour' => 0,
	44	+ 'minute' => 0,
	45	+ 'second' => 0,
	46	+ ), $this->cal->prevYear('array'));
47	47	}
48	48
49	49	public function testThisYear()
		@@ -64,13 +64,13 @@ discard block
		block discarded – undo
64	64	public function testPrevMonth_Array()
65	65	{
66	66	$this->assertEqual(array(
67		- 'year' => 2003,
68		- 'month' => 9,
69		- 'day' => 1,
70		- 'hour' => 0,
71		- 'minute' => 0,
72		- 'second' => 0,
73		- ), $this->cal->prevMonth('array'));
	67	+ 'year' => 2003,
	68	+ 'month' => 9,
	69	+ 'day' => 1,
	70	+ 'hour' => 0,
	71	+ 'minute' => 0,
	72	+ 'second' => 0,
	73	+ ), $this->cal->prevMonth('array'));
74	74	}
75	75
76	76	public function testThisMonth()
		@@ -91,13 +91,13 @@ discard block
		block discarded – undo
91	91	public function testPrevDay_Array()
92	92	{
93	93	$this->assertEqual(array(
94		- 'year' => 2003,
95		- 'month' => 10,
96		- 'day' => 24,
97		- 'hour' => 0,
98		- 'minute' => 0,
99		- 'second' => 0,
100		- ), $this->cal->prevDay('array'));
	94	+ 'year' => 2003,
	95	+ 'month' => 10,
	96	+ 'day' => 24,
	97	+ 'hour' => 0,
	98	+ 'minute' => 0,
	99	+ 'second' => 0,
	100	+ ), $this->cal->prevDay('array'));
101	101	}
102	102
103	103	public function testThisDay()

		@@ -32,13 +32,13 @@
		block discarded – undo
32	32	public function testPrevDay_Array()
33	33	{
34	34	$this->assertEqual(array(
35		- 'year' => 2003,
36		- 'month' => 9,
37		- 'day' => 30,
38		- 'hour' => 0,
39		- 'minute' => 0,
40		- 'second' => 0,
41		- ), $this->cal->prevDay('array'));
	35	+ 'year' => 2003,
	36	+ 'month' => 9,
	37	+ 'day' => 30,
	38	+ 'hour' => 0,
	39	+ 'minute' => 0,
	40	+ 'second' => 0,
	41	+ ), $this->cal->prevDay('array'));
42	42	}
43	43
44	44	public function testThisDay()

		@@ -27,13 +27,13 @@
		block discarded – undo
27	27	public function testPrevDay_Array()
28	28	{
29	29	$this->assertEqual(array(
30		- 'year' => 2003,
31		- 'month' => 10,
32		- 'day' => 24,
33		- 'hour' => 0,
34		- 'minute' => 0,
35		- 'second' => 0,
36		- ), $this->cal->prevDay('array'));
	30	+ 'year' => 2003,
	31	+ 'month' => 10,
	32	+ 'day' => 24,
	33	+ 'hour' => 0,
	34	+ 'minute' => 0,
	35	+ 'second' => 0,
	36	+ ), $this->cal->prevDay('array'));
37	37	}
38	38	}
39	39

		@@ -65,8 +65,8 @@
		block discarded – undo
65	65	// Flag current day
66	66	$selectedDays = array(
67	67	new Calendar_Day(date('Y', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
68		- date('n', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
69		- date('j', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser)))),
	68	+ date('n', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser))),
	69	+ date('j', xoops_getUserTimestamp(time(), $extcalTimeHandler->_getUserTimeZone($xoopsUser)))),
70	70	);
71	71
72	72	// Build calendar object

		@@ -39,32 +39,32 @@
		block discarded – undo
39	39	}
40	40
41	41	switch (@$_GET['view']) {
42		- default:
43		- $_GET['view'] = 'calendar_year';
44		- case 'calendar_year':
45		- require_once CALENDAR_ROOT.'Year.php';
46		- $c = new Calendar_Year($_GET['y']);
47		- break;
48		- case 'calendar_month':
49		- require_once CALENDAR_ROOT.'Month.php';
50		- $c = new Calendar_Month($_GET['y'], $_GET['m']);
51		- break;
52		- case 'calendar_day':
53		- require_once CALENDAR_ROOT.'Day.php';
54		- $c = new Calendar_Day($_GET['y'], $_GET['m'], $_GET['d']);
55		- break;
56		- case 'calendar_hour':
57		- require_once CALENDAR_ROOT.'Hour.php';
58		- $c = new Calendar_Hour($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h']);
59		- break;
60		- case 'calendar_minute':
61		- require_once CALENDAR_ROOT.'Minute.php';
62		- $c = new Calendar_Minute($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i']);
63		- break;
64		- case 'calendar_second':
65		- require_once CALENDAR_ROOT.'Second.php';
66		- $c = new Calendar_Second($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i'], $_GET['s']);
67		- break;
	42	+ default:
	43	+ $_GET['view'] = 'calendar_year';
	44	+ case 'calendar_year':
	45	+ require_once CALENDAR_ROOT.'Year.php';
	46	+ $c = new Calendar_Year($_GET['y']);
	47	+ break;
	48	+ case 'calendar_month':
	49	+ require_once CALENDAR_ROOT.'Month.php';
	50	+ $c = new Calendar_Month($_GET['y'], $_GET['m']);
	51	+ break;
	52	+ case 'calendar_day':
	53	+ require_once CALENDAR_ROOT.'Day.php';
	54	+ $c = new Calendar_Day($_GET['y'], $_GET['m'], $_GET['d']);
	55	+ break;
	56	+ case 'calendar_hour':
	57	+ require_once CALENDAR_ROOT.'Hour.php';
	58	+ $c = new Calendar_Hour($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h']);
	59	+ break;
	60	+ case 'calendar_minute':
	61	+ require_once CALENDAR_ROOT.'Minute.php';
	62	+ $c = new Calendar_Minute($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i']);
	63	+ break;
	64	+ case 'calendar_second':
	65	+ require_once CALENDAR_ROOT.'Second.php';
	66	+ $c = new Calendar_Second($_GET['y'], $_GET['m'], $_GET['d'], $_GET['h'], $_GET['i'], $_GET['s']);
	67	+ break;
68	68	}
69	69
70	70	// Convert timestamp to human readable date

mambax7 / extcal

Branch — master (c921ab)

Status

Category

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Switch Indentation +26 added lines, -26 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch