Extcal_2_28::addTable_etablissement() - Code Metrics - Inspection of "2.39 RC2" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (c921ab)

by Michael

created 2016-09-09 09:18 UTC

Extcal_2_28::addTable_etablissement() B

↳ Parent: Extcal_2_28

Complexity

Conditions	1
Paths	1

Size

Total Lines	33
Code Lines	7

Duplication

Lines	33
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
eloc	7
c	0
b	0
f	0
nc	1
nop	0
dl	33
loc	33
rs	8.8571

<?php
/**
 * extcal module.
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright           XOOPS Project (http://xoops.org)
 * @license             http://www.fsf.org/copyleft/gpl.html GNU public license
 *
 * @since               2.2
 *
 * @author              JJDai <http://xoops.kiolo.com>
 **/
//----------------------------------------------------
class Extcal_2_28
namespace YourVendor;

class YourClass { }
{
    //----------------------------------------------------

    /**
     * @param XoopsModule $module
     * @param             $options
     */
    public function __construct(XoopsModule $module, $options)

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $this->addTable_etablissement();
        $this->alterTable_event();
    }

    //----------------------------------------------------
    public function alterTable_event()
    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $tbl = $xoopsDB->prefix('extcal_event');

        $sql = <<<__sql__
ALTER TABLE `{$tbl}`
  add  `event_organisateur` varchar(255) NOT NULL default '',
  add  `event_picture1` varchar(255) NOT NULL,
  add  `event_picture2` varchar(255) NOT NULL,
  add  `event_price` varchar(255) NOT NULL default '',
  add  `event_etablissement` int(5) NOT NULL DEFAULT '1';
__sql__;

        $xoopsDB->queryF($sql);
    }

    //----------------------------------------------------
    public function addTable_etablissement()
    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $tbl = $xoopsDB->prefix('extcal_etablissement');

        $sql = <<<__sql__
CREATE TABLE `{$tbl}` (
  `id` int(5) NOT NULL auto_increment,
  `nom` varchar(255) NOT NULL,
  `desc` text NOT NULL,
  `logo` varchar(255) NOT NULL,
  `categorie` varchar(255) NOT NULL,
  `adresse` varchar(255) NOT NULL,
  `adresse2` varchar(255) NOT NULL,
  `cp` varchar(10) NOT NULL,
  `ville` varchar(50) NOT NULL,
  `tel_fixe` varchar(20) NOT NULL,
  `tel_portable` varchar(20) NOT NULL,
  `mail` varchar(255) NOT NULL,
  `site` varchar(255) NOT NULL,
  `horaires` text NOT NULL,
  `divers` text NOT NULL,
  `tarifs` text NOT NULL,
  `map` text NOT NULL,

  PRIMARY KEY  (`id`)
) ENGINE = MYISAM ;
__sql__;

        $xoopsDB->queryF($sql);
        //---------------------------------------------------
    }
    //-----------------------------------------------------------------
}   // fin de la classe


Branch — master (c921ab)

Extcal_2_28::addTable_etablissement() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/**
3		* extcal module.
4		*
5		* You may not change or alter any portion of this comment or credits
6		* of supporting developers from this source code or any supporting source code
7		* which is considered copyrighted (c) material of the original comment or credit authors.
8		* This program is distributed in the hope that it will be useful,
9		* but WITHOUT ANY WARRANTY; without even the implied warranty of
10		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11		*
12		* @copyright XOOPS Project (http://xoops.org)
13		* @license http://www.fsf.org/copyleft/gpl.html GNU public license
14		*
15		* @since 2.2
16		*
17		* @author JJDai <http://xoops.kiolo.com>
18		**/
19		//----------------------------------------------------
20	View Code Duplication	class Extcal_2_28
		0 ignored issues – show Duplication introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
21		{
22		//----------------------------------------------------
23
24		/**
25		* @param XoopsModule $module
26		* @param $options
27		*/
28		public function __construct(XoopsModule $module, $options)
		0 ignored issues – show Unused Code introduced 2016-08-09 05:35 UTC by Report Bug Copy Issue Report The parameter `$module` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-08-09 05:35 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29		{
30		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
31
32		$this->addTable_etablissement();
33		$this->alterTable_event();
34		}
35
36		//----------------------------------------------------
37		public function alterTable_event()
38		{
39		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
40
41		$tbl = $xoopsDB->prefix('extcal_event');
42
43		$sql = <<<__sql__
44		ALTER TABLE `{$tbl}`
45		add `event_organisateur` varchar(255) NOT NULL default '',
46		add `event_picture1` varchar(255) NOT NULL,
47		add `event_picture2` varchar(255) NOT NULL,
48		add `event_price` varchar(255) NOT NULL default '',
49		add `event_etablissement` int(5) NOT NULL DEFAULT '1';
50		__sql__;
51
52		$xoopsDB->queryF($sql);
53		}
54
55		//----------------------------------------------------
56		public function addTable_etablissement()
57		{
58		global $xoopsDB;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
59
60		$tbl = $xoopsDB->prefix('extcal_etablissement');
61
62		$sql = <<<__sql__
63		CREATE TABLE `{$tbl}` (
64		`id` int(5) NOT NULL auto_increment,
65		`nom` varchar(255) NOT NULL,
66		`desc` text NOT NULL,
67		`logo` varchar(255) NOT NULL,
68		`categorie` varchar(255) NOT NULL,
69		`adresse` varchar(255) NOT NULL,
70		`adresse2` varchar(255) NOT NULL,
71		`cp` varchar(10) NOT NULL,
72		`ville` varchar(50) NOT NULL,
73		`tel_fixe` varchar(20) NOT NULL,
74		`tel_portable` varchar(20) NOT NULL,
75		`mail` varchar(255) NOT NULL,
76		`site` varchar(255) NOT NULL,
77		`horaires` text NOT NULL,
78		`divers` text NOT NULL,
79		`tarifs` text NOT NULL,
80		`map` text NOT NULL,
81
82		PRIMARY KEY (`id`)
83		) ENGINE = MYISAM ;
84		__sql__;
85
86		$xoopsDB->queryF($sql);
87		//---------------------------------------------------
88		}
89		//-----------------------------------------------------------------
90		} // fin de la classe
91

mambax7 / extcal

Branch — master (c921ab)

Extcal_2_28::addTable_etablissement() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like