Extcal_2_04::__construct() - Code Metrics - Inspection of "2.39 RC2" - mambax7/extcal - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (c921ab)

by Michael

created 2016-09-09 09:18 UTC

Extcal_2_04::__construct() A

↳ Parent: Extcal_2_04

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	4
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	7
rs	9.4285

<?php
/**
 * extcal module.
 *
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 *
 * @copyright           XOOPS Project (http://xoops.org)
 * @license             http://www.fsf.org/copyleft/gpl.html GNU public license
 *
 * @since               2.2
 *
 * @author              JJDai <http://xoops.kiolo.com>
 **/
//----------------------------------------------------
class Extcal_2_04
namespace YourVendor;

class YourClass { }
{
    //----------------------------------------------------

    /**
     * @param XoopsModule $module
     * @param             $options
     */
    public function __construct(XoopsModule $module, $options)

    {
        global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

        $sql = 'ALTER TABLE `' . $xoopsDB->prefix('extcal_event') . "` ADD `event_nbmember` tinyint(4) NOT NULL default '0' AFTER `event_submitdate` ;";
        $xoopsDB->query($sql);
    }

    //-----------------------------------------------------------------
}   // fin de la classe


Branch — master (c921ab)

Extcal_2_04::__construct() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/**
3			* extcal module.
4			*
5			* You may not change or alter any portion of this comment or credits
6			* of supporting developers from this source code or any supporting source code
7			* which is considered copyrighted (c) material of the original comment or credit authors.
8			* This program is distributed in the hope that it will be useful,
9			* but WITHOUT ANY WARRANTY; without even the implied warranty of
10			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
11			*
12			* @copyright XOOPS Project (http://xoops.org)
13			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
14			*
15			* @since 2.2
16			*
17			* @author JJDai <http://xoops.kiolo.com>
18			**/
19			//----------------------------------------------------
20			class Extcal_2_04
			0 ignored issues – show Coding Style Compatibility introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
21			{
22			//----------------------------------------------------
23
24			/**
25			* @param XoopsModule $module
26			* @param $options
27			*/
28			public function __construct(XoopsModule $module, $options)
			0 ignored issues – show Unused Code introduced 2016-08-09 05:35 UTC by Report Bug Copy Issue Report The parameter `$module` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-08-09 05:35 UTC by Report Bug Copy Issue Report The parameter `$options` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
29			{
30			global $xoopsDB;
			0 ignored issues – show Compatibility Best Practice introduced 2016-01-26 04:18 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
31
32			$sql = 'ALTER TABLE `' . $xoopsDB->prefix('extcal_event') . "` ADD `event_nbmember` tinyint(4) NOT NULL default '0' AFTER `event_submitdate` ;";
33			$xoopsDB->query($sql);
34			}
35
36			//-----------------------------------------------------------------
37			} // fin de la classe
38

mambax7 / extcal

Branch — master (c921ab)

Extcal_2_04::__construct() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like