extcal_notify_iteminfo()

Complexity

Conditions	4
Paths	3

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function extcal_notify_iteminfo($category, $itemId)
{
    if ('global' === $category || 'cat' === $category) {
        $item['name'] = '';

$item was never initialized. Although not strictly required by PHP, it is generally a good practice to add $item = array(); before regardless.

        $item['url']  = '';

        return $item;
    }

    if ('event' === $category) {
        $eventHandler = Helper::getInstance()->getHandler(_EXTCAL_CLN_EVENT);
        $event        = $eventHandler->getEvent($itemId, 0, true);

The method getEvent() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

        $item['name'] = $event->getVar('event_title');
        $item['url']  = XOOPS_URL . '/modules/extcal/event.php?event=' . $event->getVar('event_id');

        return $item;
    }

    return '';
}