| Conditions | 9 |
| Paths | 10 |
| Total Lines | 156 |
| Code Lines | 131 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 185 | public function getFormatedReccurRule($event_recur_rules) |
||
| 186 | { |
||
| 187 | $eventOptions = \explode('|', $event_recur_rules); |
||
| 188 | |||
| 189 | switch ($eventOptions[0]) { |
||
| 190 | case 'daily': |
||
| 191 | |||
| 192 | $interval = $eventOptions[1]; |
||
| 193 | |||
| 194 | return \sprintf(\_MD_EXTCAL_RR_DAILY, $interval); |
||
| 195 | break; |
||
| 196 | case 'weekly': |
||
| 197 | |||
| 198 | $daysName = [ |
||
| 199 | 'MO' => _CAL_MONDAY, |
||
| 200 | 'TU' => _CAL_TUESDAY, |
||
| 201 | 'WE' => _CAL_WEDNESDAY, |
||
| 202 | 'TH' => _CAL_THURSDAY, |
||
| 203 | 'FR' => _CAL_FRIDAY, |
||
| 204 | 'SA' => _CAL_SATURDAY, |
||
| 205 | 'SU' => _CAL_SUNDAY, |
||
| 206 | ]; |
||
| 207 | |||
| 208 | $interval = $eventOptions[1]; |
||
| 209 | \array_shift($eventOptions); |
||
| 210 | \array_shift($eventOptions); |
||
| 211 | $day = ''; |
||
| 212 | foreach ($eventOptions as $option) { |
||
| 213 | $day .= ' ' . $daysName[$option] . ', '; |
||
| 214 | } |
||
| 215 | $ret = \sprintf(\_MD_EXTCAL_RR_WEEKLY, $day, $interval); |
||
| 216 | |||
| 217 | return $ret; |
||
| 218 | break; |
||
| 219 | case 'monthly': |
||
| 220 | |||
| 221 | $monthDays = [ |
||
| 222 | '1MO' => \_MD_EXTCAL_1_MO, |
||
| 223 | '1TU' => \_MD_EXTCAL_1_TU, |
||
| 224 | '1WE' => \_MD_EXTCAL_1_WE, |
||
| 225 | '1TH' => \_MD_EXTCAL_1_TH, |
||
| 226 | '1FR' => \_MD_EXTCAL_1_FR, |
||
| 227 | '1SA' => \_MD_EXTCAL_1_SA, |
||
| 228 | '1SU' => \_MD_EXTCAL_1_SU, |
||
| 229 | '2MO' => \_MD_EXTCAL_2_MO, |
||
| 230 | '2TU' => \_MD_EXTCAL_2_TU, |
||
| 231 | '2WE' => \_MD_EXTCAL_2_WE, |
||
| 232 | '2TH' => \_MD_EXTCAL_2_TH, |
||
| 233 | '2FR' => \_MD_EXTCAL_2_FR, |
||
| 234 | '2SA' => \_MD_EXTCAL_2_SA, |
||
| 235 | '2SU' => \_MD_EXTCAL_2_SU, |
||
| 236 | '3MO' => \_MD_EXTCAL_3_MO, |
||
| 237 | '3TU' => \_MD_EXTCAL_3_TU, |
||
| 238 | '3WE' => \_MD_EXTCAL_3_WE, |
||
| 239 | '3TH' => \_MD_EXTCAL_3_TH, |
||
| 240 | '3FR' => \_MD_EXTCAL_3_FR, |
||
| 241 | '3SA' => \_MD_EXTCAL_3_SA, |
||
| 242 | '3SU' => \_MD_EXTCAL_3_SU, |
||
| 243 | '4MO' => \_MD_EXTCAL_4_MO, |
||
| 244 | '4TU' => \_MD_EXTCAL_4_TU, |
||
| 245 | '4WE' => \_MD_EXTCAL_4_WE, |
||
| 246 | '4TH' => \_MD_EXTCAL_4_TH, |
||
| 247 | '4FR' => \_MD_EXTCAL_4_FR, |
||
| 248 | '4SA' => \_MD_EXTCAL_4_SA, |
||
| 249 | '4SU' => \_MD_EXTCAL_4_SU, |
||
| 250 | '-1MO' => \_MD_EXTCAL_LAST_MO, |
||
| 251 | '-1TU' => \_MD_EXTCAL_LAST_TU, |
||
| 252 | '-1WE' => \_MD_EXTCAL_LAST_WE, |
||
| 253 | '-1TH' => \_MD_EXTCAL_LAST_TH, |
||
| 254 | '-1FR' => \_MD_EXTCAL_LAST_FR, |
||
| 255 | '-1SA' => \_MD_EXTCAL_LAST_SA, |
||
| 256 | '-1SU' => \_MD_EXTCAL_LAST_SU, |
||
| 257 | ]; |
||
| 258 | |||
| 259 | $interval = $eventOptions[1]; |
||
| 260 | if (0 === mb_strpos($eventOptions[2], 'MD')) { |
||
| 261 | return \sprintf(\_MD_EXTCAL_RR_MONTHLY, mb_substr($eventOptions[2], 2), $interval); |
||
| 262 | } |
||
| 263 | |||
| 264 | return \sprintf(\_MD_EXTCAL_RR_MONTHLY, $monthDays[$eventOptions[2]], $interval); |
||
| 265 | break; |
||
| 266 | case 'yearly': |
||
| 267 | |||
| 268 | $monthDays = [ |
||
| 269 | '1MO' => \_MD_EXTCAL_1_MO, |
||
| 270 | '1TU' => \_MD_EXTCAL_1_TU, |
||
| 271 | '1WE' => \_MD_EXTCAL_1_WE, |
||
| 272 | '1TH' => \_MD_EXTCAL_1_TH, |
||
| 273 | '1FR' => \_MD_EXTCAL_1_FR, |
||
| 274 | '1SA' => \_MD_EXTCAL_1_SA, |
||
| 275 | '1SU' => \_MD_EXTCAL_1_SU, |
||
| 276 | '2MO' => \_MD_EXTCAL_2_MO, |
||
| 277 | '2TU' => \_MD_EXTCAL_2_TU, |
||
| 278 | '2WE' => \_MD_EXTCAL_2_WE, |
||
| 279 | '2TH' => \_MD_EXTCAL_2_TH, |
||
| 280 | '2FR' => \_MD_EXTCAL_2_FR, |
||
| 281 | '2SA' => \_MD_EXTCAL_2_SA, |
||
| 282 | '2SU' => \_MD_EXTCAL_2_SU, |
||
| 283 | '3MO' => \_MD_EXTCAL_3_MO, |
||
| 284 | '3TU' => \_MD_EXTCAL_3_TU, |
||
| 285 | '3WE' => \_MD_EXTCAL_3_WE, |
||
| 286 | '3TH' => \_MD_EXTCAL_3_TH, |
||
| 287 | '3FR' => \_MD_EXTCAL_3_FR, |
||
| 288 | '3SA' => \_MD_EXTCAL_3_SA, |
||
| 289 | '3SU' => \_MD_EXTCAL_3_SU, |
||
| 290 | '4MO' => \_MD_EXTCAL_4_MO, |
||
| 291 | '4TU' => \_MD_EXTCAL_4_TU, |
||
| 292 | '4WE' => \_MD_EXTCAL_4_WE, |
||
| 293 | '4TH' => \_MD_EXTCAL_4_TH, |
||
| 294 | '4FR' => \_MD_EXTCAL_4_FR, |
||
| 295 | '4SA' => \_MD_EXTCAL_4_SA, |
||
| 296 | '4SU' => \_MD_EXTCAL_4_SU, |
||
| 297 | '-1MO' => \_MD_EXTCAL_LAST_MO, |
||
| 298 | '-1TU' => \_MD_EXTCAL_LAST_TU, |
||
| 299 | '-1WE' => \_MD_EXTCAL_LAST_WE, |
||
| 300 | '-1TH' => \_MD_EXTCAL_LAST_TH, |
||
| 301 | '-1FR' => \_MD_EXTCAL_LAST_FR, |
||
| 302 | '-1SA' => \_MD_EXTCAL_LAST_SA, |
||
| 303 | '-1SU' => \_MD_EXTCAL_LAST_SU, |
||
| 304 | ]; |
||
| 305 | |||
| 306 | $monthName = [ |
||
| 307 | 1 => _CAL_JANUARY, |
||
| 308 | 2 => _CAL_FEBRUARY, |
||
| 309 | 3 => _CAL_MARCH, |
||
| 310 | 4 => _CAL_APRIL, |
||
| 311 | 5 => _CAL_MAY, |
||
| 312 | 6 => _CAL_JUNE, |
||
| 313 | 7 => _CAL_JULY, |
||
| 314 | 8 => _CAL_AUGUST, |
||
| 315 | 9 => _CAL_SEPTEMBER, |
||
| 316 | 10 => _CAL_OCTOBER, |
||
| 317 | 11 => _CAL_NOVEMBER, |
||
| 318 | 12 => _CAL_DECEMBER, |
||
| 319 | ]; |
||
| 320 | |||
| 321 | $interval = $eventOptions[1]; |
||
| 322 | $day = $eventOptions[2]; |
||
| 323 | \array_shift($eventOptions); |
||
| 324 | \array_shift($eventOptions); |
||
| 325 | \array_shift($eventOptions); |
||
| 326 | $month = ''; |
||
| 327 | foreach ($eventOptions as $option) { |
||
| 328 | $month .= ' ' . $monthName[$option] . ', '; |
||
| 329 | } |
||
| 330 | $dayString = $day; |
||
| 331 | if (\array_key_exists($day, $monthDays)) { |
||
| 332 | $dayString = $monthDays[$day]; |
||
| 333 | } |
||
| 334 | $ret = \sprintf(\_MD_EXTCAL_RR_YEARLY, $month, $dayString, $interval); |
||
| 335 | |||
| 336 | return $ret; |
||
| 337 | break; |
||
| 338 | } |
||
| 339 | |||
| 340 | return false; |
||
| 341 | } |
||
| 343 |
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: