mambax7 /
extcal
| Conditions | 4 |
| Paths | 8 |
| Total Lines | 60 |
| Code Lines | 44 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public function getForm($action = false) |
||
| 63 | { |
||
| 64 | global $xoopsDB; |
||
| 65 | |||
| 66 | if (false === $action) { |
||
| 67 | $action = $_SERVER['REQUEST_URI']; |
||
| 68 | } |
||
| 69 | |||
| 70 | $title = $this->isNew() ? \sprintf(\_MD_EXTCAL_LOCATION_ADD) : \sprintf(\_MD_EXTCAL_LOCATION_EDIT); |
||
| 71 | |||
| 72 | require_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php'; |
||
| 73 | |||
| 74 | $form = new \XoopsThemeForm($title, 'form', $action, 'post', true); |
||
| 75 | $form->setExtra('enctype="multipart/form-data"'); |
||
| 76 | |||
| 77 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_NOM, 'nom', 50, 255, $this->getVar('nom')), true); |
||
|
Bug
introduced
by
|
|||
| 78 | $form->addElement(new \XoopsFormDhtmlTextArea(\_MD_EXTCAL_LOCATION_DESCRIPTION, 'description', $this->getVar('description'), 10), false); |
||
| 79 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_CATEGORIE, 'categorie', 40, 255, $this->getVar('categorie')), false); |
||
| 80 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_ADRESSE, 'adresse', 50, 255, $this->getVar('adresse')), false); |
||
| 81 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_ADRESSE2, 'adresse2', 50, 255, $this->getVar('adresse2')), false); |
||
| 82 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_CP, 'cp', 10, 10, $this->getVar('cp')), false); |
||
| 83 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_VILLE, 'ville', 20, 255, $this->getVar('ville')), false); |
||
| 84 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_TEL_FIXE, 'tel_fixe', 20, 20, $this->getVar('tel_fixe')), false); |
||
| 85 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_TEL_PORTABLE, 'tel_portable', 20, 20, $this->getVar('tel_portable')), false); |
||
| 86 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_MAIL, 'mail', 50, 255, $this->getVar('mail')), false); |
||
| 87 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_SITE, 'site', 50, 255, $this->getVar('site')), false); |
||
| 88 | $form->addElement(new \XoopsFormTextArea(\_MD_EXTCAL_LOCATION_HORAIRES, 'horaires', $this->getVar('horaires'), 3, 40)); |
||
| 89 | $form->addElement(new \XoopsFormTextArea(\_MD_EXTCAL_LOCATION_DIVERS, 'divers', $this->getVar('divers'), 5, 40)); |
||
| 90 | //$form->addElement( new \XoopsFormTextArea(_MD_EXTCAL_LOCATION_TARIFS, 'tarifs', $this->getVar("tarifs"), 5, 40)); |
||
| 91 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_TARIFS . ' ( ' . \_MD_EXTCAL_DEVISE2 . ' )', 'tarifs', 20, 20, $this->getVar('tarifs')), false); |
||
| 92 | |||
| 93 | //$form->addElement( new \XoopsFormTextArea(_MD_EXTCAL_LOCATION_MAP, 'map', $this->getVar("map"), 5, 40)); |
||
| 94 | $form->addElement(new \XoopsFormText(\_MD_EXTCAL_LOCATION_MAP, 'map', 150, 255, $this->getVar('map')), false); |
||
| 95 | |||
| 96 | //Logo |
||
| 97 | $file_tray = new \XoopsFormElementTray(\sprintf(\_MD_EXTCAL_FORM_IMG, 2), ''); |
||
| 98 | if ('' != $this->getVar('logo')) { |
||
| 99 | $file_tray->addElement(new \XoopsFormLabel('', "<img src='" . XOOPS_URL . '/uploads/extcal/location/' . $this->getVar('logo') . "' name='image' id='image' alt=''><br><br>")); |
||
| 100 | $check_del_img = new \XoopsFormCheckBox('', 'delimg'); |
||
| 101 | $check_del_img->addOption(1, \_MD_EXTCAL_DEL_IMG); |
||
| 102 | $file_tray->addElement($check_del_img); |
||
| 103 | $file_img = new \XoopsFormFile(\_MD_EXTCAL_IMG, 'attachedimage', 3145728); |
||
| 104 | unset($check_del_img); |
||
| 105 | } else { |
||
| 106 | $file_img = new \XoopsFormFile('', 'attachedimage', 3145728); |
||
| 107 | } |
||
| 108 | $file_img->setExtra("size ='40'"); |
||
| 109 | $file_tray->addElement($file_img); |
||
| 110 | $msg = \sprintf(\_MD_EXTCAL_IMG_CONFIG, (int)(3145728 / 1000), 500); |
||
| 111 | $file_label = new \XoopsFormLabel('', '<br>' . $msg); |
||
| 112 | $file_tray->addElement($file_label); |
||
| 113 | $form->addElement($file_tray); |
||
| 114 | $form->addElement(new \XoopsFormHidden('file', $this->getVar('logo'))); |
||
| 115 | unset($file_img, $file_tray); |
||
| 116 | |||
| 117 | $form->addElement(new \XoopsFormHidden('op', 'save_location')); |
||
| 118 | $form->addElement(new \XoopsFormButton('', 'submit', \_SUBMIT, 'submit')); |
||
| 119 | $form->display(); |
||
| 120 | |||
| 121 | return $form; |
||
| 122 | } |
||
| 124 |
Loading history...