XoopsModules\Extcal\Perm

Complexity

Total Complexity

9

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getHandler()	0	8	2
A	getUserGroup()	0	7	2
A	getAuthorizedCat()	0	17	4
A	isAllowed()	0	5	1

<?php

namespace XoopsModules\Extcal;

/**
 * Class Perm.
 */
class Perm
{
    /**
     * @return Perm
     */
    public static function getHandler()
    {
        static $permHandler;
        if (!isset($permHandler)) {
            $permHandler = new self();
        }

        return $permHandler;
    }

    /**
     * @param $user
     *
     * @return string
     */
    public function getUserGroup($user)
    {
        if ($user instanceof \XoopsUser) {
            return $user->getGroups();

The expression return $user->getGroups() returns the type array which is incompatible with the documented return type string.

        }

        return XOOPS_GROUP_ANONYMOUS;
    }

    /**
     * @param           $user
     * @param           $perm
     *
     * @return bool
     */
    public function getAuthorizedCat($user, $perm)
    {
        static $authorizedCat;
        $userId = $user ? $user->getVar('uid') : 0;
        if (!isset($authorizedCat[$perm][$userId])) {
            /** @var \XoopsGroupPermHandler $grouppermHandler */
            $groupPermHandler = \xoops_getHandler('groupperm');
            /** @var \XoopsModuleHandler $moduleHandler */
            $moduleHandler = \xoops_getHandler('module');
            $module        = $moduleHandler->getByDirname('extcal');
            if (!$module) {
                return false;
            }
            $authorizedCat[$perm][$userId] = $groupPermHandler->getItemIds($perm, $this->getUserGroup($user), $module->getVar('mid'));

The method getItemIds() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsGroupPermHandler or XoopsPersistableObjectHandler.

        }

        return $authorizedCat[$perm][$userId];
    }

    /**
     * @param $user
     * @param $perm
     * @param $catId
     *
     * @return bool
     */
    public function isAllowed($user, $perm, $catId)
    {
        $autorizedCat = $this->getAuthorizedCat($user, $perm);

        return \in_array($catId, $autorizedCat);

$autorizedCat of type boolean is incompatible with the type array expected by parameter $haystack of in_array().

    }
}