Passed
Push — master ( eae254...f7b1d8 )
by Michael
04:10 queued 57s
created
class/Common/Blocksadmin.php 1 patch
Braces   +15 added lines, -30 removed lines patch added patch discarded remove patch
@@ -150,8 +150,7 @@  discard block
 block discarded – undo
150 150
             foreach ($cachetimes as $cachetime => $cachetimeName) {
151 151
                 if ($i->getVar('bcachetime') == $cachetime) {
152 152
                     $cachetimeOptions .= "<option value='$cachetime' selected='selected'>$cachetimeName</option>\n";
153
-                }
154
-                else {
153
+                } else {
155 154
                     $cachetimeOptions .= "<option value='$cachetime'>$cachetimeName</option>\n";
156 155
                 }
157 156
             }
@@ -168,38 +167,29 @@  discard block
 block discarded – undo
168 167
             $sel0  = $sel1;
169 168
             if (1 === $i->getVar('visible')) {
170 169
                 $sel1 = ' checked';
171
-            }
172
-            else {
170
+            } else {
173 171
                 $sel0 = ' checked';
174 172
             }
175 173
             if (\XOOPS_SIDEBLOCK_LEFT === $i->getVar('side')) {
176 174
                 $ssel0 = ' checked';
177
-            }
178
-            elseif (\XOOPS_SIDEBLOCK_RIGHT === $i->getVar('side')) {
175
+            } elseif (\XOOPS_SIDEBLOCK_RIGHT === $i->getVar('side')) {
179 176
                 $ssel1 = ' checked';
180
-            }
181
-            elseif (\XOOPS_CENTERBLOCK_LEFT === $i->getVar('side')) {
177
+            } elseif (\XOOPS_CENTERBLOCK_LEFT === $i->getVar('side')) {
182 178
                 $ssel2 = ' checked';
183
-            }
184
-            elseif (\XOOPS_CENTERBLOCK_RIGHT === $i->getVar('side')) {
179
+            } elseif (\XOOPS_CENTERBLOCK_RIGHT === $i->getVar('side')) {
185 180
                 $ssel4 = ' checked';
186
-            }
187
-            elseif (\XOOPS_CENTERBLOCK_CENTER === $i->getVar('side')) {
181
+            } elseif (\XOOPS_CENTERBLOCK_CENTER === $i->getVar('side')) {
188 182
                 $ssel3 = ' checked';
189
-            }
190
-            elseif (\XOOPS_CENTERBLOCK_BOTTOMLEFT === $i->getVar('side')) {
183
+            } elseif (\XOOPS_CENTERBLOCK_BOTTOMLEFT === $i->getVar('side')) {
191 184
                 $ssel5 = ' checked';
192
-            }
193
-            elseif (\XOOPS_CENTERBLOCK_BOTTOMRIGHT === $i->getVar('side')) {
185
+            } elseif (\XOOPS_CENTERBLOCK_BOTTOMRIGHT === $i->getVar('side')) {
194 186
                 $ssel6 = ' checked';
195
-            }
196
-            elseif (\XOOPS_CENTERBLOCK_BOTTOM === $i->getVar('side')) {
187
+            } elseif (\XOOPS_CENTERBLOCK_BOTTOM === $i->getVar('side')) {
197 188
                 $ssel7 = ' checked';
198 189
             }
199 190
             if ('' === $i->getVar('title')) {
200 191
                 $title = '&nbsp;';
201
-            }
202
-            else {
192
+            } else {
203 193
                 $title = $i->getVar('title');
204 194
             }
205 195
             $name = $i->getVar('name');
@@ -414,8 +404,7 @@  discard block
 block discarded – undo
414 404
         $clone->setVar('bid', 0);
415 405
         if (\in_array($block->getVar('block_type'), ['C', 'E'])) {
416 406
             $clone->setVar('block_type', 'E');
417
-        }
418
-        else {
407
+        } else {
419 408
             $clone->setVar('block_type', 'D');
420 409
         }
421 410
         //        $newid = $clone->store(); //see https://github.com/XOOPS/XoopsCore25/issues/1105
@@ -540,8 +529,7 @@  discard block
 block discarded – undo
540 529
             if (\in_array(0, $bmodule)) {
541 530
                 $sql = \sprintf('INSERT INTO `%s` (block_id, module_id) VALUES (%u, %d)', $this->db->prefix('block_module_link'), $bid, 0);
542 531
                 $this->db->query($sql);
543
-            }
544
-            else {
532
+            } else {
545 533
                 foreach ($bmodule as $bmid) {
546 534
                     $sql = \sprintf('INSERT INTO `%s` (block_id, module_id) VALUES (%u, %d)', $this->db->prefix('block_module_link'), $bid, (int)$bmid);
547 535
                     $this->db->query($sql);
@@ -595,8 +583,7 @@  discard block
 block discarded – undo
595 583
                 if (\in_array(0, $bmodule[$i], true)) {
596 584
                     $sql = \sprintf('INSERT INTO `%s` (block_id, module_id) VALUES (%u, %d)', $this->db->prefix('block_module_link'), $bid[$i], 0);
597 585
                     $this->db->query($sql);
598
-                }
599
-                else {
586
+                } else {
600 587
                     foreach ($bmodule[$i] as $bmid) {
601 588
                         $sql = \sprintf('INSERT INTO `%s` (block_id, module_id) VALUES (%u, %d)', $this->db->prefix('block_module_link'), $bid[$i], (int)$bmid);
602 589
                         $this->db->query($sql);
@@ -663,16 +650,14 @@  discard block
 block discarded – undo
663 650
                                              'T' => \_AM_SYSTEM_BLOCKS_AFNOSMILE,
664 651
                                          ]);
665 652
             $form->addElement($ctypeSelect);
666
-        }
667
-        else {
653
+        } else {
668 654
             if ('' !== $block['template']) {
669 655
                 /** @var \XoopsTplfileHandler $tplfileHandler */
670 656
                 $tplfileHandler = \xoops_getHandler('tplfile');
671 657
                 $btemplate      = $tplfileHandler->find($GLOBALS['xoopsConfig']['template_set'], 'block', $block['bid']);
672 658
                 if (\count($btemplate) > 0) {
673 659
                     $form->addElement(new \XoopsFormLabel(\_AM_SYSTEM_BLOCKS_CONTENT, '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id=' . $btemplate[0]->getVar('tpl_id') . '">' . \_AM_SYSTEM_BLOCKS_EDITTPL . '</a>'));
674
-                }
675
-                else {
660
+                } else {
676 661
                     $btemplate2 = $tplfileHandler->find('default', 'block', $block['bid']);
677 662
                     if (\count($btemplate2) > 0) {
678 663
                         $form->addElement(new \XoopsFormLabel(\_AM_SYSTEM_BLOCKS_CONTENT, '<a href="' . XOOPS_URL . '/modules/system/admin.php?fct=tplsets&amp;op=edittpl&amp;id=' . $btemplate2[0]->getVar('tpl_id') . '" target="_blank">' . \_AM_SYSTEM_BLOCKS_EDITTPL . '</a>'));
Please login to merge, or discard this patch.