Issues in index.php - All Issues - Inspection of "2.25 RC1" - mambax7/contact - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 720064...d5ad83 )

by Michael

created 2017-07-02 02:41 UTC

index.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Contact module
 *
 * @copyright   The XOOPS Project http://sourceforge.net/projects/xoops/
 * @license     http://www.fsf.org/copyleft/gpl.html GNU public license
 * @author      Kazumi Ono (aka Onokazu)
 * @author      Trabis <[email protected]>
 * @author      Hossein Azizabadi (AKA Voltan)
 * @author      Mirza (AKA Bleekk)
  */
include __DIR__ . '/header.php';
$GLOBALS['xoopsOption']['template_main'] = 'contact_index.tpl';
//unset($_SESSION);
include XOOPS_ROOT_PATH . '/header.php';
global $xoopsModuleConfig, $xoopsModule;
function myFunction($a, $b) {
    // Do something
}
/*Modules Options*/
if ($xoopsModuleConfig['form_dept'] == 1) {
    // show a drop down with the correct departments listed
    $departmentlist = array();
    $departments    = xoops_getModuleOption('contact_dept', 'contact');
    foreach ($departments as $val) {
        list($name, $email) = explode(',', $val, 2); //split the name and email
        $departmentlist[] = $name;
    }
    $GLOBALS['xoopsTpl']->assign('depart', $xoopsModuleConfig['form_dept']);
    $GLOBALS['xoopsTpl']->assign('departments', $departmentlist);
}
$GLOBALS['xoopsTpl']->assign('recaptcha', $xoopsModuleConfig['recaptchause']);
$GLOBALS['xoopsTpl']->assign('recaptchakey', $xoopsModuleConfig['recaptchakey']);
$GLOBALS['xoopsTpl']->assign('url', $xoopsModuleConfig['form_url']);
$GLOBALS['xoopsTpl']->assign('icq', $xoopsModuleConfig['form_icq']);
$GLOBALS['xoopsTpl']->assign('skype', $xoopsModuleConfig['form_skype']);
$GLOBALS['xoopsTpl']->assign('company', $xoopsModuleConfig['form_company']);
$GLOBALS['xoopsTpl']->assign('location', $xoopsModuleConfig['form_location']);
$GLOBALS['xoopsTpl']->assign('phone', $xoopsModuleConfig['form_phone']);
$GLOBALS['xoopsTpl']->assign('address', $xoopsModuleConfig['form_address']);

$GLOBALS['xoopsTpl']->assign('map', $xoopsModuleConfig['embed_maps']);
/*end Modules options*/

$GLOBALS['xoopsTpl']->assign('breadcrumb', '<li><a href="' . XOOPS_URL . '">' . _YOURHOME . '</a></li> <li class="active">' . $xoopsModule->name().'</li>');
$GLOBALS['xoopsTpl']->assign('info', xoops_getModuleOption('contact_info', 'contact'));
$GLOBALS['xoopsTpl']->assign('contact_default', xoops_getModuleOption('contact_default', 'contact'));

/* lang vars, added by goffy */
$GLOBALS['xoopsTpl']->assign('lng_username', _MD_CONTACT_NAME);
$GLOBALS['xoopsTpl']->assign('lng_email', _MD_CONTACT_MAIL);
$GLOBALS['xoopsTpl']->assign('lng_url', _MD_CONTACT_URL);
$GLOBALS['xoopsTpl']->assign('lng_company', _MD_CONTACT_COMPANY);
$GLOBALS['xoopsTpl']->assign('lng_icq', _MD_CONTACT_ICQ_NAME);
$GLOBALS['xoopsTpl']->assign('lng_address', _MD_CONTACT_ADDRESS);
$GLOBALS['xoopsTpl']->assign('lng_location', _MD_CONTACT_LOCATION);
$GLOBALS['xoopsTpl']->assign('lng_phone', _MD_CONTACT_PHONE);
$GLOBALS['xoopsTpl']->assign('lng_skypename', _MD_CONTACT_SKYPE_NAME);
$GLOBALS['xoopsTpl']->assign('lng_department', _MD_CONTACT_DEPARTMENT);
$GLOBALS['xoopsTpl']->assign('lng_subject', _MD_CONTACT_SUBJECT);
$GLOBALS['xoopsTpl']->assign('lng_message', _MD_CONTACT_MESSAGE);
$GLOBALS['xoopsTpl']->assign('lng_submit', _MD_CONTACT_SUBMIT);

$GLOBALS['xoopsTpl']->assign('lng_username_info', _MD_CONTACT_NAME_INFO);
$GLOBALS['xoopsTpl']->assign('lng_email_info', _MD_CONTACT_MAIL_INFO);
$GLOBALS['xoopsTpl']->assign('lng_url_info', _MD_CONTACT_URL_INFO);
$GLOBALS['xoopsTpl']->assign('lng_company_info', _MD_CONTACT_COMPANY_INFO);
$GLOBALS['xoopsTpl']->assign('lng_address_info', _MD_CONTACT_ADDRESS_INFO);
$GLOBALS['xoopsTpl']->assign('lng_location_info', _MD_CONTACT_LOCATION_INFO);
$GLOBALS['xoopsTpl']->assign('lng_phone_info', _MD_CONTACT_PHONE_INFO);
$GLOBALS['xoopsTpl']->assign('lng_icq_info', _MD_CONTACT_ICQ_INFO);
$GLOBALS['xoopsTpl']->assign('lng_skypename_info', _MD_CONTACT_SKYPE_NAME_INFO);
$GLOBALS['xoopsTpl']->assign('lng_subject_info', _MD_CONTACT_SUBJECT_INFO);
$GLOBALS['xoopsTpl']->assign('lng_message_info', _MD_CONTACT_MESSAGE_INFO);
               
include XOOPS_ROOT_PATH . '/footer.php';


Push — master ( 720064...d5ad83 )

index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11
12			/**
13			* Contact module
14			*
15			* @copyright The XOOPS Project http://sourceforge.net/projects/xoops/
16			* @license http://www.fsf.org/copyleft/gpl.html GNU public license
17			* @author Kazumi Ono (aka Onokazu)
18			* @author Trabis <[email protected]>
19			* @author Hossein Azizabadi (AKA Voltan)
20			* @author Mirza (AKA Bleekk)
21			*/
22			include __DIR__ . '/header.php';
23			$GLOBALS['xoopsOption']['template_main'] = 'contact_index.tpl';
24			//unset($_SESSION);
25			include XOOPS_ROOT_PATH . '/header.php';
26			global $xoopsModuleConfig, $xoopsModule;
			0 ignored issues – show Compatibility Best Practice introduced 2017-07-01 20:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
27			/Modules Options/
28			if ($xoopsModuleConfig['form_dept'] == 1) {
29			// show a drop down with the correct departments listed
30			$departmentlist = array();
31			$departments = xoops_getModuleOption('contact_dept', 'contact');
32			foreach ($departments as $val) {
33			list($name, $email) = explode(',', $val, 2); //split the name and email
34			$departmentlist[] = $name;
35			}
36			$GLOBALS['xoopsTpl']->assign('depart', $xoopsModuleConfig['form_dept']);
37			$GLOBALS['xoopsTpl']->assign('departments', $departmentlist);
38			}
39			$GLOBALS['xoopsTpl']->assign('recaptcha', $xoopsModuleConfig['recaptchause']);
40			$GLOBALS['xoopsTpl']->assign('recaptchakey', $xoopsModuleConfig['recaptchakey']);
41			$GLOBALS['xoopsTpl']->assign('url', $xoopsModuleConfig['form_url']);
42			$GLOBALS['xoopsTpl']->assign('icq', $xoopsModuleConfig['form_icq']);
43			$GLOBALS['xoopsTpl']->assign('skype', $xoopsModuleConfig['form_skype']);
44			$GLOBALS['xoopsTpl']->assign('company', $xoopsModuleConfig['form_company']);
45			$GLOBALS['xoopsTpl']->assign('location', $xoopsModuleConfig['form_location']);
46			$GLOBALS['xoopsTpl']->assign('phone', $xoopsModuleConfig['form_phone']);
47			$GLOBALS['xoopsTpl']->assign('address', $xoopsModuleConfig['form_address']);
48
49			$GLOBALS['xoopsTpl']->assign('map', $xoopsModuleConfig['embed_maps']);
50			/end Modules options/
51
52			$GLOBALS['xoopsTpl']->assign('breadcrumb', '<li><a href="' . XOOPS_URL . '">' . _YOURHOME . '</a></li> <li class="active">' . $xoopsModule->name().'</li>');
53			$GLOBALS['xoopsTpl']->assign('info', xoops_getModuleOption('contact_info', 'contact'));
54			$GLOBALS['xoopsTpl']->assign('contact_default', xoops_getModuleOption('contact_default', 'contact'));
55
56			/* lang vars, added by goffy */
57			$GLOBALS['xoopsTpl']->assign('lng_username', _MD_CONTACT_NAME);
58			$GLOBALS['xoopsTpl']->assign('lng_email', _MD_CONTACT_MAIL);
59			$GLOBALS['xoopsTpl']->assign('lng_url', _MD_CONTACT_URL);
60			$GLOBALS['xoopsTpl']->assign('lng_company', _MD_CONTACT_COMPANY);
61			$GLOBALS['xoopsTpl']->assign('lng_icq', _MD_CONTACT_ICQ_NAME);
62			$GLOBALS['xoopsTpl']->assign('lng_address', _MD_CONTACT_ADDRESS);
63			$GLOBALS['xoopsTpl']->assign('lng_location', _MD_CONTACT_LOCATION);
64			$GLOBALS['xoopsTpl']->assign('lng_phone', _MD_CONTACT_PHONE);
65			$GLOBALS['xoopsTpl']->assign('lng_skypename', _MD_CONTACT_SKYPE_NAME);
66			$GLOBALS['xoopsTpl']->assign('lng_department', _MD_CONTACT_DEPARTMENT);
67			$GLOBALS['xoopsTpl']->assign('lng_subject', _MD_CONTACT_SUBJECT);
68			$GLOBALS['xoopsTpl']->assign('lng_message', _MD_CONTACT_MESSAGE);
69			$GLOBALS['xoopsTpl']->assign('lng_submit', _MD_CONTACT_SUBMIT);
70
71			$GLOBALS['xoopsTpl']->assign('lng_username_info', _MD_CONTACT_NAME_INFO);
72			$GLOBALS['xoopsTpl']->assign('lng_email_info', _MD_CONTACT_MAIL_INFO);
73			$GLOBALS['xoopsTpl']->assign('lng_url_info', _MD_CONTACT_URL_INFO);
74			$GLOBALS['xoopsTpl']->assign('lng_company_info', _MD_CONTACT_COMPANY_INFO);
75			$GLOBALS['xoopsTpl']->assign('lng_address_info', _MD_CONTACT_ADDRESS_INFO);
76			$GLOBALS['xoopsTpl']->assign('lng_location_info', _MD_CONTACT_LOCATION_INFO);
77			$GLOBALS['xoopsTpl']->assign('lng_phone_info', _MD_CONTACT_PHONE_INFO);
78			$GLOBALS['xoopsTpl']->assign('lng_icq_info', _MD_CONTACT_ICQ_INFO);
79			$GLOBALS['xoopsTpl']->assign('lng_skypename_info', _MD_CONTACT_SKYPE_NAME_INFO);
80			$GLOBALS['xoopsTpl']->assign('lng_subject_info', _MD_CONTACT_SUBJECT_INFO);
81			$GLOBALS['xoopsTpl']->assign('lng_message_info', _MD_CONTACT_MESSAGE_INFO);
82
83			include XOOPS_ROOT_PATH . '/footer.php';
84

mambax7 / contact

Push — master ( 720064...d5ad83 )

index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like