mambax7 / chess

include/notification.inc.php

Spacing +6 added lines, -6 removed lines

@@ -39,10 +39,10 @@ 
 // The language file gets automatically included within this module,
 // but not when viewing the notifications page via notifications.php.
 global $xoopsConfig;
-if (file_exists(XOOPS_ROOT_PATH . "/modules/chess/language/{$xoopsConfig['language']}/main.php")) {
-    require_once XOOPS_ROOT_PATH . "/modules/chess/language/{$xoopsConfig['language']}/main.php";
+if (file_exists(XOOPS_ROOT_PATH."/modules/chess/language/{$xoopsConfig['language']}/main.php")) {
+    require_once XOOPS_ROOT_PATH."/modules/chess/language/{$xoopsConfig['language']}/main.php";
 } else {
-    require_once XOOPS_ROOT_PATH . '/modules/chess/language/english/main.php';
+    require_once XOOPS_ROOT_PATH.'/modules/chess/language/english/main.php';
 }
 /**#@-*/
 
@@ -60,7 +60,7 @@ 
     if ('global' == $category) {
         $item['name'] = 'Chess';
 
-        $item['url'] = XOOPS_URL . '/modules/chess/';
+        $item['url'] = XOOPS_URL.'/modules/chess/';
 
         return $item;
     } elseif ('game' == $category) {
@@ -104,9 +104,9 @@ 
             $date = _MD_CHESS_NA;
         }
 
-        $item['name'] = "$username_white " . _MD_CHESS_LABEL_VS . " $username_black ($date)";
+        $item['name'] = "$username_white "._MD_CHESS_LABEL_VS." $username_black ($date)";
 
-        $item['url'] = XOOPS_URL . '/modules/chess/game.php?game_id=' . $item_id;
+        $item['url'] = XOOPS_URL.'/modules/chess/game.php?game_id='.$item_id;
 
         return $item;
     }

Indentation +33 added lines, -33 removed lines

@@ -40,9 +40,9 @@ 
 // but not when viewing the notifications page via notifications.php.
 global $xoopsConfig;
 if (file_exists(XOOPS_ROOT_PATH . "/modules/chess/language/{$xoopsConfig['language']}/main.php")) {
-    require_once XOOPS_ROOT_PATH . "/modules/chess/language/{$xoopsConfig['language']}/main.php";
+	require_once XOOPS_ROOT_PATH . "/modules/chess/language/{$xoopsConfig['language']}/main.php";
 } else {
-    require_once XOOPS_ROOT_PATH . '/modules/chess/language/english/main.php';
+	require_once XOOPS_ROOT_PATH . '/modules/chess/language/english/main.php';
 }
 /**#@-*/
 
@@ -57,57 +57,57 @@ 
  */
 function chess_notify_item_info($category, $item_id)
 {
-    if ('global' == $category) {
-        $item['name'] = 'Chess';
+	if ('global' == $category) {
+		$item['name'] = 'Chess';
 
-        $item['url'] = XOOPS_URL . '/modules/chess/';
+		$item['url'] = XOOPS_URL . '/modules/chess/';
 
-        return $item;
-    } elseif ('game' == $category) {
-        global $xoopsDB;
+		return $item;
+	} elseif ('game' == $category) {
+		global $xoopsDB;
 
-        $table = $xoopsDB->prefix('chess_games');
+		$table = $xoopsDB->prefix('chess_games');
 
-        $result = $xoopsDB->query(
-            trim(
-                "
+		$result = $xoopsDB->query(
+			trim(
+				"
 			SELECT white_uid, black_uid, UNIX_TIMESTAMP(start_date) AS start_date
 			FROM   $table
 			WHERE  game_id = '$item_id'
 		"
-            )
-        );
+			)
+		);
 
-        $gamedata = $xoopsDB->fetchArray($result);
+		$gamedata = $xoopsDB->fetchArray($result);
 
-        $xoopsDB->freeRecordSet($result);
+		$xoopsDB->freeRecordSet($result);
 
-        if (false !== $gamedata) {
-            // get mapping of user IDs to usernames
+		if (false !== $gamedata) {
+			// get mapping of user IDs to usernames
 
-            $criteria = new \Criteria('uid', "({$gamedata['white_uid']}, {$gamedata['black_uid']})", 'IN');
+			$criteria = new \Criteria('uid', "({$gamedata['white_uid']}, {$gamedata['black_uid']})", 'IN');
 
-            $memberHandler = xoops_getHandler('member');
+			$memberHandler = xoops_getHandler('member');
 
-            $usernames = $memberHandler->getUserList($criteria);
+			$usernames = $memberHandler->getUserList($criteria);
 
-            $username_white = $usernames[$gamedata['white_uid']] ?? _MD_CHESS_NA;
+			$username_white = $usernames[$gamedata['white_uid']] ?? _MD_CHESS_NA;
 
-            $username_black = $usernames[$gamedata['black_uid']] ?? _MD_CHESS_NA;
+			$username_black = $usernames[$gamedata['black_uid']] ?? _MD_CHESS_NA;
 
-            $date = $gamedata['start_date'] ? date('Y.m.d', $gamedata['start_date']) : _MD_CHESS_NA;
-        } else {
-            $username_white = _MD_CHESS_NA;
+			$date = $gamedata['start_date'] ? date('Y.m.d', $gamedata['start_date']) : _MD_CHESS_NA;
+		} else {
+			$username_white = _MD_CHESS_NA;
 
-            $username_black = _MD_CHESS_NA;
+			$username_black = _MD_CHESS_NA;
 
-            $date = _MD_CHESS_NA;
-        }
+			$date = _MD_CHESS_NA;
+		}
 
-        $item['name'] = "$username_white " . _MD_CHESS_LABEL_VS . " $username_black ($date)";
+		$item['name'] = "$username_white " . _MD_CHESS_LABEL_VS . " $username_black ($date)";
 
-        $item['url'] = XOOPS_URL . '/modules/chess/game.php?game_id=' . $item_id;
+		$item['url'] = XOOPS_URL . '/modules/chess/game.php?game_id=' . $item_id;
 
-        return $item;
-    }
+		return $item;
+	}
 }

include/install.php

Indentation +141 added lines, -141 removed lines

@@ -50,105 +50,105 @@ 
  */
 function xoops_module_pre_update_chess($module, $oldversion)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    // For downward-compatiblity, in case this function doesn't get called by the module handler.
+	// For downward-compatiblity, in case this function doesn't get called by the module handler.
 
-    $GLOBALS['chess_module_pre_update_called'] = true;
+	$GLOBALS['chess_module_pre_update_called'] = true;
 
-    if ($oldversion < 102) { // old version < 1.02: direct update not supported.
-        $docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
+	if ($oldversion < 102) { // old version < 1.02: direct update not supported.
+		$docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
 
-        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
+		chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
 
-        return false;
-    } elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
-        return true;
-    }
+		return false;
+	} elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
+		return true;
+	}
 
-    // 1.02 <= old version < 1.07: perform update.
+	// 1.02 <= old version < 1.07: perform update.
 
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    $challenges_table = $xoopsDB->prefix('chess_challenges');
+	$challenges_table = $xoopsDB->prefix('chess_challenges');
 
-    $games_table = $xoopsDB->prefix('chess_games');
+	$games_table = $xoopsDB->prefix('chess_games');
 
-    // Check that ratings table does not already exist.
+	// Check that ratings table does not already exist.
 
-    chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_1, $ratings_table));
+	chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_1, $ratings_table));
 
-    $result = $xoopsDB->query("SHOW TABLES LIKE '$ratings_table'");
+	$result = $xoopsDB->query("SHOW TABLES LIKE '$ratings_table'");
 
-    if (!$result) {
-        $mysql_errno = $xoopsDB->errno();
+	if (!$result) {
+		$mysql_errno = $xoopsDB->errno();
 
-        $mysql_error = $xoopsDB->error();
+		$mysql_error = $xoopsDB->error();
 
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
+		chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
 
-        return false;
-    }
+		return false;
+	}
 
-    if ($xoopsDB->getRowsNum($result) > 0) {
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_3, $ratings_table), true);
+	if ($xoopsDB->getRowsNum($result) > 0) {
+		chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_3, $ratings_table), true);
 
-        return false;
-    }
+		return false;
+	}
 
-    $xoopsDB->freeRecordSet($result);
+	$xoopsDB->freeRecordSet($result);
 
-    chess_set_message($module, _MI_CHESS_OK);
+	chess_set_message($module, _MI_CHESS_OK);
 
-    // Check database tables.
+	// Check database tables.
 
-    chess_set_message($module, _MI_CHESS_CHK_DB_TABLES);
+	chess_set_message($module, _MI_CHESS_CHK_DB_TABLES);
 
-    $table_check_messages = chess_check_tables([$challenges_table, $games_table]);
+	$table_check_messages = chess_check_tables([$challenges_table, $games_table]);
 
-    if (!empty($table_check_messages)) {
-        foreach ($table_check_messages as $message) {
-            chess_set_message($module, $message, true);
-        }
+	if (!empty($table_check_messages)) {
+		foreach ($table_check_messages as $message) {
+			chess_set_message($module, $message, true);
+		}
 
-        return false;
-    }
+		return false;
+	}
 
-    chess_set_message($module, _MI_CHESS_OK);
+	chess_set_message($module, _MI_CHESS_OK);
 
-    // Check that values in column pgn_result of games table are in range.
+	// Check that values in column pgn_result of games table are in range.
 
-    $pgn_result_values = "'*','1-0','0-1','1/2-1/2'";
+	$pgn_result_values = "'*','1-0','0-1','1/2-1/2'";
 
-    chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_1, $games_table));
+	chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_1, $games_table));
 
-    $result = $xoopsDB->query("SELECT COUNT(*) FROM `$games_table` WHERE `pgn_result` NOT IN ($pgn_result_values)");
+	$result = $xoopsDB->query("SELECT COUNT(*) FROM `$games_table` WHERE `pgn_result` NOT IN ($pgn_result_values)");
 
-    if (!$result) {
-        $mysql_errno = $xoopsDB->errno();
+	if (!$result) {
+		$mysql_errno = $xoopsDB->errno();
 
-        $mysql_error = $xoopsDB->error();
+		$mysql_error = $xoopsDB->error();
 
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
+		chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
 
-        return false;
-    }
+		return false;
+	}
 
-    [$count] = $xoopsDB->fetchRow($result);
+	[$count] = $xoopsDB->fetchRow($result);
 
-    if ($count > 0) {
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_3, 'pgn_result', $games_table, $pgn_result_values), true);
+	if ($count > 0) {
+		chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_3, 'pgn_result', $games_table, $pgn_result_values), true);
 
-        chess_set_message($module, _MI_CHESS_GAMES_TABLE_4, true);
+		chess_set_message($module, _MI_CHESS_GAMES_TABLE_4, true);
 
-        return false;
-    }
+		return false;
+	}
 
-    $xoopsDB->freeRecordSet($result);
+	$xoopsDB->freeRecordSet($result);
 
-    chess_set_message($module, _MI_CHESS_OK);
+	chess_set_message($module, _MI_CHESS_OK);
 
-    return true; // successful
+	return true; // successful
 }
 
 /**
@@ -160,28 +160,28 @@ 
  */
 function xoops_module_update_chess($module, $oldversion)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    // Before proceeding, ensure that pre-update processing has been done, and that all the checks pass.
+	// Before proceeding, ensure that pre-update processing has been done, and that all the checks pass.
 
-    // For downward-compatiblity, in case the "pre_update" function doesn't get called by the module handler.
+	// For downward-compatiblity, in case the "pre_update" function doesn't get called by the module handler.
 
-    if (!@$GLOBALS['chess_module_pre_update_called'] && !xoops_module_pre_update_chess($module, $oldversion)) {
-        return false;
-    }
+	if (!@$GLOBALS['chess_module_pre_update_called'] && !xoops_module_pre_update_chess($module, $oldversion)) {
+		return false;
+	}
 
-    if ($oldversion >= 107) { // old version >= 1.07:  no action needed.
-        return true;
-    }
+	if ($oldversion >= 107) { // old version >= 1.07:  no action needed.
+		return true;
+	}
 
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    $challenges_table = $xoopsDB->prefix('chess_challenges');
+	$challenges_table = $xoopsDB->prefix('chess_challenges');
 
-    $games_table = $xoopsDB->prefix('chess_games');
+	$games_table = $xoopsDB->prefix('chess_games');
 
-    $queries = [
-        "CREATE TABLE `$ratings_table` (
+	$queries = [
+		"CREATE TABLE `$ratings_table` (
 			`player_uid` mediumint(8) unsigned NOT NULL default '0',
 			`rating` smallint(6) unsigned NOT NULL default '1200',
 			`games_won` smallint(6) unsigned NOT NULL default '0',
@@ -192,48 +192,48 @@ 
 			KEY `games` (`games_won`,`games_lost`,`games_drawn`)
 			) ENGINE=MyISAM",
 
-        "ALTER TABLE `$challenges_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
-        "ALTER TABLE `$challenges_table` ADD INDEX `game_type` (`game_type`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `player1_uid` (`player1_uid`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `player2_uid` (`player2_uid`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `create_date` (`create_date`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `is_rated` (`is_rated`)",
+		"ALTER TABLE `$challenges_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
+		"ALTER TABLE `$challenges_table` ADD INDEX `game_type` (`game_type`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `player1_uid` (`player1_uid`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `player2_uid` (`player2_uid`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `create_date` (`create_date`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `is_rated` (`is_rated`)",
 
-        "ALTER TABLE `$games_table` CHANGE `pgn_result` `pgn_result` ENUM('*','0-1','1-0','1/2-1/2') DEFAULT '*' NOT NULL",
-        "ALTER TABLE `$games_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
-        "ALTER TABLE `$games_table` ADD INDEX `white_uid` (`white_uid`)",
-        "ALTER TABLE `$games_table` ADD INDEX `black_uid` (`black_uid`)",
-        "ALTER TABLE `$games_table` ADD INDEX `date` (`create_date`,`start_date`,`last_date`)",
-        "ALTER TABLE `$games_table` ADD INDEX `pgn_result` (`pgn_result`)",
-        "ALTER TABLE `$games_table` ADD INDEX `suspended_date` (`suspended`(19))",
-        "ALTER TABLE `$games_table` ADD INDEX `is_rated` (`is_rated`)",
+		"ALTER TABLE `$games_table` CHANGE `pgn_result` `pgn_result` ENUM('*','0-1','1-0','1/2-1/2') DEFAULT '*' NOT NULL",
+		"ALTER TABLE `$games_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
+		"ALTER TABLE `$games_table` ADD INDEX `white_uid` (`white_uid`)",
+		"ALTER TABLE `$games_table` ADD INDEX `black_uid` (`black_uid`)",
+		"ALTER TABLE `$games_table` ADD INDEX `date` (`create_date`,`start_date`,`last_date`)",
+		"ALTER TABLE `$games_table` ADD INDEX `pgn_result` (`pgn_result`)",
+		"ALTER TABLE `$games_table` ADD INDEX `suspended_date` (`suspended`(19))",
+		"ALTER TABLE `$games_table` ADD INDEX `is_rated` (`is_rated`)",
 
-        "UPDATE `$games_table` SET `is_rated` = '0' WHERE `white_uid` = `black_uid`",
-    ];
+		"UPDATE `$games_table` SET `is_rated` = '0' WHERE `white_uid` = `black_uid`",
+	];
 
-    // Update database tables.
+	// Update database tables.
 
-    chess_set_message($module, _MI_CHESS_UPDATING_DATABASE);
+	chess_set_message($module, _MI_CHESS_UPDATING_DATABASE);
 
-    foreach ($queries as $query) {
-        chess_set_message($module, "> $query");
+	foreach ($queries as $query) {
+		chess_set_message($module, "> $query");
 
-        $result = $xoopsDB->query($query);
+		$result = $xoopsDB->query($query);
 
-        if (!$result) {
-            $mysql_errno = $xoopsDB->errno();
+		if (!$result) {
+			$mysql_errno = $xoopsDB->errno();
 
-            $mysql_error = $xoopsDB->error();
+			$mysql_error = $xoopsDB->error();
 
-            chess_set_message($module, " ... ($mysql_errno) $mysql_error");
+			chess_set_message($module, " ... ($mysql_errno) $mysql_error");
 
-            return false;
-        }
+			return false;
+		}
 
-        chess_set_message($module, _MI_CHESS_OK);
-    }
+		chess_set_message($module, _MI_CHESS_OK);
+	}
 
-    /***
+	/***
      * #*#TODO# - Leave this here for now, in case I think of a way to get it to work.
      * # This causes an error about the rating_system module configuration parameter not being defined,
      * # so I added a note in INSTALL.TXT about manually recalculating the ratings after install.
@@ -244,9 +244,9 @@ 
      * chess_recalc_ratings();
      ***/
 
-    chess_set_message($module, _MI_CHESS_UPDATE_SUCCESSFUL);
+	chess_set_message($module, _MI_CHESS_UPDATE_SUCCESSFUL);
 
-    return true; // successful
+	return true; // successful
 }
 
 /**
@@ -257,45 +257,45 @@ 
  */
 function chess_check_tables($table_names)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $messages = [];
+	$messages = [];
 
-    foreach ($table_names as $table_name) {
-        $query = "CHECK TABLE `$table_name`";
+	foreach ($table_names as $table_name) {
+		$query = "CHECK TABLE `$table_name`";
 
-        $result = $xoopsDB->query($query);
+		$result = $xoopsDB->query($query);
 
-        if (!$result) {
-            $mysql_errno = $xoopsDB->errno();
+		if (!$result) {
+			$mysql_errno = $xoopsDB->errno();
 
-            $mysql_error = $xoopsDB->error();
+			$mysql_error = $xoopsDB->error();
 
-            $messages[] = $query;
+			$messages[] = $query;
 
-            $messages[] = " ... ($mysql_errno) $mysql_error";
+			$messages[] = " ... ($mysql_errno) $mysql_error";
 
-            continue;
-        }
+			continue;
+		}
 
-        // Initialize, in case the real table status fails to get retrieved.
+		// Initialize, in case the real table status fails to get retrieved.
 
-        $table_status = '*** STATUS UNKNOWN ***';
+		$table_status = '*** STATUS UNKNOWN ***';
 
-        // The query may return multiple rows.  Only the last row is normally of interest, so only that row is saved.
+		// The query may return multiple rows.  Only the last row is normally of interest, so only that row is saved.
 
-        while (false !== ($row = $xoopsDB->fetchArray($result))) {
-            $table_status = $row['Msg_text'];
-        }
+		while (false !== ($row = $xoopsDB->fetchArray($result))) {
+			$table_status = $row['Msg_text'];
+		}
 
-        $xoopsDB->freeRecordSet($result);
+		$xoopsDB->freeRecordSet($result);
 
-        if ('OK' != $table_status) {
-            $messages[] = " ... $table_name: $table_status";
-        }
-    }
+		if ('OK' != $table_status) {
+			$messages[] = " ... $table_name: $table_status";
+		}
+	}
 
-    return $messages;
+	return $messages;
 }
 
 /**
@@ -310,15 +310,15 @@ 
  */
 function chess_load_lang_file($filename, $module = '', $default = 'english')
 {
-    $lang = $GLOBALS['xoopsConfig']['language'];
+	$lang = $GLOBALS['xoopsConfig']['language'];
 
-    $path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
+	$path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
 
-    if (!($ret = @include_once("$path/$lang/$filename.php"))) {
-        $ret = include_once("$path/$default/$filename.php");
-    }
+	if (!($ret = @include_once("$path/$lang/$filename.php"))) {
+		$ret = include_once("$path/$default/$filename.php");
+	}
 
-    return $ret;
+	return $ret;
 }
 
 /**
@@ -330,13 +330,13 @@ 
  */
 function chess_set_message($module, $text = '', $error = false)
 {
-    $text = $error ? "<span style='color:#ff0000;background-color:#ffffff;font-weight:bold;'>$text</span>" : $text;
+	$text = $error ? "<span style='color:#ff0000;background-color:#ffffff;font-weight:bold;'>$text</span>" : $text;
 
-    // For downward compatibility with XOOPS versions that don't have the method XoopsModule::setMessage.
+	// For downward compatibility with XOOPS versions that don't have the method XoopsModule::setMessage.
 
-    if (is_object($module) && method_exists($module, 'setMessage')) {
-        $module->setMessage($text);
-    } else {
-        echo "<code>$text</code><br>\n";
-    }
+	if (is_object($module) && method_exists($module, 'setMessage')) {
+		$module->setMessage($text);
+	} else {
+		echo "<code>$text</code><br>\n";
+	}
 }

Spacing +5 added lines, -5 removed lines

@@ -57,9 +57,9 @@ 
     $GLOBALS['chess_module_pre_update_called'] = true;
 
     if ($oldversion < 102) { // old version < 1.02: direct update not supported.
-        $docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
+        $docfile = XOOPS_ROOT_PATH.'/modules/chess/docs/INSTALL.TXT';
 
-        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
+        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string) $oldversion, $docfile), true);
 
         return false;
     } elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
@@ -85,7 +85,7 @@ 
 
         $mysql_error = $xoopsDB->error();
 
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
+        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string) $mysql_errno, $mysql_error), true);
 
         return false;
     }
@@ -129,7 +129,7 @@ 
 
         $mysql_error = $xoopsDB->error();
 
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
+        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string) $mysql_errno, $mysql_error), true);
 
         return false;
     }
@@ -312,7 +312,7 @@ 
 {
     $lang = $GLOBALS['xoopsConfig']['language'];
 
-    $path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
+    $path = XOOPS_ROOT_PATH.(empty($module) ? '/' : "/modules/$module/").'language';
 
     if (!($ret = @include_once("$path/$lang/$filename.php"))) {
         $ret = include_once("$path/$default/$filename.php");

include/ratings_linear.inc.php

Indentation +15 added lines, -15 removed lines

@@ -41,21 +41,21 @@ 
  */
 function chess_ratings_adj_linear($white_rating, $white_games, $black_rating, $black_games, $pgn_result)
 {
-    // compute score: +1 for win, 0 for draw, -1 for loss
-    switch ($pgn_result) {
-        case '1-0':
-            $S = 1;
-            break;
-        case '1/2-1/2':
-        default: // should not occur
-            $S = 0;
-            break;
-        case '0-1':
-            $S = -1;
-            break;
-    }
+	// compute score: +1 for win, 0 for draw, -1 for loss
+	switch ($pgn_result) {
+		case '1-0':
+			$S = 1;
+			break;
+		case '1/2-1/2':
+		default: // should not occur
+			$S = 0;
+			break;
+		case '0-1':
+			$S = -1;
+			break;
+	}
 
-    return [$white_rating + $S * 10, $black_rating - $S * 10];
+	return [$white_rating + $S * 10, $black_rating - $S * 10];
 }
 
 /**
@@ -65,7 +65,7 @@ 
  */
 function chess_ratings_num_provisional_games_linear()
 {
-    return 2;
+	return 2;
 }
 
 ?>

include/ratings_linear.php

Indentation +15 added lines, -15 removed lines

@@ -47,22 +47,22 @@ 
  */
 function chess_ratings_adj_linear($white_rating, $white_games, $black_rating, $black_games, $pgn_result)
 {
-    // compute score: +1 for win, 0 for draw, -1 for loss
+	// compute score: +1 for win, 0 for draw, -1 for loss
 
-    switch ($pgn_result) {
-        case '1-0':
-            $S = 1;
-            break;
-        case '1/2-1/2':
-        default: // should not occur
-            $S = 0;
-            break;
-        case '0-1':
-            $S = -1;
-            break;
-    }
+	switch ($pgn_result) {
+		case '1-0':
+			$S = 1;
+			break;
+		case '1/2-1/2':
+		default: // should not occur
+			$S = 0;
+			break;
+		case '0-1':
+			$S = -1;
+			break;
+	}
 
-    return [$white_rating + $S * 10, $black_rating - $S * 10];
+	return [$white_rating + $S * 10, $black_rating - $S * 10];
 }
 
 /**
@@ -72,5 +72,5 @@ 
  */
 function chess_ratings_num_provisional_games_linear()
 {
-    return 2;
+	return 2;
 }

include/ratings_cxr.inc.php

Indentation +60 added lines, -60 removed lines

@@ -44,72 +44,72 @@ 
  */
 function chess_ratings_adj_cxr($white_rating, $white_games, $black_rating, $black_games, $pgn_result)
 {
-    // compute score: +1 for win, 0 for draw, -1 for loss
-    switch ($pgn_result) {
-        case '1-0':
-            $S = 1;
-            break;
-        case '1/2-1/2':
-        default: // should not occur
-            $S = 0;
-            break;
-        case '0-1':
-            $S = -1;
-            break;
-    }
+	// compute score: +1 for win, 0 for draw, -1 for loss
+	switch ($pgn_result) {
+		case '1-0':
+			$S = 1;
+			break;
+		case '1/2-1/2':
+		default: // should not occur
+			$S = 0;
+			break;
+		case '0-1':
+			$S = -1;
+			break;
+	}
 
-    if (($white_games < 5 and $black_games < 5) or ($white_games > 5 and $black_games > 5)) {
-        // Formula 1: Rnew = Rold + (S x 21) + (Ropponent - Rold) / 25
-        $w_new = ($S * 21) + ($black_rating - $white_rating) / 25;
-        $b_new = (-$S * 21) + ($white_rating - $black_rating) / 25;
-    } elseif ($white_games > 5 and $black_games < 5) {
-        // Formula 2: Rnew = Rold + (S x 6) + (Ropponent - Rold) / 100
-        $w_new = ($S * 6) + ($black_rating - $white_rating) / 100;
+	if (($white_games < 5 and $black_games < 5) or ($white_games > 5 and $black_games > 5)) {
+		// Formula 1: Rnew = Rold + (S x 21) + (Ropponent - Rold) / 25
+		$w_new = ($S * 21) + ($black_rating - $white_rating) / 25;
+		$b_new = (-$S * 21) + ($white_rating - $black_rating) / 25;
+	} elseif ($white_games > 5 and $black_games < 5) {
+		// Formula 2: Rnew = Rold + (S x 6) + (Ropponent - Rold) / 100
+		$w_new = ($S * 6) + ($black_rating - $white_rating) / 100;
 
-        // Formula 3: Rnew = (4/5) x Rold + (1/5) x Ropponent + (S x 80)
-        $b_new = ($white_rating / 5) + ($S * -80) - ($black_rating / 5);
-    } else {
-        // Formula 2: Rnew = Rold + (S x 6) + (Ropponent - Rold) / 100
-        $b_new = ($S * 6) + ($white_rating - $black_rating) / 100;
+		// Formula 3: Rnew = (4/5) x Rold + (1/5) x Ropponent + (S x 80)
+		$b_new = ($white_rating / 5) + ($S * -80) - ($black_rating / 5);
+	} else {
+		// Formula 2: Rnew = Rold + (S x 6) + (Ropponent - Rold) / 100
+		$b_new = ($S * 6) + ($white_rating - $black_rating) / 100;
 
-        // Formula 3: Rnew = (4/5) x Rold + (1/5) x Ropponent + (S x 80)
-        $w_new = ($black_rating / 5) + ($S * -80) - ($white_rating / 5);
-    }
+		// Formula 3: Rnew = (4/5) x Rold + (1/5) x Ropponent + (S x 80)
+		$w_new = ($black_rating / 5) + ($S * -80) - ($white_rating / 5);
+	}
 
-    // Rule R1: The winning rated player must gain at least two points.
-    // Rule R2: The losing rated player must lose at least two points.
-    if (abs($w_new) < 2) {
-        $w_new = $S * 2;
-    }
-    if (abs($b_new) < 2) {
-        $b_new = $S * -2;
-    }
+	// Rule R1: The winning rated player must gain at least two points.
+	// Rule R2: The losing rated player must lose at least two points.
+	if (abs($w_new) < 2) {
+		$w_new = $S * 2;
+	}
+	if (abs($b_new) < 2) {
+		$b_new = $S * -2;
+	}
 
-    // Rule R3: The rated player must not gain nor lose more than 41 points.
-    if (abs($w_new) > 41) {
-        $w_new = $S * 41;
-    }
-    if (abs($b_new) > 41) {
-        $b_new = $S * -41;
-    }
+	// Rule R3: The rated player must not gain nor lose more than 41 points.
+	if (abs($w_new) > 41) {
+		$w_new = $S * 41;
+	}
+	if (abs($b_new) > 41) {
+		$b_new = $S * -41;
+	}
 
-    if (1 == $S) {
-        if ($white_games < 5 and $w_new < 0) {
-            $w_new = 2;
-        }
-        if ($black_games < 5 and $b_new > 0) {
-            $b_new = -2;
-        }
-    } elseif (-1 == $S) {
-        if ($white_games < 5 and $w_new > 0) {
-            $w_new = -2;
-        }
-        if ($black_games < 5 and $b_new < 0) {
-            $b_new = 2;
-        }
-    }
+	if (1 == $S) {
+		if ($white_games < 5 and $w_new < 0) {
+			$w_new = 2;
+		}
+		if ($black_games < 5 and $b_new > 0) {
+			$b_new = -2;
+		}
+	} elseif (-1 == $S) {
+		if ($white_games < 5 and $w_new > 0) {
+			$w_new = -2;
+		}
+		if ($black_games < 5 and $b_new < 0) {
+			$b_new = 2;
+		}
+	}
 
-    return [$white_rating + $w_new, $black_rating + $b_new];
+	return [$white_rating + $w_new, $black_rating + $b_new];
 }
 
 /**
@@ -119,7 +119,7 @@ 
  */
 function chess_ratings_num_provisional_games_cxr()
 {
-    return 5;
+	return 5;
 }
 
 ?>

include/ratings.php

Indentation +139 added lines, -139 removed lines

@@ -41,28 +41,28 @@ 
  */
 function chess_ratings_adj($gid)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $rating_system = chess_moduleConfig('rating_system');
+	$rating_system = chess_moduleConfig('rating_system');
 
-    $init_rating = chess_moduleConfig('initial_rating');
+	$init_rating = chess_moduleConfig('initial_rating');
 
-    if ('none' == $rating_system) {
-        return false;
-    }
+	if ('none' == $rating_system) {
+		return false;
+	}
 
-    // determine function for calculating new ratings using configured rating system
+	// determine function for calculating new ratings using configured rating system
 
-    $func = chess_ratings_get_func_adj($rating_system);
+	$func = chess_ratings_get_func_adj($rating_system);
 
-    $games_table = $xoopsDB->prefix('chess_games');
+	$games_table = $xoopsDB->prefix('chess_games');
 
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    // get the game info
+	// get the game info
 
-    $result = $xoopsDB->query(
-        "
+	$result = $xoopsDB->query(
+		"
 		SELECT
 			g.white_uid AS white_uid, g.black_uid AS black_uid, g.pgn_result AS pgn_result, w.rating AS white_rating, b.rating AS black_rating,
 			(w.games_won+w.games_lost+w.games_drawn) AS white_games, (b.games_won+b.games_lost+b.games_drawn) AS black_games
@@ -72,77 +72,77 @@ 
 		WHERE     g.game_id = '$gid' AND g.is_rated = '1' AND g.pgn_result != '*'
 			AND (w.player_uid IS NULL OR b.player_uid IS NULL OR w.player_uid != b.player_uid)
 	"
-    );
+	);
 
-    // check that game exists and is rated
+	// check that game exists and is rated
 
-    if (1 != $xoopsDB->getRowsNum($result)) {
-        return false;
-    }
+	if (1 != $xoopsDB->getRowsNum($result)) {
+		return false;
+	}
 
-    $row = $xoopsDB->fetchArray($result);
+	$row = $xoopsDB->fetchArray($result);
 
-    $xoopsDB->freeRecordSet($result);
+	$xoopsDB->freeRecordSet($result);
 
-    #var_dump($row);#*#DEBUG#
+	#var_dump($row);#*#DEBUG#
 
-    // make sure the users are in the players' table
+	// make sure the users are in the players' table
 
-    $value_list = [];
+	$value_list = [];
 
-    if (!isset($row['white_rating'])) {
-        $row['white_rating'] = $init_rating;
+	if (!isset($row['white_rating'])) {
+		$row['white_rating'] = $init_rating;
 
-        $row['white_games'] = 0;
+		$row['white_games'] = 0;
 
-        $value_list[] = "('{$row['white_uid']}','{$row['white_rating']}')";
-    }
+		$value_list[] = "('{$row['white_uid']}','{$row['white_rating']}')";
+	}
 
-    if (!isset($row['black_rating'])) {
-        $row['black_rating'] = $init_rating;
+	if (!isset($row['black_rating'])) {
+		$row['black_rating'] = $init_rating;
 
-        $row['black_games'] = 0;
+		$row['black_games'] = 0;
 
-        $value_list[] = "('{$row['black_uid']}','{$row['black_rating']}')";
-    }
+		$value_list[] = "('{$row['black_uid']}','{$row['black_rating']}')";
+	}
 
-    if (!empty($value_list)) {
-        $values = implode(',', $value_list);
+	if (!empty($value_list)) {
+		$values = implode(',', $value_list);
 
-        $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
+		$xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
 
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
-    }
+		$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	}
 
-    // calculate new ratings using configured rating system
+	// calculate new ratings using configured rating system
 
-    [$white_rating_new, $black_rating_new] = $func($row['white_rating'], $row['white_games'], $row['black_rating'], $row['black_games'], $row['pgn_result']);
+	[$white_rating_new, $black_rating_new] = $func($row['white_rating'], $row['white_games'], $row['black_rating'], $row['black_games'], $row['pgn_result']);
 
-    // determine game-count columns to increment
+	// determine game-count columns to increment
 
-    [$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
+	[$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
 
-    $xoopsDB->query(
-        "
+	$xoopsDB->query(
+		"
 		UPDATE $ratings_table
 		SET    rating = '$white_rating_new', $white_col = $white_col + 1
 		WHERE  player_uid = '{$row['white_uid']}'
 	"
-    );
+	);
 
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
 
-    $xoopsDB->query(
-        "
+	$xoopsDB->query(
+		"
 		UPDATE $ratings_table
 		SET    rating = '$black_rating_new', $black_col = $black_col + 1
 		WHERE  player_uid = '{$row['black_uid']}'
 	"
-    );
+	);
 
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
 
-    return true;
+	return true;
 }
 
 /**
@@ -152,98 +152,98 @@ 
  */
 function chess_recalc_ratings()
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $rating_system = chess_moduleConfig('rating_system');
+	$rating_system = chess_moduleConfig('rating_system');
 
-    $init_rating = chess_moduleConfig('initial_rating');
+	$init_rating = chess_moduleConfig('initial_rating');
 
-    if ('none' == $rating_system) {
-        return false;
-    }
+	if ('none' == $rating_system) {
+		return false;
+	}
 
-    // determine function for calculating new ratings using configured rating system
+	// determine function for calculating new ratings using configured rating system
 
-    $func = chess_ratings_get_func_adj($rating_system);
+	$func = chess_ratings_get_func_adj($rating_system);
 
-    $games_table = $xoopsDB->prefix('chess_games');
+	$games_table = $xoopsDB->prefix('chess_games');
 
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    // Nuke the current ratings.  #*#TBD# - don't want to empty this table, since there will be other info in it besides ratings (?)
+	// Nuke the current ratings.  #*#TBD# - don't want to empty this table, since there will be other info in it besides ratings (?)
 
-    $xoopsDB->query("DELETE FROM $ratings_table");
+	$xoopsDB->query("DELETE FROM $ratings_table");
 
-    // get all games
+	// get all games
 
-    $result = $xoopsDB->query(
-        "
+	$result = $xoopsDB->query(
+		"
 		SELECT    white_uid, black_uid, pgn_result
 		FROM      $games_table
 		WHERE     is_rated = '1' AND pgn_result != '*' AND white_uid != black_uid
 		ORDER BY  last_date ASC
 	"
-    );
+	);
 
-    $players = [];
+	$players = [];
 
-    // process the games
+	// process the games
 
-    while (false !== ($row = $xoopsDB->fetchArray($result))) {
-        #var_dump($row);#*#DEBUG#
+	while (false !== ($row = $xoopsDB->fetchArray($result))) {
+		#var_dump($row);#*#DEBUG#
 
-        if (!isset($players[$row['white_uid']])) {
-            $players[$row['white_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
-        }
+		if (!isset($players[$row['white_uid']])) {
+			$players[$row['white_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
+		}
 
-        if (!isset($players[$row['black_uid']])) {
-            $players[$row['black_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
-        }
+		if (!isset($players[$row['black_uid']])) {
+			$players[$row['black_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
+		}
 
-        $player_white = &$players[$row['white_uid']];
+		$player_white = &$players[$row['white_uid']];
 
-        $player_black = &$players[$row['black_uid']];
+		$player_black = &$players[$row['black_uid']];
 
-        // calculate new ratings using configured rating system
+		// calculate new ratings using configured rating system
 
-        [$white_rating_new, $black_rating_new] = $func(
-            $player_white['rating'],
-            $player_white['games_won'] + $player_white['games_lost'] + $player_white['games_drawn'],
-            $player_black['rating'],
-            $player_black['games_won'] + $player_black['games_lost'] + $player_black['games_drawn'],
-            $row['pgn_result']
-        );
+		[$white_rating_new, $black_rating_new] = $func(
+			$player_white['rating'],
+			$player_white['games_won'] + $player_white['games_lost'] + $player_white['games_drawn'],
+			$player_black['rating'],
+			$player_black['games_won'] + $player_black['games_lost'] + $player_black['games_drawn'],
+			$row['pgn_result']
+		);
 
-        // determine game-count columns to increment
+		// determine game-count columns to increment
 
-        [$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
+		[$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
 
-        $player_white['rating'] = $white_rating_new;
+		$player_white['rating'] = $white_rating_new;
 
-        ++$player_white[$white_col];
+		++$player_white[$white_col];
 
-        $player_black['rating'] = $black_rating_new;
+		$player_black['rating'] = $black_rating_new;
 
-        ++$player_black[$black_col];
-    }
+		++$player_black[$black_col];
+	}
 
-    $xoopsDB->freeRecordSet($result);
+	$xoopsDB->freeRecordSet($result);
 
-    if (!empty($players)) {
-        $value_list = [];
+	if (!empty($players)) {
+		$value_list = [];
 
-        foreach ($players as $player_uid => $player) {
-            $value_list[] = "('$player_uid', '{$player['rating']}', '{$player['games_won']}', '{$player['games_lost']}', '{$player['games_drawn']}')";
-        }
+		foreach ($players as $player_uid => $player) {
+			$value_list[] = "('$player_uid', '{$player['rating']}', '{$player['games_won']}', '{$player['games_lost']}', '{$player['games_drawn']}')";
+		}
 
-        $values = implode(',', $value_list);
+		$values = implode(',', $value_list);
 
-        $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
+		$xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
 
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
-    }
+		$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	}
 
-    return true;
+	return true;
 }
 
 /**
@@ -253,25 +253,25 @@ 
  */
 function chess_ratings_num_provisional_games()
 {
-    $rating_system = chess_moduleConfig('rating_system');
+	$rating_system = chess_moduleConfig('rating_system');
 
-    if ('none' == $rating_system) {
-        return 0;
-    }
+	if ('none' == $rating_system) {
+		return 0;
+	}
 
-    // determine function for getting number of provisional games using configured rating system
+	// determine function for getting number of provisional games using configured rating system
 
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
+	$file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
 
-    file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
+	file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
 
-    require_once $file;
+	require_once $file;
 
-    $func = "chess_ratings_num_provisional_games_{$rating_system}";
+	$func = "chess_ratings_num_provisional_games_{$rating_system}";
 
-    function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
+	function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
 
-    return $func();
+	return $func();
 }
 
 /**
@@ -282,17 +282,17 @@ 
  */
 function chess_ratings_get_func_adj($rating_system)
 {
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
+	$file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
 
-    file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
+	file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
 
-    require_once $file;
+	require_once $file;
 
-    $func = "chess_ratings_adj_{$rating_system}";
+	$func = "chess_ratings_adj_{$rating_system}";
 
-    function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
+	function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
 
-    return $func;
+	return $func;
 }
 
 /**
@@ -307,21 +307,21 @@ 
  */
 function chess_ratings_get_columns($pgn_result)
 {
-    switch ($pgn_result) {
-        case '1-0':
-            $white_col = 'games_won';
-            $black_col = 'games_lost';
-            break;
-        case '1/2-1/2':
-        default: // should not occur
-            $white_col = 'games_drawn';
-            $black_col = 'games_drawn';
-            break;
-        case '0-1':
-            $white_col = 'games_lost';
-            $black_col = 'games_won';
-            break;
-    }
-
-    return [$white_col, $black_col];
+	switch ($pgn_result) {
+		case '1-0':
+			$white_col = 'games_won';
+			$black_col = 'games_lost';
+			break;
+		case '1/2-1/2':
+		default: // should not occur
+			$white_col = 'games_drawn';
+			$black_col = 'games_drawn';
+			break;
+		case '0-1':
+			$white_col = 'games_lost';
+			$black_col = 'games_won';
+			break;
+	}
+
+	return [$white_col, $black_col];
 }

Spacing +7 added lines, -7 removed lines

@@ -30,7 +30,7 @@ 
 
 /**#@+
  */
-require_once XOOPS_ROOT_PATH . '/modules/chess/include/functions.php';
+require_once XOOPS_ROOT_PATH.'/modules/chess/include/functions.php';
 /**#@-*/
 
 /**
@@ -111,7 +111,7 @@ 
 
         $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
 
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+        $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
     }
 
     // calculate new ratings using configured rating system
@@ -130,7 +130,7 @@ 
 	"
     );
 
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+    $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
 
     $xoopsDB->query(
         "
@@ -140,7 +140,7 @@ 
 	"
     );
 
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+    $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
 
     return true;
 }
@@ -240,7 +240,7 @@ 
 
         $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
 
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+        $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
     }
 
     return true;
@@ -261,7 +261,7 @@ 
 
     // determine function for getting number of provisional games using configured rating system
 
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
+    $file = XOOPS_ROOT_PATH."/modules/chess/include/ratings_{$rating_system}.php";
 
     file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
 
@@ -282,7 +282,7 @@ 
  */
 function chess_ratings_get_func_adj($rating_system)
 {
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.php";
+    $file = XOOPS_ROOT_PATH."/modules/chess/include/ratings_{$rating_system}.php";
 
     file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
 

include/ratings.inc.php

Indentation +156 added lines, -156 removed lines

@@ -40,24 +40,24 @@ 
  */
 function chess_ratings_adj($gid)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $rating_system = chess_moduleConfig('rating_system');
-    $init_rating   = chess_moduleConfig('initial_rating');
+	$rating_system = chess_moduleConfig('rating_system');
+	$init_rating   = chess_moduleConfig('initial_rating');
 
-    if ('none' == $rating_system) {
-        return false;
-    }
+	if ('none' == $rating_system) {
+		return false;
+	}
 
-    // determine function for calculating new ratings using configured rating system
-    $func = chess_ratings_get_func_adj($rating_system);
+	// determine function for calculating new ratings using configured rating system
+	$func = chess_ratings_get_func_adj($rating_system);
 
-    $games_table   = $xoopsDB->prefix('chess_games');
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$games_table   = $xoopsDB->prefix('chess_games');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    // get the game info
-    $result = $xoopsDB->query(
-        "
+	// get the game info
+	$result = $xoopsDB->query(
+		"
 		SELECT
 			g.white_uid AS white_uid, g.black_uid AS black_uid, g.pgn_result AS pgn_result, w.rating AS white_rating, b.rating AS black_rating,
 			(w.games_won+w.games_lost+w.games_drawn) AS white_games, (b.games_won+b.games_lost+b.games_drawn) AS black_games
@@ -67,60 +67,60 @@ 
 		WHERE     g.game_id = '$gid' AND g.is_rated = '1' AND g.pgn_result != '*'
 			AND (w.player_uid IS NULL OR b.player_uid IS NULL OR w.player_uid != b.player_uid)
 	"
-    );
-
-    // check that game exists and is rated
-    if (1 != $xoopsDB->getRowsNum($result)) {
-        return false;
-    }
-
-    $row = $xoopsDB->fetchArray($result);
-    $xoopsDB->freeRecordSet($result);
-
-    #var_dump($row);#*#DEBUG#
-    // make sure the users are in the players' table
-    $value_list = [];
-    if (!isset($row['white_rating'])) {
-        $row['white_rating'] = $init_rating;
-        $row['white_games']  = 0;
-        $value_list[]        = "('{$row['white_uid']}','{$row['white_rating']}')";
-    }
-    if (!isset($row['black_rating'])) {
-        $row['black_rating'] = $init_rating;
-        $row['black_games']  = 0;
-        $value_list[]        = "('{$row['black_uid']}','{$row['black_rating']}')";
-    }
-    if (!empty($value_list)) {
-        $values = implode(',', $value_list);
-        $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
-    }
-
-    // calculate new ratings using configured rating system
-    [$white_rating_new, $black_rating_new] = $func($row['white_rating'], $row['white_games'], $row['black_rating'], $row['black_games'], $row['pgn_result']);
-
-    // determine game-count columns to increment
-    [$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
-
-    $xoopsDB->query(
-        "
+	);
+
+	// check that game exists and is rated
+	if (1 != $xoopsDB->getRowsNum($result)) {
+		return false;
+	}
+
+	$row = $xoopsDB->fetchArray($result);
+	$xoopsDB->freeRecordSet($result);
+
+	#var_dump($row);#*#DEBUG#
+	// make sure the users are in the players' table
+	$value_list = [];
+	if (!isset($row['white_rating'])) {
+		$row['white_rating'] = $init_rating;
+		$row['white_games']  = 0;
+		$value_list[]        = "('{$row['white_uid']}','{$row['white_rating']}')";
+	}
+	if (!isset($row['black_rating'])) {
+		$row['black_rating'] = $init_rating;
+		$row['black_games']  = 0;
+		$value_list[]        = "('{$row['black_uid']}','{$row['black_rating']}')";
+	}
+	if (!empty($value_list)) {
+		$values = implode(',', $value_list);
+		$xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
+		$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	}
+
+	// calculate new ratings using configured rating system
+	[$white_rating_new, $black_rating_new] = $func($row['white_rating'], $row['white_games'], $row['black_rating'], $row['black_games'], $row['pgn_result']);
+
+	// determine game-count columns to increment
+	[$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
+
+	$xoopsDB->query(
+		"
 		UPDATE $ratings_table
 		SET    rating = '$white_rating_new', $white_col = $white_col + 1
 		WHERE  player_uid = '{$row['white_uid']}'
 	"
-    );
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	);
+	$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
 
-    $xoopsDB->query(
-        "
+	$xoopsDB->query(
+		"
 		UPDATE $ratings_table
 		SET    rating = '$black_rating_new', $black_col = $black_col + 1
 		WHERE  player_uid = '{$row['black_uid']}'
 	"
-    );
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	);
+	$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
 
-    return true;
+	return true;
 }
 
 /**
@@ -130,82 +130,82 @@ 
  */
 function chess_recalc_ratings()
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $rating_system = chess_moduleConfig('rating_system');
-    $init_rating   = chess_moduleConfig('initial_rating');
+	$rating_system = chess_moduleConfig('rating_system');
+	$init_rating   = chess_moduleConfig('initial_rating');
 
-    if ('none' == $rating_system) {
-        return false;
-    }
+	if ('none' == $rating_system) {
+		return false;
+	}
 
-    // determine function for calculating new ratings using configured rating system
-    $func = chess_ratings_get_func_adj($rating_system);
+	// determine function for calculating new ratings using configured rating system
+	$func = chess_ratings_get_func_adj($rating_system);
 
-    $games_table   = $xoopsDB->prefix('chess_games');
-    $ratings_table = $xoopsDB->prefix('chess_ratings');
+	$games_table   = $xoopsDB->prefix('chess_games');
+	$ratings_table = $xoopsDB->prefix('chess_ratings');
 
-    // Nuke the current ratings.  #*#TBD# - don't want to empty this table, since there will be other info in it besides ratings (?)
-    $xoopsDB->query("DELETE FROM $ratings_table");
+	// Nuke the current ratings.  #*#TBD# - don't want to empty this table, since there will be other info in it besides ratings (?)
+	$xoopsDB->query("DELETE FROM $ratings_table");
 
-    // get all games
-    $result = $xoopsDB->query(
-        "
+	// get all games
+	$result = $xoopsDB->query(
+		"
 		SELECT    white_uid, black_uid, pgn_result
 		FROM      $games_table
 		WHERE     is_rated = '1' AND pgn_result != '*' AND white_uid != black_uid
 		ORDER BY  last_date ASC
 	"
-    );
-
-    $players = [];
-
-    // process the games
-    while ($row = $xoopsDB->fetchArray($result)) {
-        #var_dump($row);#*#DEBUG#
-        if (!isset($players[$row['white_uid']])) {
-            $players[$row['white_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
-        }
-        if (!isset($players[$row['black_uid']])) {
-            $players[$row['black_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
-        }
-
-        $player_white = $players[$row['white_uid']];
-        $player_black = $players[$row['black_uid']];
-
-        // calculate new ratings using configured rating system
-        [$white_rating_new, $black_rating_new] = $func(
-            $player_white['rating'],
-            $player_white['games_won'] + $player_white['games_lost'] + $player_white['games_drawn'],
-            $player_black['rating'],
-            $player_black['games_won'] + $player_black['games_lost'] + $player_black['games_drawn'],
-            $row['pgn_result']
-        );
-
-        // determine game-count columns to increment
-        [$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
-
-        $player_white['rating'] = $white_rating_new;
-        ++$player_white[$white_col];
-
-        $player_black['rating'] = $black_rating_new;
-        ++$player_black[$black_col];
-    }
-
-    $xoopsDB->freeRecordSet($result);
-
-    if (!empty($players)) {
-        $value_list = [];
-        foreach ($players as $player_uid => $player) {
-            $value_list[] = "('$player_uid', '{$player['rating']}', '{$player['games_won']}', '{$player['games_lost']}', '{$player['games_drawn']}')";
-        }
-        $values = implode(',', $value_list);
-
-        $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
-    }
-
-    return true;
+	);
+
+	$players = [];
+
+	// process the games
+	while ($row = $xoopsDB->fetchArray($result)) {
+		#var_dump($row);#*#DEBUG#
+		if (!isset($players[$row['white_uid']])) {
+			$players[$row['white_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
+		}
+		if (!isset($players[$row['black_uid']])) {
+			$players[$row['black_uid']] = ['rating' => $init_rating, 'games_won' => 0, 'games_lost' => 0, 'games_drawn' => 0];
+		}
+
+		$player_white = $players[$row['white_uid']];
+		$player_black = $players[$row['black_uid']];
+
+		// calculate new ratings using configured rating system
+		[$white_rating_new, $black_rating_new] = $func(
+			$player_white['rating'],
+			$player_white['games_won'] + $player_white['games_lost'] + $player_white['games_drawn'],
+			$player_black['rating'],
+			$player_black['games_won'] + $player_black['games_lost'] + $player_black['games_drawn'],
+			$row['pgn_result']
+		);
+
+		// determine game-count columns to increment
+		[$white_col, $black_col] = chess_ratings_get_columns($row['pgn_result']);
+
+		$player_white['rating'] = $white_rating_new;
+		++$player_white[$white_col];
+
+		$player_black['rating'] = $black_rating_new;
+		++$player_black[$black_col];
+	}
+
+	$xoopsDB->freeRecordSet($result);
+
+	if (!empty($players)) {
+		$value_list = [];
+		foreach ($players as $player_uid => $player) {
+			$value_list[] = "('$player_uid', '{$player['rating']}', '{$player['games_won']}', '{$player['games_lost']}', '{$player['games_drawn']}')";
+		}
+		$values = implode(',', $value_list);
+
+		$xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
+		$xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+	}
+
+	return true;
 }
 
 /**
@@ -215,20 +215,20 @@ 
  */
 function chess_ratings_num_provisional_games()
 {
-    $rating_system = chess_moduleConfig('rating_system');
+	$rating_system = chess_moduleConfig('rating_system');
 
-    if ('none' == $rating_system) {
-        return 0;
-    }
+	if ('none' == $rating_system) {
+		return 0;
+	}
 
-    // determine function for getting number of provisional games using configured rating system
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
-    file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
-    require_once $file;
-    $func = "chess_ratings_num_provisional_games_{$rating_system}";
-    function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
+	// determine function for getting number of provisional games using configured rating system
+	$file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
+	file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
+	require_once $file;
+	$func = "chess_ratings_num_provisional_games_{$rating_system}";
+	function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
 
-    return $func();
+	return $func();
 }
 
 /**
@@ -239,12 +239,12 @@ 
  */
 function chess_ratings_get_func_adj($rating_system)
 {
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
-    file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
-    require_once $file;
-    $func = "chess_ratings_adj_{$rating_system}";
-    function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
-    return $func;
+	$file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
+	file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
+	require_once $file;
+	$func = "chess_ratings_adj_{$rating_system}";
+	function_exists($func) or trigger_error("missing function '$func' for rating system '$rating_system'", E_USER_ERROR);
+	return $func;
 }
 
 /**
@@ -259,23 +259,23 @@ 
  */
 function chess_ratings_get_columns($pgn_result)
 {
-    switch ($pgn_result) {
-        case '1-0':
-            $white_col = 'games_won';
-            $black_col = 'games_lost';
-            break;
-        case '1/2-1/2':
-        default: // should not occur
-            $white_col = 'games_drawn';
-            $black_col = 'games_drawn';
-            break;
-        case '0-1':
-            $white_col = 'games_lost';
-            $black_col = 'games_won';
-            break;
-    }
-
-    return [$white_col, $black_col];
+	switch ($pgn_result) {
+		case '1-0':
+			$white_col = 'games_won';
+			$black_col = 'games_lost';
+			break;
+		case '1/2-1/2':
+		default: // should not occur
+			$white_col = 'games_drawn';
+			$black_col = 'games_drawn';
+			break;
+		case '0-1':
+			$white_col = 'games_lost';
+			$black_col = 'games_won';
+			break;
+	}
+
+	return [$white_col, $black_col];
 }
 
 ?>

Spacing +7 added lines, -7 removed lines

@@ -29,7 +29,7 @@ 
 
 /**#@+
  */
-require_once XOOPS_ROOT_PATH . '/modules/chess/include/functions.php';
+require_once XOOPS_ROOT_PATH.'/modules/chess/include/functions.php';
 /**#@-*/
 
 /**
@@ -93,7 +93,7 @@ 
     if (!empty($value_list)) {
         $values = implode(',', $value_list);
         $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating) VALUES $values");
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+        $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
     }
 
     // calculate new ratings using configured rating system
@@ -109,7 +109,7 @@ 
 		WHERE  player_uid = '{$row['white_uid']}'
 	"
     );
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+    $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
 
     $xoopsDB->query(
         "
@@ -118,7 +118,7 @@ 
 		WHERE  player_uid = '{$row['black_uid']}'
 	"
     );
-    $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+    $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
 
     return true;
 }
@@ -202,7 +202,7 @@ 
         $values = implode(',', $value_list);
 
         $xoopsDB->query("INSERT INTO $ratings_table (player_uid, rating, games_won, games_lost, games_drawn) VALUES $values");
-        $xoopsDB->errno() and trigger_error($xoopsDB->errno() . ':' . $xoopsDB->error(), E_USER_ERROR);
+        $xoopsDB->errno() and trigger_error($xoopsDB->errno().':'.$xoopsDB->error(), E_USER_ERROR);
     }
 
     return true;
@@ -222,7 +222,7 @@ 
     }
 
     // determine function for getting number of provisional games using configured rating system
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
+    $file = XOOPS_ROOT_PATH."/modules/chess/include/ratings_{$rating_system}.inc.php";
     file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
     require_once $file;
     $func = "chess_ratings_num_provisional_games_{$rating_system}";
@@ -239,7 +239,7 @@ 
  */
 function chess_ratings_get_func_adj($rating_system)
 {
-    $file = XOOPS_ROOT_PATH . "/modules/chess/include/ratings_{$rating_system}.inc.php";
+    $file = XOOPS_ROOT_PATH."/modules/chess/include/ratings_{$rating_system}.inc.php";
     file_exists($file) or trigger_error("missing file '$file' for rating system '$rating_system'", E_USER_ERROR);
     require_once $file;
     $func = "chess_ratings_adj_{$rating_system}";

include/common.php

Indentation +31 added lines, -31 removed lines

@@ -42,47 +42,47 @@ 
 $pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
 $pathIcon32 = \Xmf\Module\Admin::iconUrl('', 32);
 if (is_object($helper->getModule())) {
-    $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
+	$pathModIcon16 = $helper->getModule()->getInfo('modicons16');
 
-    $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
+	$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 }
 
 if (!defined($moduleDirNameUpper . '_CONSTANTS_DEFINED')) {
-    define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
+	define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
 
-    define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
+	define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
 
-    define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
+	define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
 
-    define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
+	define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
 
-    define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
+	define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
 
-    define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
+	define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
 
-    define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
+	define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
 
-    define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
+	define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
 
-    define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
-    //    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
-    define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', $pathIcon32 . '/xoopsmicrobutton.gif');
+	define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
+	//    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
+	define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
+	define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
+	define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', $pathIcon32 . '/xoopsmicrobutton.gif');
 
-    define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
+	define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
 }
 
 $icons = [
-    'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
-    'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
-    'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
-    'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
-    'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
-    'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
-    'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
-    '0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
-    '1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
+	'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
+	'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
+	'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
+	'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
+	'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
+	'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
+	'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
+	'0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
+	'1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
 ];
 
 $debug = false;
@@ -91,19 +91,19 @@ 
 $myts = \MyTextSanitizer::getInstance();
 
 if (!isset($GLOBALS['xoopsTpl']) || !($GLOBALS['xoopsTpl'] instanceof \XoopsTpl)) {
-    require_once $GLOBALS['xoops']->path('class/template.php');
+	require_once $GLOBALS['xoops']->path('class/template.php');
 
-    $GLOBALS['xoopsTpl'] = new \XoopsTpl();
+	$GLOBALS['xoopsTpl'] = new \XoopsTpl();
 }
 
 $GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL . '/modules/' . $moduleDirName);
 // Local icons path
 if (is_object($helper->getModule())) {
-    $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
+	$pathModIcon16 = $helper->getModule()->getInfo('modicons16');
 
-    $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
+	$pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 
-    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
+	$GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
 
-    $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
+	$GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
 }

Spacing +26 added lines, -26 removed lines

@@ -20,7 +20,7 @@ 
 
 use XoopsModules\Chess;
 
-include dirname(__DIR__) . '/preloads/autoloader.php';
+include dirname(__DIR__).'/preloads/autoloader.php';
 
 $moduleDirName      = basename(dirname(__DIR__));
 $moduleDirNameUpper = mb_strtoupper($moduleDirName); //$capsDirName
@@ -47,42 +47,42 @@ 
     $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 }
 
-if (!defined($moduleDirNameUpper . '_CONSTANTS_DEFINED')) {
-    define($moduleDirNameUpper . '_DIRNAME', basename(dirname(__DIR__)));
+if (!defined($moduleDirNameUpper.'_CONSTANTS_DEFINED')) {
+    define($moduleDirNameUpper.'_DIRNAME', basename(dirname(__DIR__)));
 
-    define($moduleDirNameUpper . '_ROOT_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
+    define($moduleDirNameUpper.'_ROOT_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
 
-    define($moduleDirNameUpper . '_PATH', XOOPS_ROOT_PATH . '/modules/' . $moduleDirName . '/');
+    define($moduleDirNameUpper.'_PATH', XOOPS_ROOT_PATH.'/modules/'.$moduleDirName.'/');
 
-    define($moduleDirNameUpper . '_URL', XOOPS_URL . '/modules/' . $moduleDirName . '/');
+    define($moduleDirNameUpper.'_URL', XOOPS_URL.'/modules/'.$moduleDirName.'/');
 
-    define($moduleDirNameUpper . '_IMAGE_URL', constant($moduleDirNameUpper . '_URL') . '/assets/images/');
+    define($moduleDirNameUpper.'_IMAGE_URL', constant($moduleDirNameUpper.'_URL').'/assets/images/');
 
-    define($moduleDirNameUpper . '_IMAGE_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/assets/images');
+    define($moduleDirNameUpper.'_IMAGE_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/assets/images');
 
-    define($moduleDirNameUpper . '_ADMIN_URL', constant($moduleDirNameUpper . '_URL') . '/admin/');
+    define($moduleDirNameUpper.'_ADMIN_URL', constant($moduleDirNameUpper.'_URL').'/admin/');
 
-    define($moduleDirNameUpper . '_ADMIN_PATH', constant($moduleDirNameUpper . '_ROOT_PATH') . '/admin/');
+    define($moduleDirNameUpper.'_ADMIN_PATH', constant($moduleDirNameUpper.'_ROOT_PATH').'/admin/');
 
-    define($moduleDirNameUpper . '_ADMIN', constant($moduleDirNameUpper . '_URL') . '/admin/index.php');
+    define($moduleDirNameUpper.'_ADMIN', constant($moduleDirNameUpper.'_URL').'/admin/index.php');
     //    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', constant($moduleDirNameUpper . '_URL') . '/assets/images/logoModule.png');
-    define($moduleDirNameUpper . '_UPLOAD_URL', XOOPS_UPLOAD_URL . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_UPLOAD_PATH', XOOPS_UPLOAD_PATH . '/' . $moduleDirName); // WITHOUT Trailing slash
-    define($moduleDirNameUpper . '_AUTHOR_LOGOIMG', $pathIcon32 . '/xoopsmicrobutton.gif');
+    define($moduleDirNameUpper.'_UPLOAD_URL', XOOPS_UPLOAD_URL.'/'.$moduleDirName); // WITHOUT Trailing slash
+    define($moduleDirNameUpper.'_UPLOAD_PATH', XOOPS_UPLOAD_PATH.'/'.$moduleDirName); // WITHOUT Trailing slash
+    define($moduleDirNameUpper.'_AUTHOR_LOGOIMG', $pathIcon32.'/xoopsmicrobutton.gif');
 
-    define($moduleDirNameUpper . '_CONSTANTS_DEFINED', 1);
+    define($moduleDirNameUpper.'_CONSTANTS_DEFINED', 1);
 }
 
 $icons = [
-    'edit'    => "<img src='" . $pathIcon16 . "/edit.png'  alt=" . _EDIT . "' align='middle'>",
-    'delete'  => "<img src='" . $pathIcon16 . "/delete.png' alt='" . _DELETE . "' align='middle'>",
-    'clone'   => "<img src='" . $pathIcon16 . "/editcopy.png' alt='" . _CLONE . "' align='middle'>",
-    'preview' => "<img src='" . $pathIcon16 . "/view.png' alt='" . _PREVIEW . "' align='middle'>",
-    'print'   => "<img src='" . $pathIcon16 . "/printer.png' alt='" . _CLONE . "' align='middle'>",
-    'pdf'     => "<img src='" . $pathIcon16 . "/pdf.png' alt='" . _CLONE . "' align='middle'>",
-    'add'     => "<img src='" . $pathIcon16 . "/add.png' alt='" . _ADD . "' align='middle'>",
-    '0'       => "<img src='" . $pathIcon16 . "/0.png' alt='" . 0 . "' align='middle'>",
-    '1'       => "<img src='" . $pathIcon16 . "/1.png' alt='" . 1 . "' align='middle'>",
+    'edit'    => "<img src='".$pathIcon16."/edit.png'  alt="._EDIT."' align='middle'>",
+    'delete'  => "<img src='".$pathIcon16."/delete.png' alt='"._DELETE."' align='middle'>",
+    'clone'   => "<img src='".$pathIcon16."/editcopy.png' alt='"._CLONE."' align='middle'>",
+    'preview' => "<img src='".$pathIcon16."/view.png' alt='"._PREVIEW."' align='middle'>",
+    'print'   => "<img src='".$pathIcon16."/printer.png' alt='"._CLONE."' align='middle'>",
+    'pdf'     => "<img src='".$pathIcon16."/pdf.png' alt='"._CLONE."' align='middle'>",
+    'add'     => "<img src='".$pathIcon16."/add.png' alt='"._ADD."' align='middle'>",
+    '0'       => "<img src='".$pathIcon16."/0.png' alt='".0."' align='middle'>",
+    '1'       => "<img src='".$pathIcon16."/1.png' alt='".1."' align='middle'>",
 ];
 
 $debug = false;
@@ -96,14 +96,14 @@ 
     $GLOBALS['xoopsTpl'] = new \XoopsTpl();
 }
 
-$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL . '/modules/' . $moduleDirName);
+$GLOBALS['xoopsTpl']->assign('mod_url', XOOPS_URL.'/modules/'.$moduleDirName);
 // Local icons path
 if (is_object($helper->getModule())) {
     $pathModIcon16 = $helper->getModule()->getInfo('modicons16');
 
     $pathModIcon32 = $helper->getModule()->getInfo('modicons32');
 
-    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL . '/modules/' . $moduleDirName . '/' . $pathModIcon16);
+    $GLOBALS['xoopsTpl']->assign('pathModIcon16', XOOPS_URL.'/modules/'.$moduleDirName.'/'.$pathModIcon16);
 
     $GLOBALS['xoopsTpl']->assign('pathModIcon32', $pathModIcon32);
 }

include/install.inc.php

Indentation +156 added lines, -156 removed lines

@@ -49,74 +49,74 @@ 
  */
 function xoops_module_pre_update_chess(&$module, $oldversion)
 {
-    global $xoopsDB;
-
-    // For downward-compatiblity, in case this function doesn't get called by the module handler.
-    $GLOBALS['chess_module_pre_update_called'] = true;
-
-    if ($oldversion < 102) { // old version < 1.02: direct update not supported.
-
-        $docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
-        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
-        return false;
-    } elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
-
-        return true;
-    }
-
-    // 1.02 <= old version < 1.07: perform update.
-
-    $ratings_table    = $xoopsDB->prefix('chess_ratings');
-    $challenges_table = $xoopsDB->prefix('chess_challenges');
-    $games_table      = $xoopsDB->prefix('chess_games');
-
-    // Check that ratings table does not already exist.
-    chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_1, $ratings_table));
-    $result = $xoopsDB->query("SHOW TABLES LIKE '$ratings_table'");
-    if (!$result) {
-        $mysql_errno = $xoopsDB->errno();
-        $mysql_error = $xoopsDB->error();
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
-        return false;
-    }
-    if ($xoopsDB->getRowsNum($result) > 0) {
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_3, $ratings_table), true);
-        return false;
-    }
-    $xoopsDB->freeRecordSet($result);
-    chess_set_message($module, _MI_CHESS_OK);
-
-    // Check database tables.
-    chess_set_message($module, _MI_CHESS_CHK_DB_TABLES);
-    $table_check_messages = chess_check_tables([$challenges_table, $games_table]);
-    if (!empty($table_check_messages)) {
-        foreach ($table_check_messages as $message) {
-            chess_set_message($module, $message, true);
-        }
-        return false;
-    }
-    chess_set_message($module, _MI_CHESS_OK);
-
-    // Check that values in column pgn_result of games table are in range.
-    $pgn_result_values = "'*','1-0','0-1','1/2-1/2'";
-    chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_1, $games_table));
-    $result = $xoopsDB->query("SELECT COUNT(*) FROM `$games_table` WHERE `pgn_result` NOT IN ($pgn_result_values)");
-    if (!$result) {
-        $mysql_errno = $xoopsDB->errno();
-        $mysql_error = $xoopsDB->error();
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
-        return false;
-    }
-    [$count] = $xoopsDB->fetchRow($result);
-    if ($count > 0) {
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_3, 'pgn_result', $games_table, $pgn_result_values), true);
-        chess_set_message($module, _MI_CHESS_GAMES_TABLE_4, true);
-        return false;
-    }
-    $xoopsDB->freeRecordSet($result);
-    chess_set_message($module, _MI_CHESS_OK);
-
-    return true; // successful
+	global $xoopsDB;
+
+	// For downward-compatiblity, in case this function doesn't get called by the module handler.
+	$GLOBALS['chess_module_pre_update_called'] = true;
+
+	if ($oldversion < 102) { // old version < 1.02: direct update not supported.
+
+		$docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
+		chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
+		return false;
+	} elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
+
+		return true;
+	}
+
+	// 1.02 <= old version < 1.07: perform update.
+
+	$ratings_table    = $xoopsDB->prefix('chess_ratings');
+	$challenges_table = $xoopsDB->prefix('chess_challenges');
+	$games_table      = $xoopsDB->prefix('chess_games');
+
+	// Check that ratings table does not already exist.
+	chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_1, $ratings_table));
+	$result = $xoopsDB->query("SHOW TABLES LIKE '$ratings_table'");
+	if (!$result) {
+		$mysql_errno = $xoopsDB->errno();
+		$mysql_error = $xoopsDB->error();
+		chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
+		return false;
+	}
+	if ($xoopsDB->getRowsNum($result) > 0) {
+		chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_3, $ratings_table), true);
+		return false;
+	}
+	$xoopsDB->freeRecordSet($result);
+	chess_set_message($module, _MI_CHESS_OK);
+
+	// Check database tables.
+	chess_set_message($module, _MI_CHESS_CHK_DB_TABLES);
+	$table_check_messages = chess_check_tables([$challenges_table, $games_table]);
+	if (!empty($table_check_messages)) {
+		foreach ($table_check_messages as $message) {
+			chess_set_message($module, $message, true);
+		}
+		return false;
+	}
+	chess_set_message($module, _MI_CHESS_OK);
+
+	// Check that values in column pgn_result of games table are in range.
+	$pgn_result_values = "'*','1-0','0-1','1/2-1/2'";
+	chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_1, $games_table));
+	$result = $xoopsDB->query("SELECT COUNT(*) FROM `$games_table` WHERE `pgn_result` NOT IN ($pgn_result_values)");
+	if (!$result) {
+		$mysql_errno = $xoopsDB->errno();
+		$mysql_error = $xoopsDB->error();
+		chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
+		return false;
+	}
+	[$count] = $xoopsDB->fetchRow($result);
+	if ($count > 0) {
+		chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_3, 'pgn_result', $games_table, $pgn_result_values), true);
+		chess_set_message($module, _MI_CHESS_GAMES_TABLE_4, true);
+		return false;
+	}
+	$xoopsDB->freeRecordSet($result);
+	chess_set_message($module, _MI_CHESS_OK);
+
+	return true; // successful
 }
 
 /**
@@ -128,25 +128,25 @@ 
  */
 function xoops_module_update_chess(&$module, $oldversion)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    // Before proceeding, ensure that pre-update processing has been done, and that all the checks pass.
-    // For downward-compatiblity, in case the "pre_update" function doesn't get called by the module handler.
-    if (!@$GLOBALS['chess_module_pre_update_called'] and !xoops_module_pre_update_chess($module, $oldversion)) {
-        return false;
-    }
+	// Before proceeding, ensure that pre-update processing has been done, and that all the checks pass.
+	// For downward-compatiblity, in case the "pre_update" function doesn't get called by the module handler.
+	if (!@$GLOBALS['chess_module_pre_update_called'] and !xoops_module_pre_update_chess($module, $oldversion)) {
+		return false;
+	}
 
-    if ($oldversion >= 107) { // old version >= 1.07:  no action needed.
-        return true;
-    }
+	if ($oldversion >= 107) { // old version >= 1.07:  no action needed.
+		return true;
+	}
 
-    $ratings_table    = $xoopsDB->prefix('chess_ratings');
-    $challenges_table = $xoopsDB->prefix('chess_challenges');
-    $games_table      = $xoopsDB->prefix('chess_games');
+	$ratings_table    = $xoopsDB->prefix('chess_ratings');
+	$challenges_table = $xoopsDB->prefix('chess_challenges');
+	$games_table      = $xoopsDB->prefix('chess_games');
 
-    $queries = [
+	$queries = [
 
-        "CREATE TABLE `$ratings_table` (
+		"CREATE TABLE `$ratings_table` (
 			`player_uid` mediumint(8) unsigned NOT NULL default '0',
 			`rating` smallint(6) unsigned NOT NULL default '1200',
 			`games_won` smallint(6) unsigned NOT NULL default '0',
@@ -157,40 +157,40 @@ 
 			KEY `games` (`games_won`,`games_lost`,`games_drawn`)
 			) TYPE=MyISAM",
 
-        "ALTER TABLE `$challenges_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
-        "ALTER TABLE `$challenges_table` ADD INDEX `game_type` (`game_type`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `player1_uid` (`player1_uid`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `player2_uid` (`player2_uid`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `create_date` (`create_date`)",
-        "ALTER TABLE `$challenges_table` ADD INDEX `is_rated` (`is_rated`)",
-
-        "ALTER TABLE `$games_table` CHANGE `pgn_result` `pgn_result` ENUM('*','0-1','1-0','1/2-1/2') DEFAULT '*' NOT NULL",
-        "ALTER TABLE `$games_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
-        "ALTER TABLE `$games_table` ADD INDEX `white_uid` (`white_uid`)",
-        "ALTER TABLE `$games_table` ADD INDEX `black_uid` (`black_uid`)",
-        "ALTER TABLE `$games_table` ADD INDEX `date` (`create_date`,`start_date`,`last_date`)",
-        "ALTER TABLE `$games_table` ADD INDEX `pgn_result` (`pgn_result`)",
-        "ALTER TABLE `$games_table` ADD INDEX `suspended_date` (`suspended`(19))",
-        "ALTER TABLE `$games_table` ADD INDEX `is_rated` (`is_rated`)",
-
-        "UPDATE `$games_table` SET `is_rated` = '0' WHERE `white_uid` = `black_uid`",
-    ];
-
-    // Update database tables.
-    chess_set_message($module, _MI_CHESS_UPDATING_DATABASE);
-    foreach ($queries as $query) {
-        chess_set_message($module, "> $query");
-        $result = $xoopsDB->query($query);
-        if (!$result) {
-            $mysql_errno = $xoopsDB->errno();
-            $mysql_error = $xoopsDB->error();
-            chess_set_message($module, " ... ($mysql_errno) $mysql_error");
-            return false;
-        }
-        chess_set_message($module, _MI_CHESS_OK);
-    }
-
-    /***
+		"ALTER TABLE `$challenges_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
+		"ALTER TABLE `$challenges_table` ADD INDEX `game_type` (`game_type`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `player1_uid` (`player1_uid`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `player2_uid` (`player2_uid`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `create_date` (`create_date`)",
+		"ALTER TABLE `$challenges_table` ADD INDEX `is_rated` (`is_rated`)",
+
+		"ALTER TABLE `$games_table` CHANGE `pgn_result` `pgn_result` ENUM('*','0-1','1-0','1/2-1/2') DEFAULT '*' NOT NULL",
+		"ALTER TABLE `$games_table` ADD `is_rated` ENUM('1','0') DEFAULT '1' NOT NULL",
+		"ALTER TABLE `$games_table` ADD INDEX `white_uid` (`white_uid`)",
+		"ALTER TABLE `$games_table` ADD INDEX `black_uid` (`black_uid`)",
+		"ALTER TABLE `$games_table` ADD INDEX `date` (`create_date`,`start_date`,`last_date`)",
+		"ALTER TABLE `$games_table` ADD INDEX `pgn_result` (`pgn_result`)",
+		"ALTER TABLE `$games_table` ADD INDEX `suspended_date` (`suspended`(19))",
+		"ALTER TABLE `$games_table` ADD INDEX `is_rated` (`is_rated`)",
+
+		"UPDATE `$games_table` SET `is_rated` = '0' WHERE `white_uid` = `black_uid`",
+	];
+
+	// Update database tables.
+	chess_set_message($module, _MI_CHESS_UPDATING_DATABASE);
+	foreach ($queries as $query) {
+		chess_set_message($module, "> $query");
+		$result = $xoopsDB->query($query);
+		if (!$result) {
+			$mysql_errno = $xoopsDB->errno();
+			$mysql_error = $xoopsDB->error();
+			chess_set_message($module, " ... ($mysql_errno) $mysql_error");
+			return false;
+		}
+		chess_set_message($module, _MI_CHESS_OK);
+	}
+
+	/***
      * #*#TODO# - Leave this here for now, in case I think of a way to get it to work.
      * # This causes an error about the rating_system module configuration parameter not being defined,
      * # so I added a note in INSTALL.TXT about manually recalculating the ratings after install.
@@ -201,9 +201,9 @@ 
      * chess_recalc_ratings();
      ***/
 
-    chess_set_message($module, _MI_CHESS_UPDATE_SUCCESSFUL);
+	chess_set_message($module, _MI_CHESS_UPDATE_SUCCESSFUL);
 
-    return true; // successful
+	return true; // successful
 }
 
 /**
@@ -214,37 +214,37 @@ 
  */
 function chess_check_tables($table_names)
 {
-    global $xoopsDB;
+	global $xoopsDB;
 
-    $messages = [];
+	$messages = [];
 
-    foreach ($table_names as $table_name) {
-        $query  = "CHECK TABLE `$table_name`";
-        $result = $xoopsDB->query($query);
-        if (!$result) {
-            $mysql_errno = $xoopsDB->errno();
-            $mysql_error = $xoopsDB->error();
-            $messages[]  = $query;
-            $messages[]  = " ... ($mysql_errno) $mysql_error";
-            continue;
-        }
+	foreach ($table_names as $table_name) {
+		$query  = "CHECK TABLE `$table_name`";
+		$result = $xoopsDB->query($query);
+		if (!$result) {
+			$mysql_errno = $xoopsDB->errno();
+			$mysql_error = $xoopsDB->error();
+			$messages[]  = $query;
+			$messages[]  = " ... ($mysql_errno) $mysql_error";
+			continue;
+		}
 
-        // Initialize, in case the real table status fails to get retrieved.
-        $table_status = '*** STATUS UNKNOWN ***';
+		// Initialize, in case the real table status fails to get retrieved.
+		$table_status = '*** STATUS UNKNOWN ***';
 
-        // The query may return multiple rows.  Only the last row is normally of interest, so only that row is saved.
-        while ($row = $xoopsDB->fetchArray($result)) {
-            $table_status = $row['Msg_text'];
-        }
+		// The query may return multiple rows.  Only the last row is normally of interest, so only that row is saved.
+		while ($row = $xoopsDB->fetchArray($result)) {
+			$table_status = $row['Msg_text'];
+		}
 
-        $xoopsDB->freeRecordSet($result);
+		$xoopsDB->freeRecordSet($result);
 
-        if ('OK' != $table_status) {
-            $messages[] = " ... $table_name: $table_status";
-        }
-    }
+		if ('OK' != $table_status) {
+			$messages[] = " ... $table_name: $table_status";
+		}
+	}
 
-    return $messages;
+	return $messages;
 }
 
 /**
@@ -259,12 +259,12 @@ 
  */
 function chess_load_lang_file($filename, $module = '', $default = 'english')
 {
-    $lang = $GLOBALS['xoopsConfig']['language'];
-    $path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
-    if (!($ret = @include_once("$path/$lang/$filename.php"))) {
-        $ret = include_once("$path/$default/$filename.php");
-    }
-    return $ret;
+	$lang = $GLOBALS['xoopsConfig']['language'];
+	$path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
+	if (!($ret = @include_once("$path/$lang/$filename.php"))) {
+		$ret = include_once("$path/$default/$filename.php");
+	}
+	return $ret;
 }
 
 /**
@@ -276,14 +276,14 @@ 
  */
 function chess_set_message($module, $text = '', $error = false)
 {
-    $text = $error ? "<span style='color:#ff0000;background-color:#ffffff;font-weight:bold;'>$text</span>" : $text;
-
-    // For downward compatibility with XOOPS versions that don't have the method XoopsModule::setMessage.
-    if (is_object($module) and method_exists($module, 'setMessage')) {
-        $module->setMessage($text);
-    } else {
-        echo "<code>$text</code><br />\n";
-    }
+	$text = $error ? "<span style='color:#ff0000;background-color:#ffffff;font-weight:bold;'>$text</span>" : $text;
+
+	// For downward compatibility with XOOPS versions that don't have the method XoopsModule::setMessage.
+	if (is_object($module) and method_exists($module, 'setMessage')) {
+		$module->setMessage($text);
+	} else {
+		echo "<code>$text</code><br />\n";
+	}
 }
 
 ?>

Spacing +5 added lines, -5 removed lines

@@ -56,8 +56,8 @@ 
 
     if ($oldversion < 102) { // old version < 1.02: direct update not supported.
 
-        $docfile = XOOPS_ROOT_PATH . '/modules/chess/docs/INSTALL.TXT';
-        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string)$oldversion, $docfile), true);
+        $docfile = XOOPS_ROOT_PATH.'/modules/chess/docs/INSTALL.TXT';
+        chess_set_message($module, sprintf(_MI_CHESS_OLD_VERSION, (string) $oldversion, $docfile), true);
         return false;
     } elseif ($oldversion >= 107) { // old version >= 1.07:  no action needed.
 
@@ -76,7 +76,7 @@ 
     if (!$result) {
         $mysql_errno = $xoopsDB->errno();
         $mysql_error = $xoopsDB->error();
-        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string)$mysql_errno, $mysql_error), true);
+        chess_set_message($module, sprintf(_MI_CHESS_RATINGS_TABLE_2, $ratings_table, (string) $mysql_errno, $mysql_error), true);
         return false;
     }
     if ($xoopsDB->getRowsNum($result) > 0) {
@@ -104,7 +104,7 @@ 
     if (!$result) {
         $mysql_errno = $xoopsDB->errno();
         $mysql_error = $xoopsDB->error();
-        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string)$mysql_errno, $mysql_error), true);
+        chess_set_message($module, sprintf(_MI_CHESS_GAMES_TABLE_2, $games_table, (string) $mysql_errno, $mysql_error), true);
         return false;
     }
     [$count] = $xoopsDB->fetchRow($result);
@@ -260,7 +260,7 @@ 
 function chess_load_lang_file($filename, $module = '', $default = 'english')
 {
     $lang = $GLOBALS['xoopsConfig']['language'];
-    $path = XOOPS_ROOT_PATH . (empty($module) ? '/' : "/modules/$module/") . 'language';
+    $path = XOOPS_ROOT_PATH.(empty($module) ? '/' : "/modules/$module/").'language';
     if (!($ret = @include_once("$path/$lang/$filename.php"))) {
         $ret = include_once("$path/$default/$filename.php");
     }