chess_ratings()

Complexity

Conditions	6
Paths	8

Size

Total Lines	117
Code Lines	45

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
function chess_ratings($start = 0, $msg = '', $msg_class = 'errorMsg')
{
    global $xoopsDB, $xoopsUser, $xoopsModule, $xoopsTpl;

    // Display ratings.

    // Get maximum number of items to display on a page, and constrain it to a reasonable value.

    $max_items_to_display = chess_moduleConfig('max_items');

    $max_items_to_display = min(max($max_items_to_display, 1), 1000);

    $games_table = $xoopsDB->prefix('chess_games');

The assignment to $games_table is dead and can be removed.

    $ratings_table = $xoopsDB->prefix('chess_ratings');

    // Two queries are performed, one without a limit clause to count the total number of rows for the page navigator,

    // and one with a limit clause to get the data for display on the current page.

    // SQL_CALC_FOUND_ROWS and FOUND_ROWS(), available in MySQL 4.0.0, provide a more efficient way of doing this.

    $result = $xoopsDB->query(
        "
        SELECT    COUNT(*)
        FROM      $ratings_table AS p
    "
    );

    [$num_items] = $xoopsDB->fetchRow($result);

    $xoopsDB->freeRecordSet($result);

    $pagenav = new XoopsPageNav($num_items, $max_items_to_display, $start, 'start');

    $result = $xoopsDB->query(
        "
        SELECT    player_uid, rating, (games_won+games_lost+games_drawn) AS games_played
        FROM      $ratings_table
        ORDER BY  rating DESC, player_uid ASC
        LIMIT     $start, $max_items_to_display
    "
    );

    // user IDs that will require mapping to usernames

    $userids = [];

    $players = [];

    while (false !== ($row = $xoopsDB->fetchArray($result))) {
        // save user IDs that will require mapping to usernames

        $userids[] = $row['player_uid'];

        $players[] = [
            'player_uid'   => $row['player_uid'],
            'rating'       => $row['rating'],
            'games_played' => $row['games_played'],
        ];
    }

    $xoopsDB->freeRecordSet($result);

    // get mapping of user IDs to usernames

    $memberHandler = xoops_getHandler('member');

    $criteria = new \Criteria('uid', '(' . implode(',', $userids) . ')', 'IN');

    $usernames = $memberHandler->getUserList($criteria);

The method getUserList() does not exist on XoopsObjectHandler. It seems like you code against a sub-type of XoopsObjectHandler such as XoopsPersistableObjectHandler.

    // add usernames to $players

    foreach ($players as $k => $player) {
        $players[$k]['player_uname'] = $usernames[$player['player_uid']] ?? '?';
    }

    // Display form for arbiter to recalculate ratings.

    if (is_object($xoopsUser) && $xoopsUser->isAdmin($xoopsModule->getVar('mid'))) {
        // security token added below

        $form = new XoopsThemeForm(_MD_CHESS_RECALC_RATINGS, 'form1', 'ratings.php');

        // checkbox (initially unchecked)

        $checked_value = 1;

        $checkbox_confirm_recalc_ratings = new XoopsFormCheckBox('', 'confirm_recalc_ratings', !$checked_value);

        $checkbox_confirm_recalc_ratings->addOption($checked_value, _MD_CHESS_RECALC_CONFIRM);

        $form->addElement($checkbox_confirm_recalc_ratings);

        $form->addElement(new XoopsFormButton('', 'submit_recalc_ratings', _MD_CHESS_SUBMIT_BUTTON, 'submit'));

        $form->assign($xoopsTpl);

        // security token

        // This method is used because form is templated.

        $xoopsTpl->assign('chess_xoops_request_token', is_object($GLOBALS['xoopsSecurity']) ? $GLOBALS['xoopsSecurity']->getTokenHTML() : '');
    }

    // Template variables

    $xoopsTpl->assign('chess_provisional_games', chess_ratings_num_provisional_games());

    $xoopsTpl->assign('chess_msg', $msg);

    $xoopsTpl->assign('chess_msg_class', $msg_class);

    $xoopsTpl->assign('chess_players_pagenav', $pagenav->renderNav());

    $xoopsTpl->assign('chess_players', $players);
}