bookshop_paypal

Complexity

Total Complexity

8

Size/Duplication

Total Lines	89
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getURL()	0	16	4
B	getFormContent()	0	29	3

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 35 and the first side effect is on line 30.

//  ------------------------------------------------------------------------ //
//                      BOOKSHOP - MODULE FOR XOOPS 2                        //
//                  Copyright (c) 2007, 2008 Instant Zero                    //
//                     <http://www.instant-zero.com/>                        //
// ------------------------------------------------------------------------- //
//  This program is free software; you can redistribute it and/or modify     //
//  it under the terms of the GNU General Public License as published by     //
//  the Free Software Foundation; either version 2 of the License, or        //
//  (at your option) any later version.                                      //
//                                                                           //
//  You may not change or alter any portion of this comment or credits       //
//  of supporting developers from this source code or any supporting         //
//  source code which is considered copyrighted (c) material of the          //
//  original comment or credit authors.                                      //
//                                                                           //
//  This program is distributed in the hope that it will be useful,          //
//  but WITHOUT ANY WARRANTY; without even the implied warranty of           //
//  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the            //
//  GNU General Public License for more details.                             //
//                                                                           //
//  You should have received a copy of the GNU General Public License        //
//  along with this program; if not, write to the Free Software              //
//  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307 USA //
//  ------------------------------------------------------------------------ //
/**
 * Classe responsable de la gestion de tout ce qui est relatif à Paypal
 */

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

/**
 * Class bookshop_paypal
 */
class bookshop_paypal

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $testMode;
    public $email;
    public $moneyCode;
    public $useIpn;
    public $passwordCancel;

    /**
     * @param        $testMode
     * @param        $emailPaypal
     * @param        $moneyCode
     * @param bool   $ipn
     * @param string $passwordCancel
     */
    public function __construct($testMode, $emailPaypal, $moneyCode, $ipn = false, $passwordCancel = '')
    {
        $this->testMode       = $testMode;
        $this->email          = $emailPaypal;
        $this->moneyCode      = $moneyCode;
        $this->useIpn         = $ipn;
        $this->passwordCancel = $passwordCancel;
    }

    /**
	 * Renvoie l'url à utiliser en tenant compte du fait qu'on est en mode test ou pas
     *
     * @param bool $securized
     *
     * @return string
     */
    public function getURL($securized = false)
    {
        if (!$securized) {
            if ($this->testMode == 1) {
                return 'https://www.sandbox.paypal.com/cgi-bin/webscr';
            } else {
                return 'https://www.paypal.com/cgi-bin/webscr';
            }
        } else {
            if ($this->testMode == 1) {
                return 'www.sandbox.paypal.com';
            } else {
                return 'www.paypal.com';
            }
        }
    }

    /**
	 * Renvoie les éléments à ajouter au formulaire en tant que zones cachées
     *
     * @param       $commandId
	 * @param float $ttc TTC à facturer
     *
     * @param       $emailClient
     *
     * @internal param int $commmandId Num�ro de la commande
     * @return array
     */
    public function getFormContent($commandId, $ttc, $emailClient)
    {
        global $xoopsConfig;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        $ret                     = array();
        $ret['cmd']              = '_xclick';
        $ret['upload']           = '1';
        $ret['currency_code']    = $this->moneyCode;
        $ret['business']         = $this->email;
		$ret['return'] = BOOKSHOP_URL.'thankyou.php';			// Page (générique) de remerciement après paiement
        $ret['image_url']        = XOOPS_URL . '/images/logo.gif';
        $ret['cpp_header_image'] = XOOPS_URL . '/images/logo.gif';
        $ret['invoice']          = $commandId;
        $ret['item_name']        = _BOOKSHOP_COMMAND . $commandId . ' - ' . $xoopsConfig['sitename'];
        $ret['item_number']      = $commandId;
        $ret['tax']              = 0;    // ajout 25/03/2008

38% of this comment could be valid code. Did you maybe forget this after debugging?

        $ret['amount']           = $ttc;
        $ret['custom']           = $commandId;
		//$ret['rm'] = 2;	// Renvoyer les données par POST (normalement)

60% of this comment could be valid code. Did you maybe forget this after debugging?

        $ret['email'] = $emailClient;
        // paypal_pdt
		if(xoops_trim($this->passwordCancel) != '') {	// URL à laquelle le navigateur du client est ramené si le paiement est annulé
            $ret['cancel_return'] = BOOKSHOP_URL . 'cancel-payment.php?id=' . $this->passwordCancel;
        }
        if ($this->useIpn == 1) {
            $ret['notify_url'] = BOOKSHOP_URL . 'paypal-notify.php';
        }

        return $ret;
    }
}