Issues in xoops_version.php (master) - Issues in master - mambax7/alumni-26x - Measure and Improve Code Quality continuously with Scrutinizer

Issues (884)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

xoops_version.php (11 issues)

Labels

Severity

Minor 11

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */
$moduleDirName = basename(__DIR__);

// ------------------- Informations ------------------- //
$modversion = [
    'name'                => AlumniLocale::MODULE_NAME,
    'description'         => AlumniLocale::MODULE_DESC,
    'official'            => 0,
    //1 indicates supported by XOOPS Dev Team, 0 means 3rd party supported
    'author'              => 'John Mordo',
    'nickname'            => 'jlm69',
    'author_mail'         => 'author-email',
    'author_website_url'  => 'http://jlmzone.com/',
    'author_website_name' => 'JLM Zone',
    'credits'             => 'XOOPS Development Team, John Mordo',
    'license'             => 'GPL 2.0 or later',
    'license_url'         => 'www.gnu.org/licenses/gpl-2.0.html/',
    'help'                => 'page=help',
    //
    'release_info'        => 'Changelog',
    'release_file'        => XOOPS_URL . '/modules/{$moduleDirName}/docs/changelog file',
    //
    'manual'              => 'link to manual file',
    'manual_file'         => XOOPS_URL . '/modules/{$moduleDirName}/docs/install.txt',
    'min_php'             => '5.4.0',
    'min_xoops'           => '2.6.0',
    'min_admin'           => '1.1',
    'min_db'              => [
        'mysql'  => '5.0.7',
        'mysqli' => '5.0.7'
    ],
    // images
    'image'               => 'assets/images/module_logo.png',
    'iconsmall'           => 'assets/images/iconsmall.png',
    'iconbig'             => 'assets/images/iconbig.png',
    'dirname'             => "{$moduleDirName}",
    //Frameworks
    'dirmoduleadmin'      => 'Frameworks/moduleclasses/moduleadmin',
    'sysicons16'          => 'Frameworks/moduleclasses/icons/16',
    'sysicons32'          => 'Frameworks/moduleclasses/icons/32',
    // Local path icons
    'modicons16'          => 'assets/images/icons/16',
    'modicons32'          => 'assets/images/icons/32',
    //About
    'version'             => 3.1,
    'module_status'       => 'Beta 1',
    'release_date'        => '2015/06/03',
    //yyyy/mm/dd
    //    'release'             => '2015-04-04',

    'demo_site_url'       => 'http://www.xoops.org',
    'demo_site_name'      => 'XOOPS Demo Site',
    'support_url'         => 'https://xoops.org/modules/newbb',
    'support_name'        => 'Support Forum',
    'module_website_url'  => 'www.xoops.org',
    'module_website_name' => 'XOOPS Project',
    // paypal
    'paypal'              => [
        'business'      => '[email protected]',
        'item_name'     => 'Donation : ' . AlumniLocale::MODULE_DESC,
        'amount'        => 0,
        'currency_code' => 'USD'
    ],
    // Admin system menu
    'system_menu'         => 1,
    // Admin menu
    'hasAdmin'            => 1,
    'adminindex'          => 'admin/index.php',
    'adminmenu'           => 'admin/menu.php',
    // JQuery
    'jquery'              => 1,
    // Main menu
    'hasMain'             => 1,
    //Search & Comments
    //    'hasSearch'           => 1,

    //    'search'              => array(

    //        'file'   => 'include/search.inc.php',

    //        'func'   => 'XXXX_search'),

    //    'hasComments'         => 1,

    //    'comments'              => array(

    //        'pageName'   => 'index.php',

    //        'itemName'   => 'id'),


    // Install/Update
    'onInstall'           => 'include/oninstall.php',
    'onUpdate'            => 'include/onupdate.php'//  'onUninstall'         => 'include/onuninstall.php'


];

// ------------------- Mysql ------------------- //
$modversion['schema'] = 'sql/schema.yml';

// Tables created by sql file (without prefix!)
$modversion['tables'] = [
    $moduleDirName . '_listing',
    $moduleDirName . '_categories',
    $moduleDirName . '_ip_log'
];

// ------------------- Templates ------------------- //

$modversion['templates'] = [
    ['file' => 'alumni_adlist.tpl', 'description' => ''],
    ['file' => 'alumni_category.tpl', 'description' => ''],
    ['file' => 'alumni_index.tpl', 'description' => ''],
    ['file' => 'alumni_item.tpl', 'description' => ''],
    ['file' => 'alumni_search.tpl', 'description' => ''],
    ['file' => 'alumni_sendfriend.tpl', 'description' => ''],
    ['file' => '/admin/alumni_admin_cat.tpl', 'description' => ''],
    ['file' => '/admin/alumni_admin_listing.tpl', 'description' => ''],
    ['file' => '/admin/alumni_admin_moderated.tpl', 'description' => ''],
    ['file' => '/admin/alumni_admin_permissions.tpl', 'description' => ''],
    ['file' => '/blocks/alumni_block_new.tpl', 'description' => '']
];

// ------------------- Blocks ------------------- //
//blocks should or don't have have hardcoded numbers?
/*
$modversion['blocks'][] = array(
    'file'        => 'alumni.php',
    'name'        => constant($blocksLang . '_BNAME'),
    'description' => constant($blocksLang . '_BNAME_DESC'),
    'show_func'   => 'alumni_show',
    'edit_func'   => 'alumni_edit',
    'template'    => 'alumni_block_new.tpl',
    //    'can_clone'     => true,
    'options'     => 'date|10|25|0');
*/

$modversion['blocks'][] = [
    'file' => 'alumni.php',
    'name' => AlumniLocale::CONF_BNAME,
    'description' => AlumniLocale::CONF_BNAME_DESC,
    'show_func'   => 'alumni_show',
    'edit_func'   => 'alumni_edit',
    'template'    => 'alumni_block_new.tpl',
    'can_clone'   => true,
    'options'     => 'date|10|25|0'
];

// Search
$modversion['hasSearch'] = 1;

$i = 0;

// $xoopsModuleConfig['alumni_moderated']
$modversion['config'][] = [
    'name'        => 'alumni_moderated',
    'title'       => AlumniLocale::CONF_MODERATE,
    'description' => '',
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '0',
    'options'     => []
];

// $xoopsModuleConfig['alumni_per_page']
$modversion['config'][] = [
    'name'        => 'alumni_per_page',
    'title'       => AlumniLocale::CONF_PERPAGE,
    'description' => '',
    'formtype'    => 'select',
    'valuetype'   => 'int',
    'default'     => '10',
    'options'     => ['10' => 10, '15' => 15, '20' => 20, '25' => 25, '30' => 30, '35' => 35, '40' => 40, '50' => 50]
];

// $xoopsModuleConfig['alumni_new_listing']
$modversion['config'][] = [
    'name'        => 'alumni_new_listing',
    'title'       => AlumniLocale::CONF_SHOW_NEW,
    'description' => AlumniLocale::CONF_ONHOME,
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

// $xoopsModuleConfig['alumni_newalumni']
$modversion['config'][] = [
    'name'        => 'alumni_newalumni',
    'title'       => AlumniLocale::CONF_NUMNEW,
    'description' => AlumniLocale::CONF_ONHOME,
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '10',
    'options'     => []
];

// $xoopsModuleConfig['alumni_countday']
$modversion['config'][] = [
    'name'        => 'alumni_countday',
    'title'       => AlumniLocale::CONF_NEWTIME,
    'description' => AlumniLocale::CONF_INDAYS,
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '3',
    'options'     => []
];

// $xoopsModuleConfig['alumni_photomax']
$modversion['config'][] = [
    'name'        => 'alumni_photomax',
    'title'       => AlumniLocale::CONF_MAXFILESIZE,
    'description' => AlumniLocale::CONF_INBYTES,
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '500000',
    'options'     => []
];

// $xoopsModuleConfig['alumni_maxwide']
$modversion['config'][] = [
    'name'        => 'alumni_maxwide',
    'title'       => AlumniLocale::CONF_MAXWIDE,
    'description' => AlumniLocale::CONF_INPIXEL,
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '700',
    'options'     => []
];

// $xoopsModuleConfig['alumni_maxhigh']
$modversion['config'][] = [
    'name'        => 'alumni_maxhigh',
    'title'       => AlumniLocale::CONF_MAXHIGH,
    'description' => AlumniLocale::CONF_INPIXEL,
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '1000',
    'options'     => []
];


// $xoopsModuleConfig['alumni_showsubcat']
$modversion['config'][] = [
    'name'        => 'alumni_showsubcat',
    'title'       => AlumniLocale::CONF_DISPLSUBCAT,
    'description' => AlumniLocale::CONF_ONHOME,
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

// $xoopsModuleConfig['alumni_numsubcat']
$modversion['config'][] = [
    'name'        => 'alumni_numsubcat',
    'title'       => AlumniLocale::CONF_NUMSUBCAT,
    'description' => '',
    'formtype'    => 'textbox',
    'valuetype'   => 'int',
    'default'     => '4',
    'options'     => []
];

// $xoopsModuleConfig['alumni_csortorder']
$modversion['config'][] = [
    'name'        => 'alumni_csortorder',
    'title'       => AlumniLocale::CONF_CORDER,
    'description' => '',
    'formtype'    => 'select',
    'valuetype'   => 'text',
    'default'     => 'title',
    'options'     => [AlumniLocale::CONF_ORDERALPHA => 'title', AlumniLocale::CONF_ORDERPERSONAL => 'ordre']
];

// $xoopsModuleConfig['alumni_lsortorder']
$modversion['config'][] = [
    'name'        => 'alumni_lsortorder',
    'title'       => AlumniLocale::CONF_LORDER,
    'description' => '',
    'formtype'    => 'select',
    'valuetype'   => 'text',
    'default'     => 'name',
    'options'     => [AlumniLocale::CONF_ORDER_DATE => 'date DESC', AlumniLocale::CONF_ORDER_NAME => 'name ASC', AlumniLocale::CONF_ORDER_POP => 'hits DESC']
];

// $xoopsModuleConfig['alumni_form_options'] - Use WYSIWYG Editors?


$editors = XoopsLists::getDirListAsArray(XOOPS_ROOT_PATH . '/class/xoopseditor');

$modversion['config'][] = [
    'name'        => 'alumni_form_options',
    'title'       => AlumniLocale::CONF_EDITOR,
    'description' => AlumniLocale::CONF_LIST_EDITORS,
    'formtype'    => 'select',
    'valuetype'   => 'text',
    'default'     => 'dhtmltextarea',
    'options'     => $editors
];


// $xoopsModuleConfig['alumni_use_captcha']
$modversion['config'][] = [
    'name'        => 'alumni_use_captcha',
    'title'       => AlumniLocale::CONF_USE_CAPTCHA,
    'description' => '',
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

// $xoopsModuleConfig['alumni_use_code']
$modversion['config'][] = [
    'name'        => 'alumni_use_code',
    'title'       => AlumniLocale::CONF_USE_INDEX_CODE,
    'description' => AlumniLocale::CONF_USE_INDEX_CODE_DESC,
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

// $xoopsModuleConfig['alumni_use_banner']
$modversion['config'][] = [
    'name'        => 'alumni_use_banner',
    'title'       => AlumniLocale::CONF_USE_BANNER,
    'description' => AlumniLocale::CONF_USE_BANNER_DESC,
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

// $xoopsModuleConfig['alumni_index_code']
$modversion['config'][] = [
    'name'        => 'alumni_index_code',
    'title'       => AlumniLocale::CONF_INDEX_CODE,
    'description' => AlumniLocale::CONF_INDEX_CODE_DESC,
    'formtype'    => 'textarea',
    'valuetype'   => 'text',
    'default'     => ''

];

// $xoopsModuleConfig['alumni_index_code_place']
$modversion['config'][] = [
    'name'        => 'alumni_code_place',
    'title'       => AlumniLocale::CONF_INDEX_CODE_PLACE,
    'description' => AlumniLocale::CONF_INDEX_CODE_PLACE_DESC,
    'formtype'    => 'textbox',
    'valuetype'   => 'text',
    'default'     => '5'
];

// $xoopsModuleConfig['alumni_offer_search'] - added for optional search
$modversion['config'][] = [
    'name'        => 'alumni_offer_search',
    'title'       => AlumniLocale::CONF_OFFER_SEARCH,
    'description' => AlumniLocale::CONF_OFFER_SEARCH_DESC,
    'formtype'    => 'yesno',
    'valuetype'   => 'int',
    'default'     => '1',
    'options'     => []
];

$modversion['notification']    = [];
$modversion['hasNotification'] = 1;


1			<?php
2			/*
3			You may not change or alter any portion of this comment or credits
4			of supporting developers from this source code or any supporting source code
5			which is considered copyrighted (c) material of the original comment or credit authors.
6
7			This program is distributed in the hope that it will be useful,
8			but WITHOUT ANY WARRANTY; without even the implied warranty of
9			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10			*/
11			/**
12			* Alumni module for Xoops
13			*
14			* @copyright XOOPS Project https://xoops.org/
15			* @license GPL 2.0 or later
16			* @package alumni
17			* @since 2.6.x
18			* @author John Mordo (jlm69)
19			*/
20			$moduleDirName = basename(__DIR__);
21
22			// ------------------- Informations ------------------- //
23			$modversion = [
24			'name' => AlumniLocale::MODULE_NAME,
25			'description' => AlumniLocale::MODULE_DESC,
26			'official' => 0,
27			//1 indicates supported by XOOPS Dev Team, 0 means 3rd party supported
28			'author' => 'John Mordo',
29			'nickname' => 'jlm69',
30			'author_mail' => 'author-email',
31			'author_website_url' => 'http://jlmzone.com/',
32			'author_website_name' => 'JLM Zone',
33			'credits' => 'XOOPS Development Team, John Mordo',
34			'license' => 'GPL 2.0 or later',
35			'license_url' => 'www.gnu.org/licenses/gpl-2.0.html/',
36			'help' => 'page=help',
37			//
38			'release_info' => 'Changelog',
39			'release_file' => XOOPS_URL . '/modules/{$moduleDirName}/docs/changelog file',
40			//
41			'manual' => 'link to manual file',
42			'manual_file' => XOOPS_URL . '/modules/{$moduleDirName}/docs/install.txt',
43			'min_php' => '5.4.0',
44			'min_xoops' => '2.6.0',
45			'min_admin' => '1.1',
46			'min_db' => [
47			'mysql' => '5.0.7',
48			'mysqli' => '5.0.7'
49			],
50			// images
51			'image' => 'assets/images/module_logo.png',
52			'iconsmall' => 'assets/images/iconsmall.png',
53			'iconbig' => 'assets/images/iconbig.png',
54			'dirname' => "{$moduleDirName}",
55			//Frameworks
56			'dirmoduleadmin' => 'Frameworks/moduleclasses/moduleadmin',
57			'sysicons16' => 'Frameworks/moduleclasses/icons/16',
58			'sysicons32' => 'Frameworks/moduleclasses/icons/32',
59			// Local path icons
60			'modicons16' => 'assets/images/icons/16',
61			'modicons32' => 'assets/images/icons/32',
62			//About
63			'version' => 3.1,
64			'module_status' => 'Beta 1',
65			'release_date' => '2015/06/03',
66			//yyyy/mm/dd
67			// 'release' => '2015-04-04',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
68			'demo_site_url' => 'http://www.xoops.org',
69			'demo_site_name' => 'XOOPS Demo Site',
70			'support_url' => 'https://xoops.org/modules/newbb',
71			'support_name' => 'Support Forum',
72			'module_website_url' => 'www.xoops.org',
73			'module_website_name' => 'XOOPS Project',
74			// paypal
75			'paypal' => [
76			'business' => '[email protected]',
77			'item_name' => 'Donation : ' . AlumniLocale::MODULE_DESC,
78			'amount' => 0,
79			'currency_code' => 'USD'
80			],
81			// Admin system menu
82			'system_menu' => 1,
83			// Admin menu
84			'hasAdmin' => 1,
85			'adminindex' => 'admin/index.php',
86			'adminmenu' => 'admin/menu.php',
87			// JQuery
88			'jquery' => 1,
89			// Main menu
90			'hasMain' => 1,
91			//Search & Comments
92			// 'hasSearch' => 1,
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
93			// 'search' => array(
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
94			// 'file' => 'include/search.inc.php',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
95			// 'func' => 'XXXX_search'),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
96			// 'hasComments' => 1,
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
97			// 'comments' => array(
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
98			// 'pageName' => 'index.php',
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
99			// 'itemName' => 'id'),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
100
101			// Install/Update
102			'onInstall' => 'include/oninstall.php',
103			'onUpdate' => 'include/onupdate.php'// 'onUninstall' => 'include/onuninstall.php'
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
104
105			];
106
107			// ------------------- Mysql ------------------- //
108			$modversion['schema'] = 'sql/schema.yml';
109
110			// Tables created by sql file (without prefix!)
111			$modversion['tables'] = [
112			$moduleDirName . '_listing',
113			$moduleDirName . '_categories',
114			$moduleDirName . '_ip_log'
115			];
116
117			// ------------------- Templates ------------------- //
118
119			$modversion['templates'] = [
120			['file' => 'alumni_adlist.tpl', 'description' => ''],
121			['file' => 'alumni_category.tpl', 'description' => ''],
122			['file' => 'alumni_index.tpl', 'description' => ''],
123			['file' => 'alumni_item.tpl', 'description' => ''],
124			['file' => 'alumni_search.tpl', 'description' => ''],
125			['file' => 'alumni_sendfriend.tpl', 'description' => ''],
126			['file' => '/admin/alumni_admin_cat.tpl', 'description' => ''],
127			['file' => '/admin/alumni_admin_listing.tpl', 'description' => ''],
128			['file' => '/admin/alumni_admin_moderated.tpl', 'description' => ''],
129			['file' => '/admin/alumni_admin_permissions.tpl', 'description' => ''],
130			['file' => '/blocks/alumni_block_new.tpl', 'description' => '']
131			];
132
133			// ------------------- Blocks ------------------- //
134			//blocks should or don't have have hardcoded numbers?
135			/*
136			$modversion['blocks'][] = array(
137			'file' => 'alumni.php',
138			'name' => constant($blocksLang . '_BNAME'),
139			'description' => constant($blocksLang . '_BNAME_DESC'),
140			'show_func' => 'alumni_show',
141			'edit_func' => 'alumni_edit',
142			'template' => 'alumni_block_new.tpl',
143			// 'can_clone' => true,
144			'options' => 'date\|10\|25\|0');
145			*/
146
147			$modversion['blocks'][] = [
148			'file' => 'alumni.php',
149			'name' => AlumniLocale::CONF_BNAME,
150			'description' => AlumniLocale::CONF_BNAME_DESC,
151			'show_func' => 'alumni_show',
152			'edit_func' => 'alumni_edit',
153			'template' => 'alumni_block_new.tpl',
154			'can_clone' => true,
155			'options' => 'date\|10\|25\|0'
156			];
157
158			// Search
159			$modversion['hasSearch'] = 1;
160
161			$i = 0;
162
163			// $xoopsModuleConfig['alumni_moderated']
164			$modversion['config'][] = [
165			'name' => 'alumni_moderated',
166			'title' => AlumniLocale::CONF_MODERATE,
167			'description' => '',
168			'formtype' => 'yesno',
169			'valuetype' => 'int',
170			'default' => '0',
171			'options' => []
172			];
173
174			// $xoopsModuleConfig['alumni_per_page']
175			$modversion['config'][] = [
176			'name' => 'alumni_per_page',
177			'title' => AlumniLocale::CONF_PERPAGE,
178			'description' => '',
179			'formtype' => 'select',
180			'valuetype' => 'int',
181			'default' => '10',
182			'options' => ['10' => 10, '15' => 15, '20' => 20, '25' => 25, '30' => 30, '35' => 35, '40' => 40, '50' => 50]
183			];
184
185			// $xoopsModuleConfig['alumni_new_listing']
186			$modversion['config'][] = [
187			'name' => 'alumni_new_listing',
188			'title' => AlumniLocale::CONF_SHOW_NEW,
189			'description' => AlumniLocale::CONF_ONHOME,
190			'formtype' => 'yesno',
191			'valuetype' => 'int',
192			'default' => '1',
193			'options' => []
194			];
195
196			// $xoopsModuleConfig['alumni_newalumni']
197			$modversion['config'][] = [
198			'name' => 'alumni_newalumni',
199			'title' => AlumniLocale::CONF_NUMNEW,
200			'description' => AlumniLocale::CONF_ONHOME,
201			'formtype' => 'textbox',
202			'valuetype' => 'int',
203			'default' => '10',
204			'options' => []
205			];
206
207			// $xoopsModuleConfig['alumni_countday']
208			$modversion['config'][] = [
209			'name' => 'alumni_countday',
210			'title' => AlumniLocale::CONF_NEWTIME,
211			'description' => AlumniLocale::CONF_INDAYS,
212			'formtype' => 'textbox',
213			'valuetype' => 'int',
214			'default' => '3',
215			'options' => []
216			];
217
218			// $xoopsModuleConfig['alumni_photomax']
219			$modversion['config'][] = [
220			'name' => 'alumni_photomax',
221			'title' => AlumniLocale::CONF_MAXFILESIZE,
222			'description' => AlumniLocale::CONF_INBYTES,
223			'formtype' => 'textbox',
224			'valuetype' => 'int',
225			'default' => '500000',
226			'options' => []
227			];
228
229			// $xoopsModuleConfig['alumni_maxwide']
230			$modversion['config'][] = [
231			'name' => 'alumni_maxwide',
232			'title' => AlumniLocale::CONF_MAXWIDE,
233			'description' => AlumniLocale::CONF_INPIXEL,
234			'formtype' => 'textbox',
235			'valuetype' => 'int',
236			'default' => '700',
237			'options' => []
238			];
239
240			// $xoopsModuleConfig['alumni_maxhigh']
241			$modversion['config'][] = [
242			'name' => 'alumni_maxhigh',
243			'title' => AlumniLocale::CONF_MAXHIGH,
244			'description' => AlumniLocale::CONF_INPIXEL,
245			'formtype' => 'textbox',
246			'valuetype' => 'int',
247			'default' => '1000',
248			'options' => []
249			];
250
251
252			// $xoopsModuleConfig['alumni_showsubcat']
253			$modversion['config'][] = [
254			'name' => 'alumni_showsubcat',
255			'title' => AlumniLocale::CONF_DISPLSUBCAT,
256			'description' => AlumniLocale::CONF_ONHOME,
257			'formtype' => 'yesno',
258			'valuetype' => 'int',
259			'default' => '1',
260			'options' => []
261			];
262
263			// $xoopsModuleConfig['alumni_numsubcat']
264			$modversion['config'][] = [
265			'name' => 'alumni_numsubcat',
266			'title' => AlumniLocale::CONF_NUMSUBCAT,
267			'description' => '',
268			'formtype' => 'textbox',
269			'valuetype' => 'int',
270			'default' => '4',
271			'options' => []
272			];
273
274			// $xoopsModuleConfig['alumni_csortorder']
275			$modversion['config'][] = [
276			'name' => 'alumni_csortorder',
277			'title' => AlumniLocale::CONF_CORDER,
278			'description' => '',
279			'formtype' => 'select',
280			'valuetype' => 'text',
281			'default' => 'title',
282			'options' => [AlumniLocale::CONF_ORDERALPHA => 'title', AlumniLocale::CONF_ORDERPERSONAL => 'ordre']
283			];
284
285			// $xoopsModuleConfig['alumni_lsortorder']
286			$modversion['config'][] = [
287			'name' => 'alumni_lsortorder',
288			'title' => AlumniLocale::CONF_LORDER,
289			'description' => '',
290			'formtype' => 'select',
291			'valuetype' => 'text',
292			'default' => 'name',
293			'options' => [AlumniLocale::CONF_ORDER_DATE => 'date DESC', AlumniLocale::CONF_ORDER_NAME => 'name ASC', AlumniLocale::CONF_ORDER_POP => 'hits DESC']
294			];
295
296			// $xoopsModuleConfig['alumni_form_options'] - Use WYSIWYG Editors?
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
297
298			$editors = XoopsLists::getDirListAsArray(XOOPS_ROOT_PATH . '/class/xoopseditor');
299
300			$modversion['config'][] = [
301			'name' => 'alumni_form_options',
302			'title' => AlumniLocale::CONF_EDITOR,
303			'description' => AlumniLocale::CONF_LIST_EDITORS,
304			'formtype' => 'select',
305			'valuetype' => 'text',
306			'default' => 'dhtmltextarea',
307			'options' => $editors
308			];
309
310
311			// $xoopsModuleConfig['alumni_use_captcha']
312			$modversion['config'][] = [
313			'name' => 'alumni_use_captcha',
314			'title' => AlumniLocale::CONF_USE_CAPTCHA,
315			'description' => '',
316			'formtype' => 'yesno',
317			'valuetype' => 'int',
318			'default' => '1',
319			'options' => []
320			];
321
322			// $xoopsModuleConfig['alumni_use_code']
323			$modversion['config'][] = [
324			'name' => 'alumni_use_code',
325			'title' => AlumniLocale::CONF_USE_INDEX_CODE,
326			'description' => AlumniLocale::CONF_USE_INDEX_CODE_DESC,
327			'formtype' => 'yesno',
328			'valuetype' => 'int',
329			'default' => '1',
330			'options' => []
331			];
332
333			// $xoopsModuleConfig['alumni_use_banner']
334			$modversion['config'][] = [
335			'name' => 'alumni_use_banner',
336			'title' => AlumniLocale::CONF_USE_BANNER,
337			'description' => AlumniLocale::CONF_USE_BANNER_DESC,
338			'formtype' => 'yesno',
339			'valuetype' => 'int',
340			'default' => '1',
341			'options' => []
342			];
343
344			// $xoopsModuleConfig['alumni_index_code']
345			$modversion['config'][] = [
346			'name' => 'alumni_index_code',
347			'title' => AlumniLocale::CONF_INDEX_CODE,
348			'description' => AlumniLocale::CONF_INDEX_CODE_DESC,
349			'formtype' => 'textarea',
350			'valuetype' => 'text',
351			'default' => ''
352
353			];
354
355			// $xoopsModuleConfig['alumni_index_code_place']
356			$modversion['config'][] = [
357			'name' => 'alumni_code_place',
358			'title' => AlumniLocale::CONF_INDEX_CODE_PLACE,
359			'description' => AlumniLocale::CONF_INDEX_CODE_PLACE_DESC,
360			'formtype' => 'textbox',
361			'valuetype' => 'text',
362			'default' => '5'
363			];
364
365			// $xoopsModuleConfig['alumni_offer_search'] - added for optional search
366			$modversion['config'][] = [
367			'name' => 'alumni_offer_search',
368			'title' => AlumniLocale::CONF_OFFER_SEARCH,
369			'description' => AlumniLocale::CONF_OFFER_SEARCH_DESC,
370			'formtype' => 'yesno',
371			'valuetype' => 'int',
372			'default' => '1',
373			'options' => []
374			];
375
376			$modversion['notification'] = [];
377			$modversion['hasNotification'] = 1;
378

mambax7 / alumni-26x

Issues (884)

Security Analysis no request data

xoops_version.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like