Issues in sendfriend.php (master) - Issues in master - mambax7/alumni-26x - Measure and Improve Code Quality continuously with Scrutinizer

Issues (884)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

sendfriend.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */

use Xoops\Core\Request;

include __DIR__ . '/header.php';
$xoops         = Xoops::getInstance();
$myts          = MyTextSanitizer::getInstance();
$moduleDirName = basename(__DIR__);

//if (!empty($_POST['submit'])) {
if (Request::getString('submit', '', 'POST')) {
    if ('1' == $xoops->getModuleConfig('alumni_use_captcha') && !$xoops->user->isAdmin()) {
        $xoopsCaptcha = XoopsCaptcha::getInstance();
        if (!$xoopsCaptcha->verify()) {
            $xoops->redirect(XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/index.php', 4, $xoopsCaptcha->getMessage());
            exit(0);
        }
    }
    //       if (!$xoops->security()->check()) {
    //           $xoops->redirect('javascript:history.go(-1)', 3, implode(',', $xoops->security()->getErrors()));
    //       }

    $yname = Request::getString('yname', '', 'POST'); //$_POST['yname'];
    $ymail = Request::getString('ymail', '', 'POST'); //$_POST['ymail'];
    $fname = Request::getString('fname', '', 'POST'); //$_POST['fname'];
    $fmail = Request::getString('fmail', '', 'POST'); //$_POST['fmail'];

    $lid = Request::getInt('lid', 0);

    $alumni   = Alumni::getInstance();
    $helper   = Xoops::getModuleHelper('alumni');
    $moduleId = $helper->getModule()->getVar('mid');

    $groups           = $xoops->isUser() ? $xoops->user->getGroups() : '3';
    $alumni_ids       = $xoops->getHandlerGroupPermission()->getItemIds('alumni_view', $groups, $moduleId);
    $listingHandler   = $xoops->getModuleHandler('listing', 'alumni');
    $listing_criteria = new CriteriaCompo();
    $listing_criteria->add(new Criteria('lid', $lid, '='));
    $listing_criteria->add(new Criteria('cid', '(' . implode(', ', $alumni_ids) . ')', 'IN'));
    $numrows = $listingHandler->getCount($listing_criteria);

    $listingArray = $listingHandler->getAll($listing_criteria);
    unset($listing_criteria);
    foreach (array_keys($listingArray) as $i) {
        $lid        = $listingArray[$i]->getVar('lid');
        $cid        = $listingArray[$i]->getVar('cid');
        $name       = $listingArray[$i]->getVar('name');
        $mname      = $listingArray[$i]->getVar('mname');
        $lname      = $listingArray[$i]->getVar('lname');
        $school     = $listingArray[$i]->getVar('school');
        $year       = $listingArray[$i]->getVar('year');
        $studies    = $listingArray[$i]->getVar('studies');
        $activities = $listingArray[$i]->getVar('activities');
        $extrainfo  = $listingArray[$i]->getVar('extrainfo');
        $occ        = $listingArray[$i]->getVar('occ');
        $date       = $listingArray[$i]->getVar('date');
        $email      = $listingArray[$i]->getVar('email');
        $submitter  = $listingArray[$i]->getVar('submitter');
        $usid       = $listingArray[$i]->getVar('usid');
        $town       = $listingArray[$i]->getVar('town');
        $valid      = $listingArray[$i]->getVar('valid');
        $photo      = $listingArray[$i]->getVar('photo');
        $photo2     = $listingArray[$i]->getVar('photo2');
        $view       = $listingArray[$i]->getVar('view');

        $useroffset = '';
        if ($xoopsUser) {
            $timezone = $xoopsUser->timezone();
            if (isset($timezone)) {
                $useroffset = $xoopsUser->timezone();
            } else {
                $useroffset = $xoopsConfig['default_TZ'];
            }
        }
        $date       = ($useroffset * 3600) + $date;
        $date       = XoopsLocale::formatTimestamp($date, 's');
        $name       = $myts->htmlSpecialChars($name);
        $mname      = $myts->htmlSpecialChars($mname);
        $lname      = $myts->htmlSpecialChars($lname);
        $school     = $myts->htmlSpecialChars($school);
        $year       = $myts->htmlSpecialChars($year);
        $studies    = $myts->htmlSpecialChars($studies);
        $activities = $myts->displayTarea($activities, 1, 0, 1, 1, 1);
        $occ        = $myts->htmlSpecialChars($occ);
        $submitter  = $myts->htmlSpecialChars($submitter);
        $town       = $myts->htmlSpecialChars($town);

        $tags                       = [];
        $tags['YNAME']              = $yname;
        $tags['YMAIL']              = $ymail;
        $tags['FNAME']              = $fname;
        $tags['FMAIL']              = $fmail;
        $tags['HELLO']              = AlumniLocale::HELLO;
        $tags['LID']                = $lid;
        $tags['CLASSOF']            = AlumniLocale::CLASSOF;
        $tags['NAME']               = $name;
        $tags['MNAME']              = $mname;
        $tags['LNAME']              = $lname;
        $tags['SCHOOL']             = $school;
        $tags['STUDIES']            = $studies;
        $tags['TOWN']               = $town;
        $tags['YEAR']               = $year;
        $tags['OTHER']              = '' . AlumniLocale::INTERESTED . ' ' . $xoopsConfig['sitename'] . '';
        $tags['LISTINGS']           = '' . XOOPS_URL . "/modules/{$moduleDirName}/";
        $tags['LINK_URL']           = '' . XOOPS_URL . "/modules/{$moduleDirName}/listing.php?lid=" . addslashes($lid) . '';
        $tags['THINKS_INTERESTING'] = '' . AlumniLocale::MESSAGE . '';
        $tags['YOU_CAN_VIEW_BELOW'] = '' . AlumniLocale::YOU_CAN_VIEW_BELOW . '';
        $tags['WEBMASTER']          = AlumniLocale::WEBMASTER;
        $tags['NO_REPLY']           = AlumniLocale::NO_REPLY;
        $subject                    = '' . AlumniLocale::SUBJECT . ' ' . $xoopsConfig['sitename'] . '';

        $xoopsMailer = $xoops->getMailer();
        $xoopsMailer->useMail();
        $xoopsMailer->setTemplateDir(XOOPS_ROOT_PATH . "/modules/{$moduleDirName}/language/english/mail_template/");
        $xoopsMailer->setTemplate('listing_send_friend.tpl');
        $xoopsMailer->setFromEmail($ymail);
        $xoopsMailer->setToEmails($fmail);
        $xoopsMailer->setSubject($subject);
        //    $xoopsMailer->$xoops->multimailer;
        $xoopsMailer->assign($tags);
        $xoopsMailer->send();
        echo $xoopsMailer->getErrors();

        $xoops->redirect('index.php', 3, AlumniLocale::ALUM_SEND);
        exit();
    }
} else {
    global $xoops;
function myFunction($a, $b) {
    // Do something
}

    $lid = Request::getInt('lid', 0);
    $xoops->header('alumni_sendfriend.tpl');

    include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';

    $listingHandler = $xoops->getModuleHandler('listing', $moduleDirName);
    $listing_2_send = $listingHandler->get($lid);

    $listing_2_send->getVar('name');
    $listing_2_send->getVar('mname');
    $listing_2_send->getVar('lname');

    ob_start();
    $form = new Xoops\Form\ThemeForm(AlumniLocale::SENDTO, 'sendfriend_form', 'sendfriend.php');
    $form->setExtra('enctype="multipart/form-data"');
    //    $GLOBALS['xoopsGTicket']->addTicketXoopsFormElement($form, __LINE__, 1800, 'token');
    $form->addElement(new Xoops\Form\Label(AlumniLocale::LISTING_SEND, $listing_2_send->getVar('name') . ' ' . $listing_2_send->getVar('mname') . ' ' . $listing_2_send->getVar('lname') . ''));
    if ($xoopsUser) {
        $idd  = $xoopsUser->getVar('name', 'E');
        $idde = $xoopsUser->getVar('email', 'E');
    }

    $form->addElement(new Xoops\Form\Text(XoopsLocale::C_YOUR_NAME, 'yname', 30, 50, $idd), true);
    $form->addElement(new Xoops\Form\Text(XoopsLocale::C_YOUR_EMAIL, 'ymail', 30, 60, $idde), true);
    $form->addElement(new Xoops\Form\Text(AlumniLocale::NAMEFR, 'fname', 30, 60, ''), true);
    $form->addElement(new Xoops\Form\Text(AlumniLocale::MAILFR, 'fmail', 30, 60, ''), true);

    if ('1' == $xoops->getModuleConfig('alumni_use_captcha') && !$xoops->user->isAdmin()) {
        $form->addElement(new XoopsFormCaptcha());
    }
    //   $form->addElement(new Xoops\Form\Hidden('security', $xoops->security()->createToken()));
    $form->addElement(new Xoops\Form\Hidden('lid', $lid), false);
    $form->addElement(new Xoops\Form\Button('', 'submit', XoopsLocale::A_SUBMIT, 'submit'));
    $form->display();
    $xoopsTpl->assign('sendfriend_form', ob_get_contents());

    ob_end_clean();
}
Xoops::getInstance()->footer();


1		<?php
2		/*
3		You may not change or alter any portion of this comment or credits
4		of supporting developers from this source code or any supporting source code
5		which is considered copyrighted (c) material of the original comment or credit authors.
6
7		This program is distributed in the hope that it will be useful,
8		but WITHOUT ANY WARRANTY; without even the implied warranty of
9		MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
10		*/
11
12		/**
13		* Alumni module for Xoops
14		*
15		* @copyright XOOPS Project https://xoops.org/
16		* @license GPL 2.0 or later
17		* @package alumni
18		* @since 2.6.x
19		* @author John Mordo (jlm69)
20		*/
21
22		use Xoops\Core\Request;
23
24		include __DIR__ . '/header.php';
25		$xoops = Xoops::getInstance();
26		$myts = MyTextSanitizer::getInstance();
27		$moduleDirName = basename(__DIR__);
28
29		//if (!empty($_POST['submit'])) {
30		if (Request::getString('submit', '', 'POST')) {
31	View Code Duplication	if ('1' == $xoops->getModuleConfig('alumni_use_captcha') && !$xoops->user->isAdmin()) {
32		$xoopsCaptcha = XoopsCaptcha::getInstance();
33		if (!$xoopsCaptcha->verify()) {
34		$xoops->redirect(XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname') . '/index.php', 4, $xoopsCaptcha->getMessage());
35		exit(0);
36		}
37		}
38		// if (!$xoops->security()->check()) {
39		// $xoops->redirect('javascript:history.go(-1)', 3, implode(',', $xoops->security()->getErrors()));
40		// }
41
42		$yname = Request::getString('yname', '', 'POST'); //$_POST['yname'];
43		$ymail = Request::getString('ymail', '', 'POST'); //$_POST['ymail'];
44		$fname = Request::getString('fname', '', 'POST'); //$_POST['fname'];
45		$fmail = Request::getString('fmail', '', 'POST'); //$_POST['fmail'];
46
47		$lid = Request::getInt('lid', 0);
48
49		$alumni = Alumni::getInstance();
50		$helper = Xoops::getModuleHelper('alumni');
51		$moduleId = $helper->getModule()->getVar('mid');
52
53		$groups = $xoops->isUser() ? $xoops->user->getGroups() : '3';
54		$alumni_ids = $xoops->getHandlerGroupPermission()->getItemIds('alumni_view', $groups, $moduleId);
55		$listingHandler = $xoops->getModuleHandler('listing', 'alumni');
56		$listing_criteria = new CriteriaCompo();
57		$listing_criteria->add(new Criteria('lid', $lid, '='));
58		$listing_criteria->add(new Criteria('cid', '(' . implode(', ', $alumni_ids) . ')', 'IN'));
59		$numrows = $listingHandler->getCount($listing_criteria);
60
61		$listingArray = $listingHandler->getAll($listing_criteria);
62		unset($listing_criteria);
63		foreach (array_keys($listingArray) as $i) {
64		$lid = $listingArray[$i]->getVar('lid');
65		$cid = $listingArray[$i]->getVar('cid');
66		$name = $listingArray[$i]->getVar('name');
67		$mname = $listingArray[$i]->getVar('mname');
68		$lname = $listingArray[$i]->getVar('lname');
69		$school = $listingArray[$i]->getVar('school');
70		$year = $listingArray[$i]->getVar('year');
71		$studies = $listingArray[$i]->getVar('studies');
72		$activities = $listingArray[$i]->getVar('activities');
73		$extrainfo = $listingArray[$i]->getVar('extrainfo');
74		$occ = $listingArray[$i]->getVar('occ');
75		$date = $listingArray[$i]->getVar('date');
76		$email = $listingArray[$i]->getVar('email');
77		$submitter = $listingArray[$i]->getVar('submitter');
78		$usid = $listingArray[$i]->getVar('usid');
79		$town = $listingArray[$i]->getVar('town');
80		$valid = $listingArray[$i]->getVar('valid');
81		$photo = $listingArray[$i]->getVar('photo');
82		$photo2 = $listingArray[$i]->getVar('photo2');
83		$view = $listingArray[$i]->getVar('view');
84
85		$useroffset = '';
86	View Code Duplication	if ($xoopsUser) {
87		$timezone = $xoopsUser->timezone();
88		if (isset($timezone)) {
89		$useroffset = $xoopsUser->timezone();
90		} else {
91		$useroffset = $xoopsConfig['default_TZ'];
92		}
93		}
94		$date = ($useroffset * 3600) + $date;
95		$date = XoopsLocale::formatTimestamp($date, 's');
96		$name = $myts->htmlSpecialChars($name);
97		$mname = $myts->htmlSpecialChars($mname);
98		$lname = $myts->htmlSpecialChars($lname);
99		$school = $myts->htmlSpecialChars($school);
100		$year = $myts->htmlSpecialChars($year);
101		$studies = $myts->htmlSpecialChars($studies);
102		$activities = $myts->displayTarea($activities, 1, 0, 1, 1, 1);
103		$occ = $myts->htmlSpecialChars($occ);
104		$submitter = $myts->htmlSpecialChars($submitter);
105		$town = $myts->htmlSpecialChars($town);
106
107		$tags = [];
108		$tags['YNAME'] = $yname;
109		$tags['YMAIL'] = $ymail;
110		$tags['FNAME'] = $fname;
111		$tags['FMAIL'] = $fmail;
112		$tags['HELLO'] = AlumniLocale::HELLO;
113		$tags['LID'] = $lid;
114		$tags['CLASSOF'] = AlumniLocale::CLASSOF;
115		$tags['NAME'] = $name;
116		$tags['MNAME'] = $mname;
117		$tags['LNAME'] = $lname;
118		$tags['SCHOOL'] = $school;
119		$tags['STUDIES'] = $studies;
120		$tags['TOWN'] = $town;
121		$tags['YEAR'] = $year;
122		$tags['OTHER'] = '' . AlumniLocale::INTERESTED . ' ' . $xoopsConfig['sitename'] . '';
123		$tags['LISTINGS'] = '' . XOOPS_URL . "/modules/{$moduleDirName}/";
124		$tags['LINK_URL'] = '' . XOOPS_URL . "/modules/{$moduleDirName}/listing.php?lid=" . addslashes($lid) . '';
125		$tags['THINKS_INTERESTING'] = '' . AlumniLocale::MESSAGE . '';
126		$tags['YOU_CAN_VIEW_BELOW'] = '' . AlumniLocale::YOU_CAN_VIEW_BELOW . '';
127		$tags['WEBMASTER'] = AlumniLocale::WEBMASTER;
128		$tags['NO_REPLY'] = AlumniLocale::NO_REPLY;
129		$subject = '' . AlumniLocale::SUBJECT . ' ' . $xoopsConfig['sitename'] . '';
130
131		$xoopsMailer = $xoops->getMailer();
132		$xoopsMailer->useMail();
133		$xoopsMailer->setTemplateDir(XOOPS_ROOT_PATH . "/modules/{$moduleDirName}/language/english/mail_template/");
134		$xoopsMailer->setTemplate('listing_send_friend.tpl');
135		$xoopsMailer->setFromEmail($ymail);
136		$xoopsMailer->setToEmails($fmail);
137		$xoopsMailer->setSubject($subject);
138		// $xoopsMailer->$xoops->multimailer;
139		$xoopsMailer->assign($tags);
140		$xoopsMailer->send();
141		echo $xoopsMailer->getErrors();
142
143		$xoops->redirect('index.php', 3, AlumniLocale::ALUM_SEND);
144		exit();
145		}
146		} else {
147		global $xoops;
		0 ignored issues – show Compatibility Best Practice introduced 2017-05-24 04:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
148
149		$lid = Request::getInt('lid', 0);
150		$xoops->header('alumni_sendfriend.tpl');
151
152		include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
153
154		$listingHandler = $xoops->getModuleHandler('listing', $moduleDirName);
155		$listing_2_send = $listingHandler->get($lid);
156
157		$listing_2_send->getVar('name');
158		$listing_2_send->getVar('mname');
159		$listing_2_send->getVar('lname');
160
161		ob_start();
162		$form = new Xoops\Form\ThemeForm(AlumniLocale::SENDTO, 'sendfriend_form', 'sendfriend.php');
163		$form->setExtra('enctype="multipart/form-data"');
164		// $GLOBALS['xoopsGTicket']->addTicketXoopsFormElement($form, __LINE__, 1800, 'token');
165		$form->addElement(new Xoops\Form\Label(AlumniLocale::LISTING_SEND, $listing_2_send->getVar('name') . ' ' . $listing_2_send->getVar('mname') . ' ' . $listing_2_send->getVar('lname') . ''));
166		if ($xoopsUser) {
167		$idd = $xoopsUser->getVar('name', 'E');
168		$idde = $xoopsUser->getVar('email', 'E');
169		}
170
171		$form->addElement(new Xoops\Form\Text(XoopsLocale::C_YOUR_NAME, 'yname', 30, 50, $idd), true);
172		$form->addElement(new Xoops\Form\Text(XoopsLocale::C_YOUR_EMAIL, 'ymail', 30, 60, $idde), true);
173		$form->addElement(new Xoops\Form\Text(AlumniLocale::NAMEFR, 'fname', 30, 60, ''), true);
174		$form->addElement(new Xoops\Form\Text(AlumniLocale::MAILFR, 'fmail', 30, 60, ''), true);
175
176		if ('1' == $xoops->getModuleConfig('alumni_use_captcha') && !$xoops->user->isAdmin()) {
177		$form->addElement(new XoopsFormCaptcha());
178		}
179		// $form->addElement(new Xoops\Form\Hidden('security', $xoops->security()->createToken()));
180		$form->addElement(new Xoops\Form\Hidden('lid', $lid), false);
181		$form->addElement(new Xoops\Form\Button('', 'submit', XoopsLocale::A_SUBMIT, 'submit'));
182		$form->display();
183		$xoopsTpl->assign('sendfriend_form', ob_get_contents());
184
185		ob_end_clean();
186		}
187		Xoops::getInstance()->footer();
188

mambax7 / alumni-26x

Issues (884)

Security Analysis no request data

sendfriend.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like