mambax7 / alumni-26x

class/plugin/search.php

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */

use Xoops\Module\Plugin\PluginAbstract;
use Xmf\Metagen;
use Xoops\Core\Request;

/**
 * Class AlumniSearchPlugin
 */
class AlumniSearchPlugin extends PluginAbstract implements SearchPluginInterface

The type AlumniSearchPlugin has been defined more than once; this definition is ignored, only the first definition in class/plugin/good_search.php (L29-103) is considered.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @param $queryArray
     * @param $andor
     * @param $limit
     * @param $offset
     * @param $userid
     * @return array
     */
    public function search($queryArray, $andor, $limit, $offset, $userid)
    {
        $xoops           = Xoops::getInstance();
        $helper          = Xoops::getModuleHelper('alumni');
        $module_id       = $helper->getModule()->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $listing_Handler = $helper->getHandler('listing');

$listing_Handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$listing_Handler is not used, you could remove the assignment.

        $groups          = $xoops->getUserGroups();
        $alumni_ids      = $xoops->getHandlerGroupPermission()->getItemIds('alumni_view', $groups, $module_id);

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $all_ids         = implode(', ', $alumni_ids);

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $by_cat = Request::getInt('by_cat', 0);

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $andor  = 'and' == strtolower($andor) ? 'and' : 'or';

        $qb = \Xoops::getInstance()->db()->createXoopsQueryBuilder();

Avoid variables with short names like $qb. Configured minimum length is 3.

        $eb = $qb->expr();

Avoid variables with short names like $eb. Configured minimum length is 3.

        $qb->select('DISTINCT *')->fromPrefix('alumni_listing')->where($eb->eq('valid', '1'))->orderBy('lname', 'DESC')->setFirstResult($offset)->setMaxResults($limit);
        if (is_array($queryArray) && !empty($queryArray)) {
            $queryParts = [];
            foreach ($queryArray as $i => $q) {
                $query = ':query' . $i;
                $qb->setParameter($query, '%' . $q . '%', \PDO::PARAM_STR);
                $queryParts[] = $eb->orX($eb->like('name', $query), $eb->like('mname', $query), $eb->like('lname', $query), $eb->like('school', $query), $eb->like('year', $query));
            }

            $qb->andWhere($eb->in('cid', [$all_ids]));

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            if ($by_cat) {

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

                $qb->andWhere($eb->eq('cid', $by_cat));

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            }
            if ('and' == $andor) {
                $qb->andWhere(call_user_func_array([$eb, 'andX'], $queryParts));
            } else {
                $qb->andWhere(call_user_func_array([$eb, 'orX'], $queryParts));
            }
        } else {
            $qb->setParameter(':uid', (int)$userid, \PDO::PARAM_INT);
            $qb->andWhere($eb->eq('usid', ':uid'));
        }

        $myts   = MyTextSanitizer::getInstance();

$myts is not used, you could remove the assignment.

        $items  = [];
        $result = $qb->execute();
        while ($myrow = $result->fetch(\PDO::FETCH_ASSOC)) {
            $items[] = [
                'title' => $myrow['name'] . ' ' . $myrow['mname'] . ' ' . $myrow['lname'] . '   ---   ' . $myrow['school'] . ' ---   ' . $myrow['year'],
                'link'  => 'listing.php?lid=' . $myrow['lid'],
                'time'  => $myrow['date'],
                'uid'   => $myrow['usid'],
                'image' => 'images/cat/default.gif',
            ];
        }
        return $items;
    }
}