mambax7 / alumni-26x

blocks/alumni.php

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 30 and the first side effect is on line 21.

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */

defined('XOOPS_ROOT_PATH') || exit('XOOPS root path not defined');

include_once dirname(__DIR__) . '/include/common.php';

/**
 * @param $options
 * @return array
 */

function alumni_show($options)

function alumni_show() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

{
    $block        = [];
    $myts         = MyTextSanitizer::getInstance();

$myts is not used, you could remove the assignment.

    $blockDirName = basename(dirname(__DIR__));

    $xoops          = Xoops::getInstance();
    $helper         = Xoops::getModuleHelper('alumni');
    $module_id      = $helper->getModule()->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $listingHandler = $helper->getHandler('listing');
    $groups         = $xoops->getUserGroups();
    $alumni_ids     = $xoops->getHandlerGroupPermission()->getItemIds('alumni_view', $groups, $module_id);

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $all_ids        = implode(', ', $alumni_ids);

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $criteria = new CriteriaCompo();
    $criteria->add(new Criteria('valid', 1, '='));
    $criteria->add(new Criteria('cid', '(' . $all_ids . ')', 'IN'));

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    $criteria->setLimit($options[1]);
    $criteria->setSort('date');
    $criteria->setOrder('DESC');
    $block_listings = $listingHandler->getall($criteria);

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    foreach (array_keys($block_listings) as $i) {

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $name   = $block_listings[$i]->getVar('name');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $mname  = $block_listings[$i]->getVar('mname');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $lname  = $block_listings[$i]->getVar('lname');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $school = $block_listings[$i]->getVar('school');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $year   = $block_listings[$i]->getVar('year');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $view   = $block_listings[$i]->getVar('view');

$block_listings does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$view is not used, you could remove the assignment.

        $a_item           = [];

$a_item does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $a_item['school'] = $school;

$a_item does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $a_item['link']   = '<a href="' . XOOPS_URL . "/modules/{$blockDirName}/listing.php?lid=" . addslashes($block_listings[$i]->getVar('lid')) . "\"><b>$year&nbsp;-&nbsp;$name $mname $lname</b><br></a>";

$a_item does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $block['items'][] = $a_item;

$a_item does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

    }
    $block['lang_title'] = AlumniLocale::BLOCKS_ITEM;
    $block['lang_date']  = AlumniLocale::BLOCKS_DATE;
    $block['link']       = '<a href="' . XOOPS_URL . "/modules/{$blockDirName}/index.php\"><b>" . AlumniLocale::BLOCKS_ALL_LISTINGS . '</b></a></div>';

    return $block;
}

/**
 * @param $options
 * @return string
 */

function alumni_edit($options)

function alumni_edit() does not seem to conform to the naming convention (^(?:[a-z]|__)[a-zA-Z0-9]*$).

{
    $form = AlumniLocale::BLOCKS_ORDER . "&nbsp;<select name='options[]'>";
    $form .= "<option value='date'";
    if ('date' === $options[0]) {
        $form .= " selected='selected'";
    }
    $form .= '>' . AlumniLocale::BLOCKS_DATE . "</option>\n";
    $form .= "<option value='view'";
    if ('view' === $options[0]) {
        $form .= " selected='selected'";
    }
    $form .= '>' . AlumniLocale::BLOCKS_HITS . '</option>';
    $form .= "</select>\n";
    $form .= '&nbsp;' . AlumniLocale::BLOCKS_DISPLAY . "&nbsp;<input type='text' name='options[]' value='" . $options[1] . "'/>&nbsp;" . AlumniLocale::BLOCKS_LISTINGS;
    $form .= '&nbsp;<br><br>' . AlumniLocale::BLOCKS_LENGTH . "&nbsp;<input type='text' name='options[]' value='" . $options[2] . "'/>&nbsp;" . AlumniLocale::BLOCKS_CHARS . '<br><br>';

    return $form;
}