+global\AlumniSearchPlugin::search()

Complexity

Conditions	8
Paths	20

Size

Total Lines	64
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function search($queries, $andor, $limit, $start, $userid)
    {
        $xoops   = Xoops::getInstance();
        $alumni  = Alumni::getInstance();

$alumni is not used, you could remove the assignment.

        $myts    = MyTextSanitizer::getInstance();

$myts is not used, you could remove the assignment.

        $by_cat  = Request::getInt('by_cat', '');

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $andor   = Request::getWord('andor', 'AND');

$andor is not used, you could remove the assignment.

        $queries = [];

$queries is not used, you could remove the assignment.

        $query   = Request::getString('query', '');
        $start   = Request::getInt('start', '0');

        $helper         = Xoops::getModuleHelper('alumni');
        $module_id      = $helper->getModule()->getVar('mid');

$module_id does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $listingHandler = $helper->getHandler('listing');
        $groups         = $xoops->getUserGroups();
        $alumni_ids     = $xoops->getHandlerGroupperm()->getItemIds('alumni_view', $groups, $module_id);

$alumni_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $all_ids        = implode(', ', $alumni_ids);

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $criteria = new CriteriaCompo();
        $criteria->add(new Criteria('valid', 1, '='));
        //  $criteria->add(new Criteria('date', time(), '<='));

67% of this comment could be valid code. Did you maybe forget this after debugging?

        $criteria->add(new Criteria('cid', '(' . $all_ids . ')', 'IN'));

$all_ids does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if (0 != $userid) {
            $criteria->add(new Criteria('usid', $userid, '='));
        }
        if ($by_cat) {

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $criteria->add(new Criteria('cid', $by_cat, '='));

$by_cat does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }

        $queries = [$query];
        $queries = implode('+', $queries);

        $count = 0;

$count is not used, you could remove the assignment.

        $i     = 0;

$i is not used, you could remove the assignment.

        $criteria->add(new Criteria('name', '%' . $queries . '%', 'LIKE'), 'AND');
        $criteria->add(new Criteria('mname', '%' . $queries . '%', 'LIKE'), 'OR');
        $criteria->add(new Criteria('lname', '%' . $queries . '%', 'LIKE'), 'OR');
        $criteria->add(new Criteria('school', '%' . $queries . '%', 'LIKE'), 'OR');
        $criteria->add(new Criteria('year', '%' . $queries . '%', 'LIKE'), 'OR');

        $criteria->setLimit($limit);
        $criteria->setSort('date');
        $criteria->setOrder('DESC');
        $criteria->setStart($start);

        $numrows     = $listingHandler->getCount();

$numrows is not used, you could remove the assignment.

        $this_search = $listingHandler->getall($criteria);

$this_search does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $ret = [];
        $k   = 0;

Avoid variables with short names like $k. Configured minimum length is 3.

        foreach ($this_search as $obj) {

$this_search does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $ret[$k]['image'] = 'images/cat/default.gif';
            $ret[$k]['link']  = 'listing.php?lid=' . $obj->getVar('lid') . '';
            $ret[$k]['title'] = $obj->getVar('name') . ' ' . $obj->getVar('mname') . ' ' . $obj->getVar('lname') . '   ---   ' . $obj->getVar('school') . '
		---   ' . $obj->getVar('year');
            $ret[$k]['time']  = $obj->getVar('date');
            $ret[$k]['uid']   = $obj->getVar('usid');
            $k++;
        }

        return $ret;
    }
}