AlumniListingForm

Complexity

Total Complexity

14

Size/Duplication

Total Lines	129
Duplicated Lines	9.3 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
F	__construct()	12	123	14

<?php
/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/

/**
 * Alumni module for Xoops
 *
 * @copyright       XOOPS Project https://xoops.org/
 * @license         GPL 2.0 or later
 * @package         alumni
 * @since           2.6.x
 * @author          John Mordo (jlm69)
 */

use Xoops\Core\Request;

/**
 * Class AlumniListingForm
 */
class AlumniListingForm extends Xoops\Form\ThemeForm

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @param \AlumniListing $obj
     */
    public function __construct(AlumniListing $obj)

__construct uses the super-global variable $_REQUEST which is generally not recommended.

    {
        $xoops = Xoops::getInstance();

        if ('1' == $xoops->getModuleConfig('alumni_moderated')) {
            $title = sprintf($obj->isNew() ? AlumniLocale::ADD_MOD : AlumniLocale::EDIT_MOD);
        } else {
            $title = sprintf($obj->isNew() ? AlumniLocale::ADD_LISTING : AlumniLocale::EDIT_LISTING);
        }

        parent::__construct($title, 'form', false, 'post', true);

        $this->setExtra('enctype="multipart/form-data"');

        $member_handler = $xoops->getHandlerMember();

$member_handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $userGroups     = $member_handler->getGroupList();

$member_handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$userGroups is not used, you could remove the assignment.

        $lid = Request::getInt('lid', 0);

$lid is not used, you could remove the assignment.

//        if (isset($lid)) {

55% of this comment could be valid code. Did you maybe forget this after debugging?

//            $lid = $lid;
//        }

        $this->addElement(new Xoops\Form\Label(AlumniLocale::SUBMITTER, $xoops->user->uname()));

        $categoryHandler = $xoops->getModuleHandler('category', 'alumni');
        $categories      = $categoryHandler->getObjects();
        $mytree          = new XoopsObjectTree($categories, 'cid', 'pid');

$mytree is not used, you could remove the assignment.

        if ($obj->isNew()) {
            $this_cid = Request::getInt('cid', 0);

$this_cid does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        } else {
            $this_cid = $obj->getVar('cid');

$this_cid does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $categories_Handler = $xoops->getModuleHandler('category', 'alumni');

$categories_Handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $categories         = $categories_Handler->getObjects();

$categories_Handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $mytree             = new XoopsObjectTree($categories, 'cid', 'pid');
        $category_select    = $mytree->makeSelBox('cid', 'title', '--', $this_cid, true);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Label(AlumniLocale::SCHOOL, $category_select), true);

$category_select does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_name           = '';

$cat_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$cat_name is not used, you could remove the assignment.

        $categories_Handler = $xoops->getModuleHandler('category', 'alumni');

$categories_Handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $catObj             = $categories_Handler->get($obj->getVar('cid'));

$categories_Handler does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $cat_name           = $catObj->getVar('title');

$cat_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Hidden('school', $cat_name));

$cat_name does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Text(AlumniLocale::NAME_2, 'name', 50, 255, $obj->getVar('name')), true);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::MNAME_2, 'mname', 50, 255, $obj->getVar('mname')), false);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::LNAME_2, 'lname', 50, 255, $obj->getVar('lname')), true);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::CLASS_OF_2, 'year', 50, 255, $obj->getVar('year')), true);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::STUDIES_2, 'studies', 50, 255, $obj->getVar('studies')), false);
        $activities               = $obj->getVar('activities', 'e') ?: '';
        $editor_configs           = [];

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['name']   = 'activities';

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['value']  = $activities;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['editor'] = $xoops->getModuleConfig('alumni_form_options');

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['rows']   = 6;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['cols']   = 8;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Editor(AlumniLocale::ACTIVITIES, 'activities', $editor_configs), false);

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $extrainfo                = $obj->getVar('extrainfo', 'e') ?: '';
        $editor_configs           = [];

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['name']   = 'extrainfo';

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['value']  = $extrainfo;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['editor'] = $xoops->getModuleConfig('alumni_form_options');

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['rows']   = 6;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $editor_configs['cols']   = 8;

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Editor(AlumniLocale::EXTRAINFO, 'extrainfo', $editor_configs), false);

$editor_configs does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $photo_old            = $obj->getVar('photo') ?: '';

$photo_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $uploadirectory_photo = XOOPS_ROOT_PATH . '/modules/alumni/photos/grad_photo';

$uploadirectory_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $imgtray_photo        = new Xoops\Form\ElementTray(AlumniLocale::GRAD_PHOTO, '<br>');

$imgtray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $imgpath_photo        = sprintf(AlumniLocale::FORMIMAGE_PATH, $uploadirectory_photo);

$imgpath_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$imgpath_photo is not used, you could remove the assignment.

        $fileseltray_photo    = new Xoops\Form\ElementTray('', '<br>');

$fileseltray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $fileseltray_photo->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo', $xoops->getModuleConfig('alumni_photomax')), false);

$fileseltray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($photo_old) {

$photo_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

This code seems to be duplicated across your project.

            $fileseltray_photo->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/grad_photo/' . $photo_old . '">' . $photo_old . '</a>', false));

$fileseltray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $imgtray_checkbox = new Xoops\Form\Checkbox('', 'del_photo', 0);

$imgtray_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $imgtray_checkbox->addOption(1, AlumniLocale::DELPICT);

$imgtray_checkbox does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $fileseltray_photo->addElement($imgtray_checkbox);

$fileseltray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $imgtray_photo->addElement($fileseltray_photo);

$imgtray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement($imgtray_photo);

$imgtray_photo does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Hidden('photo_old', $photo_old));

$photo_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $photo2_old            = $obj->getVar('photo2') ?: '';

$photo2_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $uploadirectory_photo2 = XOOPS_ROOT_PATH . '/modules/alumni/photos/now_photo';

$uploadirectory_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $imgtray_photo2        = new Xoops\Form\ElementTray(AlumniLocale::NOW_PHOTO, '<br>');

$imgtray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $imgpath_photo2        = sprintf(AlumniLocale::FORMIMAGE_PATH, $uploadirectory_photo2);

$imgpath_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

$imgpath_photo2 is not used, you could remove the assignment.

        $fileseltray_photo2    = new Xoops\Form\ElementTray('', '<br>');

$fileseltray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $fileseltray_photo2->addElement(new Xoops\Form\File(AlumniLocale::FORMUPLOAD, 'photo2', $xoops->getModuleConfig('alumni_photomax')), false);

$fileseltray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        if ($photo2_old) {

$photo2_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

This code seems to be duplicated across your project.

            $fileseltray_photo2->addElement(new Xoops\Form\Label(AlumniLocale::PHOTO2, '<a href="photos/now_photo/' . $photo2_old . '">' . $photo2_old . '</a>', false));

$fileseltray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $imgtray_checkbox2 = new Xoops\Form\Checkbox('', 'del_photo2', 0);

$imgtray_checkbox2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $imgtray_checkbox2->addOption(1, AlumniLocale::DELPICT);

$imgtray_checkbox2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

            $fileseltray_photo2->addElement($imgtray_checkbox2);

$fileseltray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        }
        $imgtray_photo2->addElement($fileseltray_photo2);

$imgtray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement($imgtray_photo2);

$imgtray_photo2 does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Hidden('photo2_old', $photo2_old));

$photo2_old does not seem to conform to the naming convention (^[a-z][a-zA-Z0-9]*$).

        $this->addElement(new Xoops\Form\Text(AlumniLocale::EMAIL_2, 'email', 50, 255, $obj->getVar('email')), true);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::OCC_2, 'occ', 50, 255, $obj->getVar('occ')), false);
        $this->addElement(new Xoops\Form\Text(AlumniLocale::TOWN_2, 'town', 50, 255, $obj->getVar('town')), false);

        if ($xoops->user->isAdmin()) {
            $this->addElement(new Xoops\Form\RadioYesNo(AlumniLocale::APPROVE_2, 'valid', $obj->getVar('valid'), XoopsLocale::YES, XoopsLocale::NO));
        }
        if ('1' == $xoops->getModuleConfig('alumni_use_captcha')) {
            $this->addElement(new Xoops\Form\Captcha());
        }

        $this->addElement(new Xoops\Form\Hidden('security', $xoops->security()->createToken()));

        if (isset($_REQUEST['date'])) {
            $this->addElement(new Xoops\Form\Hidden('date', $_REQUEST['date']));
        } else {
            $this->addElement(new XoopsFormHidden('date', time()));
        }
        $this->addElement(new Xoops\Form\Hidden('submitter', $xoops->user->uname()));
        $this->addElement(new Xoops\Form\Hidden('usid', $xoops->user->uid()));
        $this->addElement(new Xoops\Form\Hidden('op', 'save_listing'));
        $this->addElement(new Xoops\Form\Button('', 'submit', XoopsLocale::A_SUBMIT, 'submit'));
    }
}