Inspection of "[altsys] version 0.82.5" - mambax7/altsys - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (0881bb)

by Michael

created 2016-06-23 08:53 UTC

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH in mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH in mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/admin_menu.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/admin_menu.php';

Please login to merge, or discard this patch.

html/modules/altsys/admin/index.php 1 patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,13 +1,13 @@
 block discarded – undo
 <?php
 
-require '../../../mainfile.php' ;
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH in mainfile.php') ;
+require '../../../mainfile.php';
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH in mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/index.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/index.php';

Please login to merge, or discard this patch.

html/modules/altsys/preload/AltsysPreload.class.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH into mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH into mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/preload.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/preload.php';

Please login to merge, or discard this patch.

html/modules/altsys/setup_xoops_trust_path.php 1 patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -1,45 +1,45 @@
 block discarded – undo
 <?php
 
-$xoopsOption['nocommon'] = 1 ;
-define('_LEGACY_PREVENT_LOAD_CORE_', 1) ;
+$xoopsOption['nocommon'] = 1;
+define('_LEGACY_PREVENT_LOAD_CORE_', 1);
 
-include '../../mainfile.php' ;
+include '../../mainfile.php';
 
 if (defined('XOOPS_TRUST_PATH') && XOOPS_TRUST_PATH != '' && file_exists(XOOPS_TRUST_PATH.'/libs/altsys')) {
-    die('No problem with your XOOPS_TRUST_PATH') ;
+    die('No problem with your XOOPS_TRUST_PATH');
 }
 
 
 // show the hint if password mathes
-$hint = '' ;
+$hint = '';
 if (@$_POST['dbpassword'] == XOOPS_DB_PASS) {
     // find XOOPS_TRUST_PATH
-    $xoops_trust_path = '' ;
-    $base_dirs = array( XOOPS_ROOT_PATH , dirname(XOOPS_ROOT_PATH) , dirname(dirname(XOOPS_ROOT_PATH)) ) ;
+    $xoops_trust_path = '';
+    $base_dirs = array(XOOPS_ROOT_PATH, dirname(XOOPS_ROOT_PATH), dirname(dirname(XOOPS_ROOT_PATH)));
     foreach ($base_dirs as $base_dir) {
-        $dh = @opendir($base_dir) ;
-        if (! empty($dh)) {
+        $dh = @opendir($base_dir);
+        if (!empty($dh)) {
             while (($file = readdir($dh)) !== false) {
                 if (substr($file, 0, 1) == '.') {
-                    continue ;
+                    continue;
                 }
-                $fullpath = $base_dir . '/' . $file ;
-                if (! is_dir($fullpath)) {
-                    continue ;
+                $fullpath = $base_dir.'/'.$file;
+                if (!is_dir($fullpath)) {
+                    continue;
                 }
                 if (is_dir($fullpath.'/libs/altsys')) {
-                    $xoops_trust_path = $fullpath ;
-                    break 2 ;
+                    $xoops_trust_path = $fullpath;
+                    break 2;
                 }
             }
         }
     }
     // fall back
     if (empty($xoops_trust_path)) {
-        $xoops_trust_path = dirname(XOOPS_ROOT_PATH).'/xoops_trust_path' ;
+        $xoops_trust_path = dirname(XOOPS_ROOT_PATH).'/xoops_trust_path';
     }
     // create the hint
-    if (! defined('XOOPS_TRUST_PATH')) {
+    if (!defined('XOOPS_TRUST_PATH')) {
         $hint = "Insert the red line.<br />define('XOOPS_ROOT_PATH', '".htmlspecialchars(XOOPS_ROOT_PATH, ENT_QUOTES)."');<br /><ins style='color:red;'>define('XOOPS_TRUST_PATH', '".htmlspecialchars($xoops_trust_path, ENT_QUOTES)."');</ins>";
     } else {
         $hint = "<del>define('XOOPS_TRUST_PATH', '');</del><br /><ins style='color:red;'>define('XOOPS_TRUST_PATH', '".htmlspecialchars($xoops_trust_path, ENT_QUOTES)."');</ins>";

Please login to merge, or discard this patch.

html/modules/altsys/include/onupdate.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH into mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH into mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/onupdate.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/onupdate.php';

Please login to merge, or discard this patch.

html/modules/altsys/include/onuninstall.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH into mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH into mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/onuninstall.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/onuninstall.php';

Please login to merge, or discard this patch.

html/modules/altsys/include/oninstall.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH into mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH into mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/oninstall.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/oninstall.php';

Please login to merge, or discard this patch.

html/modules/altsys/include/Legacy_AltsysAdminRenderSystem.class.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -1,12 +1,12 @@
 block discarded – undo
 <?php
 
-if (! defined('XOOPS_TRUST_PATH')) {
-    die('set XOOPS_TRUST_PATH into mainfile.php') ;
+if (!defined('XOOPS_TRUST_PATH')) {
+    die('set XOOPS_TRUST_PATH into mainfile.php');
 }
 
-$mydirname = basename(dirname(dirname(__FILE__))) ;
-$mydirpath = dirname(dirname(__FILE__)) ;
+$mydirname = basename(dirname(dirname(__FILE__)));
+$mydirpath = dirname(dirname(__FILE__));
 // require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
-$mytrustdirname = 'altsys' ;
+$mytrustdirname = 'altsys';
 
-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/include/Legacy_AltsysAdminRenderSystem.class.php' ;
+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/include/Legacy_AltsysAdminRenderSystem.class.php';

Please login to merge, or discard this patch.

html/modules/altsys/index.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 
-$xoopsOption['nocommon'] = 1 ;
-define('_LEGACY_PREVENT_LOAD_CORE_', true) ;
-require '../../mainfile.php' ;
+$xoopsOption['nocommon'] = 1;
+define('_LEGACY_PREVENT_LOAD_CORE_', true);
+require '../../mainfile.php';
 
-header('Location: '.XOOPS_URL.'/user.php') ;
+header('Location: '.XOOPS_URL.'/user.php');

Please login to merge, or discard this patch.

		@@ -1,12 +1,12 @@
		block discarded – undo
1	1	<?php
2	2
3		-if (! defined('XOOPS_TRUST_PATH')) {
4		- die('set XOOPS_TRUST_PATH in mainfile.php') ;
	3	+if (!defined('XOOPS_TRUST_PATH')) {
	4	+ die('set XOOPS_TRUST_PATH in mainfile.php');
5	5	}
6	6
7		-$mydirname = basename(dirname(dirname(__FILE__))) ;
8		-$mydirpath = dirname(dirname(__FILE__)) ;
	7	+$mydirname = basename(dirname(dirname(__FILE__)));
	8	+$mydirpath = dirname(dirname(__FILE__));
9	9	// require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
10		-$mytrustdirname = 'altsys' ;
	10	+$mytrustdirname = 'altsys';
11	11
12		-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/admin_menu.php' ;
	12	+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/admin_menu.php';

		@@ -1,13 +1,13 @@
		block discarded – undo
1	1	<?php
2	2
3		-require '../../../mainfile.php' ;
4		-if (! defined('XOOPS_TRUST_PATH')) {
5		- die('set XOOPS_TRUST_PATH in mainfile.php') ;
	3	+require '../../../mainfile.php';
	4	+if (!defined('XOOPS_TRUST_PATH')) {
	5	+ die('set XOOPS_TRUST_PATH in mainfile.php');
6	6	}
7	7
8		-$mydirname = basename(dirname(dirname(__FILE__))) ;
9		-$mydirpath = dirname(dirname(__FILE__)) ;
	8	+$mydirname = basename(dirname(dirname(__FILE__)));
	9	+$mydirpath = dirname(dirname(__FILE__));
10	10	// require $mydirpath.'/mytrustdirname.php' ; // set $mytrustdirname
11		-$mytrustdirname = 'altsys' ;
	11	+$mytrustdirname = 'altsys';
12	12
13		-require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/index.php' ;
	13	+require XOOPS_TRUST_PATH.'/libs/'.$mytrustdirname.'/index.php';

		@@ -1,45 +1,45 @@
		block discarded – undo
1	1	<?php
2	2
3		-$xoopsOption['nocommon'] = 1 ;
4		-define('_LEGACY_PREVENT_LOAD_CORE_', 1) ;
	3	+$xoopsOption['nocommon'] = 1;
	4	+define('_LEGACY_PREVENT_LOAD_CORE_', 1);
5	5
6		-include '../../mainfile.php' ;
	6	+include '../../mainfile.php';
7	7
8	8	if (defined('XOOPS_TRUST_PATH') && XOOPS_TRUST_PATH != '' && file_exists(XOOPS_TRUST_PATH.'/libs/altsys')) {
9		- die('No problem with your XOOPS_TRUST_PATH') ;
	9	+ die('No problem with your XOOPS_TRUST_PATH');
10	10	}
11	11
12	12
13	13	// show the hint if password mathes
14		-$hint = '' ;
	14	+$hint = '';
15	15	if (@$_POST['dbpassword'] == XOOPS_DB_PASS) {
16	16	// find XOOPS_TRUST_PATH
17		- $xoops_trust_path = '' ;
18		- $base_dirs = array( XOOPS_ROOT_PATH , dirname(XOOPS_ROOT_PATH) , dirname(dirname(XOOPS_ROOT_PATH)) ) ;
	17	+ $xoops_trust_path = '';
	18	+ $base_dirs = array(XOOPS_ROOT_PATH, dirname(XOOPS_ROOT_PATH), dirname(dirname(XOOPS_ROOT_PATH)));
19	19	foreach ($base_dirs as $base_dir) {
20		- $dh = @opendir($base_dir) ;
21		- if (! empty($dh)) {
	20	+ $dh = @opendir($base_dir);
	21	+ if (!empty($dh)) {
22	22	while (($file = readdir($dh)) !== false) {
23	23	if (substr($file, 0, 1) == '.') {
24		- continue ;
	24	+ continue;
25	25	}
26		- $fullpath = $base_dir . '/' . $file ;
27		- if (! is_dir($fullpath)) {
28		- continue ;
	26	+ $fullpath = $base_dir.'/'.$file;
	27	+ if (!is_dir($fullpath)) {
	28	+ continue;
29	29	}
30	30	if (is_dir($fullpath.'/libs/altsys')) {
31		- $xoops_trust_path = $fullpath ;
32		- break 2 ;
	31	+ $xoops_trust_path = $fullpath;
	32	+ break 2;
33	33	}
34	34	}
35	35	}
36	36	}
37	37	// fall back
38	38	if (empty($xoops_trust_path)) {
39		- $xoops_trust_path = dirname(XOOPS_ROOT_PATH).'/xoops_trust_path' ;
	39	+ $xoops_trust_path = dirname(XOOPS_ROOT_PATH).'/xoops_trust_path';
40	40	}
41	41	// create the hint
42		- if (! defined('XOOPS_TRUST_PATH')) {
	42	+ if (!defined('XOOPS_TRUST_PATH')) {
43	43	$hint = "Insert the red line.<br />define('XOOPS_ROOT_PATH', '".htmlspecialchars(XOOPS_ROOT_PATH, ENT_QUOTES)."');<br /><ins style='color:red;'>define('XOOPS_TRUST_PATH', '".htmlspecialchars($xoops_trust_path, ENT_QUOTES)."');</ins>";
44	44	} else {
45	45	$hint = "<del>define('XOOPS_TRUST_PATH', '');</del><br /><ins style='color:red;'>define('XOOPS_TRUST_PATH', '".htmlspecialchars($xoops_trust_path, ENT_QUOTES)."');</ins>";

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2
3		-$xoopsOption['nocommon'] = 1 ;
4		-define('_LEGACY_PREVENT_LOAD_CORE_', true) ;
5		-require '../../mainfile.php' ;
	3	+$xoopsOption['nocommon'] = 1;
	4	+define('_LEGACY_PREVENT_LOAD_CORE_', true);
	5	+require '../../mainfile.php';
6	6
7		-header('Location: '.XOOPS_URL.'/user.php') ;
	7	+header('Location: '.XOOPS_URL.'/user.php');

mambax7 / altsys

Branch — master (0881bb)

Category

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch