mambax7 / altsys

xoops_trust_path/libs/altsys/class/d3utilities.php

Doc Comments +1 added lines, -1 removed lines

@@ -359,7 +359,7 @@
     }
 
     /**
-     * @param $name
+     * @param string $name
      * @param $options
      * @param $current_value
      * @return string

Spacing +17 added lines, -17 removed lines

@@ -37,7 +37,7 @@ 
 
         $this->mydirname = $mydirname;
 
-        $this->table = $db->prefix($mydirname ? $mydirname . '_' . $table_body : $table_body);
+        $this->table = $db->prefix($mydirname ? $mydirname.'_'.$table_body : $table_body);
 
         $this->primary_key = $primary_key;
 
@@ -63,7 +63,7 @@ 
 
     public function get_language_constant($name)
     {
-        return constant(mb_strtoupper('_MD_A_' . $this->dirname . '_' . $this->page_name . '_' . $name));
+        return constant(mb_strtoupper('_MD_A_'.$this->dirname.'_'.$this->page_name.'_'.$name));
     }
 
     /**
@@ -79,13 +79,13 @@ 
             case 'blob':
                 $length = empty($col['length']) ? 65535 : (int)$col['length'];
 
-                return "`{$col['name']}`='" . addslashes(xoops_substr($value, 0, $length)) . "'";
+                return "`{$col['name']}`='".addslashes(xoops_substr($value, 0, $length))."'";
             case 'char':
             case 'varchar':
             case 'string':
                 $length = empty($col['length']) ? 255 : (int)$col['length'];
 
-                return "`{$col['name']}`='" . addslashes(xoops_substr($value, 0, $length)) . "'";
+                return "`{$col['name']}`='".addslashes(xoops_substr($value, 0, $length))."'";
             case 'int':
             case 'integer':
                 $value = (int)$value;
@@ -123,21 +123,21 @@ 
                 continue;
             }
 
-            $set4sql .= $this->get_set4sql(@$_POST[$col['name']], $col) . ',';
+            $set4sql .= $this->get_set4sql(@$_POST[$col['name']], $col).',';
         }
 
         if (!empty($set4sql)) {
             if ($id > 0) {
                 // UPDATE
 
-                $db->queryF("UPDATE $this->table SET " . mb_substr($set4sql, 0, -1) . " WHERE $this->primary_key='" . addslashes($id) . "'");
+                $db->queryF("UPDATE $this->table SET ".mb_substr($set4sql, 0, -1)." WHERE $this->primary_key='".addslashes($id)."'");
 
                 return [$id, 'update'];
             }
 
             // INSERT
 
-            $db->queryF("INSERT INTO $this->table SET " . mb_substr($set4sql, 0, -1));
+            $db->queryF("INSERT INTO $this->table SET ".mb_substr($set4sql, 0, -1));
 
             return [$db->getInsertId(), 'insert'];
         }
@@ -170,7 +170,7 @@ 
         $ret = [];
 
         foreach (array_keys($_POST[$column4key]) as $id) {
-            $id = (int)$id;    // primary_key should be 'integer'
+            $id = (int)$id; // primary_key should be 'integer'
 
             $set4sql = '';
 
@@ -183,14 +183,14 @@ 
                     continue;
                 }
 
-                $set4sql .= $this->get_set4sql(@$_POST[$col['name']][$id], $col) . ',';
+                $set4sql .= $this->get_set4sql(@$_POST[$col['name']][$id], $col).',';
             }
 
             if (!empty($set4sql)) {
                 $result = $db->query("SELECT * FROM $this->table WHERE $this->primary_key=$id");
 
                 if (1 == $db->getRowsNum($result)) {
-                    $db->queryF("UPDATE $this->table SET " . mb_substr($set4sql, 0, -1) . " WHERE $this->primary_key=$id");
+                    $db->queryF("UPDATE $this->table SET ".mb_substr($set4sql, 0, -1)." WHERE $this->primary_key=$id");
 
                     if (1 == $db->getAffectedRows()) {
                         $ret[$id] = $db->fetchArray($result);
@@ -215,7 +215,7 @@ 
         $ret = [];
 
         foreach (array_keys($_POST['admin_main_checkboxes']) as $id) {
-            $id = (int)$id;    // primary_key should be 'integer'
+            $id = (int)$id; // primary_key should be 'integer'
 
             $result = $db->query("SELECT * FROM $this->table WHERE $this->primary_key=$id");
 
@@ -227,13 +227,13 @@ 
                 if ($delete_comments) {
                     // remove comments
 
-                    $db->queryF('DELETE FROM ' . $db->prefix('xoopscomments') . " WHERE com_modid=$this->mid AND com_itemid=$id");
+                    $db->queryF('DELETE FROM '.$db->prefix('xoopscomments')." WHERE com_modid=$this->mid AND com_itemid=$id");
                 }
 
                 if ($delete_notifications) {
                     // remove notifications
 
-                    $db->queryF('DELETE FROM ' . $db->prefix('xoopsnotifications') . " WHERE not_modid=$this->mid AND not_itemid=$id");
+                    $db->queryF('DELETE FROM '.$db->prefix('xoopsnotifications')." WHERE not_modid=$this->mid AND not_itemid=$id");
                 }
             }
         }
@@ -314,7 +314,7 @@ 
                 default:
                     $size = empty($col['edit_size']) ? 32 : (int)$col['edit_size'];
                     $length = empty($col['length']) ? 255 : (int)$col['length'];
-                    $lines[$col['name']] = "<input type='text' name='{$col['name']}' size='$size' maxlength='$length' value='" . htmlspecialchars($col['default_value'], ENT_QUOTES) . "' />";
+                    $lines[$col['name']] = "<input type='text' name='{$col['name']}' size='$size' maxlength='$length' value='".htmlspecialchars($col['default_value'], ENT_QUOTES)."' />";
                     break;
                 case false:
                     $lines[$col['name']] = htmlspecialchars($col['default_value'], ENT_QUOTES);
@@ -354,7 +354,7 @@ 
             <form action='' method='get' name='admin_control' id='admin_control'>
                 $hiddens
                 $controllers_html
-                <input type='submit' value='" . _SUBMIT . "' />
+                <input type='submit' value='"._SUBMIT."' />
             </form>\n";
     }
 
@@ -367,12 +367,12 @@ 
 
     public function get_select($name, $options, $current_value)
     {
-        $ret = "<select name='" . htmlspecialchars($name, ENT_QUOTES) . "'>\n";
+        $ret = "<select name='".htmlspecialchars($name, ENT_QUOTES)."'>\n";
 
         foreach ($options as $key => $val) {
             $selected = $val == $current_value ? "selected='selected'" : '';
 
-            $ret .= "<option value='" . htmlspecialchars($key, ENT_QUOTES) . "' $selected>" . htmlspecialchars($val, ENT_QUOTES) . "</option>\n";
+            $ret .= "<option value='".htmlspecialchars($key, ENT_QUOTES)."' $selected>".htmlspecialchars($val, ENT_QUOTES)."</option>\n";
         }
 
         $ret .= "</select>\n";

xoops_trust_path/libs/altsys/class/MyBlocksAdmin.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -1145,7 +1145,7 @@ 
     }
 
     /**
-     * @param        $bid
+     * @param        integer $bid
      * @param string $mode
      */
 
@@ -1353,7 +1353,7 @@ 
 
     /**
      * @param $bctype
-     * @return mixed|string
+     * @return string
      */
 
     public function get_blockname_from_ctype($bctype)

Indentation +27 added lines, -27 removed lines

@@ -117,7 +117,7 @@ 
 
             $moduleHandler = xoops_getHandler('module');
 
-         if (! empty($_GET['dirname'])) {
+            if (! empty($_GET['dirname'])) {
                 $dirname = preg_replace('/[^0-9a-zA-Z_-]/', '', \Xmf\Request::getString('dirname', '', 'GET'));
 
                 $target_module = $moduleHandler->getByDirname($dirname);
@@ -558,12 +558,12 @@ 
             ];
 
             $blocks4assign[] = [
-                                   'name_raw' => $block_data['name'],
-                                   'title_raw' => $block_data['title'],
-                                   'cell_position' => $this->renderCell4BlockPosition($block_data),
-                                   'cell_module_link' => $this->renderCell4BlockModuleLink($block_data),
-                                   'cell_group_perm' => $this->renderCell4BlockReadGroupPerm($block_data),
-                               ] + $block_data;
+                                    'name_raw' => $block_data['name'],
+                                    'title_raw' => $block_data['title'],
+                                    'cell_position' => $this->renderCell4BlockPosition($block_data),
+                                    'cell_module_link' => $this->renderCell4BlockModuleLink($block_data),
+                                    'cell_group_perm' => $this->renderCell4BlockReadGroupPerm($block_data),
+                                ] + $block_data;
         }
 
         // display
@@ -573,14 +573,14 @@ 
         $tpl = new D3Tpl();
 
         $tpl->assign([
-                         'target_mid' => $this->target_mid,
-                         'target_dirname' => $this->target_dirname,
-                         'target_mname' => $this->target_mname,
-                         'language' => $this->lang,
-                         'cachetime_options' => $this->cachetime_options,
-                         'blocks' => $blocks4assign,
-                         'gticket_hidden' => $xoopsGTicket->getTicketHtml(__LINE__, 1800, 'myblocksadmin'),
-                     ]);
+                            'target_mid' => $this->target_mid,
+                            'target_dirname' => $this->target_dirname,
+                            'target_mname' => $this->target_mname,
+                            'language' => $this->lang,
+                            'cachetime_options' => $this->cachetime_options,
+                            'blocks' => $blocks4assign,
+                            'gticket_hidden' => $xoopsGTicket->getTicketHtml(__LINE__, 1800, 'myblocksadmin'),
+                        ]);
 
         $tpl->display('db:altsys_main_myblocksadmin_list.tpl');
     }
@@ -1274,18 +1274,18 @@ 
         }
 
         $tpl->assign([
-                         'target_dirname' => $this->target_dirname,
-                         'target_mname' => $this->target_mname,
-                         'language' => $this->lang,
-                         'cachetime_options' => $this->cachetime_options,
-                         'ctype_options' => $this->ctype_options,
-                         'block' => $block4assign,
-                         'op' => $next_op,
-                         'form_title' => $form_title,
-                         'submit_button' => $button_value,
-                         'common_fck_installed' => $this->checkFck(),
-                         'gticket_hidden' => $GLOBALS['xoopsSecurity']->getTokenHTML('myblocksadmin'),
-                     ]);
+                            'target_dirname' => $this->target_dirname,
+                            'target_mname' => $this->target_mname,
+                            'language' => $this->lang,
+                            'cachetime_options' => $this->cachetime_options,
+                            'ctype_options' => $this->ctype_options,
+                            'block' => $block4assign,
+                            'op' => $next_op,
+                            'form_title' => $form_title,
+                            'submit_button' => $button_value,
+                            'common_fck_installed' => $this->checkFck(),
+                            'gticket_hidden' => $GLOBALS['xoopsSecurity']->getTokenHTML('myblocksadmin'),
+                        ]);
 
         if (defined('XOOPS_CUBE_LEGACY')) {
             $tpl->display('db:altsys_main_myblocksadmin_edit_4legacy.tpl');

Spacing +45 added lines, -45 removed lines

@@ -117,7 +117,7 @@ 
 
             $moduleHandler = xoops_getHandler('module');
 
-         if (! empty($_GET['dirname'])) {
+         if (!empty($_GET['dirname'])) {
                 $dirname = preg_replace('/[^0-9a-zA-Z_-]/', '', \Xmf\Request::getString('dirname', '', 'GET'));
 
                 $target_module = $moduleHandler->getByDirname($dirname);
@@ -128,7 +128,7 @@ 
 
                 $this->target_mid = $target_module->getVar('mid');
 
-                $this->target_mname = $target_module->getVar('name') . ' ' . sprintf('(%2.2f)', $target_module->getVar('version') / 100.0);
+                $this->target_mname = $target_module->getVar('name').' '.sprintf('(%2.2f)', $target_module->getVar('version') / 100.0);
 
                 $this->target_dirname = $target_module->getVar('dirname');
 
@@ -138,9 +138,9 @@ 
 
                 $breadcrumbsObj = AltsysBreadcrumbs::getInstance();
 
-                $breadcrumbsObj->appendPath(XOOPS_URL . '/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', '_MI_ALTSYS_MENU_MYBLOCKSADMIN');
+                $breadcrumbsObj->appendPath(XOOPS_URL.'/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', '_MI_ALTSYS_MENU_MYBLOCKSADMIN');
 
-                $breadcrumbsObj->appendPath(XOOPS_URL . '/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin&dirname=' . $this->target_dirname, $this->target_mname);
+                $breadcrumbsObj->appendPath(XOOPS_URL.'/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin&dirname='.$this->target_dirname, $this->target_mname);
             } else {
                 // custom blocks
 
@@ -154,28 +154,28 @@ 
 
                 $breadcrumbsObj = AltsysBreadcrumbs::getInstance();
 
-                $breadcrumbsObj->appendPath(XOOPS_URL . '/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', '_MI_ALTSYS_MENU_MYBLOCKSADMIN');
+                $breadcrumbsObj->appendPath(XOOPS_URL.'/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', '_MI_ALTSYS_MENU_MYBLOCKSADMIN');
 
-                $breadcrumbsObj->appendPath(XOOPS_URL . '/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin&dirname=' . $this->target_dirname, '_MI_ALTSYS_MENU_CUSTOMBLOCKS');
+                $breadcrumbsObj->appendPath(XOOPS_URL.'/modules/altsys/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin&dirname='.$this->target_dirname, '_MI_ALTSYS_MENU_CUSTOMBLOCKS');
             }
         } else {
             // myblocksadmin as a library
 
             $this->target_mid = $xoopsModule->getVar('mid');
 
-            $this->target_mname = $xoopsModule->getVar('name') . ' ' . sprintf('(%2.2f)', $xoopsModule->getVar('version') / 100.0);
+            $this->target_mname = $xoopsModule->getVar('name').' '.sprintf('(%2.2f)', $xoopsModule->getVar('version') / 100.0);
 
             $this->target_dirname = $xoopsModule->getVar('dirname');
 
-            $mod_url = XOOPS_URL . '/modules/' . $xoopsModule->getVar('dirname');
+            $mod_url = XOOPS_URL.'/modules/'.$xoopsModule->getVar('dirname');
 
             $modinfo = $xoopsModule->getInfo();
 
             $breadcrumbsObj = AltsysBreadcrumbs::getInstance();
 
-            $breadcrumbsObj->appendPath($mod_url . '/' . @$modinfo['adminindex'], $this->target_mname);
+            $breadcrumbsObj->appendPath($mod_url.'/'.@$modinfo['adminindex'], $this->target_mname);
 
-            $breadcrumbsObj->appendPath($mod_url . '/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', _MD_A_MYBLOCKSADMIN_BLOCKADMIN);
+            $breadcrumbsObj->appendPath($mod_url.'/admin/index.php?mode=admin&lib=altsys&page=myblocksadmin', _MD_A_MYBLOCKSADMIN_BLOCKADMIN);
         }
 
         // read xoops_version.php of the target
@@ -301,7 +301,7 @@ 
         } else {
             // origined from the table of `block_module_link`
 
-            $result = $this->db->query('SELECT module_id FROM ' . $this->db->prefix('block_module_link') . " WHERE block_id='$bid'");
+            $result = $this->db->query('SELECT module_id FROM '.$this->db->prefix('block_module_link')." WHERE block_id='$bid'");
 
             $selected_mids = [];
 
@@ -370,7 +370,7 @@ 
         } else {
             // origined from the table of `group_perm`
 
-            $result = $this->db->query('SELECT gperm_groupid FROM ' . $this->db->prefix('group_permission') . " WHERE gperm_itemid='$bid' AND gperm_name='block_read'");
+            $result = $this->db->query('SELECT gperm_groupid FROM '.$this->db->prefix('group_permission')." WHERE gperm_itemid='$bid' AND gperm_name='block_read'");
 
             $selected_gids = [];
 
@@ -473,31 +473,31 @@ 
 
         return "
                 <div class='blockposition $scol0'>
-                    <input type='radio' name='sides[$bid]' value='" . XOOPS_SIDEBLOCK_LEFT . "' class='blockposition' $ssel0 onclick='document.getElementById(\"extra_side_$bid\").value=" . XOOPS_SIDEBLOCK_LEFT . ";' />
+                    <input type='radio' name='sides[$bid]' value='".XOOPS_SIDEBLOCK_LEFT."' class='blockposition' $ssel0 onclick='document.getElementById(\"extra_side_$bid\").value=".XOOPS_SIDEBLOCK_LEFT.";' />
                 </div>
-                <div style='float:" . _GLOBAL_LEFT . ";'>-</div>
+                <div style='float:" . _GLOBAL_LEFT.";'>-</div>
                 <div class='blockposition $scol2'>
-                    <input type='radio' name='sides[$bid]' value='" . XOOPS_CENTERBLOCK_LEFT . "' class='blockposition' $ssel2 onclick='document.getElementById(\"extra_side_$bid\").value=" . XOOPS_CENTERBLOCK_LEFT . ";' />
+                    <input type='radio' name='sides[$bid]' value='".XOOPS_CENTERBLOCK_LEFT."' class='blockposition' $ssel2 onclick='document.getElementById(\"extra_side_$bid\").value=".XOOPS_CENTERBLOCK_LEFT.";' />
                 </div>
                 <div class='blockposition $scol3'>
-                    <input type='radio' name='sides[$bid]' value='" . XOOPS_CENTERBLOCK_CENTER . "' class='blockposition' $ssel3 onclick='document.getElementById(\"extra_side_$bid\").value=" . XOOPS_CENTERBLOCK_CENTER . ";' />
+                    <input type='radio' name='sides[$bid]' value='".XOOPS_CENTERBLOCK_CENTER."' class='blockposition' $ssel3 onclick='document.getElementById(\"extra_side_$bid\").value=".XOOPS_CENTERBLOCK_CENTER.";' />
                 </div>
                 <div class='blockposition $scol4'>
-                    <input type='radio' name='sides[$bid]' value='" . XOOPS_CENTERBLOCK_RIGHT . "' class='blockposition' $ssel4 onclick='document.getElementById(\"extra_side_$bid\").value=" . XOOPS_CENTERBLOCK_RIGHT . ";' />
+                    <input type='radio' name='sides[$bid]' value='".XOOPS_CENTERBLOCK_RIGHT."' class='blockposition' $ssel4 onclick='document.getElementById(\"extra_side_$bid\").value=".XOOPS_CENTERBLOCK_RIGHT.";' />
                 </div>
-                <div style='float:" . _GLOBAL_LEFT . ";'>-</div>
+                <div style='float:" . _GLOBAL_LEFT.";'>-</div>
                 <div class='blockposition $scol1'>
-                    <input type='radio' name='sides[$bid]' value='" . XOOPS_SIDEBLOCK_RIGHT . "' class='blockposition' $ssel1 onclick='document.getElementById(\"extra_side_$bid\").value=" . XOOPS_SIDEBLOCK_RIGHT . ";' />
+                    <input type='radio' name='sides[$bid]' value='".XOOPS_SIDEBLOCK_RIGHT."' class='blockposition' $ssel1 onclick='document.getElementById(\"extra_side_$bid\").value=".XOOPS_SIDEBLOCK_RIGHT.";' />
                 </div>
                 <br />
                 <br />
-                <div style='float:" . _GLOBAL_LEFT . ";width:50px;' class='$stextbox'>
-                    <input type='text' name='extra_sides[$bid]' value='" . $value4extra_side . "' style='width:20px;' id='extra_side_$bid' />
+                <div style='float:" . _GLOBAL_LEFT.";width:50px;' class='$stextbox'>
+                    <input type='text' name='extra_sides[$bid]' value='".$value4extra_side."' style='width:20px;' id='extra_side_$bid' />
                 </div>
                 <div class='blockposition $scoln'>
                     <input type='radio' name='sides[$bid]' value='-1' class='blockposition' $sseln onclick='document.getElementById(\"extra_side_$bid\").value=-1;' />
                 </div>
-                <div style='float:" . _GLOBAL_LEFT . ";'>" . _NONE . '</div>
+                <div style='float:"._GLOBAL_LEFT.";'>"._NONE.'</div>
     ';
     }
 
@@ -509,7 +509,7 @@ 
 
         // main query
 
-        $sql = 'SELECT * FROM ' . $this->db->prefix('newblocks') . " WHERE mid='$this->target_mid' ORDER BY visible DESC,side,weight";
+        $sql = 'SELECT * FROM '.$this->db->prefix('newblocks')." WHERE mid='$this->target_mid' ORDER BY visible DESC,side,weight";
 
         $result = $this->db->query($sql);
 
@@ -568,7 +568,7 @@ 
 
         // display
 
-        require_once XOOPS_TRUST_PATH . '/libs/altsys/class/D3Tpl.class.php';
+        require_once XOOPS_TRUST_PATH.'/libs/altsys/class/D3Tpl.class.php';
 
         $tpl = new D3Tpl();
 
@@ -595,7 +595,7 @@ 
             return [];
         }
 
-        include XOOPS_ROOT_PATH . '/modules/' . $this->target_dirname . '/xoops_version.php';
+        include XOOPS_ROOT_PATH.'/modules/'.$this->target_dirname.'/xoops_version.php';
 
         if (empty($modversion['blocks'])) {
             return [];
@@ -608,7 +608,7 @@ 
     {
         // query for getting blocks
 
-        $sql = 'SELECT * FROM ' . $this->db->prefix('newblocks') . " WHERE mid='$this->target_mid' ORDER BY visible DESC,side,weight";
+        $sql = 'SELECT * FROM '.$this->db->prefix('newblocks')." WHERE mid='$this->target_mid' ORDER BY visible DESC,side,weight";
 
         $result = $this->db->query($sql);
 
@@ -645,9 +645,9 @@ 
         // skip system (TODO)
 
         if ($this->target_mid > 1) {
-            $form->addAppendix('module_admin', $this->target_mid, $this->target_mname . ' ' . _MD_A_MYBLOCKSADMIN_PERM_MADMIN);
+            $form->addAppendix('module_admin', $this->target_mid, $this->target_mname.' '._MD_A_MYBLOCKSADMIN_PERM_MADMIN);
 
-            $form->addAppendix('module_read', $this->target_mid, $this->target_mname . ' ' . _MD_A_MYBLOCKSADMIN_PERM_MREAD);
+            $form->addAppendix('module_read', $this->target_mid, $this->target_mname.' '._MD_A_MYBLOCKSADMIN_PERM_MREAD);
         }
 
         foreach ($item_list as $item_id => $item_name) {
@@ -719,27 +719,27 @@ 
         $msg = _MD_A_MYBLOCKSADMIN_DBUPDATED;
 
         if (false != $block->store()) {
-            include_once XOOPS_ROOT_PATH . '/class/template.php';
+            include_once XOOPS_ROOT_PATH.'/class/template.php';
 
             $xoopsTpl = new XoopsTpl();
 
             $xoopsTpl->xoops_setCaching(2);
 
             if ('' != $block->getVar('template')) {
-                if ($xoopsTpl->is_cached('db:' . $block->getVar('template'))) {
-                    if (!$xoopsTpl->clear_cache('db:' . $block->getVar('template'))) {
-                        $msg = 'Unable to clear cache for block ID' . $bid;
+                if ($xoopsTpl->is_cached('db:'.$block->getVar('template'))) {
+                    if (!$xoopsTpl->clear_cache('db:'.$block->getVar('template'))) {
+                        $msg = 'Unable to clear cache for block ID'.$bid;
                     }
                 }
             } else {
-                if ($xoopsTpl->is_cached('db:system_dummy.tpl', 'blk_' . $bid)) {
-                    if (!$xoopsTpl->clear_cache('db:system_dummy.tpl', 'blk_' . $bid)) {
-                        $msg = 'Unable to clear cache for block ID' . $bid;
+                if ($xoopsTpl->is_cached('db:system_dummy.tpl', 'blk_'.$bid)) {
+                    if (!$xoopsTpl->clear_cache('db:system_dummy.tpl', 'blk_'.$bid)) {
+                        $msg = 'Unable to clear cache for block ID'.$bid;
                     }
                 }
             }
         } else {
-            $msg = 'Failed update of block. ID:' . $bid;
+            $msg = 'Failed update of block. ID:'.$bid;
         }
 
         return $msg;
@@ -1078,7 +1078,7 @@ 
         do {
             $func_num--;
 
-            list($count) = $this->db->fetchRow($this->db->query('SELECT COUNT(*) FROM ' . $this->db->prefix('newblocks') . ' WHERE mid=' . (int)$mid . ' AND func_num=' . $func_num));
+            list($count) = $this->db->fetchRow($this->db->query('SELECT COUNT(*) FROM '.$this->db->prefix('newblocks').' WHERE mid='.(int)$mid.' AND func_num='.$func_num));
         } while ($count > 0);
 
         return $func_num > 128 ? $func_num : 255;
@@ -1121,7 +1121,7 @@ 
             // permission copy
 
             foreach ($GLOBALS['xoopsUser']->getGroups() as $gid) {
-                $sql = 'INSERT INTO ' . $this->db->prefix('group_permission') . " (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES ($gid, $bid, 1, 'block_read')";
+                $sql = 'INSERT INTO '.$this->db->prefix('group_permission')." (gperm_groupid, gperm_itemid, gperm_modid, gperm_name) VALUES ($gid, $bid, 1, 'block_read')";
 
                 $this->db->query($sql);
             }
@@ -1259,7 +1259,7 @@ 
 
         // display
 
-        require_once XOOPS_TRUST_PATH . '/libs/altsys/class/D3Tpl.class.php';
+        require_once XOOPS_TRUST_PATH.'/libs/altsys/class/D3Tpl.class.php';
 
         $tpl = new D3Tpl();
 
@@ -1268,7 +1268,7 @@ 
         if (defined('XOOPS_CUBE_LEGACY')) {
             $tpl->assign('xoops_cube_legacy', true);
 
-            include_once XOOPS_ROOT_PATH . '/class/xoopsformloader.php';
+            include_once XOOPS_ROOT_PATH.'/class/xoopsformloader.php';
         } else {
             $tpl->assign('xoops_cube_legacy', false);
         }
@@ -1300,7 +1300,7 @@ 
 
     public function checkFck()
     {
-        return file_exists(XOOPS_ROOT_PATH . '/common/fckeditor/fckeditor.js');
+        return file_exists(XOOPS_ROOT_PATH.'/common/fckeditor/fckeditor.js');
     }
 
     /**
@@ -1373,14 +1373,14 @@ 
         // Ticket Check
 
         if (!$GLOBALS['xoopsSecurity']->check(true, 'myblocksadmin')) {
-            redirect_header(XOOPS_URL . '/', 3, $GLOBALS['xoopsSecurity']->getErrors());
+            redirect_header(XOOPS_URL.'/', 3, $GLOBALS['xoopsSecurity']->getErrors());
         }
 
         $msg = '';
 
         $bid = (int)(@$_GET['bid']);
 
-        if (! empty($_POST['preview'])) {
+        if (!empty($_POST['preview'])) {
             // preview
 
             $this->preview_request = $this->fetchRequest4Block($bid);
@@ -1407,12 +1407,12 @@ 
         } elseif (!empty($_POST['submit'])) {
             // update module_admin,module_read,block_read
 
-            include dirname(__DIR__) . '/include/mygroupperm.php';
+            include dirname(__DIR__).'/include/mygroupperm.php';
 
             $msg = _MD_A_MYBLOCKSADMIN_PERMUPDATED;
         }
 
-        redirect_header('?mode=admin&lib=altsys&page=myblocksadmin&dirname=' . $this->target_dirname, 1, $msg);
+        redirect_header('?mode=admin&lib=altsys&page=myblocksadmin&dirname='.$this->target_dirname, 1, $msg);
 
         exit;
     }

xoops_trust_path/libs/altsys/class/SetupAltsysLangMgr.class.php

Doc Comments +2 added lines, -2 removed lines

@@ -63,8 +63,8 @@
     }
 
     /**
-     * @param $dirname
-     * @param $fileBodyName
+     * @param string $dirname
+     * @param string $fileBodyName
      */
 
     public function _loadLanguage($dirname, $fileBodyName)

Spacing +10 added lines, -10 removed lines

@@ -5,12 +5,12 @@ 
 }
 
 if (!defined('XOOPS_TRUST_PATH') || XOOPS_TRUST_PATH == '') {
-    header('Location: ' . XOOPS_URL . '/modules/altsys/setup_xoops_trust_path.php');
+    header('Location: '.XOOPS_URL.'/modules/altsys/setup_xoops_trust_path.php');
 
     exit;
 }
 
-define('ALTSYS_MYLANGUAGE_ROOT_PATH', XOOPS_ROOT_PATH . '/my_language');
+define('ALTSYS_MYLANGUAGE_ROOT_PATH', XOOPS_ROOT_PATH.'/my_language');
 
 /**
  * Class SetupAltsysLangMgr
@@ -33,8 +33,8 @@ 
     }
 }
 
-require_once XOOPS_ROOT_PATH . '/core/XCube_LanguageManager.class.php';
-require_once XOOPS_ROOT_PATH . '/modules/legacy/kernel/Legacy_LanguageManager.class.php';
+require_once XOOPS_ROOT_PATH.'/core/XCube_LanguageManager.class.php';
+require_once XOOPS_ROOT_PATH.'/modules/legacy/kernel/Legacy_LanguageManager.class.php';
 
 /**
  * Class AltsysLangMgr_LanguageManager
@@ -47,7 +47,7 @@ 
 
     public function prepare()
     {
-        $langmanpath = XOOPS_TRUST_PATH . '/libs/altsys/class/D3LanguageManager.class.php';
+        $langmanpath = XOOPS_TRUST_PATH.'/libs/altsys/class/D3LanguageManager.class.php';
 
         if (!is_file($langmanpath)) {
             die('install the latest altsys');
@@ -75,12 +75,12 @@ 
             $root = XCube_Root::getSingleton();
 
             if (!empty($root->mContext->mXoopsConfig['theme_set'])) {
-                $langdir = XOOPS_THEME_PATH . '/' . $root->mContext->mXoopsConfig['theme_set'] . '/language';
+                $langdir = XOOPS_THEME_PATH.'/'.$root->mContext->mXoopsConfig['theme_set'].'/language';
 
                 if (file_exists($langdir)) {
-                    $langfile = $langdir . '/' . $this->mLanguageName . '.php';
+                    $langfile = $langdir.'/'.$this->mLanguageName.'.php';
 
-                    $engfile = $langdir . '/english.php';
+                    $engfile = $langdir.'/english.php';
 
                     if (is_file($langfile)) {
                         require_once $langfile;
@@ -95,7 +95,7 @@ 
 
         // read normal
 
-        $this->langman->read($fileBodyName . '.php', $dirname);
+        $this->langman->read($fileBodyName.'.php', $dirname);
     }
 
     /**
@@ -107,7 +107,7 @@ 
         // I dare not to use langman...
 
         if (false === mb_strpos($type, '.') && $this->langman->my_language) {
-            $mylang_file = $this->langman->my_language . '/' . $this->mLanguageName . '/' . $type . '.php';
+            $mylang_file = $this->langman->my_language.'/'.$this->mLanguageName.'/'.$type.'.php';
 
             if (is_file($mylang_file)) {
                 require_once $mylang_file;

xoops_trust_path/libs/altsys/include/altsys_functions.php

Doc Comments +2 added lines, -2 removed lines

@@ -130,8 +130,8 @@
 }
 
 /**
- * @param $mid
- * @param $coretype
+ * @param integer $mid
+ * @param integer|null $coretype
  * @return string
  */
 function altsys_get_link2modpreferences($mid, $coretype)

Spacing +16 added lines, -16 removed lines

@@ -45,17 +45,17 @@ 
     global $xoopsModule, $xoopsConfig, $mydirname, $mydirpath, $mytrustdirname, $mytrustdirpath, $mymenu_fake_uri;
 
     $mymenu_find_paths = [
-        $mydirpath . '/admin/mymenu.php',
-        $mydirpath . '/mymenu.php',
-        $mytrustdirpath . '/admin/mymenu.php',
-        $mytrustdirpath . '/mymenu.php',
+        $mydirpath.'/admin/mymenu.php',
+        $mydirpath.'/mymenu.php',
+        $mytrustdirpath.'/admin/mymenu.php',
+        $mytrustdirpath.'/mymenu.php',
     ];
 
     foreach ($mymenu_find_paths as $mymenu_find_path) {
         if (is_file($mymenu_find_path)) {
             include $mymenu_find_path;
 
-            include_once __DIR__ . '/adminmenu_functions.php';
+            include_once __DIR__.'/adminmenu_functions.php';
 
             altsys_adminmenu_insert_mymenu($xoopsModule);
 
@@ -73,14 +73,14 @@ 
 {
     $mylang = $GLOBALS['xoopsConfig']['language'];
 
-    if (is_file(XOOPS_ROOT_PATH . '/modules/altsys/language/' . $mylang . '/' . $type . '.php')) {
-        include_once XOOPS_ROOT_PATH . '/modules/altsys/language/' . $mylang . '/' . $type . '.php';
-    } elseif (is_file(XOOPS_TRUST_PATH . '/libs/altsys/language/' . $mylang . '/' . $type . '.php')) {
-        include_once XOOPS_TRUST_PATH . '/libs/altsys/language/' . $mylang . '/' . $type . '.php';
-    } elseif (is_file(XOOPS_ROOT_PATH . '/modules/altsys/language/english/' . $type . '.php')) {
-        include_once XOOPS_ROOT_PATH . '/modules/altsys/language/english/' . $type . '.php';
-    } elseif (is_file(XOOPS_TRUST_PATH . '/libs/altsys/language/english/' . $type . '.php')) {
-        include_once XOOPS_TRUST_PATH . '/libs/altsys/language/english/' . $type . '.php';
+    if (is_file(XOOPS_ROOT_PATH.'/modules/altsys/language/'.$mylang.'/'.$type.'.php')) {
+        include_once XOOPS_ROOT_PATH.'/modules/altsys/language/'.$mylang.'/'.$type.'.php';
+    } elseif (is_file(XOOPS_TRUST_PATH.'/libs/altsys/language/'.$mylang.'/'.$type.'.php')) {
+        include_once XOOPS_TRUST_PATH.'/libs/altsys/language/'.$mylang.'/'.$type.'.php';
+    } elseif (is_file(XOOPS_ROOT_PATH.'/modules/altsys/language/english/'.$type.'.php')) {
+        include_once XOOPS_ROOT_PATH.'/modules/altsys/language/english/'.$type.'.php';
+    } elseif (is_file(XOOPS_TRUST_PATH.'/libs/altsys/language/english/'.$type.'.php')) {
+        include_once XOOPS_TRUST_PATH.'/libs/altsys/language/english/'.$type.'.php';
     }
 }
 
@@ -144,9 +144,9 @@ 
         case ALTSYS_CORE_TYPE_X23P:
         case ALTSYS_CORE_TYPE_ICMS:
         default:
-            return XOOPS_URL . '/modules/system/admin.php?fct=preferences&op=showmod&mod=' . $mid;
+            return XOOPS_URL.'/modules/system/admin.php?fct=preferences&op=showmod&mod='.$mid;
         case ALTSYS_CORE_TYPE_XCL21:
-            return XOOPS_URL . '/modules/legacy/admin/index.php?action=PreferenceEdit&confmod_id=' . $mid;
+            return XOOPS_URL.'/modules/legacy/admin/index.php?action=PreferenceEdit&confmod_id='.$mid;
     }
 }
 
@@ -179,7 +179,7 @@ 
             continue;
         }
 
-        @unlink(XOOPS_COMPILE_PATH . '/' . $file);
+        @unlink(XOOPS_COMPILE_PATH.'/'.$file);
     }
 
     closedir($dh);

xoops_trust_path/libs/altsys/include/Archive_Zip.php

Doc Comments +13 added lines, -10 removed lines

@@ -142,6 +142,9 @@ 
 
     //  function Archive_Zip($p_zipname)
 
+    /**
+     * @param string $p_zipname
+     */
     public function __construct($p_zipname)
     {
         // ----- Check the zlib
@@ -185,7 +188,7 @@ 
      * @param  mixed $p_filelist   The list of the files or folders to add.
      *                             It can be a string with filenames separated
      *                             by a comma, or an array of filenames.
-     * @param  mixed $p_params     An array of variable parameters and values.
+     * @param  integer $p_params     An array of variable parameters and values.
      * @return mixed An array of file description on success,
      *                             an error code on error
      */
@@ -263,7 +266,7 @@ 
      * @param    mixed $p_filelist   The list of the files or folders to add.
      *                               It can be a string with filenames separated
      *                               by a comma, or an array of filenames.
-     * @param    mixed $p_params     An array of variable parameters and values.
+     * @param    integer $p_params     An array of variable parameters and values.
      * @return mixed An array of file description on success,
      *                               0 on an unrecoverable failure, an error code is logged.
      */
@@ -430,7 +433,7 @@ 
      *                            each entry extraction.
      *
      * @access public
-     * @param    mixed $p_params An array of variable parameters and values.
+     * @param    integer $p_params An array of variable parameters and values.
      * @return mixed An array of file description on success,
      *                           0 on an unrecoverable failure, an error code is logged.
      */
@@ -1194,7 +1197,7 @@ 
      * Archive_Zip::_openFd()
      *
      * { Description }
-     * @param $p_mode
+     * @param string $p_mode
      * @return int
      */
 
@@ -1530,7 +1533,7 @@ 
      * Archive_Zip::_addFile()
      *
      * { Description }
-     * @param $p_filename
+     * @param boolean|string $p_filename
      * @param $p_add_dir
      * @param $p_remove_dir
      * @param $p_remove_all_dir
@@ -1997,7 +2000,7 @@ 
      * @param $p_nb_entries
      * @param $p_size
      * @param $p_offset
-     * @param $p_comment
+     * @param string $p_comment
      * @return int
      */
 
@@ -4376,8 +4379,8 @@ 
      *
      * { Description }
      *
-     * @param         $p_src
-     * @param         $p_dest
+     * @param         integer $p_src
+     * @param         integer $p_dest
      * @param         $p_size
      * @param int $p_mode
      * @return int
@@ -4464,8 +4467,8 @@ 
      * _tool_Rename()
      *
      * { Description }
-     * @param $p_src
-     * @param $p_dest
+     * @param string $p_src
+     * @param string $p_dest
      * @return int
      */
 

Spacing +44 added lines, -44 removed lines

@@ -151,7 +151,7 @@ 
               }*/ // GIJ
 
         if (!extension_loaded('zlib')) {
-            die("The extension 'zlib' couldn't be found.\n" . 'Please make sure your version of PHP was built ' . "with 'zlib' support.\n");
+            die("The extension 'zlib' couldn't be found.\n".'Please make sure your version of PHP was built '."with 'zlib' support.\n");
 
             return false;
         }
@@ -533,7 +533,7 @@ 
             && ('' == $p_params['by_index'])
             && ('' == $p_params['by_ereg'])
             && ('' == $p_params['by_preg'])) {
-            $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAMETER, 'At least one filtering rule must' . ' be set as parameter');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAMETER, 'At least one filtering rule must'.' be set as parameter');
 
             return 0;
         }
@@ -593,7 +593,7 @@ 
             // ----- Open the zip file
 
             if (0 == ($this->_zip_fd = @fopen($this->_zipname, 'rb'))) {
-                $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->_zipname . '\' in binary read mode');
+                $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->_zipname.'\' in binary read mode');
 
                 return 0;
             }
@@ -652,7 +652,7 @@ 
             // TBC : Should also check the archive format
 
             if (!is_file($p_archive)) {
-                $this->_errorLog(ARCHIVE_ZIP_ERR_MISSING_FILE, "No file with filename '" . $p_archive . "'");
+                $this->_errorLog(ARCHIVE_ZIP_ERR_MISSING_FILE, "No file with filename '".$p_archive."'");
 
                 $v_result = ARCHIVE_ZIP_ERR_MISSING_FILE;
             } else {
@@ -774,7 +774,7 @@ 
         }
 
         if ($p_with_code) {
-            return ($v_value . ' (' . $this->_error_code . ')');
+            return ($v_value.' ('.$this->_error_code.')');
         }
 
         return $v_value;
@@ -798,10 +798,10 @@ 
     public function errorInfo($p_full = false)
     {
         if ($p_full) {
-            return ($this->errorName(true) . ' : ' . $this->_error_string);
+            return ($this->errorName(true).' : '.$this->_error_string);
         }
 
-        return ($this->_error_string . ' [code ' . $this->_error_code . ']');
+        return ($this->_error_string.' [code '.$this->_error_code.']');
     }
 
     // }}}
@@ -866,7 +866,7 @@ 
         if (!is_file($this->_zipname)) {
             // ----- Error log
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_MISSING_FILE, "Missing archive file '" . $this->_zipname . "'");
+            $this->_errorLog(ARCHIVE_ZIP_ERR_MISSING_FILE, "Missing archive file '".$this->_zipname."'");
 
             return false;
         }
@@ -876,7 +876,7 @@ 
         if (!is_readable($this->_zipname)) {
             // ----- Error log
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, "Unable to read archive '" . $this->_zipname . "'");
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, "Unable to read archive '".$this->_zipname."'");
 
             return false;
         }
@@ -1021,14 +1021,14 @@ 
 
         // ----- Creates a temporay file
 
-        $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR . uniqid('archive_zip-') . '.tmp';
+        $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR.uniqid('archive_zip-').'.tmp';
 
         // ----- Open the temporary file in write mode
 
         if (0 == ($v_zip_temp_fd = @fopen($v_zip_temp_name, 'wb'))) {
             $this->_closeFd();
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_zip_temp_name . '\' in binary write mode');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_zip_temp_name.'\' in binary write mode');
 
             return self::errorCode();
         }
@@ -1205,7 +1205,7 @@ 
         // ----- Look if already open
 
         if (0 != $this->_zip_fd) {
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Zip file \'' . $this->_zipname . '\' already open');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Zip file \''.$this->_zipname.'\' already open');
 
             return self::errorCode();
         }
@@ -1213,7 +1213,7 @@ 
         // ----- Open the zip file
 
         if (0 == ($this->_zip_fd = @fopen($this->_zipname, $p_mode))) {
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->_zipname . '\' in ' . $p_mode . ' mode');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->_zipname.'\' in '.$p_mode.' mode');
 
             return self::errorCode();
         }
@@ -1462,7 +1462,7 @@ 
                 // ----- Look for path
 
                 if ('.' != $p_filename) {
-                    $v_path = $p_filename . '/';
+                    $v_path = $p_filename.'/';
                 } else {
                     $v_path = '';
                 }
@@ -1476,10 +1476,10 @@ 
                 while ($p_hitem = readdir($p_hdir)) {
                     // ----- Look for a file
 
-                    if (is_file($v_path . $p_hitem)) {
+                    if (is_file($v_path.$p_hitem)) {
                         // ----- Add the file
 
-                        if (1 != ($v_result = $this->_addFile($v_path . $p_hitem, $v_header, $p_add_dir, $p_remove_dir, $p_remove_all_dir, $p_params))) {
+                        if (1 != ($v_result = $this->_addFile($v_path.$p_hitem, $v_header, $p_add_dir, $p_remove_dir, $p_remove_all_dir, $p_params))) {
                             // ----- Return status
 
                             return $v_result;
@@ -1493,7 +1493,7 @@ 
                     else {
                         // ----- Need an array as parameter
 
-                        $p_temp_list[0] = $v_path . $p_hitem;
+                        $p_temp_list[0] = $v_path.$p_hitem;
 
                         $v_result = $this->_addFileList($p_temp_list, $p_result_list, $p_add_dir, $p_remove_dir, $p_remove_all_dir, $p_params);
 
@@ -1570,7 +1570,7 @@ 
 
             if (('./' == mb_substr($p_filename, 0, 2)) || ('./' == mb_substr($p_remove_dir, 0, 2))) {
                 if (('./' == mb_substr($p_filename, 0, 2)) && ('./' != mb_substr($p_remove_dir, 0, 2))) {
-                    $p_remove_dir = './' . $p_remove_dir;
+                    $p_remove_dir = './'.$p_remove_dir;
                 }
 
                 if (('./' != mb_substr($p_filename, 0, 2)) && ('./' == mb_substr($p_remove_dir, 0, 2))) {
@@ -1595,9 +1595,9 @@ 
 
         if ('' != $p_add_dir) {
             if ('/' == mb_substr($p_add_dir, -1)) {
-                $v_stored_filename = $p_add_dir . $v_stored_filename;
+                $v_stored_filename = $p_add_dir.$v_stored_filename;
             } else {
-                $v_stored_filename = $p_add_dir . '/' . $v_stored_filename;
+                $v_stored_filename = $p_add_dir.'/'.$v_stored_filename;
             }
         }
 
@@ -1679,7 +1679,7 @@ 
 
             // header.
 
-            eval('$v_result = ' . $p_params[ARCHIVE_ZIP_PARAM_PRE_ADD] . '(ARCHIVE_ZIP_PARAM_PRE_ADD, $v_local_header);');
+            eval('$v_result = '.$p_params[ARCHIVE_ZIP_PARAM_PRE_ADD].'(ARCHIVE_ZIP_PARAM_PRE_ADD, $v_local_header);');
 
             if (0 == $v_result) {
                 // ----- Change the file status
@@ -1762,7 +1762,7 @@ 
 
                 // ----- Write the compressed content
 
-                $v_binary_data = pack('a' . $p_header['compressed_size'], $v_content_compressed);
+                $v_binary_data = pack('a'.$p_header['compressed_size'], $v_content_compressed);
 
                 @fwrite($this->_zip_fd, $v_binary_data, $p_header['compressed_size']);
 
@@ -1780,7 +1780,7 @@ 
 
                 $p_header['size'] = 0;
 
-                $p_header['external'] = 0x41FF0010;   // Value for a folder : to be checked
+                $p_header['external'] = 0x41FF0010; // Value for a folder : to be checked
 
                 // ----- Call the header generation
 
@@ -1806,7 +1806,7 @@ 
 
             // header.
 
-            eval('$v_result = ' . $p_params[ARCHIVE_ZIP_PARAM_POST_ADD] . '(ARCHIVE_ZIP_PARAM_POST_ADD, $v_local_header);');
+            eval('$v_result = '.$p_params[ARCHIVE_ZIP_PARAM_POST_ADD].'(ARCHIVE_ZIP_PARAM_POST_ADD, $v_local_header);');
 
             if (0 == $v_result) {
                 // ----- Ignored
@@ -2055,7 +2055,7 @@ 
         if (0 == ($this->_zip_fd = @fopen($this->_zipname, 'rb'))) {
             // ----- Error log
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \'' . $this->_zipname . '\' in binary read mode');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive \''.$this->_zipname.'\' in binary read mode');
 
             // ----- Return
 
@@ -2246,7 +2246,7 @@ 
             || (('/' != mb_substr($p_path, 0, 1))
                 && ('../' != mb_substr($p_path, 0, 3))
                 && (':/' != mb_substr($p_path, 1, 2)))) {
-            $p_path = './' . $p_path;
+            $p_path = './'.$p_path;
         }
 
         // ----- Reduce the path last (and duplicated) '/'
@@ -2549,7 +2549,7 @@ 
         // ----- Add the path
 
         if ('' != $p_path) {
-            $p_entry['filename'] = $p_path . '/' . $p_entry['filename'];
+            $p_entry['filename'] = $p_path.'/'.$p_entry['filename'];
         }
 
         // ----- Look for pre-extract callback
@@ -2568,7 +2568,7 @@ 
 
             // header.
 
-            eval('$v_result = ' . $p_params[ARCHIVE_ZIP_PARAM_PRE_EXTRACT] . '(ARCHIVE_ZIP_PARAM_PRE_EXTRACT, $v_local_header);');
+            eval('$v_result = '.$p_params[ARCHIVE_ZIP_PARAM_PRE_EXTRACT].'(ARCHIVE_ZIP_PARAM_PRE_EXTRACT, $v_local_header);');
 
             if (0 == $v_result) {
                 // ----- Change the file status
@@ -2674,7 +2674,7 @@ 
 
                         $v_buffer = fread($this->_zip_fd, $v_read_size);
 
-                        $v_binary_data = pack('a' . $v_read_size, $v_buffer);
+                        $v_binary_data = pack('a'.$v_read_size, $v_buffer);
 
                         @fwrite($v_dest_file, $v_binary_data, $v_read_size);
 
@@ -2753,7 +2753,7 @@ 
 
             // header.
 
-            eval('$v_result = ' . $p_params[ARCHIVE_ZIP_PARAM_POST_EXTRACT] . '(ARCHIVE_ZIP_PARAM_POST_EXTRACT, $v_local_header);');
+            eval('$v_result = '.$p_params[ARCHIVE_ZIP_PARAM_POST_EXTRACT].'(ARCHIVE_ZIP_PARAM_POST_EXTRACT, $v_local_header);');
         }
 
         // ----- Return
@@ -2894,7 +2894,7 @@ 
 
             // ----- Error log
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid block size : ' . mb_strlen($v_binary_data));
+            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid block size : '.mb_strlen($v_binary_data));
 
             // ----- Return
 
@@ -3037,7 +3037,7 @@ 
 
             // ----- Error log
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid block size : ' . mb_strlen($v_binary_data));
+            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid block size : '.mb_strlen($v_binary_data));
 
             // ----- Return
 
@@ -3152,7 +3152,7 @@ 
         @fseek($this->_zip_fd, $v_size);
 
         if (@ftell($this->_zip_fd) != $v_size) {
-            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to go to the end of the archive \'' . $this->_zipname . '\'');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to go to the end of the archive \''.$this->_zipname.'\'');
 
             return self::errorCode();
         }
@@ -3169,7 +3169,7 @@ 
             @fseek($this->_zip_fd, $v_size - 22);
 
             if (($v_pos = @ftell($this->_zip_fd)) != ($v_size - 22)) {
-                $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \'' . $this->_zipname . '\'');
+                $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \''.$this->_zipname.'\'');
 
                 return self::errorCode();
             }
@@ -3201,7 +3201,7 @@ 
             @fseek($this->_zip_fd, $v_size - $v_maximum_size);
 
             if (@ftell($this->_zip_fd) != ($v_size - $v_maximum_size)) {
-                $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \'' . $this->_zipname . '\'');
+                $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Unable to seek back to the middle of the archive \''.$this->_zipname.'\'');
 
                 return self::errorCode();
             }
@@ -3248,7 +3248,7 @@ 
         // ----- Look for invalid block size
 
         if (18 != mb_strlen($v_binary_data)) {
-            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid End of Central Dir Record size : ' . mb_strlen($v_binary_data));
+            $this->_errorLog(ARCHIVE_ZIP_ERR_BAD_FORMAT, 'Invalid End of Central Dir Record size : '.mb_strlen($v_binary_data));
 
             return self::errorCode();
         }
@@ -3405,7 +3405,7 @@ 
                             && (mb_substr($v_header_list[$v_nb_extracted]['stored_filename'], 0, mb_strlen($p_params[ARCHIVE_ZIP_PARAM_BY_NAME][$j])) == $p_params[ARCHIVE_ZIP_PARAM_BY_NAME][$j])) {
                             $v_found = true;
                         } elseif ((0x00000010 == ($v_header_list[$v_nb_extracted]['external'] & 0x00000010)) /* Indicates a folder */
-                                  && ($v_header_list[$v_nb_extracted]['stored_filename'] . '/' == $p_params[ARCHIVE_ZIP_PARAM_BY_NAME][$j])) {
+                                  && ($v_header_list[$v_nb_extracted]['stored_filename'].'/' == $p_params[ARCHIVE_ZIP_PARAM_BY_NAME][$j])) {
                             $v_found = true;
                         }
                     } // ----- Look for a filename
@@ -3465,7 +3465,7 @@ 
         if ($v_nb_extracted > 0) {
             // ----- Creates a temporay file
 
-            $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR . uniqid('archive_zip-') . '.tmp';
+            $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR.uniqid('archive_zip-').'.tmp';
 
             // ----- Creates a temporary zip archive
 
@@ -3807,7 +3807,7 @@ 
 
         // ----- Creates a temporay file
 
-        $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR . uniqid('archive_zip-') . '.tmp';
+        $v_zip_temp_name = ARCHIVE_ZIP_TEMPORARY_DIR.uniqid('archive_zip-').'.tmp';
 
         // ----- Open the temporary file in write mode
 
@@ -3816,7 +3816,7 @@ 
 
             $p_archive_to_add->_closeFd();
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \'' . $v_zip_temp_name . '\' in binary write mode');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open temporary file \''.$v_zip_temp_name.'\' in binary write mode');
 
             return self::errorCode();
         }
@@ -4015,7 +4015,7 @@ 
         if (0 == ($v_zip_temp_fd = @fopen($p_archive_filename, 'rb'))) {
             $this->_closeFd();
 
-            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive file \'' . $p_archive_filename . '\' in binary write mode');
+            $this->_errorLog(ARCHIVE_ZIP_ERR_READ_OPEN_FAIL, 'Unable to open archive file \''.$p_archive_filename.'\' in binary write mode');
 
             return self::errorCode();
         }
@@ -4077,7 +4077,7 @@ 
 
         for (reset($p_params); list($v_key, $v_value) = each($p_params);) {
             if (!isset($p_default[$v_key])) {
-                $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAMETER, 'Unsupported parameter with key \'' . $v_key . '\'');
+                $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAMETER, 'Unsupported parameter with key \''.$v_key.'\'');
 
                 return self::errorCode();
             }
@@ -4105,7 +4105,7 @@ 
 
             if (isset($p_params[$v_key]) && ('' != $p_params[$v_key])) {
                 if (!function_exists($p_params[$v_key])) {
-                    $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAM_VALUE, "Callback '" . $p_params[$v_key] . "()' is not an existing function for " . "parameter '" . $v_key . "'");
+                    $this->_errorLog(ARCHIVE_ZIP_ERR_INVALID_PARAM_VALUE, "Callback '".$p_params[$v_key]."()' is not an existing function for "."parameter '".$v_key."'");
 
                     return self::errorCode();
                 }
@@ -4217,7 +4217,7 @@ 
                     // ----- Ignore only the double '//' in path,
                     // but not the first and last '/'
                 } else {
-                    $v_result = $v_list[$i] . ($i != (count($v_list) - 1) ? '/' . $v_result : '');
+                    $v_result = $v_list[$i].($i != (count($v_list) - 1) ? '/'.$v_result : '');
                 }
             }
         }

xoops_trust_path/libs/altsys/include/gtickets.php

Doc Comments +3 added lines, -3 removed lines

@@ -191,7 +191,7 @@ 
          * @param bool   $post
          * @param string $area
          * @param bool   $allow_repost
-         * @return bool
+         * @return null|boolean
          */
 
         public function check($post = true, $area = '', $allow_repost = true)
@@ -362,9 +362,9 @@ 
         }
 
         /**
-         * @param $key_name
+         * @param string $key_name
          * @param $tmp_array
-         * @return array
+         * @return string[]
          */
 
         public function extract_post_recursive($key_name, $tmp_array)

Spacing +20 added lines, -20 removed lines

@@ -28,8 +28,8 @@ 
             // language file
 
             if (defined('XOOPS_ROOT_PATH') && !empty($xoopsConfig['language']) && !mb_strstr($xoopsConfig['language'], '/')) {
-                if (is_file(dirname(__DIR__) . '/language/' . $xoopsConfig['language'] . '/gticket_messages.phtml')) {
-                    include dirname(__DIR__) . '/language/' . $xoopsConfig['language'] . '/gticket_messages.phtml';
+                if (is_file(dirname(__DIR__).'/language/'.$xoopsConfig['language'].'/gticket_messages.phtml')) {
+                    include dirname(__DIR__).'/language/'.$xoopsConfig['language'].'/gticket_messages.phtml';
                 }
             }
 
@@ -60,7 +60,7 @@ 
 
         public function getTicketHtml($salt = '', $timeout = 1800, $area = '')
         {
-            return '<input type="hidden" name="XOOPS_G_TICKET" value="' . $this->issue($salt, $timeout, $area) . '" />';
+            return '<input type="hidden" name="XOOPS_G_TICKET" value="'.$this->issue($salt, $timeout, $area).'" />';
         }
 
         // returns an object of XoopsFormHidden including theh ticket
@@ -117,7 +117,7 @@ 
 
         public function getTicketParamString($salt = '', $noamp = false, $timeout = 1800, $area = '')
         {
-            return ($noamp ? '' : '&amp;') . 'XOOPS_G_TICKET=' . $this->issue($salt, $timeout, $area);
+            return ($noamp ? '' : '&amp;').'XOOPS_G_TICKET='.$this->issue($salt, $timeout, $area);
         }
 
         // issue a ticket
@@ -135,9 +135,9 @@ 
 
             if ('' === $salt) {
                 if (version_compare(PHP_VERSION, '7.0.0') >= 0 && function_exists('random_bytes')) {
-                    $salt = '$2y$07$' . str_replace('+', '.', base64_encode(random_bytes(self::PBKDF2_SALT_BYTES)));
+                    $salt = '$2y$07$'.str_replace('+', '.', base64_encode(random_bytes(self::PBKDF2_SALT_BYTES)));
                 } elseif (function_exists('mcrypt_create_iv')) {
-                    $salt = '$2y$07$' . str_replace('+', '.', base64_encode(mcrypt_create_iv(16, MCRYPT_DEV_URANDOM)));
+                    $salt = '$2y$07$'.str_replace('+', '.', base64_encode(mcrypt_create_iv(16, MCRYPT_DEV_URANDOM)));
                 }
             }
 
@@ -147,7 +147,7 @@ 
 
             $appendix_salt = empty($_SERVER['PATH']) ? XOOPS_DB_NAME : $_SERVER['PATH'];
 
-            $token = crypt($salt . $usec . $appendix_salt . $sec, $salt);
+            $token = crypt($salt.$usec.$appendix_salt.$sec, $salt);
 
             $this->_latest_token = $token;
 
@@ -182,7 +182,7 @@ 
 
             // paid md5ed token as a ticket
 
-            return md5($token . XOOPS_DB_PREFIX);
+            return md5($token.XOOPS_DB_PREFIX);
         }
 
         // check a ticket
@@ -228,7 +228,7 @@ 
                 // default lifetime 30min
 
                 if ($stub['expire'] >= time()) {
-                    if (md5($stub['token'] . XOOPS_DB_PREFIX) === $ticket) {
+                    if (md5($stub['token'].XOOPS_DB_PREFIX) === $ticket) {
                         $found_stub = $stub;
                     } else {
                         // store the other valid stubs into session
@@ -236,7 +236,7 @@ 
                         $_SESSION['XOOPS_G_STUBS'][] = $stub;
                     }
                 } else {
-                    if (md5($stub['token'] . XOOPS_DB_PREFIX) === $ticket) {
+                    if (md5($stub['token'].XOOPS_DB_PREFIX) === $ticket) {
                         // not CSRF but Time-Out
 
                         $timeout_flag = true;
@@ -321,7 +321,7 @@ 
 
             $table = '<table>';
 
-            $form = '<form action="?' . htmlspecialchars(@$_SERVER['QUERY_STRING'], ENT_QUOTES) . '" method="post" >';
+            $form = '<form action="?'.htmlspecialchars(@$_SERVER['QUERY_STRING'], ENT_QUOTES).'" method="post" >';
 
             foreach ($_POST as $key => $val) {
                 if ('XOOPS_G_TICKET' == $key) {
@@ -343,22 +343,22 @@ 
                         $val = stripslashes($val);
                     }
 
-                    $table .= '<tr><th>' . htmlspecialchars($key, ENT_QUOTES) . '</th><td>' . htmlspecialchars($val, ENT_QUOTES) . '</td></tr>' . "\n";
+                    $table .= '<tr><th>'.htmlspecialchars($key, ENT_QUOTES).'</th><td>'.htmlspecialchars($val, ENT_QUOTES).'</td></tr>'."\n";
 
-                    $form .= '<input type="hidden" name="' . htmlspecialchars($key, ENT_QUOTES) . '" value="' . htmlspecialchars($val, ENT_QUOTES) . '" />' . "\n";
+                    $form .= '<input type="hidden" name="'.htmlspecialchars($key, ENT_QUOTES).'" value="'.htmlspecialchars($val, ENT_QUOTES).'" />'."\n";
                 }
             }
 
             $table .= '</table>';
 
-            $form .= $this->getTicketHtml(__LINE__, 300, $area) . '<input type="submit" value="' . $this->messages['btn_repost'] . '" /></form>';
+            $form .= $this->getTicketHtml(__LINE__, 300, $area).'<input type="submit" value="'.$this->messages['btn_repost'].'" /></form>';
 
             error_reporting(0);
 
             while (@ob_get_level() && @ob_end_clean()) {
             }
 
-            echo '<html><head><title>' . $this->messages['err_general'] . '</title><style>table,td,th {border:solid black 1px; border-collapse:collapse;}</style></head><body>' . sprintf($this->messages['fmt_prompt4repost'], $this->getErrors()) . $table . $form . '</body></html>';
+            echo '<html><head><title>'.$this->messages['err_general'].'</title><style>table,td,th {border:solid black 1px; border-collapse:collapse;}</style></head><body>'.sprintf($this->messages['fmt_prompt4repost'], $this->getErrors()).$table.$form.'</body></html>';
         }
 
         /**
@@ -379,7 +379,7 @@ 
                 }
 
                 if (is_array($val)) {
-                    list($tmp_table, $tmp_form) = $this->extract_post_recursive($key_name . '[' . htmlspecialchars($key, ENT_QUOTES) . ']', $val);
+                    list($tmp_table, $tmp_form) = $this->extract_post_recursive($key_name.'['.htmlspecialchars($key, ENT_QUOTES).']', $val);
 
                     $table .= $tmp_table;
 
@@ -389,9 +389,9 @@ 
                         $val = stripslashes($val);
                     }
 
-                    $table .= '<tr><th>' . $key_name . '[' . htmlspecialchars($key, ENT_QUOTES) . ']</th><td>' . htmlspecialchars($val, ENT_QUOTES) . '</td></tr>' . "\n";
+                    $table .= '<tr><th>'.$key_name.'['.htmlspecialchars($key, ENT_QUOTES).']</th><td>'.htmlspecialchars($val, ENT_QUOTES).'</td></tr>'."\n";
 
-                    $form .= '<input type="hidden" name="' . $key_name . '[' . htmlspecialchars($key, ENT_QUOTES) . ']" value="' . htmlspecialchars($val, ENT_QUOTES) . '" />' . "\n";
+                    $form .= '<input type="hidden" name="'.$key_name.'['.htmlspecialchars($key, ENT_QUOTES).']" value="'.htmlspecialchars($val, ENT_QUOTES).'" />'."\n";
                 }
             }
 
@@ -451,8 +451,8 @@ 
 
         public function errorHandler4FindOutput($errNo, $errStr, $errFile, $errLine)
         {
-            if (preg_match('?' . preg_quote(XOOPS_ROOT_PATH) . '([^:]+)\:(\d+)?', $errStr, $regs)) {
-                echo 'Irregular output! check the file ' . htmlspecialchars($regs[1], ENT_QUOTES | ENT_HTML5) . ' line ' . htmlspecialchars($regs[2], ENT_QUOTES | ENT_HTML5);
+            if (preg_match('?'.preg_quote(XOOPS_ROOT_PATH).'([^:]+)\:(\d+)?', $errStr, $regs)) {
+                echo 'Irregular output! check the file '.htmlspecialchars($regs[1], ENT_QUOTES | ENT_HTML5).' line '.htmlspecialchars($regs[2], ENT_QUOTES | ENT_HTML5);
             } else {
                 echo 'Irregular output! check language files etc.';
             }

xoops_trust_path/libs/altsys/include/mygrouppermform.php

Doc Comments +10 added lines, -4 removed lines

@@ -82,6 +82,12 @@ 
 
     //  public function MyXoopsGroupPermForm($title, $modid, $permname, $permdesc)
 
+    /**
+     * @param string $title
+     * @param integer $modid
+     * @param string $permname
+     * @param string $permdesc
+     */
     public function __construct($title, $modid, $permname, $permdesc)
     {
         //      $this->XoopsForm($title, 'groupperm_form', XOOPS_URL.'/modules/system/admin/groupperm.php', 'post'); GIJ
@@ -121,9 +127,9 @@ 
      * Add appendix
      *
      * @access public
-     * @param $permName
-     * @param $itemId
-     * @param $itemName
+     * @param string $permName
+     * @param integer $itemId
+     * @param string $itemName
      */
 
     public function addAppendix($permName, $itemId, $itemName)
@@ -311,7 +317,7 @@ 
     /**
      * Constructor
      * @param      $caption
-     * @param      $name
+     * @param      string $name
      * @param      $groupId
      * @param null $values
      */

Indentation +14 added lines, -14 removed lines

@@ -486,20 +486,20 @@
         }
 
         $tree .= ' />'
-                 . $option['name']
-                 . '<input type="hidden" name="'
-                 . $this->getName()
-                 . '[parents]['
-                 . $option['id']
-                 . ']" value="'
-                 . implode(':', $parentIds)
-                 . '" /><input type="hidden" name="'
-                 . $this->getName()
-                 . '[itemname]['
-                 . $option['id']
-                 . ']" value="'
-                 . htmlspecialchars($option['name'], ENT_QUOTES | ENT_HTML5)
-                 . "\" /><br />\n";
+                    . $option['name']
+                    . '<input type="hidden" name="'
+                    . $this->getName()
+                    . '[parents]['
+                    . $option['id']
+                    . ']" value="'
+                    . implode(':', $parentIds)
+                    . '" /><input type="hidden" name="'
+                    . $this->getName()
+                    . '[itemname]['
+                    . $option['id']
+                    . ']" value="'
+                    . htmlspecialchars($option['name'], ENT_QUOTES | ENT_HTML5)
+                    . "\" /><br />\n";
 
         if (isset($option['children'])) {
             foreach ($option['children'] as $child) {

Spacing +21 added lines, -21 removed lines

@@ -18,11 +18,11 @@ 
     exit;
 }
 
-require_once XOOPS_ROOT_PATH . '/class/xoopsform/formelement.php';
-require_once XOOPS_ROOT_PATH . '/class/xoopsform/formhidden.php';
-require_once XOOPS_ROOT_PATH . '/class/xoopsform/formbutton.php';
-require_once XOOPS_ROOT_PATH . '/class/xoopsform/formelementtray.php';
-require_once XOOPS_ROOT_PATH . '/class/xoopsform/form.php';
+require_once XOOPS_ROOT_PATH.'/class/xoopsform/formelement.php';
+require_once XOOPS_ROOT_PATH.'/class/xoopsform/formhidden.php';
+require_once XOOPS_ROOT_PATH.'/class/xoopsform/formbutton.php';
+require_once XOOPS_ROOT_PATH.'/class/xoopsform/formelementtray.php';
+require_once XOOPS_ROOT_PATH.'/class/xoopsform/form.php';
 
 /**
  * Renders a form for setting module specific group permissions
@@ -188,13 +188,13 @@ 
 
             $selected = $grouppermHandler->getItemIds($this->_permName, $i, $this->_modid);
 
-            $ele = new MyXoopsGroupFormCheckBox($glist[$i], 'perms[' . $this->_permName . ']', $i, $selected);
+            $ele = new MyXoopsGroupFormCheckBox($glist[$i], 'perms['.$this->_permName.']', $i, $selected);
 
             $ele->setOptionTree($this->_itemTree);
 
             // GIJ start
 
-            $ele->setDescription('<input type="checkbox" onclick="with(document.groupperm_form){for(i=0;i<length;i++){if(elements[i].name.match(/^perms\[(module_admin|module_read|block_read)\]\[groups\]\[' . $i . '\]/)){elements[i].checked=this.checked;}}};">');
+            $ele->setDescription('<input type="checkbox" onclick="with(document.groupperm_form){for(i=0;i<length;i++){if(elements[i].name.match(/^perms\[(module_admin|module_read|block_read)\]\[groups\]\['.$i.'\]/)){elements[i].checked=this.checked;}}};">');
 
             // GIJ_end
 
@@ -237,9 +237,9 @@ 
 
         $this->addElement($tray);
 
-        $ret = '<h4>' . $this->getTitle() . '</h4>' . $this->_permDesc . '<br />';
+        $ret = '<h4>'.$this->getTitle().'</h4>'.$this->_permDesc.'<br />';
 
-        $ret .= "<form name='" . $this->getName() . "' id='" . $this->getName() . "' action='" . $this->getAction() . "' method='" . $this->getMethod() . "'" . $this->getExtra() . ">\n<table width='100%' class='outer' cellspacing='1'>\n";
+        $ret .= "<form name='".$this->getName()."' id='".$this->getName()."' action='".$this->getAction()."' method='".$this->getMethod()."'".$this->getExtra().">\n<table width='100%' class='outer' cellspacing='1'>\n";
 
         $elements = &$this->getElements();
 
@@ -249,21 +249,21 @@ 
             } elseif (!$elements[$i]->isHidden()) {
                 // group name
 
-                $ret .= "<tr valign='top' align='" . _GLOBAL_LEFT . "'><td class='head'>" . $elements[$i]->getCaption();
+                $ret .= "<tr valign='top' align='"._GLOBAL_LEFT."'><td class='head'>".$elements[$i]->getCaption();
 
                 // group description
 
                 if ('' != $elements[$i]->getDescription()) {
-                    $ret .= '<br /><br /><span style="font-weight: normal;">' . $elements[$i]->getDescription() . '</span>';
+                    $ret .= '<br /><br /><span style="font-weight: normal;">'.$elements[$i]->getDescription().'</span>';
                 }
 
-                $ret .= "</td>\n<td class='even'>\n" . $elements[$i]->render() . "\n</td></tr>\n";
+                $ret .= "</td>\n<td class='even'>\n".$elements[$i]->render()."\n</td></tr>\n";
             } else {
                 $ret .= $elements[$i]->render();
             }
         }
 
-        $ret .= '</table>' . $xoopsGTicket->getTicketHtml(__LINE__, 1800, 'myblocksadmin') . '</form>';
+        $ret .= '</table>'.$xoopsGTicket->getTicketHtml(__LINE__, 1800, 'myblocksadmin').'</form>';
 
         return $ret;
     }
@@ -396,7 +396,7 @@ 
 
                 $checked = $append['selected'] ? 'checked="checked"' : '';
 
-                $name = 'perms[' . $append['permname'] . ']';
+                $name = 'perms['.$append['permname'].']';
 
                 $itemid = $append['itemid'];
 
@@ -428,7 +428,7 @@ 
 
                 $this->_renderOptionTree($tree, $this->_optionTree[$topitem], $prefix);
 
-                $ret .= $tree . '</td>';
+                $ret .= $tree.'</td>';
 
                 $cols++;
             }
@@ -451,7 +451,7 @@ 
 
     public function _renderOptionTree(&$tree, $option, $prefix, $parentIds = [])
     {
-        $tree .= $prefix . '<input type="checkbox" name="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" id="' . $this->getName() . '[groups][' . $this->_groupId . '][' . $option['id'] . ']" onclick="';
+        $tree .= $prefix.'<input type="checkbox" name="'.$this->getName().'[groups]['.$this->_groupId.']['.$option['id'].']" id="'.$this->getName().'[groups]['.$this->_groupId.']['.$option['id'].']" onclick="';
 
         // If there are parent elements, add javascript that will
 
@@ -460,9 +460,9 @@ 
         // sure permissions to parent items are added as well.
 
         foreach ($parentIds as $pid) {
-            $parent_ele = $this->getName() . '[groups][' . $this->_groupId . '][' . $pid . ']';
+            $parent_ele = $this->getName().'[groups]['.$this->_groupId.']['.$pid.']';
 
-            $tree .= "var ele = xoopsGetElementById('" . $parent_ele . "'); if(ele.checked != true) {ele.checked = this.checked;}";
+            $tree .= "var ele = xoopsGetElementById('".$parent_ele."'); if(ele.checked != true) {ele.checked = this.checked;}";
         }
 
         // If there are child elements, add javascript that will
@@ -474,9 +474,9 @@ 
         // is no permission to this item.
 
         foreach ($option['allchild'] as $cid) {
-            $child_ele = $this->getName() . '[groups][' . $this->_groupId . '][' . $cid . ']';
+            $child_ele = $this->getName().'[groups]['.$this->_groupId.']['.$cid.']';
 
-            $tree .= "var ele = xoopsGetElementById('" . $child_ele . "'); if(this.checked != true) {ele.checked = false;}";
+            $tree .= "var ele = xoopsGetElementById('".$child_ele."'); if(this.checked != true) {ele.checked = false;}";
         }
 
         $tree .= '" value="1"';
@@ -505,7 +505,7 @@ 
             foreach ($option['children'] as $child) {
                 array_push($parentIds, $option['id']);
 
-                $this->_renderOptionTree($tree, $this->_optionTree[$child], $prefix . '&nbsp;-', $parentIds);
+                $this->_renderOptionTree($tree, $this->_optionTree[$child], $prefix.'&nbsp;-', $parentIds);
             }
         }
     }

xoops_trust_path/libs/altsys/include/Text_Diff.php

Doc Comments +5 added lines, -5 removed lines

@@ -532,7 +532,7 @@ 
      * @param $xlim
      * @param $yoff
      * @param $ylim
-     * @param $nchunks
+     * @param double $nchunks
      * @return array
      */
 
@@ -692,10 +692,10 @@ 
      *
      * Note that XLIM, YLIM are exclusive bounds.  All line numbers are
      * origin-0 and discarded lines are not counted.
-     * @param $xoff
-     * @param $xlim
-     * @param $yoff
-     * @param $ylim
+     * @param integer $xoff
+     * @param integer $xlim
+     * @param integer $yoff
+     * @param integer $ylim
      */
 
     public function _compareseq($xoff, $xlim, $yoff, $ylim)

xoops_trust_path/libs/altsys/include/Text_Diff_Renderer.php

Doc Comments +5 added lines, -5 removed lines

@@ -145,10 +145,10 @@ 
     }
 
     /**
-     * @param $xbeg
-     * @param $xlen
-     * @param $ybeg
-     * @param $ylen
+     * @param integer $xbeg
+     * @param integer $xlen
+     * @param integer $ybeg
+     * @param integer $ylen
      * @param $edits
      * @return string
      */
@@ -217,7 +217,7 @@ 
     }
 
     /**
-     * @param $header
+     * @param string $header
      * @return string
      */
 

Spacing +9 added lines, -9 removed lines

@@ -42,7 +42,7 @@ 
     public function __construct($params = [])
     {
         foreach ($params as $param => $value) {
-            $v = '_' . $param;
+            $v = '_'.$param;
 
             if (isset($this->$v)) {
                 $this->$v = $value;
@@ -141,7 +141,7 @@ 
             $output .= $this->_block($x0, $xi - $x0, $y0, $yi - $y0, $block);
         }
 
-        return $output . $this->_endDiff();
+        return $output.$this->_endDiff();
     }
 
     /**
@@ -174,7 +174,7 @@ 
             }
         }
 
-        return $output . $this->_endBlock();
+        return $output.$this->_endBlock();
     }
 
     /**
@@ -206,14 +206,14 @@ 
     public function _blockHeader($xbeg, $xlen, $ybeg, $ylen)
     {
         if ($xlen > 1) {
-            $xbeg .= ',' . ($xbeg + $xlen - 1);
+            $xbeg .= ','.($xbeg + $xlen - 1);
         }
 
         if ($ylen > 1) {
-            $ybeg .= ',' . ($ybeg + $ylen - 1);
+            $ybeg .= ','.($ybeg + $ylen - 1);
         }
 
-        return $xbeg . ($xlen ? ($ylen ? 'c' : 'd') : 'a') . $ybeg;
+        return $xbeg.($xlen ? ($ylen ? 'c' : 'd') : 'a').$ybeg;
     }
 
     /**
@@ -223,7 +223,7 @@ 
 
     public function _startBlock($header)
     {
-        return $header . "\n";
+        return $header."\n";
     }
 
     /**
@@ -243,7 +243,7 @@ 
 
     public function _lines($lines, $prefix = ' ')
     {
-        return $prefix . implode("\n$prefix", $lines) . "\n";
+        return $prefix.implode("\n$prefix", $lines)."\n";
     }
 
     /**
@@ -284,6 +284,6 @@ 
 
     public function _changed($orig, $final)
     {
-        return $this->_deleted($orig) . "---\n" . $this->_added($final);
+        return $this->_deleted($orig)."---\n".$this->_added($final);
     }
 }