Issues in category.php (master) - Issues in master - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Issues (292)

Security Analysis not enabled

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

Header Injection

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

admin/category.php (3 issues)

Labels

Unused Code 3

Severity

Minor 3

<?php declare(strict_types=1);

/*
 * You may not change or alter any portion of this comment or credits
 * of supporting developers from this source code or any supporting source code
 * which is considered copyrighted (c) material of the original comment or credit authors.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
 */

/**
 * @copyright    XOOPS Project (https://xoops.org)
 * @license      GNU GPL 2.0 or later (https://www.gnu.org/licenses/gpl-2.0.html)
 * @author       XOOPS Development Team
 * @author       Pascal Le Boustouller: original author ([email protected])
 * @author       Luc Bizet (www.frxoops.org)
 * @author       jlm69 (www.jlmzone.com)
 * @author       mamba (www.xoops.org)
 */

use Xmf\Request;
use XoopsModules\Adslight\{
    Helper,
    Tree,
    Utility
};

/** @var Helper $helper */
require_once __DIR__ . '/admin_header.php';
xoops_cp_header();

$op = Request::getString('op', 'list');

#  function adsNewCat
#####################################################
/**
 * @param $cid
 */
function adsNewCat($cid): void
function adsNewCat(/** @scrutinizer ignore-unused */ $cid): void
{
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_ADDSUBCAT . '</legend>';
    Utility::showImage();
    echo '<form method="post" action="category.php" name="imcat"><input type="hidden" name="op" value="AdsAddCat"></font><br><br>
        <table class="outer" border=0>
    <tr>
      <td class="even">' . _AM_ADSLIGHT_CATNAME . ' </td><td class="odd" colspan=2><input type="text" name="title" size="50" maxlength="100">&nbsp; ' . _AM_ADSLIGHT_IN . ' &nbsp;';

    $cid    = Request::getInt('cid', 0, 'GET');
    $sql    = 'SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid}";
    $result = $xoopsDB->query($sql);
    if (!$xoopsDB->isResultSet($result)) {
        \trigger_error("Query Failed! SQL: $sql- Error: " . $xoopsDB->error(), E_USER_ERROR);
    }
    [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);
    $mytree->makeMySelBox('title', 'title', $cid, 1);
    echo '    </td>  </tr>';
    $cat_desc     = '';
    $cat_keywords = '';

    if ('1' === $helper->getConfig('adslight_cat_desc')) {
        echo '<tr><td class="even">'
             . _AM_ADSLIGHT_CAT_META_DESCRIPTION
             . " </td><td class=\"odd\" colspan=2>\n"
             . "    <input type=\"text\" name=\"cat_desc\" value=\"{$cat_desc}\" size=\"80\" maxlength=\"200\">\n"
             . "  </td></tr>\n"
             . '  <tr><td class="even">'
             . _AM_ADSLIGHT_CAT_META_KEYWORDS
             . " </td><td class=\"odd\" colspan=2>\n"
             . "    <input type=\"text\" name=\"cat_keywords\" value=\"{$cat_keywords}\" size=\"80\" maxlength=\"200\">\n"
             . "  </td></tr>\n";
    }

    echo "  <tr>\n" . '    <td class="even">' . _AM_ADSLIGHT_IMGCAT . '  </td><td class="odd" colspan=2><select name="img" onChange="showimage()">';

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
    }
    asort($filelist);
    //    while (list($key, $file) = each($filelist)) {
    foreach ($filelist as $key => $file) {
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ('.' === $file || '..' === $file) {
                $a = 1;

            }
        } elseif ('default.png' === $file) {
            echo "<option value=\"{$file}\" selected>{$file}</option>";
        } else {
            echo "<option value=\"{$file}\">{$file}</option>";
        }
    }
    echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/img_cat/default.png" name="avatar" align="absmiddle"><br><b>' . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';
    echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1" checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="affprice" value="0">' . _NO . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="cat_moderate" value="0">' . _NO . '</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="moderate_subcat" value="0">' . _NO . '</td></tr>';

    if ('title' !== $helper->getConfig('adslight_csortorder')) {
        echo '<tr><td>' . _AM_ADSLIGHT_ORDER . ' </td><td><input type="text" name="cat_order" size="4" value="0" ></td><td class="foot"><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
    } else {
        $cat_order = (int)$cat_order;
        echo "<input type=\"hidden\" name=\"cat_order\" value=\"{$cat_order}\">";
        echo '<tr><td class="foot" colspan=3><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
    }

    echo '</table></form><br></fieldset><br>';
    xoops_cp_footer();
}

#  function adsModCat
#####################################################
/**
 * @param $cid
 */
function adsModCat($cid): void
{
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $mytree = new Tree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

    //    require_once __DIR__ . '/admin_header.php';

    //    loadModuleAdminMenu(1, '');
    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODIFCAT . '</legend>';
    //    ShowImg();
    Utility::showImage();
    $sql    = 'SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid}";
    $result = $xoopsDB->query($sql);
    if (!$xoopsDB->isResultSet($result)) {
        \trigger_error("Query Failed! SQL: $sql- Error: " . $xoopsDB->error(), E_USER_ERROR);
    }
    [$cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat] = $xoopsDB->fetchRow($result);

    $title    = \htmlspecialchars($title, ENT_QUOTES | ENT_HTML5);
    $cat_desc = $GLOBALS['xoopsDB']->escape($cat_desc);
    echo '<form action="category.php" method="post" name="imcat">';
    echo $GLOBALS['xoopsSecurity']->getTokenHTML();
    echo '<table class="outer" border="0"><tr>
    <td class="even">' . _AM_ADSLIGHT_CATNAME . "   </td><td class=\"odd\"><input type=\"text\" name=\"title\" value=\"{$title}\" size=\"50\" maxlength=\"100\">&nbsp; " . _AM_ADSLIGHT_IN . ' &nbsp;';
    $mytree->makeMySelBox('title', 'title', $pid, 1);
    echo '</td></tr>';
    if ('1' === $helper->getConfig('adslight_cat_desc')) {
        echo '<tr><td class="even">' . _AM_ADSLIGHT_CAT_META_DESCRIPTION . ' </td><td class="odd" colspan=2>';
        echo "<input type=\"text\" name=\"cat_desc\" value=\"{$cat_desc}\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';

        echo '<tr><td class="even">' . _AM_ADSLIGHT_CAT_META_KEYWORDS . ' </td><td class="odd" colspan=2>';
        echo "<input type=\"text\" name=\"cat_keywords\" value=\"{$cat_keywords}\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';
    }

    echo '<tr>
    <td class="even">' . _AM_ADSLIGHT_IMGCAT . '  </td><td class="odd"><select name="img" onChange="showimage()">';

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
    }
    asort($filelist);
    //    while (list($key, $file) = each($filelist)) {
    foreach ($filelist as $key => $file) {
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ('.' === $file || '..' === $file) {
                $a = 1;

            }
        } elseif ($file === $imgs) {
            echo "<option value=\"{$file}\" selected>{$file}</option>";
        } else {
            echo "<option value=\"{$file}\">{$file}</option>";
        }
    }
    echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . "/modules/adslight/assets/images/img_cat/{$imgs}\" name=\"avatar\" align=\"absmiddle\"><br><b>" . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1"';
    if ('1' === $affprice) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="affprice" value="0"';
    if ('0' === $affprice) {
        echo 'checked';
    }
    echo '>' . _NO . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"';
    if ('1' === $cat_moderate) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="cat_moderate" value="0"';
    if ('0' === $cat_moderate) {
        echo 'checked';
    }
    echo '>' . _NO . '</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"';
    if ('1' === $moderate_subcat) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="moderate_subcat" value="0"';
    if ('0' === $moderate_subcat) {
        echo 'checked';
    }
    echo '>' . _NO . '</td></tr>';

    if ('title' !== $helper->getConfig('adslight_csortorder')) {
        echo '<tr><td class="even">' . _AM_ADSLIGHT_ORDER . " </td><td class=\"odd\"><input type=\"text\" name=\"cat_order\" size=\"4\" value=\"{$cat_order}\"></td></tr>";
    } else {
        $cat_order = (int)$cat_order;
        echo "<input type=\"hidden\" name=\"cat_order\" value=\"{$cat_order}\">";
    }

    echo '</table>';

    echo "<input type=\"hidden\" name=\"cidd\" value=\"{$cid}\">"
         . '<input type="hidden" name="op" value="AdsModCatS">'
         . '<table class="foot" border="0"><tr><td width="20%"><br>'

         . '<input type="submit" value="'
         . _AM_ADSLIGHT_SAVMOD
         . '"></form></td><td><br>'
         . '<form action="category.php" method="post">'
         . "<input type=\"hidden\" name=\"cid\" value=\"{$cid}\">"
         . '<input type="hidden" name="op" value="AdsDelCat">'
         . '<input type="submit" value="'
         . _AM_ADSLIGHT_DEL
         . '"></form></td></tr></table>';
    echo '</fieldset><br>';
    xoops_cp_footer();
}

#  function adsModCatS
#####################################################
/**
 * @param $cidd
 * @param $cid
 * @param $img
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $cat_order
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function adsModCatS(
    $cidd,
    $cid,
    $img,
    $title,
    $cat_desc,
    $cat_keywords,
    $cat_order,
    $affprice,
    $cat_moderate,
    $moderate_subcat
): void {
    global $xoopsDB, $myts;
    $helper = Helper::getInstance();
    $title  = \htmlspecialchars($title, ENT_QUOTES | ENT_HTML5);
    $cidd   = (int)$cidd;

    $sql = 'UPDATE '
           . $xoopsDB->prefix('adslight_categories')
           . " SET title='{$title}', cat_desc='{$cat_desc}', cat_keywords='{$cat_keywords}', pid='{$cid}', img='{$img}', cat_order='{$cat_order}', affprice='{$affprice}', cat_moderate='{$cat_moderate}', moderate_subcat='{$moderate_subcat}' WHERE cid={$cidd}";
    $xoopsDB->query($sql);

    if (1 !== $moderate_subcat) {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=0, moderate_subcat=0 WHERE pid={$cidd}");
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=1, moderate_subcat=1 WHERE pid={$cidd}");
    }

    $helper->redirect('admin/map.php', 10, _AM_ADSLIGHT_CATSMOD);
}

#  function adsAddCat
#####################################################
/**
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $cid
 * @param $img
 * @param $cat_order
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function adsAddCat(
    $title,
    $cat_desc,
    $cat_keywords,
    $cid,
    $img,
    $cat_order,
    $affprice,
    $cat_moderate,
    $moderate_subcat
): void {
    global $xoopsDB, $myts;
    $helper          = Helper::getInstance();
    $moderate_subcat = (int)$moderate_subcat;
    $title           = \htmlspecialchars($title, ENT_QUOTES | ENT_HTML5);
    if ('' === $title) {
        $title = '! ! ? ! !';
    }

    $sql = 'INSERT INTO ' . $xoopsDB->prefix('adslight_categories') . " VALUES (NULL, '{$cid}', '{$title}', '{$cat_desc}', '{$cat_keywords}', '{$img}', '{$cat_order}', '{$affprice}', '{$cat_moderate}', '{$moderate_subcat}')";
    $xoopsDB->query($sql);

    if (1 === $moderate_subcat) {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=1 WHERE pid = ' . (int)$cid);
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0 WHERE pid = ' . (int)$cid);
    }

    $helper->redirect('admin/map.php', 3, _AM_ADSLIGHT_CATADD);
}

#  function adsDelCat
#####################################################
/**
 * @param     $cid
 * @param int $ok
 */
function adsDelCat($cid, $ok = 0): void
{
    $helper = Helper::getInstance();
    $cid    = (int)$cid;
    if (1 === (int)$ok) {
        /** @var \XoopsMySQLDatabase $xoopsDB */
        $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
        $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid} OR pid={$cid}");
        $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE cid={$cid}");

        $helper->redirect('admin/map.php', 3, _AM_ADSLIGHT_CATDEL);
    } else {
        //        require_once __DIR__ . '/admin_header.php';
        //        loadModuleAdminMenu(1, '');

        OpenTable();
        echo '<br><div style="text-align: center;"><strong>' . _AM_ADSLIGHT_SURDELCAT . '</strong></div><br><br>';
        echo "[ <a href=\"category.php?op=AdsDelCat&cid={$cid}&ok=1\">" . _YES . '</a> | <a href="map.php">' . _NO . '</a> ]<br><br>';
        closeTable();
        xoops_cp_footer();
    }
}

#####################################################
//@todo REMOVE THIS ASAP!  This code is extremely unsafe
foreach ($_POST as $k => $v) {
    ${$k} = $v;
}

$ok  = Request::getInt('ok', 0, 'GET');
$cid = Request::getInt('cid', 0);
$op  = Request::getString('op', '');

switch ($op) {
    case 'AdsNewCat':
        adsNewCat($cid);
        break;
    case 'AdsAddCat':
        adsAddCat(
            $title,
            $cat_desc,
            $cat_keywords,
            $cid,
            $img,
            $cat_order,
            $affprice,
            $cat_moderate,
            $moderate_subcat
        );
        break;
    case 'AdsDelCat':
        adsDelCat($cid, $ok);
        break;
    case 'AdsModCat':
        adsModCat($cid);
        break;
    case 'AdsModCatS':
        adsModCatS(
            $cidd,
            $cid,
            $img,
            $title,
            $cat_desc,
            $cat_keywords,
            $cat_order,
            $affprice,
            $cat_moderate,
            $moderate_subcat
        );
        break;
    default:
        //        index();
        break;
}


mambax7 / adslight

Issues (292)

Security Analysis not enabled

admin/category.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like