ModuleFeedback::getFormFeedback() - Code Metrics - Inspection of "updates/cosmetics/fixes/testdata" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 05ee30...e8b784 )

by Michael

created 2021-08-13 11:49 UTC

ModuleFeedback::getFormFeedback() B

↳ Parent: ModuleFeedback

Complexity

Conditions	2
Paths	2

Size

Total Lines	102
Code Lines	79

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
eloc	79
c	1
b	1
f	0
dl	0
loc	102
rs	8.4581
cc	2
nc	2
nop	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace XoopsModules\Adslight\Common;

use XoopsConfigHandler;
use XoopsFormButtonTray;
use XoopsFormEditor;
use XoopsFormHidden;
use XoopsFormSelect;
use XoopsFormText;
use XoopsModuleHandler;
use XoopsObject;
use XoopsThemeForm;

/*
 You may not change or alter any portion of this comment or credits
 of supporting developers from this source code or any supporting source code
 which is considered copyrighted (c) material of the original comment or credit authors.

 This program is distributed in the hope that it will be useful,
 but WITHOUT ANY WARRANTY; without even the implied warranty of
 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
*/
/**
 * Feedback plugin for xoops modules
 *
 * @copyright      XOOPS Project  (https://xoops.org)
 * @license        GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
 * @author         Michael Beck <[email protected]>
 * @author         Wedega - Email:<[email protected]>
 * @author         Fernando Santos (topet05) <[email protected]>
 */
\defined('XOOPS_ROOT_PATH') || die('Restricted access');

/**
 * Class Object ModuleFeedback
 */
class ModuleFeedback extends XoopsObject
{
    public $name    = '';
    public $email   = '';
    public $site    = '';
    public $type    = '';
    public $content = '';

    /**
     * Constructor
     *
     * @param null
     */
    public function __construct()
    {
    }

    /**
     * @static function &getInstance
     *
     * @param null
     */
    public static function getInstance(): void
    {
        static $instance = false;
        if (!$instance) {
            $instance = new self();
        }
    }

    /**
     * @public function getFormFeedback:
     * provide form for sending a feedback to module author
     * @param bool $action
     * @return XoopsThemeForm
     */
    public function getFormFeedback($action = false): XoopsThemeForm
    {
        if (!$action) {
            $action = $_SERVER['REQUEST_URI'];

        }

        $moduleDirName      = \basename(\dirname(__DIR__, 2));
        $moduleDirNameUpper = \mb_strtoupper($moduleDirName);
        // Get Theme Form
        \xoops_load('XoopsFormLoader');
        $form = new \XoopsThemeForm(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_FORM_TITLE'
            ), 'formfeedback', 'feedback.php', 'post', true
        );
        $form->setExtra('enctype="multipart/form-data"');
        $recipient = new \XoopsFormText(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_RECIPIENT'
            ), 'recipient', 50, 255, $GLOBALS['xoopsModule']->getInfo(
            'author_mail'
        )
        );
        $recipient->setExtra('disabled="disabled"');
        $form->addElement($recipient);
        $your_name = new \XoopsFormText(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_NAME'
            ), 'your_name', 50, 255, $this->name
        );
        $your_name->setExtra(
            'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_NAME_PLACEHOLER') . '"'
        );
        $form->addElement($your_name);
        $your_site = new \XoopsFormText(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_SITE'
            ), 'your_site', 50, 255, $this->site
        );
        $your_site->setExtra(
            'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_SITE_PLACEHOLER') . '"'
        );
        $form->addElement($your_site);
        $your_mail = new \XoopsFormText(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_MAIL'
            ), 'your_mail', 50, 255, $this->email
        );
        $your_mail->setExtra(
            'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_MAIL_PLACEHOLER') . '"'
        );
        $form->addElement($your_mail);
        $fbtypeSelect = new \XoopsFormSelect(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE'
            ), 'fb_type', $this->type
        );
        $fbtypeSelect->addOption('', '');
        $fbtypeSelect->addOption(
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_SUGGESTION'),
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_SUGGESTION')
        );
        $fbtypeSelect->addOption(
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_BUGS'),
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_BUGS')
        );
        $fbtypeSelect->addOption(
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_TESTIMONIAL'),
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_TESTIMONIAL')
        );
        $fbtypeSelect->addOption(
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_FEATURES'),
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_FEATURES')
        );
        $fbtypeSelect->addOption(
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_OTHERS'),
            \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_OTHERS')
        );
        $form->addElement($fbtypeSelect, true);
        $editorConfigs           = [];
        $editorConfigs['name']   = 'fb_content';
        $editorConfigs['value']  = $this->content;
        $editorConfigs['rows']   = 5;
        $editorConfigs['cols']   = 40;
        $editorConfigs['width']  = '100%';
        $editorConfigs['height'] = '400px';
        /** @var XoopsModuleHandler $moduleHandler */
        $moduleHandler = \xoops_getHandler('module');
        $module        = $moduleHandler->getByDirname('system');
        /** @var XoopsConfigHandler $configHandler */
        $configHandler           = \xoops_getHandler('config');
        $config                  = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
        $editorConfigs['editor'] = $config['general_editor'];
        $editor                  = new \XoopsFormEditor(
            \constant(
                'CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_CONTENT'
            ), 'fb_content', $editorConfigs
        );
        $form->addElement($editor, true);
        $form->addElement(new \XoopsFormHidden('op', 'send'));
        $form->addElement(new \XoopsFormButtonTray('', \_SUBMIT, 'submit', '', false));
        return $form;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace XoopsModules\Adslight\Common;
6
7			use XoopsConfigHandler;
8			use XoopsFormButtonTray;
9			use XoopsFormEditor;
10			use XoopsFormHidden;
11			use XoopsFormSelect;
12			use XoopsFormText;
13			use XoopsModuleHandler;
14			use XoopsObject;
15			use XoopsThemeForm;
16
17			/*
18			You may not change or alter any portion of this comment or credits
19			of supporting developers from this source code or any supporting source code
20			which is considered copyrighted (c) material of the original comment or credit authors.
21
22			This program is distributed in the hope that it will be useful,
23			but WITHOUT ANY WARRANTY; without even the implied warranty of
24			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
25			*/
26			/**
27			* Feedback plugin for xoops modules
28			*
29			* @copyright XOOPS Project (https://xoops.org)
30			* @license GNU GPL 2 or later (http://www.gnu.org/licenses/gpl-2.0.html)
31			* @author Michael Beck <[email protected]>
32			* @author Wedega - Email:<[email protected]>
33			* @author Fernando Santos (topet05) <[email protected]>
34			*/
35			\defined('XOOPS_ROOT_PATH') \|\| die('Restricted access');
36
37			/**
38			* Class Object ModuleFeedback
39			*/
40			class ModuleFeedback extends XoopsObject
41			{
42			public $name = '';
43			public $email = '';
44			public $site = '';
45			public $type = '';
46			public $content = '';
47
48			/**
49			* Constructor
50			*
51			* @param null
52			*/
53			public function __construct()
54			{
55			}
56
57			/**
58			* @static function &getInstance
59			*
60			* @param null
61			*/
62			public static function getInstance(): void
63			{
64			static $instance = false;
65			if (!$instance) {
66			$instance = new self();
67			}
68			}
69
70			/**
71			* @public function getFormFeedback:
72			* provide form for sending a feedback to module author
73			* @param bool $action
74			* @return XoopsThemeForm
75			*/
76			public function getFormFeedback($action = false): XoopsThemeForm
77			{
78			if (!$action) {
79			$action = $_SERVER['REQUEST_URI'];
			0 ignored issues – show Unused Code introduced 2021-08-13 11:54 UTC by Report Bug Copy Issue Report The assignment to `$action` is dead and can be removed. Loading history...
80			}
81
82			$moduleDirName = \basename(\dirname(__DIR__, 2));
83			$moduleDirNameUpper = \mb_strtoupper($moduleDirName);
84			// Get Theme Form
85			\xoops_load('XoopsFormLoader');
86			$form = new \XoopsThemeForm(
87			\constant(
88			'CO_' . $moduleDirNameUpper . '_' . 'FB_FORM_TITLE'
89			), 'formfeedback', 'feedback.php', 'post', true
90			);
91			$form->setExtra('enctype="multipart/form-data"');
92			$recipient = new \XoopsFormText(
93			\constant(
94			'CO_' . $moduleDirNameUpper . '_' . 'FB_RECIPIENT'
95			), 'recipient', 50, 255, $GLOBALS['xoopsModule']->getInfo(
96			'author_mail'
97			)
98			);
99			$recipient->setExtra('disabled="disabled"');
100			$form->addElement($recipient);
101			$your_name = new \XoopsFormText(
102			\constant(
103			'CO_' . $moduleDirNameUpper . '_' . 'FB_NAME'
104			), 'your_name', 50, 255, $this->name
105			);
106			$your_name->setExtra(
107			'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_NAME_PLACEHOLER') . '"'
108			);
109			$form->addElement($your_name);
110			$your_site = new \XoopsFormText(
111			\constant(
112			'CO_' . $moduleDirNameUpper . '_' . 'FB_SITE'
113			), 'your_site', 50, 255, $this->site
114			);
115			$your_site->setExtra(
116			'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_SITE_PLACEHOLER') . '"'
117			);
118			$form->addElement($your_site);
119			$your_mail = new \XoopsFormText(
120			\constant(
121			'CO_' . $moduleDirNameUpper . '_' . 'FB_MAIL'
122			), 'your_mail', 50, 255, $this->email
123			);
124			$your_mail->setExtra(
125			'placeholder="' . \constant('CO_' . $moduleDirNameUpper . '_' . 'FB_MAIL_PLACEHOLER') . '"'
126			);
127			$form->addElement($your_mail);
128			$fbtypeSelect = new \XoopsFormSelect(
129			\constant(
130			'CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE'
131			), 'fb_type', $this->type
132			);
133			$fbtypeSelect->addOption('', '');
134			$fbtypeSelect->addOption(
135			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_SUGGESTION'),
136			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_SUGGESTION')
137			);
138			$fbtypeSelect->addOption(
139			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_BUGS'),
140			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_BUGS')
141			);
142			$fbtypeSelect->addOption(
143			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_TESTIMONIAL'),
144			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_TESTIMONIAL')
145			);
146			$fbtypeSelect->addOption(
147			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_FEATURES'),
148			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_FEATURES')
149			);
150			$fbtypeSelect->addOption(
151			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_OTHERS'),
152			\constant('CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_OTHERS')
153			);
154			$form->addElement($fbtypeSelect, true);
155			$editorConfigs = [];
156			$editorConfigs['name'] = 'fb_content';
157			$editorConfigs['value'] = $this->content;
158			$editorConfigs['rows'] = 5;
159			$editorConfigs['cols'] = 40;
160			$editorConfigs['width'] = '100%';
161			$editorConfigs['height'] = '400px';
162			/** @var XoopsModuleHandler $moduleHandler */
163			$moduleHandler = \xoops_getHandler('module');
164			$module = $moduleHandler->getByDirname('system');
165			/** @var XoopsConfigHandler $configHandler */
166			$configHandler = \xoops_getHandler('config');
167			$config = $configHandler->getConfigsByCat(0, $module->getVar('mid'));
168			$editorConfigs['editor'] = $config['general_editor'];
169			$editor = new \XoopsFormEditor(
170			\constant(
171			'CO_' . $moduleDirNameUpper . '_' . 'FB_TYPE_CONTENT'
172			), 'fb_content', $editorConfigs
173			);
174			$form->addElement($editor, true);
175			$form->addElement(new \XoopsFormHidden('op', 'send'));
176			$form->addElement(new \XoopsFormButtonTray('', \_SUBMIT, 'submit', '', false));
177			return $form;
178			}
179			}
180

mambax7 / adslight

Push — master ( 05ee30...e8b784 )

ModuleFeedback::getFormFeedback() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like