Issues in members.php - All Issues - Inspection of "Scrutinizer" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( be43a3...3139c5 )

by Michael
created 2021-08-12 07:55 UTC
members.php (1 issue)

Labels

Unused Code 1
Severity

Minor 1
<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

use Xmf\Request;
use XoopsModules\Adslight\{
    ClassifiedsTree,
    Utility
};

require_once __DIR__ . '/header.php';

$myts = \MyTextSanitizer::getInstance(); // MyTextSanitizer object
global $xoopsModule;
$pathIcon16 = \Xmf\Module\Admin::iconUrl('', 16);
xoops_load('XoopsLocal');
$moduleDirName = basename(__DIR__);

//require_once XOOPS_ROOT_PATH . '/modules/adslight/class/classifiedstree.php';
$mytree                                  = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
$GLOBALS['xoopsOption']['template_main'] = 'adslight_members.tpl';
require_once XOOPS_ROOT_PATH . '/header.php';
require_once XOOPS_ROOT_PATH . '/include/comment_view.php';

$lid       = Request::getInt('lid', 0, 'GET');
$usid      = Request::getInt('usid', 0, 'GET');
$module_id = $xoopsModule->getVar('mid');
if (is_object($GLOBALS['xoopsUser'])) {
    $groups = $GLOBALS['xoopsUser']->getGroups();
} else {
    $groups = XOOPS_GROUP_ANONYMOUS;
}
/** @var \XoopsGroupPermHandler $grouppermHandler */
$grouppermHandler = xoops_getHandler('groupperm');
$perm_itemid      = Request::getInt('item_id', 0, 'POST');

//If no access
$permit = (!$grouppermHandler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) ? '0' : '1';

$GLOBALS['xoopsTpl']->assign('permit', $permit);
$isadmin = (($GLOBALS['xoopsUser'] instanceof \XoopsUser)
            && $GLOBALS['xoopsUser']->isAdmin($xoopsModule->mid())) ? true : false;

$GLOBALS['xoopsTpl']->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
$GLOBALS['xoopsTpl']->assign('add_from_title', _ADSLIGHT_ADDFROM);
$GLOBALS['xoopsTpl']->assign('add_from_sitename', $xoopsConfig['sitename']);
$GLOBALS['xoopsTpl']->assign('mydirname', $moduleDirName);
$GLOBALS['xoopsTpl']->assign('comments_head', _ADSLIGHT_COMMENTS_HEAD);
$GLOBALS['xoopsTpl']->assign('lang_user_rating', _ADSLIGHT_USER_RATING);
$GLOBALS['xoopsTpl']->assign('lang_ratethisuser', _ADSLIGHT_RATETHISUSER);
$GLOBALS['xoopsTpl']->assign('title_head', _ADSLIGHT_TITLE);
$GLOBALS['xoopsTpl']->assign('date_head', _ADSLIGHT_ADDED_ON);
$GLOBALS['xoopsTpl']->assign('views_head', _ADSLIGHT_VIEW2);
$GLOBALS['xoopsTpl']->assign('replies_head', _ADSLIGHT_REPLIES);
$GLOBALS['xoopsTpl']->assign('expires_head', _ADSLIGHT_EXPIRES_ON);
$GLOBALS['xoopsTpl']->assign('all_user_listings', _ADSLIGHT_ALL_USER_LISTINGS);
$GLOBALS['xoopsTpl']->assign('nav_main', '<a href="index.php">' . _ADSLIGHT_MAIN . '</a>');
$GLOBALS['xoopsTpl']->assign('mydirname', $moduleDirName);
$GLOBALS['xoopsTpl']->assign('xoops_module_header', '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" >');

$GLOBALS['xoopsTpl']->assign('adslight_active_menu', $GLOBALS['xoopsModuleConfig']['adslight_active_menu']);
$GLOBALS['xoopsTpl']->assign('adslight_active_rss', $GLOBALS['xoopsModuleConfig']['adslight_active_rss']);
$GLOBALS['xoTheme']->addMeta('meta', 'robots', 'noindex, nofollow');

$show = 4;
$min  = Request::getInt('min', 0, 'GET');
if (!isset($max)) {
    $max = $min + $show;
}
$orderby = 'date ASC';
$rate    = ('1' == $GLOBALS['xoopsModuleConfig']['adslight_rate_user']) ? '1' : '0';
$GLOBALS['xoopsTpl']->assign('rate', $rate);

if ($GLOBALS['xoopsUser']) {
    $member_usid = $GLOBALS['xoopsUser']->getVar('uid', 'E');
    $istheirs    = ($usid == $member_usid) ? 1 : '';
}

$cat_perms  = '';
$categories = Utility::getMyItemIds('adslight_view');
if (is_array($categories) && count($categories) > 0) {
    $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
}

if (1 == $istheirs) {
    $countresult = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE usid=' . $xoopsDB->escape($usid) . " AND valid='Yes' $cat_perms");
    list($trow) = $xoopsDB->fetchRow($countresult);

    $sql    = 'SELECT lid, cid, title, status, expire, type, desctext, tel, price, typeprice, date, email, submitter, usid, town, country, contactby, premium, valid, photo, hits, item_rating, item_votes, user_rating, user_votes, comments FROM '
              . $xoopsDB->prefix('adslight_listing')
              . ' WHERE usid = '
              . $xoopsDB->escape($usid)
              . " AND valid='Yes' $cat_perms ORDER BY $orderby";
    $result = $xoopsDB->query($sql, $show, $min);
} else {
    $countresult = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE usid=' . $xoopsDB->escape($usid) . " AND valid='Yes' AND status!='1' $cat_perms");
    list($trow) = $xoopsDB->fetchRow($countresult);

    $sql    = 'SELECT lid, cid, title, status, expire, type, desctext, tel, price, typeprice, date, email, submitter, usid, town, country, contactby, premium, valid, photo, hits, item_rating, item_votes, user_rating, user_votes, comments FROM '
              . $xoopsDB->prefix('adslight_listing')
              . ' WHERE usid = '
              . $xoopsDB->escape($usid)
              . " AND valid='Yes' AND status!='1' $cat_perms ORDER BY $orderby";
    $result = $xoopsDB->query($sql, $show, $min);
}

$trows   = $trow;
$pagenav = '';
if ($trows > '0') {
    $GLOBALS['xoopsTpl']->assign('min', $min);
    $rank = 1;

    if ($trows > '1') {
        $GLOBALS['xoopsTpl']->assign('show_nav', true);
        $GLOBALS['xoopsTpl']->assign('lang_sortby', _ADSLIGHT_SORTBY);
        $GLOBALS['xoopsTpl']->assign('lang_title', _ADSLIGHT_TITLE);
        $GLOBALS['xoopsTpl']->assign('lang_titleatoz', _ADSLIGHT_TITLEATOZ);
        $GLOBALS['xoopsTpl']->assign('lang_titleztoa', _ADSLIGHT_TITLEZTOA);
        $GLOBALS['xoopsTpl']->assign('lang_date', _ADSLIGHT_DATE);
        $GLOBALS['xoopsTpl']->assign('lang_dateold', _ADSLIGHT_DATEOLD);
        $GLOBALS['xoopsTpl']->assign('lang_datenew', _ADSLIGHT_DATENEW);
        $GLOBALS['xoopsTpl']->assign('lang_popularity', _ADSLIGHT_POPULARITY);
        $GLOBALS['xoopsTpl']->assign('lang_popularityleast', _ADSLIGHT_POPULARITYLTOM);
        $GLOBALS['xoopsTpl']->assign('lang_popularitymost', _ADSLIGHT_POPULARITYMTOL);
    }
    while (false
           !== (list($lid, $cid, $title, $status, $expire, $type, $desctext, $tel, $price, $typeprice, $date, $email, $submitter, $usid, $town, $country, $contactby, $premium, $valid, $photo, $hits, $item_rating, $item_votes, $user_rating, $user_votes, $comments) = $xoopsDB->fetchRow($result))) {
        $newitem   = '';
        $newcount  = $GLOBALS['xoopsModuleConfig']['adslight_countday'];
        $startdate = (time() - (86400 * $newcount));
        if ($startdate < $date) {
            //@todo move "New" alt text to language file
            $newitem = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="New" >';
        }

        if (0 == $status) {
            $status_is = _ADSLIGHT_ACTIVE;
        }
        if (1 == $status) {
            $status_is = _ADSLIGHT_INACTIVE;
        }
        if (2 == $status) {
            $status_is = _ADSLIGHT_SOLD;
        }
        $countresult = $xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_replies') . " WHERE lid='" . $xoopsDB->escape($lid) . "'");
        list($rrow) = $xoopsDB->fetchRow($countresult);
        $rrows = $rrow;
        $GLOBALS['xoopsTpl']->assign('reply_count', $rrows);

        $result2 = $xoopsDB->query('SELECT r_lid, lid, date, submitter, message, email, r_usid FROM ' . $xoopsDB->prefix('adslight_replies') . ' WHERE lid =' . $xoopsDB->escape($lid));
        list($r_lid, $rlid, $rdate, $rsubmitter, $message, $remail, $r_usid) = $xoopsDB->fetchRow($result2);


        $result8 = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . " WHERE id_price='" . $xoopsDB->escape($typeprice) . "'");
        list($nom_price) = $xoopsDB->fetchRow($result8);



        if ($isadmin) {
            $adminlink = "<a href='" . XOOPS_URL . '/modules/adslight/admin/validate_ads.php?op=modifyAds&amp;lid=' . $lid . "'><img src='" . $pathIcon16 . "/edit.png' border=0 alt=\"" . _ADSLIGHT_MODADMIN . '" ></a>';
            $GLOBALS['xoopsTpl']->assign('isadmin', $isadmin);
        } else {
            $adminlink = '';
        }
        $modify_link = '';
        if ($GLOBALS['xoopsUser'] instanceof \XoopsUser) {
            $member_usid = $GLOBALS['xoopsUser']->getVar('uid', 'E');
            if ($usid == $member_usid) {
                $istheirs = true;
                $GLOBALS['xoopsTpl']->assign('istheirs', $istheirs);
                $modify_link = "<a href='modify.php?op=ModAd&amp;lid=" . $lid . "'><img src='" . $pathIcon16 . "/edit.png'  border=0 alt=\"" . _ADSLIGHT_MODADMIN . '" ></a>';
            } else {
                $istheirs = false;
                $GLOBALS['xoopsTpl']->assign('istheirs', '');
            }
        }

        $GLOBALS['xoopsTpl']->assign('submitter', $submitter);
        $GLOBALS['xoopsTpl']->assign('usid', $usid);
        $GLOBALS['xoopsTpl']->assign('read', "$hits " . _ADSLIGHT_VIEW2);
        $GLOBALS['xoopsTpl']->assign('rating', number_format($user_rating, 2));
        $GLOBALS['xoopsTpl']->assign('status_head', _ADSLIGHT_STATUS);
        $tempXoopsLocal = new \XoopsLocal();
        //  For US currency with 2 numbers after the decimal comment out if you dont want 2 numbers after decimal
        $price2 = $tempXoopsLocal->number_format($price, 2, ',', ' ');
        $price2 = $tempXoopsLocal->number_format($price, 2, ',', ' ');
        //  For other countries uncomment the below line and comment out the above line
        //      $price = $tempXoopsLocal->number_format($price);
        $GLOBALS['xoopsTpl']->assign('price', '<strong>' . _ADSLIGHT_PRICE . "</strong>$price" . $GLOBALS['xoopsModuleConfig']['adslight_currency_symbol'] . " - $typeprice");
        $GLOBALS['xoopsTpl']->assign('price_head', _ADSLIGHT_PRICE);
        $GLOBALS['xoopsTpl']->assign('money_sign', '' . $GLOBALS['xoopsModuleConfig']['adslight_currency_symbol']);
        $GLOBALS['xoopsTpl']->assign('price_typeprice', $typeprice);





        $result7 = $xoopsDB->query('SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='" . $xoopsDB->escape($type) . "'");
        list($nom_type) = $xoopsDB->fetchRow($result7);
        $GLOBALS['xoopsTpl']->assign('type', $myts->htmlSpecialChars($nom_type));

        $priceFormatted = Utility::getMoneyFormat('%.2n', $price);
        $priceTypeprice = $myts->htmlSpecialChars($nom_price);
        $priceCurrency = $GLOBALS['xoopsModuleConfig']['adslight_currency_code'];
        //      $GLOBALS['xoopsTpl']->assign('price_price', $price.' '.$GLOBALS['xoopsModuleConfig']['adslight_currency_symbol'].' ');
        //            $priceHtml = '<strong>' . _ADSLIGHT_PRICE2 . '</strong>' . $price . ' ' . $GLOBALS['xoopsModuleConfig']['adslight_currency_symbol'] . ' - ' . $typeprice;
        $priceHtml = '<strong>' . _ADSLIGHT_PRICE2 . '</strong>' . $priceFormatted . ' - ' . $priceTypeprice;

        $GLOBALS['xoopsTpl']->assign('price_head', _ADSLIGHT_PRICE2);
        $GLOBALS['xoopsTpl']->assign('price_price', $priceFormatted);
        $GLOBALS['xoopsTpl']->assign('price_typeprice', $priceTypeprice);
        $GLOBALS['xoopsTpl']->assign('price_currency', $priceCurrency);
        $GLOBALS['xoopsTpl']->assign('price', $priceHtml);
        $GLOBALS['xoopsTpl']->assign('priceHtml', $priceHtml);






        $GLOBALS['xoopsTpl']->assign('local_town', (string)$town);
        $GLOBALS['xoopsTpl']->assign('local_country', (string)$country);
        $GLOBALS['xoopsTpl']->assign('local_head', _ADSLIGHT_LOCAL2);
        $GLOBALS['xoopsTpl']->assign('edit_ad', _ADSLIGHT_EDIT);

        $usid       = addslashes($usid);
        $votestring = (1 == $user_votes) ? _ADSLIGHT_ONEVOTE : sprintf(_ADSLIGHT_NUMVOTES, $user_votes);

        $GLOBALS['xoopsTpl']->assign('user_votes', $votestring);
        $date2 = $date + ($expire * 86400);
        $date  = formatTimestamp($date, 's');
        $date2 = formatTimestamp($date2, 's');
        $path  = $mytree->getPathFromId($cid, 'title');
        $path  = mb_substr($path, 1);
        $path  = str_replace('/', ' - ', $path);
        if ($rrows >= 1) {
            $view_now = "<a href='replies.php?lid=" . $lid . "'>" . _ADSLIGHT_VIEWNOW . '</a>';
        } else {
            $view_now = '';
        }
        $sold = '';
        if (2 == $status) {
            $sold = _ADSLIGHT_RESERVEDMEMBER;
        }

        $GLOBALS['xoopsTpl']->assign('xoops_pagetitle', '' . _ADSLIGHT_ALL_USER_LISTINGS . ' ' . $submitter);
        $updir   = $GLOBALS['xoopsModuleConfig']['adslight_link_upload'];
        $sql     = 'SELECT cod_img, lid, uid_owner, url FROM ' . $xoopsDB->prefix('adslight_pictures') . ' WHERE  uid_owner=' . $xoopsDB->escape($usid) . ' AND lid=' . $xoopsDB->escape($lid) . ' ORDER BY date_added ASC LIMIT 1';
        $resultp = $xoopsDB->query($sql);
        while (false !== (list($cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($resultp))) {
            if ($photo) {
                $photo = "<a href='viewads.php?lid=" . $lid . "'><img class=\"thumb\" src=\"$updir/thumbs/thumb_$url\" align=\"left\" width=\"100px\" alt=\"$title\" ></a>";
            }
        }
        $no_photo = "<a href='viewads.php?lid=" . $lid . "'><img class=\"thumb\" src=\"assets/images/nophoto.jpg\" align=\"left\" width=\"100px\" alt=\"$title\" ></a>";

        $GLOBALS['xoopsTpl']->append('items', [
            'id'          => $lid,
            'cid'         => $cid,
            'title'       => $myts->htmlSpecialChars($title),
            'status'      => $myts->htmlSpecialChars($status_is),
            'expire'      => $myts->htmlSpecialChars($expire),
            'type'        => $myts->htmlSpecialChars($type),
            'desctext'    => $myts->displayTarea($desctext),
            'tel'         => $myts->htmlSpecialChars($tel),
            'price'       => $myts->htmlSpecialChars($price),
            'typeprice'   => $myts->htmlSpecialChars($typeprice),
            'date'        => $myts->htmlSpecialChars($date),
            'email'       => $myts->htmlSpecialChars($email),
            'submitter'   => $myts->htmlSpecialChars($submitter),
            'usid'        => $myts->htmlSpecialChars($usid),
            'town'        => $myts->htmlSpecialChars($town),
            'country'     => $myts->htmlSpecialChars($country),
            'contactby'   => $myts->htmlSpecialChars($contactby),
            'premium'     => $myts->htmlSpecialChars($premium),
            'valid'       => $myts->htmlSpecialChars($valid),
            'hits'        => $hits,
            'rlid'        => $myts->htmlSpecialChars($rlid),
            'rdate'       => $myts->htmlSpecialChars($rdate),
            'rsubmitter'  => $myts->htmlSpecialChars($rsubmitter),
            'message'     => $myts->htmlSpecialChars($message),
            'remail'      => $myts->htmlSpecialChars($remail),
            'rrows'       => $rrows,
            'expires'     => $myts->htmlSpecialChars($date2),
            'view_now'    => $view_now,
            'modify_link' => $modify_link,
            'photo'       => $photo,
            'no_photo'    => $no_photo,
            'adminlink'   => $adminlink,
            'new'         => $newitem,
            'sold'        => $sold,
        ]);
    }
    $usid = Request::getInt('usid', 0, 'GET');

    //Calculates how many pages exist.  Which page one should be on, etc...
    $linkpages = ceil($trows / $show);
    //Page Numbering
    if (1 != $linkpages && 0 != $linkpages) {
        $prev = $min - $show;
        if ($prev >= 0) {
            $pagenav .= "<a href='members.php?usid=$usid&min=$prev&show=$show'><strong><u>&laquo;</u></strong></a> ";
        }
        $counter     = 1;
        $currentpage = ($max / $show);
        while ($counter <= $linkpages) {
            $mintemp = ($show * $counter) - $show;
            if ($counter == $currentpage) {
                $pagenav .= "<strong>($counter)</strong> ";
            } else {
                $pagenav .= "<a href='members.php?usid=$usid&min=$mintemp&show=$show'>$counter</a> ";
            }
            ++$counter;
        }
        if ($trows > $max) {
            $pagenav .= "<a href='members.php?usid=$usid&min=$max&show=$show'>";
            $pagenav .= '<strong><u>&raquo;</u></strong></a>';
        }
        $GLOBALS['xoopsTpl']->assign('nav_page', '<strong>' . _ADSLIGHT_PAGES . "</strong>&nbsp;&nbsp; $pagenav");
    }
}

require_once XOOPS_ROOT_PATH . '/footer.php';

mambax7 / adslight

Push — master ( be43a3...3139c5 )

members.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
