Issues in category.php - New Issues - Inspection of "cleanup" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 0405fd...a3f27c )

by Michael
created 2019-04-15 08:48 UTC
admin/category.php (1 issue)

Labels

Unused Code 1
Severity

Minor 1
mambax7 1
<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

use Xmf\Request;
use XoopsModules\Adslight;

require_once __DIR__ . '/admin_header.php';
xoops_cp_header();

$op = Request::getString('op', 'liste');

#  function adsNewCat
#####################################################
/**
 * @param $cid
 */
function adsNewCat($cid)
function adsNewCat(/** @scrutinizer ignore-unused */ $cid)
{
    global $xoopsDB, $myts;

    $mytree = new Adslight\ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_ADDSUBCAT . '</legend>';

    Adslight\Utility::showImage();

    echo '<form method="post" action="category.php" name="imcat"><input type="hidden" name="op" value="AdsAddCat"></font><br><br>
        <table class="outer" border=0>
    <tr>
      <td class="even">' . _AM_ADSLIGHT_CATNAME . ' </td><td class="odd" colspan=2><input type="text" name="title" size="50" maxlength="100">&nbsp; ' . _AM_ADSLIGHT_IN . ' &nbsp;';

    $cid = Request::getInt('cid', 0, 'GET');

    $result = $xoopsDB->query('SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid}");
    list($cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat) = $xoopsDB->fetchRow($result);
    $mytree->makeMySelBox('title', 'title', $cid, 1);
    echo "    </td>\n" . "  </tr>\n";

    $cat_desc     = '';
    $cat_keywords = '';

    if ('1' == $GLOBALS['xoopsModuleConfig']['adslight_cat_desc']) {
        echo '<tr><td class="even">'
             . _AM_ADSLIGHT_CAT_META_DESCRIPTION
             . " </td><td class=\"odd\" colspan=2>\n"
             . "    <input type=\"text\" name=\"cat_desc\" value=\"$cat_desc\" size=\"80\" maxlength=\"200\">\n"
             . "  </td></tr>\n"
             . '  <tr><td class="even">'
             . _AM_ADSLIGHT_CAT_META_KEYWORDS
             . " </td><td class=\"odd\" colspan=2>\n"
             . "    <input type=\"text\" name=\"cat_keywords\" value=\"$cat_keywords\" size=\"80\" maxlength=\"200\">\n"
             . "  </td></tr>\n";
    }

    echo "  <tr>\n" . '    <td class="even">' . _AM_ADSLIGHT_IMGCAT . '  </td><td class="odd" colspan=2><select name="img" onChange="showimage()">';

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
    }
    asort($filelist);
    //    while (list($key, $file) = each($filelist)) {
    foreach ($filelist as $key => $file) {
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ('.' === $file || '..' === $file) {
                $a = 1;
            }
        } else {
            if ('default.png' === $file) {
                echo "<option value=\"{$file}\" selected>{$file}</option>";
            } else {
                echo "<option value=\"{$file}\">{$file}</option>";
            }
        }
    }
    echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/img_cat/default.png" name="avatar" align="absmiddle"><br><b>' . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1" checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="affprice" value="0">' . _NO . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="cat_moderate" value="0">' . _NO . '</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"checked>' . _YES . '&nbsp;&nbsp; <input type="radio" name="moderate_subcat" value="0">' . _NO . '</td></tr>';

    if ('title' !== $GLOBALS['xoopsModuleConfig']['adslight_csortorder']) {
        echo '<tr><td>' . _AM_ADSLIGHT_ORDER . ' </td><td><input type="text" name="cat_order" size="4" value="0" ></td><td class="foot"><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
    } else {
        $cat_order = (int)$cat_order;
        echo "<input type=\"hidden\" name=\"cat_order\" value=\"$cat_order\">";
        echo '<tr><td class="foot" colspan=3><input type="submit" value="' . _AM_ADSLIGHT_ADD . '" ></td></tr>';
    }

    echo "</table>\n" . "</form>\n" . "<br>\n" . "</fieldset><br>\n";
    xoops_cp_footer();
}

#  function adsModCat
#####################################################
/**
 * @param $cid
 */
function adsModCat($cid)
{
    global $xoopsDB, $myts;

    $mytree = new Adslight\ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

    //    require_once __DIR__ . '/admin_header.php';

    //    loadModuleAdminMenu(1, '');
    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODIFCAT . '</legend>';
    //    ShowImg();
    Adslight\Utility::showImage();

    $result = $xoopsDB->query('SELECT cid, pid, title, cat_desc, cat_keywords, img, cat_order, affprice, cat_moderate, moderate_subcat FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid=$cid");
    list($cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $cat_order, $affprice, $cat_moderate, $moderate_subcat) = $xoopsDB->fetchRow($result);

    $title    = $myts->htmlSpecialChars($title);
    $cat_desc = $myts->addSlashes($cat_desc);
    echo '<form action="category.php" method="post" name="imcat">';
    echo $GLOBALS['xoopsSecurity']->getTokenHTML();
    echo '<table class="outer" border="0"><tr>
    <td class="even">' . _AM_ADSLIGHT_CATNAME . "   </td><td class=\"odd\"><input type=\"text\" name=\"title\" value=\"{$title}\" size=\"50\" maxlength=\"100\">&nbsp; " . _AM_ADSLIGHT_IN . ' &nbsp;';
    $mytree->makeMySelBox('title', 'title', $pid, 1);
    echo '</td></tr>';

    if ('1' == $GLOBALS['xoopsModuleConfig']['adslight_cat_desc']) {
        echo '<tr><td class="even">' . _AM_ADSLIGHT_CAT_META_DESCRIPTION . ' </td><td class="odd" colspan=2>';
        echo "<input type=\"text\" name=\"cat_desc\" value=\"{$cat_desc}\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';

        echo '<tr><td class="even">' . _AM_ADSLIGHT_CAT_META_KEYWORDS . ' </td><td class="odd" colspan=2>';
        echo "<input type=\"text\" name=\"cat_keywords\" value=\"{$cat_keywords}\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';
    }

    echo '<tr>
    <td class="even">' . _AM_ADSLIGHT_IMGCAT . '  </td><td class="odd"><select name="img" onChange="showimage()">';

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
    }
    asort($filelist);
    //    while (list($key, $file) = each($filelist)) {
    foreach ($filelist as $key => $file) {
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ('.' === $file || '..' === $file) {
                $a = 1;
            }
        } else {
            if ($file == $imgs) {
                echo "<option value=\"{$file}\" selected>{$file}</option>";
            } else {
                echo "<option value=\"{$file}\">{$file}</option>";
            }
        }
    }
    echo '</select>&nbsp;&nbsp;<img src="' . XOOPS_URL . "/modules/adslight/assets/images/img_cat/{$imgs}\" name=\"avatar\" align=\"absmiddle\"><br><b>" . _AM_ADSLIGHT_REPIMGCAT . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_DISPLPRICE2 . ' </td><td class="odd" colspan=2><input type="radio" name="affprice" value="1"';
    if ('1' == $affprice) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="affprice" value="0"';
    if ('0' == $affprice) {
        echo 'checked';
    }
    echo '>' . _NO . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_CAT . ' </td><td class="odd" colspan=2><input type="radio" name="cat_moderate" value="1"';
    if ('1' == $cat_moderate) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="cat_moderate" value="0"';
    if ('0' == $cat_moderate) {
        echo 'checked';
    }
    echo '>' . _NO . '</td></tr>';

    echo '<tr><td class="even">' . _AM_ADSLIGHT_MODERATE_SUBCATS . ' </td><td class="odd" colspan=2><input type="radio" name="moderate_subcat" value="1"';
    if ('1' == $moderate_subcat) {
        echo 'checked';
    }
    echo '>' . _YES . '&nbsp;&nbsp; <input type="radio" name="moderate_subcat" value="0"';
    if ('0' == $moderate_subcat) {
        echo 'checked';
    }
    echo '>' . _NO . '</td></tr>';

    if ('title' !== $GLOBALS['xoopsModuleConfig']['adslight_csortorder']) {
        echo '<tr><td class="even">' . _AM_ADSLIGHT_ORDER . " </td><td class=\"odd\"><input type=\"text\" name=\"cat_order\" size=\"4\" value=\"$cat_order\"></td></tr>";
    } else {
        $cat_order = (int)$cat_order;
        echo "<input type=\"hidden\" name=\"cat_order\" value=\"{$cat_order}\">";
    }

    echo '</table>';

    echo "<input type=\"hidden\" name=\"cidd\" value=\"{$cid}\">"
         . '<input type="hidden" name="op" value="AdsModCatS">'
         . '<table class="foot" border="0"><tr><td width="20%"><br>'

         . '<input type="submit" value="'
         . _AM_ADSLIGHT_SAVMOD
         . '"></form></td><td><br>'
         . '<form action="category.php" method="post">'
         . "<input type=\"hidden\" name=\"cid\" value=\"{$cid}\">"
         . '<input type="hidden" name="op" value="AdsDelCat">'
         . '<input type="submit" value="'
         . _AM_ADSLIGHT_DEL
         . '"></form></td></tr></table>';
    echo '</fieldset><br>';
    xoops_cp_footer();
}

#  function adsModCatS
#####################################################
/**
 * @param $cidd
 * @param $cid
 * @param $img
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $cat_order
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function adsModCatS($cidd, $cid, $img, $title, $cat_desc, $cat_keywords, $cat_order, $affprice, $cat_moderate, $moderate_subcat)
{
    global $xoopsDB, $myts;

    $title = $myts->htmlSpecialChars($title);
    $cidd  = (int)$cidd;

    $xoopsDB->query('UPDATE '
                    . $xoopsDB->prefix('adslight_categories')
                    . " SET title='$title', cat_desc='$cat_desc', cat_keywords='$cat_keywords', pid='$cid', img='$img', cat_order='$cat_order', affprice='$affprice', cat_moderate='$cat_moderate', moderate_subcat='$moderate_subcat' WHERE cid={$cidd}");

    if (1 != $moderate_subcat) {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=0, moderate_subcat=0 WHERE pid={$cidd}");
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . " SET cat_moderate=1, moderate_subcat=1 WHERE pid={$cidd}");
    }

    redirect_header('map.php', 10, _AM_ADSLIGHT_CATSMOD);
}

#  function adsAddCat
#####################################################
/**
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $cid
 * @param $img
 * @param $cat_order
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function adsAddCat($title, $cat_desc, $cat_keywords, $cid, $img, $cat_order, $affprice, $cat_moderate, $moderate_subcat)
{
    global $xoopsDB, $myts;

    $moderate_subcat = (int)$moderate_subcat;
    $title           = $myts->htmlSpecialChars($title);
    if ('' == $title) {
        $title = '! ! ? ! !';
    }

    $xoopsDB->query('INSERT INTO ' . $xoopsDB->prefix('adslight_categories') . " VALUES (NULL, '$cid', '$title', '$cat_desc', '$cat_keywords', '$img', '$cat_order', '$affprice', '$cat_moderate', '$moderate_subcat')");

    if (1 == $moderate_subcat) {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=1 WHERE pid = ' . (int)$cid . '');
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0 WHERE pid = ' . (int)$cid . '');
    }

    redirect_header('map.php', 3, _AM_ADSLIGHT_CATADD);
}

#  function adsDelCat
#####################################################
/**
 * @param     $cid
 * @param int $ok
 */
function adsDelCat($cid, $ok = 0)
{
    $cid = (int)$cid;
    if (1 == (int)$ok) {
        /** @var \XoopsMySQLDatabase $xoopsDB */
        $xoopsDB = \XoopsDatabaseFactory::getDatabaseConnection();
        $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid={$cid} OR pid={$cid}");
        $xoopsDB->queryf('DELETE FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE cid={$cid}");

        redirect_header('map.php', 3, _AM_ADSLIGHT_CATDEL);
    } else {
        //        require_once __DIR__ . '/admin_header.php';
        //        loadModuleAdminMenu(1, '');

        OpenTable();
        echo '<br><div style="text-align: center;"><strong>' . _AM_ADSLIGHT_SURDELCAT . '</strong></div><br><br>';
        echo "[ <a href=\"category.php?op=AdsDelCat&cid={$cid}&ok=1\">" . _YES . '</a> | <a href="map.php">' . _NO . '</a> ]<br><br>';
        closeTable();
        xoops_cp_footer();
    }
}

#####################################################
//@todo REMOVE THIS ASAP!  This code is extremely unsafe
foreach ($_POST as $k => $v) {
    ${$k} = $v;
}

$ok  = Request::getString('ok', '', 'GET');
$cid = Request::getInt('cid', 0);
$op  = Request::getString('op', '');

switch ($op) {
    case 'AdsNewCat':
        adsNewCat($cid);
        break;
    case 'AdsAddCat':
        adsAddCat($title, $cat_desc, $cat_keywords, $cid, $img, $cat_order, $affprice, $cat_moderate, $moderate_subcat);
        break;
    case 'AdsDelCat':
        adsDelCat($cid, $ok);
        break;
    case 'AdsModCat':
        adsModCat($cid);
        break;
    case 'AdsModCatS':
        adsModCatS($cidd, $cid, $img, $title, $cat_desc, $cat_keywords, $cat_order, $affprice, $cat_moderate, $moderate_subcat);
        break;
    default:
        //        index();
        break;
}

mambax7 / adslight

Push — master ( 0405fd...a3f27c )

admin/category.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like
