Issues in print.php - Fixed Issues - Inspection of "2.2 Beta 3" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (f83415)

by Michael

created 2016-09-28 07:11 UTC

print.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';
require_once(XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php');
include(XOOPS_ROOT_PATH . '/modules/adslight/include/functions.php');

/**
 * @param $lid
 */
function PrintAd($lid)
{
    global $xoopsConfig, $xoopsUser, $xoopsDB, $xoopsModuleConfig, $useroffset, $myts, $xoopsLogger, $moduleDirName, $main_lang;

    $currenttheme = $xoopsConfig['theme_set'];

    $result =
        $xoopsDB->query('select l.lid, l.title, l.expire, l.type, l.desctext, l.tel, l.price, l.typeprice, l.date, l.email, l.submitter, l.town, l.country, l.photo, p.cod_img, p.lid, p.uid_owner, p.url FROM ' .
                        $xoopsDB->prefix('adslight_listing') .
                        ' l LEFT JOIN ' .
                        $xoopsDB->prefix('adslight_pictures') .
                        ' p ON l.lid=p.lid where l.lid=' .
                        $xoopsDB->escape($lid) .
                        '');
    list($lid, $title, $expire, $type, $desctext, $tel, $price, $typeprice, $date, $email, $submitter, $town, $country, $photo, $cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($result);

    $title     = $myts->htmlSpecialChars($title);
    $expire    = $myts->htmlSpecialChars($expire);
    $type      = adslight_NameType($myts->htmlSpecialChars($type));
    $desctext  = $myts->displayTarea($desctext, 1, 1, 1, 1, 1);
    $tel       = $myts->htmlSpecialChars($tel);
    $price     = $myts->htmlSpecialChars($price);
    $typeprice = $myts->htmlSpecialChars($typeprice);
    $submitter = $myts->htmlSpecialChars($submitter);
    $town      = $myts->htmlSpecialChars($town);
    $country   = $myts->htmlSpecialChars($country);

    echo '
    <html>
    <head><title>' . $xoopsConfig['sitename'] . "</title>
    <meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />
    <meta http-equiv=\”robots\” content=\"noindex, nofollow, noarchive\" />
    <link rel=\"StyleSheet\" href=\"../../themes/" . $currenttheme . "/style/style.css\" type=\"text/css\">
    </head>
    <body bgcolor=\"#FFFFFF\" text=\"#000000\">
    <table border=0><tr><td>
    <table border=0 width=100% cellpadding=0 cellspacing=1 bgcolor=\"#000000\"><tr><td>
    <table border=0 width=100% cellpadding=15 cellspacing=1 bgcolor=\"#FFFFFF\"><tr><td>";

    $useroffset = '';
    if ($xoopsUser) {

        $timezone = $xoopsUser->timezone();
        if (isset($timezone)) {
            $useroffset = $xoopsUser->timezone();
        } else {
            $useroffset = $xoopsConfig['default_TZ'];
        }
    }
    $date  = ($useroffset * 3600) + $date;
    $date2 = $date + ($expire * 86400);
    $date  = formatTimestamp($date, 's');
    $date2 = formatTimestamp($date2, 's');

    echo '<br><br><table width=99% border=0>
        <tr>
      <td>' . _ADSLIGHT_CLASSIFIED . " (No. $lid ) <br>" . _ADSLIGHT_FROM . " $submitter <br><br>";

    echo " <strong>$type :</strong> <i>$title</i><br>";
    if ($price > 0) {
        echo '<strong>' . _ADSLIGHT_PRICE2 . "</strong> $price " . $xoopsModuleConfig['adslight_money'] . "  - $typeprice<br>";
    }
    if ($photo) {
        echo "<tr><td><left><img class=\"thumb\" src=\"" . XOOPS_URL . "/uploads/AdsLight/$url\" width=\"130px\" border=0 /></center>";
    }
    echo '</td>
          </tr>
    <tr>
      <td><strong>' . _ADSLIGHT_DESC . "</strong><br><br><div style=\"text-align:justify;\">$desctext</div><p>";
    if ($tel) {
        echo '<br><strong>' . _ADSLIGHT_TEL . "</strong> $tel";
    }
    if ($town) {
        echo '<br><strong>' . _ADSLIGHT_TOWN . "</strong> $town";
    }
    if ($country) {
        echo '<br><strong>' . _ADSLIGHT_COUNTRY . "</strong> $country";
    }
    echo '<hr />';
    echo '' . _ADSLIGHT_NOMAIL . ' <br>' . XOOPS_URL . '/modules/adslight/viewads.php?lid=' . $lid . '<br>';
    echo '<br><br>' . _ADSLIGHT_DATE2 . " $date " . _ADSLIGHT_AND . ' ' . _ADSLIGHT_DISPO . " $date2<br><br>";
    echo '</td>
    </tr>
    </table>';
    echo '<br><br></td></tr></table></td></tr></table>
    <br><br><center>
    ' . _ADSLIGHT_EXTRANN . ' <strong>' . $xoopsConfig['sitename'] . "</strong><br>
    <a href=\"" . XOOPS_URL . "/modules/adslight/\">" . XOOPS_URL . '/modules/adslight/</a>
    </td></tr></table>
    </body>
    </html>';
}

##############################################################

if (!isset($_POST['lid']) && isset($_GET['lid'])) {

    $lid = (int)$_GET['lid'];
} else {
    $lid = (int)$_POST['lid'];
}

$op = '';
if (!empty($_GET['op'])) {
    $op = $_GET['op'];
} elseif (!empty($_POST['op'])) {
    $op = $_POST['op'];
}

switch ($op) {

    case 'PrintAd':
        PrintAd($lid);
        break;

    default:
        redirect_header('index.php', 3, '' . _RETURNGLO . '');
        break;

}


1		<?php
2		/*
3		-------------------------------------------------------------------------
4		ADSLIGHT 2 : Module for Xoops
5
6		Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7		Started with the Classifieds module and made MANY changes
8		Website : http://www.luc-bizet.fr
9		Contact : [email protected]
10		-------------------------------------------------------------------------
11		Original credits below Version History
12		##########################################################################
13		# Classified Module for Xoops #
14		# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15		# Started with the MyAds module and made MANY changes #
16		##########################################################################
17		Original Author: Pascal Le Boustouller
18		Author Website : [email protected]
19		Licence Type : GPL
20		-------------------------------------------------------------------------
21		*/
22
23		include_once __DIR__ . '/header.php';
24		require_once(XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php');
25		include(XOOPS_ROOT_PATH . '/modules/adslight/include/functions.php');
26
27		/**
28		* @param $lid
29		*/
30		function PrintAd($lid)
31		{
32		global $xoopsConfig, $xoopsUser, $xoopsDB, $xoopsModuleConfig, $useroffset, $myts, $xoopsLogger, $moduleDirName, $main_lang;
33
34		$currenttheme = $xoopsConfig['theme_set'];
35
36		$result =
37		$xoopsDB->query('select l.lid, l.title, l.expire, l.type, l.desctext, l.tel, l.price, l.typeprice, l.date, l.email, l.submitter, l.town, l.country, l.photo, p.cod_img, p.lid, p.uid_owner, p.url FROM ' .
38		$xoopsDB->prefix('adslight_listing') .
39		' l LEFT JOIN ' .
40		$xoopsDB->prefix('adslight_pictures') .
41		' p ON l.lid=p.lid where l.lid=' .
42		$xoopsDB->escape($lid) .
43		'');
44		list($lid, $title, $expire, $type, $desctext, $tel, $price, $typeprice, $date, $email, $submitter, $town, $country, $photo, $cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($result);
45
46		$title = $myts->htmlSpecialChars($title);
47		$expire = $myts->htmlSpecialChars($expire);
48		$type = adslight_NameType($myts->htmlSpecialChars($type));
49		$desctext = $myts->displayTarea($desctext, 1, 1, 1, 1, 1);
50		$tel = $myts->htmlSpecialChars($tel);
51		$price = $myts->htmlSpecialChars($price);
52		$typeprice = $myts->htmlSpecialChars($typeprice);
53		$submitter = $myts->htmlSpecialChars($submitter);
54		$town = $myts->htmlSpecialChars($town);
55		$country = $myts->htmlSpecialChars($country);
56
57		echo '
58		<html>
59		<head><title>' . $xoopsConfig['sitename'] . "</title>
60		<meta http-equiv=\"Content-Type\" content=\"text/html; charset=utf-8\" />
61		<meta http-equiv=\”robots\” content=\"noindex, nofollow, noarchive\" />
62		<link rel=\"StyleSheet\" href=\"../../themes/" . $currenttheme . "/style/style.css\" type=\"text/css\">
63		</head>
64		<body bgcolor=\"#FFFFFF\" text=\"#000000\">
65		<table border=0><tr><td>
66		<table border=0 width=100% cellpadding=0 cellspacing=1 bgcolor=\"#000000\"><tr><td>
67		<table border=0 width=100% cellpadding=15 cellspacing=1 bgcolor=\"#FFFFFF\"><tr><td>";
68
69		$useroffset = '';
70	View Code Duplication	if ($xoopsUser) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		$timezone = $xoopsUser->timezone();
72		if (isset($timezone)) {
73		$useroffset = $xoopsUser->timezone();
74		} else {
75		$useroffset = $xoopsConfig['default_TZ'];
76		}
77		}
78		$date = ($useroffset * 3600) + $date;
79		$date2 = $date + ($expire * 86400);
80		$date = formatTimestamp($date, 's');
81		$date2 = formatTimestamp($date2, 's');
82
83		echo '<br><br><table width=99% border=0>
84		<tr>
85		<td>' . _ADSLIGHT_CLASSIFIED . " (No. $lid ) <br>" . _ADSLIGHT_FROM . " $submitter <br><br>";
86
87		echo " <strong>$type :</strong> <i>$title</i><br>";
88		if ($price > 0) {
89		echo '<strong>' . _ADSLIGHT_PRICE2 . "</strong> $price " . $xoopsModuleConfig['adslight_money'] . " - $typeprice<br>";
90		}
91		if ($photo) {
92		echo "<tr><td><left><img class=\"thumb\" src=\"" . XOOPS_URL . "/uploads/AdsLight/$url\" width=\"130px\" border=0 /></center>";
93		}
94		echo '</td>
95		</tr>
96		<tr>
97		<td><strong>' . _ADSLIGHT_DESC . "</strong><br><br><div style=\"text-align:justify;\">$desctext</div><p>";
98		if ($tel) {
99		echo '<br><strong>' . _ADSLIGHT_TEL . "</strong> $tel";
100		}
101		if ($town) {
102		echo '<br><strong>' . _ADSLIGHT_TOWN . "</strong> $town";
103		}
104		if ($country) {
105		echo '<br><strong>' . _ADSLIGHT_COUNTRY . "</strong> $country";
106		}
107		echo '<hr />';
108		echo '' . _ADSLIGHT_NOMAIL . ' <br>' . XOOPS_URL . '/modules/adslight/viewads.php?lid=' . $lid . '<br>';
109		echo '<br><br>' . _ADSLIGHT_DATE2 . " $date " . _ADSLIGHT_AND . ' ' . _ADSLIGHT_DISPO . " $date2<br><br>";
110		echo '</td>
111		</tr>
112		</table>';
113		echo '<br><br></td></tr></table></td></tr></table>
114		<br><br><center>
115		' . _ADSLIGHT_EXTRANN . ' <strong>' . $xoopsConfig['sitename'] . "</strong><br>
116		<a href=\"" . XOOPS_URL . "/modules/adslight/\">" . XOOPS_URL . '/modules/adslight/</a>
117		</td></tr></table>
118		</body>
119		</html>';
120		}
121
122		##############################################################
123
124	View Code Duplication	if (!isset($_POST['lid']) && isset($_GET['lid'])) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
125		$lid = (int)$_GET['lid'];
126		} else {
127		$lid = (int)$_POST['lid'];
128		}
129
130		$op = '';
131		if (!empty($_GET['op'])) {
132		$op = $_GET['op'];
133		} elseif (!empty($_POST['op'])) {
134		$op = $_POST['op'];
135		}
136
137		switch ($op) {
138
139		case 'PrintAd':
140		PrintAd($lid);
141		break;
142
143		default:
144		redirect_header('index.php', 3, '' . _RETURNGLO . '');
145		break;
146
147		}
148

mambax7 / adslight

Branch — master (f83415)

print.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like