update_function.php ➔ xoops_module_update_adslight() - Code Metrics - Inspection of "updates" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a84b6a)

by Michael

created 2016-09-30 17:23 UTC

update_function.php ➔ xoops_module_update_adslight() B

↳ Parent: Project

Complexity

Conditions	4
Paths	3

Size

Total Lines	33
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	19
nc	3
nop	1
dl	0
loc	33
rs	8.5806
c	0
b	0
f	0

<?php

/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once XOOPS_ROOT_PATH . '/modules/adslight/class/utilities.php';
/**
 * @param XoopsObject $xoopsModule
 *
 * @return bool
 */
function xoops_module_update_adslight(XoopsObject $xoopsModule)
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
{
    global $xoopsDB;
function myFunction($a, $b) {
    // Do something
}

    $sql = 'ALTER TABLE `' . $xoopsDB->prefix('adslight_listing') . "` MODIFY `price` decimal(20,2) NOT NULL default '0.00' AFTER `tel` ;";
    $xoopsDB->query($sql);

    $sql = 'ALTER TABLE `' . $xoopsDB->prefix('adslight_listing') . "` MODIFY `photo` varchar(100) NOT NULL default '0';";
    $xoopsDB->query($sql);

    // remove old html template files
    $template_directory = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/templates/';
    $template_list      = array_diff(scandir($template_directory), array('..', '.'));
    foreach ($template_list as $k => $v) {

        $fileinfo = new SplFileInfo($template_directory . $v);
        if ($fileinfo->getExtension() === 'html' && $fileinfo->getFilename() !== 'index.html') {
            @unlink($template_directory . $v);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
        }
    }

    xoops_load('xoopsfile');

    //remove /images directory
    $imagesDirectory = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/images/';
    $folderHandler   = XoopsFile::getHandler('folder', $imagesDirectory);
    $folderHandler->delete($imagesDirectory);

    //delete .html entries from the tpl table
    $sql = 'DELETE FROM ' . $xoopsDB->prefix('tplfile') . " WHERE `tpl_module` = '" . $xoopsModule->getVar('dirname', 'n') . "' AND `tpl_file` LIKE '%.html%'";
    $xoopsDB->queryF($sql);

    return true;
}


Branch — master (a84b6a)

update_function.php ➔ xoops_module_update_adslight() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 29 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		-------------------------------------------------------------------------
4		ADSLIGHT 2 : Module for Xoops
5
6		Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7		Started with the Classifieds module and made MANY changes
8		Website : http://www.luc-bizet.fr
9		Contact : [email protected]
10		-------------------------------------------------------------------------
11		Original credits below Version History
12		##########################################################################
13		# Classified Module for Xoops #
14		# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15		# Started with the MyAds module and made MANY changes #
16		##########################################################################
17		Original Author: Pascal Le Boustouller
18		Author Website : [email protected]
19		Licence Type : GPL
20		-------------------------------------------------------------------------
21		*/
22
23		include_once XOOPS_ROOT_PATH . '/modules/adslight/class/utilities.php';
24		/**
25		* @param XoopsObject $xoopsModule
26		*
27		* @return bool
28		*/
29		function xoops_module_update_adslight(XoopsObject $xoopsModule)
		0 ignored issues – show Best Practice introduced 2016-09-30 16:24 UTC by Report Bug Copy Issue Report The function `xoops_module_update_adslight()` has been defined more than once; this definition is ignored, only the first definition in `include/onupdate.php` (L72-153) is considered. This check looks for functions that have already been defined in other files. Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the `@ignore` annotation. /** * @ignore */ function getUser() { } function getUser($id, $realm) { } See also the PhpDoc documentation for @ignore. Loading history...
30		{
31		global $xoopsDB;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
32
33		$sql = 'ALTER TABLE `' . $xoopsDB->prefix('adslight_listing') . "` MODIFY `price` decimal(20,2) NOT NULL default '0.00' AFTER `tel` ;";
34		$xoopsDB->query($sql);
35
36		$sql = 'ALTER TABLE `' . $xoopsDB->prefix('adslight_listing') . "` MODIFY `photo` varchar(100) NOT NULL default '0';";
37		$xoopsDB->query($sql);
38
39		// remove old html template files
40		$template_directory = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/templates/';
41		$template_list = array_diff(scandir($template_directory), array('..', '.'));
42	View Code Duplication	foreach ($template_list as $k => $v) {
		1 ignored issue – show Duplication introduced 2016-09-30 16:24 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		$fileinfo = new SplFileInfo($template_directory . $v);
44		if ($fileinfo->getExtension() === 'html' && $fileinfo->getFilename() !== 'index.html') {
45		@unlink($template_directory . $v);
		0 ignored issues – show Security Best Practice introduced 2016-01-18 09:40 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
46		}
47		}
48
49		xoops_load('xoopsfile');
50
51		//remove /images directory
52		$imagesDirectory = XOOPS_ROOT_PATH . '/modules/' . $xoopsModule->getVar('dirname', 'n') . '/images/';
53		$folderHandler = XoopsFile::getHandler('folder', $imagesDirectory);
54		$folderHandler->delete($imagesDirectory);
55
56		//delete .html entries from the tpl table
57		$sql = 'DELETE FROM ' . $xoopsDB->prefix('tplfile') . " WHERE `tpl_module` = '" . $xoopsModule->getVar('dirname', 'n') . "' AND `tpl_file` LIKE '%.html%'";
58		$xoopsDB->queryF($sql);
59
60		return true;
61		}
62

mambax7 / adslight

Branch — master (a84b6a)

update_function.php ➔ xoops_module_update_adslight() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like