Issues in maps.php - All Issues - Inspection of "updates" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 25ce06...a84b6a )

by Michael

created 2016-09-30 16:22 UTC

maps.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';
require_once XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';

$myts      = MyTextSanitizer::getInstance();
$module_id = $xoopsModule->getVar('mid');

if (is_object($xoopsUser)) {
    $groups = $xoopsUser->getGroups();
} else {
    $groups = XOOPS_GROUP_ANONYMOUS;
}
$gperm_handler = xoops_getHandler('groupperm');
if (isset($_POST['item_id'])) {
    $perm_itemid = (int)$_POST['item_id'];
} else {
    $perm_itemid = 0;
}
//If no access
if (!$gperm_handler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {

    redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
}
if (!$gperm_handler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
    $prem_perm = '0';
} else {
    $prem_perm = '1';
}

#  function adslightMaps
#####################################################
function adslightMaps()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsUser, $xoopsTpl, $myts, $mytree, $meta, $mid, $moduleDirName, $main_lang, $prem_perm;
function myFunction($a, $b) {
    // Do something
}

    $GLOBALS['xoopsOption']['template_main'] = 'adslight_maps.tpl';

    include XOOPS_ROOT_PATH . '/header.php';

    $xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
    $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
    $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
    $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
    $xoopsTpl->assign('search_listings', _ADSLIGHT_SEARCH_LISTINGS);
    $xoopsTpl->assign('all_words', _ADSLIGHT_ALL_WORDS);
    $xoopsTpl->assign('any_words', _ADSLIGHT_ANY_WORDS);
    $xoopsTpl->assign('exact_match', _ADSLIGHT_EXACT_MATCH);
    $xoopsTpl->assign('only_pix', _ADSLIGHT_ONLYPIX);
    $xoopsTpl->assign('search', _ADSLIGHT_SEARCH);
    $xoopsTpl->assign('permit', $prem_perm);
    $xoopsTpl->assign('imgscss', XOOPS_URL . '/modules/adslight/assets/css/adslight.css');
    $xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);

    $xoTheme->addMeta('meta', 'robots', 'noindex, nofollow');


    $header_cssadslight = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" />';

    $xoopsTpl->assign('xoops_module_header', $header_cssadslight);

    $maps_name   = $xoopsModuleConfig['adslight_maps_set'];
    $maps_width  = $xoopsModuleConfig['adslight_maps_width'];
    $maps_height = $xoopsModuleConfig['adslight_maps_height'];

    $xoopsTpl->assign('maps_name', $maps_name);
    $xoopsTpl->assign('maps_width', $maps_width);
    $xoopsTpl->assign('maps_height', $maps_height);

    $xoopsTpl->assign('adlight_maps_title', _ADSLIGHT_MAPS_TITLE);
    $xoopsTpl->assign('bullinfotext', _ADSLIGHT_MAPS_TEXT);

    // adslight 2
    $xoopsTpl->assign('adslight_active_menu', $xoopsModuleConfig['adslight_active_menu']);
    $xoopsTpl->assign('adslight_active_rss', $xoopsModuleConfig['adslight_active_rss']);

    if ($xoopsUser) {

        $member_usid = $xoopsUser->getVar('uid');
        if ($usid = $member_usid) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $xoopsTpl->assign('istheirs', true);

            list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE usid=$member_usid"));

            $xoopsTpl->assign('show_user', $show_user);
            $xoopsTpl->assign('show_user_link', "members.php?usid=$member_usid");
        }
    }
}

######################################################

$pa = !isset($_GET['pa']) ? null : $_GET['pa'];

switch ($pa) {
    default:
        $GLOBALS['xoopsOption']['template_main'] = 'adslight_maps.tpl';
        adslightMaps();
        break;
}
include XOOPS_ROOT_PATH . '/footer.php';


1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 52 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		/*
3		-------------------------------------------------------------------------
4		ADSLIGHT 2 : Module for Xoops
5
6		Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7		Started with the Classifieds module and made MANY changes
8		Website : http://www.luc-bizet.fr
9		Contact : [email protected]
10		-------------------------------------------------------------------------
11		Original credits below Version History
12		##########################################################################
13		# Classified Module for Xoops #
14		# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15		# Started with the MyAds module and made MANY changes #
16		##########################################################################
17		Original Author: Pascal Le Boustouller
18		Author Website : [email protected]
19		Licence Type : GPL
20		-------------------------------------------------------------------------
21		*/
22
23		include_once __DIR__ . '/header.php';
24		require_once XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';
25
26		$myts = MyTextSanitizer::getInstance();
27		$module_id = $xoopsModule->getVar('mid');
28
29		if (is_object($xoopsUser)) {
30		$groups = $xoopsUser->getGroups();
31		} else {
32		$groups = XOOPS_GROUP_ANONYMOUS;
33		}
34		$gperm_handler = xoops_getHandler('groupperm');
35		if (isset($_POST['item_id'])) {
36		$perm_itemid = (int)$_POST['item_id'];
37		} else {
38		$perm_itemid = 0;
39		}
40		//If no access
41	View Code Duplication	if (!$gperm_handler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
43		}
44		if (!$gperm_handler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
45		$prem_perm = '0';
46		} else {
47		$prem_perm = '1';
48		}
49
50		# function adslightMaps
51		#####################################################
52		function adslightMaps()
		1 ignored issue – show Coding Style introduced 2016-09-29 09:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this `adslightMaps` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
53		{
54		global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsUser, $xoopsTpl, $myts, $mytree, $meta, $mid, $moduleDirName, $main_lang, $prem_perm;
		1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
55
56		$GLOBALS['xoopsOption']['template_main'] = 'adslight_maps.tpl';
57
58		include XOOPS_ROOT_PATH . '/header.php';
59
60		$xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
61		$xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
62		$xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
63		$xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
64		$xoopsTpl->assign('search_listings', _ADSLIGHT_SEARCH_LISTINGS);
65		$xoopsTpl->assign('all_words', _ADSLIGHT_ALL_WORDS);
66		$xoopsTpl->assign('any_words', _ADSLIGHT_ANY_WORDS);
67		$xoopsTpl->assign('exact_match', _ADSLIGHT_EXACT_MATCH);
68		$xoopsTpl->assign('only_pix', _ADSLIGHT_ONLYPIX);
69		$xoopsTpl->assign('search', _ADSLIGHT_SEARCH);
70		$xoopsTpl->assign('permit', $prem_perm);
71		$xoopsTpl->assign('imgscss', XOOPS_URL . '/modules/adslight/assets/css/adslight.css');
72		$xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);
73
74		$xoTheme->addMeta('meta', 'robots', 'noindex, nofollow');
		0 ignored issues – show Bug introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$xoTheme` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
75
76		$header_cssadslight = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" />';
77
78		$xoopsTpl->assign('xoops_module_header', $header_cssadslight);
79
80		$maps_name = $xoopsModuleConfig['adslight_maps_set'];
81		$maps_width = $xoopsModuleConfig['adslight_maps_width'];
82		$maps_height = $xoopsModuleConfig['adslight_maps_height'];
83
84		$xoopsTpl->assign('maps_name', $maps_name);
85		$xoopsTpl->assign('maps_width', $maps_width);
86		$xoopsTpl->assign('maps_height', $maps_height);
87
88		$xoopsTpl->assign('adlight_maps_title', _ADSLIGHT_MAPS_TITLE);
89		$xoopsTpl->assign('bullinfotext', _ADSLIGHT_MAPS_TEXT);
90
91		// adslight 2
92		$xoopsTpl->assign('adslight_active_menu', $xoopsModuleConfig['adslight_active_menu']);
93		$xoopsTpl->assign('adslight_active_rss', $xoopsModuleConfig['adslight_active_rss']);
94
95	View Code Duplication	if ($xoopsUser) {
		1 ignored issue – show Duplication introduced 2016-01-18 09:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
96		$member_usid = $xoopsUser->getVar('uid');
97		if ($usid = $member_usid) {
		0 ignored issues – show Unused Code introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$usid` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98		$xoopsTpl->assign('istheirs', true);
99
100		list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE usid=$member_usid"));
101
102		$xoopsTpl->assign('show_user', $show_user);
103		$xoopsTpl->assign('show_user_link', "members.php?usid=$member_usid");
104		}
105		}
106		}
107
108		######################################################
109
110		$pa = !isset($_GET['pa']) ? null : $_GET['pa'];
111
112		switch ($pa) {
113		default:
114		$GLOBALS['xoopsOption']['template_main'] = 'adslight_maps.tpl';
115		adslightMaps();
116		break;
117		}
118		include XOOPS_ROOT_PATH . '/footer.php';
119

mambax7 / adslight

Push — master ( 25ce06...a84b6a )

maps.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like