Issues in viewads.php - New Issues - Inspection of "$GLOBALS" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Branch — master (71f789)

by Michael
created 2016-09-30 20:18 UTC
viewads.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';
require_once XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';
xoops_load('XoopsLocal');

$myts      = MyTextSanitizer::getInstance();
$module_id = $xoopsModule->getVar('mid');

if (is_object($GLOBALS['xoopsUser'])) {

    $groups = $GLOBALS['xoopsUser']->getGroups();
} else {
    $groups = XOOPS_GROUP_ANONYMOUS;
}
$gpermHandler = xoops_getHandler('groupperm');
if (isset($_POST['item_id'])) {
    $perm_itemid = (int)$_POST['item_id'];
} else {
    $perm_itemid = 0;
}
//If no access
if (!$gpermHandler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {

    redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
}
if (!$gpermHandler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
    $prem_perm = '0';
} else {
    $prem_perm = '1';
}

include XOOPS_ROOT_PATH . '/modules/adslight/class/classifiedstree.php';
//include XOOPS_ROOT_PATH . '/modules/adslight/class/utilities.php';
$mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

#  function viewads
#####################################################
/**
 * @param int $lid
 */
function viewAds($lid = 0)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsTpl, $myts, $meta, $moduleDirName, $main_lang, $prem_perm, $xoopsModule;
    $pathIcon16 = $xoopsModule->getInfo('icons16');

    $tempXoopsLocal = new XoopsLocal;
    $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';
    include XOOPS_ROOT_PATH . '/header.php';
    include XOOPS_ROOT_PATH . '/include/comment_view.php';
    $lid  = ((int)$lid > 0) ? (int)$lid : 0;
    $rate = ($GLOBALS['xoopsModuleConfig']['adslight_rate_item'] == '1') ? '1' : '0';
    $xoopsTpl->assign('rate', $rate);
    $xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
    $xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);

    // Hack redirection erreur 404  si lid=null
    if ($lid == '') {
        header('Status: 301 Moved Permanently', false, 301);
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
        //        exit();
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
    }

    $xoopsTpl->assign('adslight_active_bookmark', $GLOBALS['xoopsModuleConfig']['adslight_active_bookmark']);
    $xoopsTpl->assign('adslight_style_bookmark', $GLOBALS['xoopsModuleConfig']['adslight_style_bookmark']);
    $xoopsTpl->assign('adslight_active_xpayement', $GLOBALS['xoopsModuleConfig']['adslight_active_xpayment']);

    // adslight 2
    $xoopsTpl->assign('adslight_active_menu', $GLOBALS['xoopsModuleConfig']['adslight_active_menu']);
    $xoopsTpl->assign('adslight_active_rss', $GLOBALS['xoopsModuleConfig']['adslight_active_rss']);

    if ($GLOBALS['xoopsUser']) {
        $member_usid = $GLOBALS['xoopsUser']->getVar('uid');
        if ($usid = $member_usid) {
            $xoopsTpl->assign('istheirs', true);

            if (strlen($GLOBALS['xoopsUser']->getVar('name'))) {
                $xoopsTpl->assign('user_name', $GLOBALS['xoopsUser']->getVar('name') . ' (' . $GLOBALS['xoopsUser']->getVar('uname') . ')');
            } else {
                $xoopsTpl->assign('user_name', $GLOBALS['xoopsUser']->getVar('uname'));
            }

            $xoopsTpl->assign('user_email', $GLOBALS['xoopsUser']->getVar('email'));

            list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE usid=$member_usid"));

            $xoopsTpl->assign('show_user', $show_user);
            $xoopsTpl->assign('show_user_link', 'members.php?usid=' . $member_usid . '');
        }
    }

    if ($GLOBALS['xoopsUser']) {
        $currentid = $GLOBALS['xoopsUser']->getVar('uid', 'E');
    }

    $cat_perms  = '';
    $categories = AdslightUtilities::getMyItemIds('adslight_view');
    if (is_array($categories) && count($categories) > 0) {
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
    }

    $result      = $xoopsDB->query('SELECT l.lid, l.cid, l.title, l.status, l.expire, l.type, l.desctext, l.tel, l.price, l.typeprice, l.typeusure, l.date, l.email, l.submitter, l.usid, l.town, l.country, l.contactby, l.premium, l.valid, l.photo, l.hits, l.item_rating, l.item_votes, l.user_rating, l.user_votes, l.comments, p.cod_img, p.lid, p.uid_owner, p.url FROM '
                                   . $xoopsDB->prefix('adslight_listing')
                                   . ' l LEFT JOIN '
                                   . $xoopsDB->prefix('adslight_pictures')
                                   . " p ON l.lid=p.lid  WHERE l.valid='Yes' AND l.lid = "
                                   . $xoopsDB->escape($lid)
                                   . " and l.status!='1' $cat_perms");
    $recordexist = $xoopsDB->getRowsNum($result);

    // Hack redirection erreur 404  si recordexist=null
    if ($recordexist == '') {
        header('Status: 301 Moved Permanently', false, 301);
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
        //        exit();
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
    }

    if ($recordexist) {
        list($lid, $cid, $title, $status, $expire, $type, $desctext, $tel, $price, $typeprice, $typeusure, $date, $email, $submitter, $usid, $town, $country, $contactby, $premium, $valid, $photo, $hits, $item_rating, $item_votes, $user_rating, $user_votes, $comments, $cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($result);

        $newcount  = $GLOBALS['xoopsModuleConfig']['adslight_countday'];
        $startdate = (time() - (86400 * $newcount));
        if ($startdate < $date) {
            $newitem = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
            $xoopsTpl->assign('new', $newitem);
        }

        $updir = $GLOBALS['xoopsModuleConfig']['adslight_link_upload'];
        $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
        $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
        $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
        $xoopsTpl->assign('ad_exists', $recordexist);
        $xoopsTpl->assign('mydirname', $moduleDirName);

        $count = 0;
        $x     = 0;
        $i     = 0;

        $result3 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE  cid=' . $xoopsDB->escape($cid) . '');
        list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result3);

        $xoopsTpl->assign('category_title', $ctitle);

        $module_id = $xoopsModule->getVar('mid');
        if (is_object($GLOBALS['xoopsUser'])) {

            $groups = $GLOBALS['xoopsUser']->getGroups();
        } else {
            $groups = XOOPS_GROUP_ANONYMOUS;
        }
        $gpermHandler = xoops_getHandler('groupperm');
        $xoopsTpl->assign('purchasable', $gpermHandler->checkRight('adslight_purchase', $cid, $groups, $module_id));

        $ctitle     = $myts->htmlSpecialChars($ctitle);
        $varid[$x]  = $ccid;
        $varnom[$x] = $ctitle;

        list($nbe) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE valid="Yes" AND cid=' . $xoopsDB->escape($cid) . ' AND status!="1"'));

        if ($pid != 0) {
            $x = 1;
            while ($pid != 0) {
                $result4 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($pid) . '');
                list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result4);

                $ctitle     = $myts->htmlSpecialChars($ctitle);
                $varid[$x]  = $ccid;
                $varnom[$x] = $ctitle;
                ++$x;
            }
            --$x;
        }
        $subcats = '';
        $arrow   = '&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/arrow.gif" alt="&raquo;" />';
        while ($x != -1) {
            $subcats .= ' ' . $arrow . ' <a href="viewcats.php?cid=' . $varid[$x] . '">' . $varnom[$x] . '</a>';
            --$x;
        }
        $xoopsTpl->assign('nav_main', '<a href="index.php">' . _ADSLIGHT_MAIN . '</a>');
        $xoopsTpl->assign('nav_sub', $subcats);
        $xoopsTpl->assign('nav_subcount', $nbe);
        $viewcount_judge = true;
        $useroffset      = '';
        if ($GLOBALS['xoopsUser']) {
            $timezone = $GLOBALS['xoopsUser']->timezone();
            if (isset($timezone)) {
                $useroffset = $GLOBALS['xoopsUser']->timezone();
            } else {
                $useroffset = $xoopsConfig['default_TZ'];
            }
            if ($GLOBALS['xoopsUser']->isAdmin()) {
                $adslight_admin = true;
            } else {
                $adslight_admin = false;
            }

            if (($adslight_admin = true) || ($GLOBALS['xoopsUser']->getVar('uid') == $usid)) {
                $viewcount_judge = false;
            }

            $contact_pm = '<a href="' . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . addslashes($usid) . '">&nbsp;' . _ADSLIGHT_CONTACT_BY_PM . '</a>';
        }
        if (true === $viewcount_judge) {
            $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_listing') . ' SET hits=hits+1 WHERE lid = ' . $xoopsDB->escape($lid) . '');
        }
        if ($item_votes == 1) {
            $votestring = _ADSLIGHT_ONEVOTE;
        } else {
            $votestring = sprintf(_ADSLIGHT_NUMVOTES, $item_votes);
        }
        $date     = ($useroffset * 3600) + $date;
        $date2    = $date + ($expire * 86400);
        $date     = formatTimestamp($date, 's');
        $date2    = formatTimestamp($date2, 's');
        $title    = $myts->htmlSpecialChars($title);
        $status   = $myts->htmlSpecialChars($status);
        $expire   = $myts->htmlSpecialChars($expire);
        $type     = $myts->htmlSpecialChars($type);
        $desctext = $myts->displayTarea($desctext, 1, 1, 1);
        $tel      = $myts->htmlSpecialChars($tel);
        //      $price = XoopsLocal::number_format($price, 2, ',', ' ');
        $typeprice = $myts->htmlSpecialChars($typeprice);
        $typeusure = $myts->htmlSpecialChars($typeusure);
        $submitter = $myts->htmlSpecialChars($submitter);
        $usid      = $myts->htmlSpecialChars($usid);
        $town      = $myts->htmlSpecialChars($town);
        $country   = $myts->htmlSpecialChars($country);
        $contactby = $myts->htmlSpecialChars($contactby);
        $premium   = $myts->htmlSpecialChars($premium);

        if ($status == 2) {
            $sold = _ADSLIGHT_RESERVED;
        } else {
            $sold = '';
        }

        $xoopsTpl->assign('printA', '<a href="print.php?op=PrintAd&amp;lid=' . $lid . '" ><img src="assets/images/print.gif" border=0 alt="' . _ADSLIGHT_PRINT . '" /></a>&nbsp;');

        if ($usid > 0) {
            $xoopsTpl->assign('submitter', '<img src="assets/images/lesannonces.png" border="0" alt="'
                                           . _ADSLIGHT_VIEW_MY_ADS
                                           . '" />&nbsp;&nbsp;<a href="members.php?usid='
                                           . addslashes($usid)
                                           . '" />'
                                           . _ADSLIGHT_VIEW_MY_ADS
                                           . ' '
                                           . $submitter
                                           . '</a>');
        } else {
            $xoopsTpl->assign('submitter', _ADSLIGHT_VIEW_MY_ADS . ' $submitter');
        }
        $xoopsTpl->assign('lid', $lid);
        $xoopsTpl->assign('read', "$hits " . _ADSLIGHT_VIEW2);
        $xoopsTpl->assign('rating', $tempXoopsLocal->number_format($item_rating, 2));
        $xoopsTpl->assign('votes', $votestring);
        $xoopsTpl->assign('lang_rating', _ADSLIGHT_RATINGC);
        $xoopsTpl->assign('lang_ratethisitem', _ADSLIGHT_RATETHISITEM);
        $xoopsTpl->assign('xoop_user', false);
        $isOwner = '';
        if ($GLOBALS['xoopsUser']) {
            $xoopsTpl->assign('xoop_user', true);
            $currentid = $GLOBALS['xoopsUser']->getVar('uid', 'E');
            if ($usid == $currentid) {
                $xoopsTpl->assign('modifyads', '<img src='
                                               . $pathIcon16
                                               . '/edit.png border="0" alt="'
                                               . _ADSLIGHT_MODIFANN
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ModAd&amp;lid='
                                               . $lid
                                               . '">'
                                               . _ADSLIGHT_MODIFANN
                                               . '</a>');
                $xoopsTpl->assign('deleteads', '<img src='
                                               . $pathIcon16
                                               . '/delete.png  border="0" alt="'
                                               . _ADSLIGHT_SUPPRANN
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ListingDel&amp;lid='
                                               . $lid
                                               . '">'
                                               . _ADSLIGHT_SUPPRANN
                                               . '</a>');
                $xoopsTpl->assign('add_photos', '<img src="assets/images/shape_square_add.png" border="0" alt="'
                                                . _ADSLIGHT_SUPPRANN
                                                . '" />&nbsp;&nbsp;<a href="view_photos.php?lid='
                                                . $lid
                                                . '&uid='
                                                . $usid
                                                . '">'
                                                . _ADSLIGHT_ADD_PHOTOS
                                                . '</a>');

                $isOwner = true;
                $xoopsTpl->assign('isOwner', $isOwner);
            }
            if ($GLOBALS['xoopsUser']->isAdmin()) {
                $xoopsTpl->assign('admin', '<a href="'
                                           . XOOPS_URL
                                           . '/modules/adslight/admin/modify_ads.php?op=ModifyAds&amp;lid='
                                           . $lid
                                           . '"><img src='
                                           . $pathIcon16
                                           . '/edit.png  border=0 alt="'
                                           . _ADSLIGHT_MODADMIN
                                           . '" /></a>');
            }
        }

        $result7 = $xoopsDB->query('SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . ' WHERE id_type=' . $xoopsDB->escape($type) . '');
        list($nom_type) = $xoopsDB->fetchRow($result7);

        $result8 = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . ' WHERE id_price=' . $xoopsDB->escape($typeprice) . '');
        list($nom_price) = $xoopsDB->fetchRow($result8);

        $result9 = $xoopsDB->query('SELECT nom_usure FROM ' . $xoopsDB->prefix('adslight_usure') . ' WHERE id_usure=' . $xoopsDB->escape($typeusure) . '');
        list($nom_usure) = $xoopsDB->fetchRow($result9);

        $xoopsTpl->assign('type', $myts->htmlSpecialChars($nom_type));
        $xoopsTpl->assign('title', $title);
        $xoopsTpl->assign('status', $status);
        $xoopsTpl->assign('desctext', $desctext);
        $xoopsTpl->assign('xoops_pagetitle', $title . ' - ' . $town . ': ' . $country . ' - ' . $ctitle);

        // meta description tags for ads
        $desctextclean = strip_tags($desctext, '<font><img><strong><i><u>');
        $xoTheme->addMeta('meta', 'description', "$title - " . substr($desctextclean, 0, 150));

        if ($price > 0) {
            $xoopsTpl->assign('price', '<strong>' . _ADSLIGHT_PRICE2 . '</strong>' . $price . ' ' . $GLOBALS['xoopsModuleConfig']['adslight_money'] . ' - ' . $typeprice);
            $xoopsTpl->assign('price_head', _ADSLIGHT_PRICE2);
            //      $xoopsTpl->assign('price_price', $price.' '.$GLOBALS['xoopsModuleConfig']['adslight_money'].' ');

            $xoopsTpl->assign('price_price', AdslightUtilities::getMoneyFormat('%.2n', $price));

            $xoopsTpl->assign('price_typeprice', $myts->htmlSpecialChars($nom_price));
            $xoopsTpl->assign('price_currency', $GLOBALS['xoopsModuleConfig']['adslight_currency']);
            $xoopsTpl->assign('price_amount', $price);
        }

        $xoopsTpl->assign('usure_typeusure', $nom_usure);
        $xoopsTpl->assign('premium', $premium);

        // $xoopsTpl->assign('mustlogin', _ADSLIGHT_MUSTLOGIN);
        $xoopsTpl->assign('redirect', '' . '?xoops_redirect=/modules/adslight/index.php');

        if ($town) {
            $xoopsTpl->assign('local_town', $town);
        }
        if ($GLOBALS['xoopsModuleConfig']['adslight_use_country'] == 1) {
            if ($country) {
                $xoopsTpl->assign('local_country', $country);
                $xoopsTpl->assign('country_head', '<img src="assets/images/world_go.png" border="0" alt="country" />&nbsp;&nbsp;' . _ADSLIGHT_COUNTRY);
            }
        }

        $tphon = '';
        if ($tel) {
            $tphon = '<br>' . _ADSLIGHT_ORBY . '&nbsp;<strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
        }

        if ($contactby == 1) {
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '';
        }
        if ($contactby == 2) {
            $contact = $contact_pm . '' . $tphon;
        }
        if ($contactby == 3) {
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '<br>' . _ADSLIGHT_ORBY . '' . $contact_pm;
        }
        if ($contactby == 4) {
            $contact = '<br><strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
        }
        // $xoopsTpl->assign('contact', $contact);
        $xoopsTpl->assign('local_head', '<img src="assets/images/house.png" border="0" alt="local_head" />&nbsp;&nbsp;' . _ADSLIGHT_LOCAL);

        if ($lid) {
            if ($sold) {
                $xoopsTpl->assign('bullinfotext', $sold);
            } else {
                if ($GLOBALS['xoopsUser']) {
                    $xoopsTpl->assign('bullinfotext', _ADSLIGHT_CONTACT_SUBMITTER . ' ' . $submitter . ' ' . _ADSLIGHT_CONTACTBY2 . ' ' . $contact);
                } else {
                    $xoopsTpl->assign('bullinfotext', '<span style="color: #de090e;"><b>' . _ADSLIGHT_MUSTLOGIN . '</b></span>');
                }
            }
        }

        $user_profile = XoopsUser::getUnameFromId($usid);
        $xoopsTpl->assign('user_profile', '<img src="assets/images/profil.png" border="0" alt="'
                                          . _ADSLIGHT_PROFILE
                                          . '" />&nbsp;&nbsp;<a rel="nofollow" href="'
                                          . XOOPS_URL
                                          . '/user.php?usid='
                                          . addslashes($usid)
                                          . '">'
                                          . _ADSLIGHT_PROFILE
                                          . ' '
                                          . $user_profile
                                          . '</a>');

        if ($photo != '') {
            include_once __DIR__ . '/class/pictures.php';

            $criteria_lid          = new criteria('lid', $lid);
            $criteria_uid          = new criteria('uid', $usid);
            $album_factory         = new Xoopsjlm_picturesHandler($xoopsDB);
            $pictures_object_array =& $album_factory->getObjects($criteria_lid, $criteria_uid);
            $pictures_number       = $album_factory->getCount($criteria_lid, $criteria_uid);
            if ($pictures_number == 0) {
                $nopicturesyet = _ADSLIGHT_NOTHINGYET;
                $xoopsTpl->assign('lang_nopicyet', $nopicturesyet);
            } else {

                /**
                 * Lets populate an array with the data from the pictures
                 */
                $i = 0;
                foreach ($pictures_object_array as $picture) {
                    $pictures_array[$i]['url']     = $picture->getVar('url', 's');
                    $pictures_array[$i]['desc']    = $picture->getVar('title', 's');
                    $pictures_array[$i]['cod_img'] = $picture->getVar('cod_img', 's');
                    $pictures_array[$i]['lid']     = $picture->getVar('lid', 's');
                    $xoopsTpl->assign('pics_array', $pictures_array);

                    ++$i;
                }
            }
            $owner      = new XoopsUser();
            $identifier = $owner->getUnameFromId($usid);
            if ($GLOBALS['xoopsModuleConfig']['adslight_lightbox'] == 1) {
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" />
<script type="text/javascript" src="assets/lightbox/js/jquery-1.7.2.min.js"></script>
<script type="text/javascript" src="assets/lightbox/js/jquery-ui-1.8.18.custom.min"></script>
<script type="text/javascript" src="assets/lightbox/js/jquery.smooth-scroll.min.js"></script>
<script type="text/javascript" src="assets/lightbox/js/lightbox.js"></script>
<link rel="stylesheet" href="assets/css/galery.css" type="text/css" media="screen" />
<link rel="stylesheet" type="text/css" media="screen" href="assets/lightbox/css/lightbox.css"></link>';
            } else {
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/assets/css/adslight.css" type="text/css" media="all" />
<link rel="stylesheet" href="assets/css/galery.css" type="text/css" media="screen" />';
            }

            $xoopsTpl->assign('path_uploads', $GLOBALS['xoopsModuleConfig']['adslight_link_upload']);

            $xoopsTpl->assign('permit', $prem_perm);

            if ($GLOBALS['xoopsModuleConfig']['active_rewriteurl'] > 0) {
                /*  ici le meta Canonicale pour le Rewrite */
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
            } else {
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
            }
            $xoopsTpl->assign('photo', $photo);
            $xoopsTpl->assign('pic_lid', $pic_lid);
            $xoopsTpl->assign('pic_owner', $uid_owner);
        } else {
            $xoopsTpl->assign('photo', '');
        }
        $xoopsTpl->assign('date', '<img alt="date" border="0" src="assets/images/date.png" />&nbsp;&nbsp;<strong>'
                                  . _ADSLIGHT_DATE2
                                  . ':</strong> '
                                  . $date
                                  . '<br><img alt="date_error" border="0" src="assets/images/date_error.png" />&nbsp;&nbsp;<strong>'
                                  . _ADSLIGHT_DISPO
                                  . ':</strong> '
                                  . $date2
                                  . '');
    } else {
        $xoopsTpl->assign('no_ad', _ADSLIGHT_NOCLAS);
    }
    $result8 = $xoopsDB->query('SELECT title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($cid) . '');

    list($ctitle) = $xoopsDB->fetchRow($result8);
    $xoopsTpl->assign('friend', '<img src="assets/images/friend.gif" border="0" alt="'
                                . _ADSLIGHT_SENDFRIENDS
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="sendfriend.php?op=SendFriend&amp;lid='
                                . $lid
                                . '">'
                                . _ADSLIGHT_SENDFRIENDS
                                . '</a>');

    $xoopsTpl->assign('alerteabus', '<img src="assets/images/error.png" border="0" alt="'
                                    . _ADSLIGHT_ALERTEABUS
                                    . '" />&nbsp;&nbsp;<a rel="nofollow" href="report-abuse.php?op=ReportAbuse&amp;lid='
                                    . $lid
                                    . '">'
                                    . _ADSLIGHT_ALERTEABUS
                                    . '</a>');

    $xoopsTpl->assign('link_main', '<a href="../adslight/">' . _ADSLIGHT_MAIN . '</a>');
    $xoopsTpl->assign('link_cat', '<a href="viewcats.php?cid=' . addslashes($cid) . '">' . _ADSLIGHT_GORUB . ' ' . $ctitle . '</a>');

    $xoopsTpl->assign('printA', '<img src="assets/images/print.gif" border="0" alt="'
                                . _ADSLIGHT_PRINT
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="print.php?op=PrintAd&amp;lid='
                                . $lid
                                . '">'
                                . _ADSLIGHT_PRINT
                                . '</a>');
}

#  function categorynewgraphic
#####################################################
/**
 * @param $cid
 *
 * @return string
 */
function categorynewgraphic($cid)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    global $xoopsDB;

    $cat_perms  = '';
    $categories = AdslightUtilities::getMyItemIds('adslight_view');
    if (is_array($categories) && count($categories) > 0) {
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
    }

    $newresult = $xoopsDB->query('SELECT date FROM '
                                 . $xoopsDB->prefix('adslight_listing')
                                 . ' WHERE cid='
                                 . $xoopsDB->escape($cid)
                                 . ' AND valid = "Yes" '
                                 . $cat_perms
                                 . ' ORDER BY date desc limit 1');
    list($date) = $xoopsDB->fetchRow($newresult);

    $newcount  = $GLOBALS['xoopsModuleConfig']['adslight_countday'];
    $startdate = (time() - (86400 * $newcount));
    if ($startdate < $date) {
        return '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
    }
}

######################################################

$pa      = !isset($_GET['pa']) ? null : $_GET['pa'];
$lid     = !isset($_GET['lid']) ? null : $_GET['lid'];
$cid     = !isset($_GET['cid']) ? null : $_GET['cid'];
$usid    = isset($_GET['usid']) ? $_GET['usid'] : '';
$min     = !isset($_GET['min']) ? null : $_GET['min'];
$show    = !isset($_GET['show']) ? null : $_GET['show'];
$orderby = !isset($_GET['orderby']) ? null : $_GET['orderby'];

switch ($pa) {

    default:
        $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';

        viewAds($lid);
        break;
}
include XOOPS_ROOT_PATH . '/footer.php';

mambax7 / adslight

Branch — master (71f789)

viewads.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like
