options.php ➔ listingModUsure() - Code Metrics - Inspection of "$GLOBALS" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (71f789)

by Michael

created 2016-09-30 20:18 UTC

options.php ➔ listingModUsure() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	34
Code Lines	27

Duplication

Lines	28
Ratio	82.35 %

Importance

Changes

Metric	Value
cc	1
eloc	27
nc	1
nop	1
dl	28
loc	34
rs	8.8571
c	0
b	0
f	0

<?php

/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/
include_once __DIR__ . '/admin_header.php';

$op = XoopsRequest::getCmd('op', 'liste');

#  function Index
#####################################################
function index()
/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}
    include_once __DIR__ . '/header.php';
    xoops_cp_header();
    //    loadModuleAdminMenu(2, "");

    echo $adminObject->addNavigation(basename(__FILE__));

    // Ajouter un type
    echo "<table width='100%' border='0' cellspacing='1' cellpadding='8' style='border: 2px solid #DFE0E0;'><tr class='bg4'><td valign='top'>\n";
    echo "<form method=\"post\" action=\"options.php\">
        <b>" . _AM_ADSLIGHT_ADDTYPE . '</b><br><br>
        ' . _AM_ADSLIGHT_TYPE . "   <input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\">
        <input type=\"hidden\" name=\"op\" value=\"ListingAddType\">
        <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\">
        </form>";
    echo '<br>';

    // Modifier un type
    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_type') . ''));
    if ($numrows > 0) {

        echo "<form method=\"post\" action=\"options.php\">
             <b>" . _AM_ADSLIGHT_MODTYPE . '</b></font><br><br>';
        $result2 = $xoopsDB->query('SELECT id_type, nom_type FROM ' . $xoopsDB->prefix('adslight_type') . ' ORDER BY nom_type');
        echo '' . _AM_ADSLIGHT_TYPE . " <select name=\"id_type\">";

        while (list($id_type, $nom_type) = $xoopsDB->fetchRow($result2)) {
            $nom_type = $myts->htmlSpecialChars($nom_type);
            echo "<option value=\"$id_type\">$nom_type</option>";
        }
        echo "</select>
            <input type=\"hidden\" name=\"op\" value=\"ListingModType\">
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_MODIF . "\">
            </form>";
        echo '</td></tr></table>';
        echo '<br>';
    }

    // Ajouter un type de prix
    echo "<table width='100%' border='0' cellspacing='1' cellpadding='8' style='border: 2px solid #DFE0E0;'><tr class='bg4'><td valign='top'>\n";
    echo "<form method=\"post\" action=\"options.php\">
        <b>" . _AM_ADSLIGHT_ADDPRICE . '</b><br><br>
        ' . _AM_ADSLIGHT_TYPE . "   <input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\">
        <input type=\"hidden\" name=\"op\" value=\"ListingAddPrice\">
        <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\">
        </form>";
    echo '<br>';

    // Modifier un type de prix
    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_price') . ''));
    if ($numrows > 0) {

        echo "<form method=\"post\" action=\"options.php\">
            <b>" . _AM_ADSLIGHT_MODPRICE . '</b></font><br><br>';
        $result3 = $xoopsDB->query('SELECT id_price, nom_price FROM ' . $xoopsDB->prefix('adslight_price') . ' ORDER BY nom_price');
        echo '' . _AM_ADSLIGHT_TYPE . " <select name=\"id_price\">";

        while (list($id_price, $nom_price) = $xoopsDB->fetchRow($result3)) {
            $nom_price = $myts->htmlSpecialChars($nom_price);
            echo "<option value=\"$id_price\">$nom_price</option>";
        }
        echo "</select>
            <input type=\"hidden\" name=\"op\" value=\"ListingModPrice\">
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_MODIF . "\">
            </form>";
        echo '</td></tr></table>';
        echo '<br>';
    }

    // Ajouter un type d'usure
    echo "<table width='100%' border='0' cellspacing='1' cellpadding='8' style='border: 2px solid #DFE0E0;'><tr class='bg4'><td valign='top'>\n";
    echo "<form method=\"post\" action=\"options.php\">
        <b>" . _AM_ADSLIGHT_ADDUSURE . '</b><br><br>
        ' . _AM_ADSLIGHT_TYPE . "   <input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\">
        <input type=\"hidden\" name=\"op\" value=\"ListingAddUsure\">
        <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\">
        </form>";
    echo '<br>';

    // Modifier un type d'usure
    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_usure') . ''));
    if ($numrows > 0) {

        echo "<form method=\"post\" action=\"options.php\">
            <b>" . _AM_ADSLIGHT_MODUSURE . '</b></font><br><br>';
        $result8 = $xoopsDB->query('SELECT id_usure, nom_usure FROM ' . $xoopsDB->prefix('adslight_usure') . ' ORDER BY nom_usure');
        echo '' . _AM_ADSLIGHT_TYPE . " <select name=\"id_usure\">";

        while (list($id_usure, $nom_usure) = $xoopsDB->fetchRow($result8)) {
            $nom_usure = $myts->htmlSpecialChars($nom_usure);
            echo "<option value=\"$id_usure\">$nom_usure</option>";
        }
        echo "</select>
            <input type=\"hidden\" name=\"op\" value=\"ListingModUsure\">
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_MODIF . "\">
            </form>";
        echo '</td></tr></table>';
        echo '<br>';
    }

    xoops_cp_footer();
}

#  function listingAddType
#####################################################
/**
 * @param $type
 */
function listingAddType($type)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT  COUNT(*)  FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE nom_type='$type'"));
    if ($numrows > 0) {
        include_once __DIR__ . '/header.php';
        xoops_cp_header();
        //    loadModuleAdminMenu(2, "");


        echo "<table width='100%' border='0' cellspacing='1' cellpadding='8' style='border: 2px solid #DFE0E0;'><tr class='bg4'><td valign='top'>\n";
        echo '<br><div style="text-align:center;"><b>' . _AM_ADSLIGHT_ERRORTYPE . " $nom_type " . _AM_ADSLIGHT_EXIST . '</b></div><br><br>';

        echo "<form method=\"post\" action=\"options.php\">
            <b>" . _AM_ADSLIGHT_ADDTYPE . '</b><br><br>
            ' . _AM_ADSLIGHT_TYPE . "<input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\" />
            <input type=\"hidden\" name=\"op\" value=\"ListingAddType\" />
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\" />
            </form>";
        echo '</td></tr></table>';
        xoops_cp_footer();
    } else {
        $type = $myts->htmlSpecialChars($type);

        if ($type == '') {
            $type = '! ! ? ! !';
        }
        $xoopsDB->query('insert into ' . $xoopsDB->prefix('adslight_type') . " values (NULL, '$type')");

        redirect_header('options.php', 1, _AM_ADSLIGHT_ADDTYPE2);
    }
}

#  function listingModType
#####################################################
/**
 * @param $id_type
 */
function listingModType($id_type)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}
    include_once __DIR__ . '/header.php';
    xoops_cp_header();
    $id_type = (int)$id_type;
    //    loadModuleAdminMenu(2, "");

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODTYPE . '</legend>';
    $result = $xoopsDB->query('SELECT id_type, nom_type FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type=$id_type");
    list($id_type, $nom_type) = $xoopsDB->fetchRow($result);

    $nom_type = $myts->htmlSpecialChars($nom_type);

    echo "<form action=\"options.php\" method=\"post\">"
         . ''
         . _AM_ADSLIGHT_TYPE
         . " <input type=\"text\" name=\"nom_type\" value=\"$nom_type\" size=\"51\" maxlength=\"50\" /><br>"
         . "<input type=\"hidden\" name=\"id_type\" value=\"$id_type\" />"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingModTypeS\" />"
         . "<table border=\"0\"><tr><td>"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_SAVMOD
         . "\" /></form>"
         . "<form action=\"options.php\" method=\"post\">"
         . "<input type=\"hidden\" name=\"id_type\" value=\"$id_type\" />"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingDelType\" />"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_DEL
         . "\" /></form></td></tr></table>";

    echo '</td></tr></table>';
    xoops_cp_footer();
}

#  function listingModTypeS
#####################################################
/**
 * @param $id_type
 * @param $nom_type
 */
function listingModTypeS($id_type, $nom_type)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $id_type  = (int)$id_type;
    $nom_type = $myts->htmlSpecialChars($nom_type);

    $xoopsDB->query('UPDATE ' . $xoopsDB->prefix('adslight_type') . " SET nom_type='$nom_type' WHERE id_type='$id_type'");

    redirect_header('options.php', 1, _AM_ADSLIGHT_TYPEMOD);
}

#  function listingDelType
#####################################################
/**
 * @param $id_type
 */
function listingDelType($id_type)

{
    global $xoopsDB, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $id_type = (int)$id_type;

    $xoopsDB->query('DELETE FROM ' . $xoopsDB->prefix('adslight_type') . " WHERE id_type='$id_type'");

    redirect_header('options.php', 1, _AM_ADSLIGHT_TYPEDEL);
}

#  function listingAddPrice
#####################################################
/**
 * @param $type
 */
function listingAddPrice($type)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT  COUNT(*)  FROM ' . $xoopsDB->prefix('adslight_price') . " WHERE nom_price='$type'"));
    if ($numrows > 0) {
        include_once __DIR__ . '/header.php';
        xoops_cp_header();
        //    loadModuleAdminMenu(2, "");


        echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODANN . '</legend>';
        echo '<br><div style="text-align:center;"><b>' . _AM_ADSLIGHT_ERRORPRICE . " $nom_price " . _AM_ADSLIGHT_EXIST . '</b></div><br><br>';

        echo "<form method=\"post\" action=\"options.php\">
            <b>" . _AM_ADSLIGHT_ADDPRICE . '</b><br><br>
            ' . _AM_ADSLIGHT_TYPE . "   <input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\">
            <input type=\"hidden\" name=\"op\" value=\"ListingAddPrice\">
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\">
            </form>";
        echo '</td></tr></table>';
        xoops_cp_footer();
    } else {
        $type = $myts->htmlSpecialChars($type);
        if ($type == '') {
            $type = '! ! ? ! !';
        }
        $xoopsDB->query('insert into ' . $xoopsDB->prefix('adslight_price') . " values (NULL, '$type')");

        redirect_header('options.php', 1, _AM_ADSLIGHT_ADDPRICE2);
    }
}

#  function listingModPrice
#####################################################
/**
 * @param $id_price
 */
function listingModPrice($id_price)

{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    include_once __DIR__ . '/header.php';
    xoops_cp_header();
    //    loadModuleAdminMenu(2, "");

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODPRICE . '</legend>';
    echo '<b>' . _AM_ADSLIGHT_MODPRICE . '</b><br><br>';
    $id_price = (int)$id_price;
    $result   = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . " WHERE id_price=$id_price");
    list($nom_price) = $xoopsDB->fetchRow($result);

    $nom_price = $myts->htmlSpecialChars($nom_price);

    echo "<form action=\"options.php\" method=\"post\">"
         . ''
         . _AM_ADSLIGHT_TYPE
         . " <input type=\"text\" name=\"nom_price\" value=\"$nom_price\" size=\"51\" maxlength=\"50\"><br>"
         . "<input type=\"hidden\" name=\"id_price\" value=\"$id_price\">"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingModPriceS\">"
         . "<table border=\"0\"><tr><td>"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_SAVMOD
         . "\"></form>"
         . "<form action=\"options.php\" method=\"post\">"
         . "<input type=\"hidden\" name=\"id_price\" value=\"$id_price\">"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingDelPrice\">"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_DEL
         . "\"></form></td></tr></table>";

    echo '</td></tr></table>';
    xoops_cp_footer();
}

#  function listingModPriceS
#####################################################
/**
 * @param $id_price
 * @param $nom_price
 */
function listingModPriceS($id_price, $nom_price)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $id_price  = (int)$id_price;
    $nom_price = $myts->htmlSpecialChars($nom_price);
    $xoopsDB->query('UPDATE ' . $xoopsDB->prefix('adslight_price') . " SET nom_price='{$nom_price}' WHERE id_price='{$id_price}'");
    redirect_header('options.php', 1, _AM_ADSLIGHT_PRICEMOD);
}

#  function listingDelPrice
#####################################################
/**
 * @param $id_price
 */
function listingDelPrice($id_price)

{
    global $xoopsDB, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $xoopsDB->query('DELETE FROM ' . $xoopsDB->prefix('adslight_price') . " WHERE id_price='{$id_price}'");
    redirect_header('options.php', 1, _AM_ADSLIGHT_PRICEDEL);
}

#  function listingAddUsure
#####################################################
/**
 * @param $type
 */
function listingAddUsure($type)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    list($numrows) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_usure') . " WHERE nom_usure='$type'"));
    if ($numrows > 0) {
        include_once __DIR__ . '/header.php';
        xoops_cp_header();
        //    loadModuleAdminMenu(2, "");


        echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODANN . '</legend>';
        echo '<br><div style="text-align:center;"><b>' . _AM_ADSLIGHT_ERRORUSURE . " $nom_usure " . _AM_ADSLIGHT_EXIST . '</b></div><br><br>';

        echo "<form method=\"post\" action=\"options.php\">
            <b>" . _AM_ADSLIGHT_ADDUSURE . '</b><br><br>
            ' . _AM_ADSLIGHT_TYPE . "   <input type=\"text\" name=\"type\" size=\"30\" maxlength=\"100\">
            <input type=\"hidden\" name=\"op\" value=\"ListingAddUsure\">
            <input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\">
            </form>";
        echo '</td></tr></table>';
        xoops_cp_footer();
    } else {
        $type = $myts->htmlSpecialChars($type);
        if ('' == $type) {
            $type = '! ! ? ! !';
        }
        $xoopsDB->query('INSERT INTO ' . $xoopsDB->prefix('adslight_usure') . " VALUES (NULL, '$type')");
        redirect_header('options.php', 1, _AM_ADSLIGHT_ADDUSURE2);
    }
}

#  function listingModUsure
#####################################################
/**
 * @param $id_usure
 */
function listingModUsure($id_usure)

{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    include_once __DIR__ . '/header.php';
    xoops_cp_header();
    //    loadModuleAdminMenu(2, "");

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODUSURE . '</legend>';
    echo '<b>' . _AM_ADSLIGHT_MODUSURE . '</b><br><br>';
    $result9 = $xoopsDB->query('SELECT nom_usure FROM ' . $xoopsDB->prefix('adslight_usure') . " WHERE id_usure=$id_usure");
    list($nom_usure) = $xoopsDB->fetchRow($result9);

    $nom_usure = $myts->htmlSpecialChars($nom_usure);

    echo "<form action=\"options.php\" method=\"post\">"
         . ''
         . _AM_ADSLIGHT_USURE
         . " <input type=\"text\" name=\"nom_usure\" value=\"$nom_usure\" size=\"51\" maxlength=\"50\"><br>"
         . "<input type=\"hidden\" name=\"id_usure\" value=\"$id_usure\">"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingModUsureS\">"
         . "<table border=\"0\"><tr><td>"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_SAVMOD
         . "\"></form>"
         . "<form action=\"options.php\" method=\"post\">"
         . "<input type=\"hidden\" name=\"id_usure\" value=\"$id_usure\">"
         . "<input type=\"hidden\" name=\"op\" value=\"ListingDelUsure\">"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_DEL
         . "\"></form></td></tr></table>";

    echo '</td></tr></table>';
    xoops_cp_footer();
}

#  function listingModUsureS
#####################################################
/**
 * @param $id_usure
 * @param $nom_usure
 */
function listingModUsureS($id_usure, $nom_usure)

{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $nom_usure = $myts->htmlSpecialChars($nom_usure);

    $xoopsDB->query('UPDATE ' . $xoopsDB->prefix('adslight_usure') . " SET nom_usure='$nom_usure' WHERE id_usure='$id_usure'");

    redirect_header('options.php', 1, _AM_ADSLIGHT_USUREMOD);
}

#  function listingDelUsure
#####################################################
/**
 * @param $id_usure
 */
function listingDelUsure($id_usure)

{
    global $xoopsDB, $moduleDirName, $admin_lang;
function myFunction($a, $b) {
    // Do something
}

    $id_usure = (int)$id_usure;
    $xoopsDB->query('DELETE FROM ' . $xoopsDB->prefix('adslight_usure') . " WHERE id_usure='{$id_usure}'");

    redirect_header('options.php', 1, _AM_ADSLIGHT_USUREDEL);
}

#####################################################
#####################################################
//@todo REMOVE THIS ASAP. This code is extremely unsafe
foreach ($_POST as $k => $v) {
    ${$k} = $v;
}

$pa  = XoopsRequest::getString('pa', '', 'GET');
$lid = XoopsRequest::getInt('lid', 0);
$op  = XoopsRequest::getCmd('op', '');

switch ($op) {
    case 'ListingDelPrice':
        listingDelPrice($id_price);
        break;
    case 'ListingModPrice':
        listingModPrice($id_price);
        break;
    case 'ListingModPriceS':
        listingModPriceS($id_price, $nom_price);
        break;
    case 'ListingAddPrice':
        listingAddPrice($type);
        break;
    case 'ListingDelUsure':
        listingDelUsure($id_usure);
        break;
    case 'ListingModUsure':
        listingModUsure($id_usure);
        break;
    case 'ListingModUsureS':
        listingModUsureS($id_usure, $nom_usure);
        break;
    case 'ListingAddUsure':
        listingAddUsure($type);
        break;
    case 'ListingDelType':
        listingDelType($id_type);
        break;
    case 'ListingModType':
        listingModType($id_type);
        break;
    case 'ListingModTypeS':
        listingModTypeS($id_type, $nom_type);
        break;
    case 'ListingAddType':
        listingAddType($type);
        break;
    default:
        index();
        break;
}


Branch — master (71f789)

options.php ➔ listingModUsure() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 28 and the first side effect is on line 22. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			-------------------------------------------------------------------------
4			ADSLIGHT 2 : Module for Xoops
5
6			Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7			Started with the Classifieds module and made MANY changes
8			Website : http://www.luc-bizet.fr
9			Contact : [email protected]
10			-------------------------------------------------------------------------
11			Original credits below Version History
12			##########################################################################
13			# Classified Module for Xoops #
14			# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15			# Started with the MyAds module and made MANY changes #
16			##########################################################################
17			Original Author: Pascal Le Boustouller
18			Author Website : [email protected]
19			Licence Type : GPL
20			-------------------------------------------------------------------------
21			*/
22			include_once __DIR__ . '/admin_header.php';
23
24			$op = XoopsRequest::getCmd('op', 'liste');
25
26			# function Index
27			#####################################################
28			function index()
			0 ignored issues – show Best Practice introduced 2016-09-30 16:24 UTC by Report Bug Copy Issue Report The function `index()` has been defined more than once; this definition is ignored, only the first definition in `admin/main.php` (L29-287) is considered. This check looks for functions that have already been defined in other files. Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the `@ignore` annotation. /** * @ignore */ function getUser() { } function getUser($id, $realm) { } See also the PhpDoc documentation for @ignore. Loading history...
29			{
30			global $xoopsDB, $xoopsConfig, $xoopsModule, $myts, $moduleDirName, $admin_lang;
			1 ignored issue – show Compatibility Best Practice introduced 2016-09-28 07:11 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
31			include_once __DIR__ . '/header.php';
32			xoops_cp_header();
33			// loadModuleAdminMenu(2, "");
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
34			echo $adminObject->addNavigation(basename(__FILE__));
			0 ignored issues – show Bug introduced 2016-09-28 07:11 UTC by Report Bug Copy Issue Report The variable `$adminObject` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
35			// Ajouter un type

mambax7 / adslight

Branch — master (71f789)

options.php ➔ listingModUsure() B

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like