+global\Xoopsjlm_picturesHandler::receivePicture()

Complexity

Conditions	3
Paths	3

Size

Total Lines	48
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function receivePicture($title, $path_upload, $thumbwidth, $thumbheight, $pictwidth, $pictheight, $maxfilebytes, $maxfilewidth, $maxfileheight)

receivePicture uses the super-global variable $_POST which is generally not recommended.

receivePicture uses the super-global variable $_FILES which is generally not recommended.

    {
        global $xoopsUser, $xoopsDB, $_POST, $_FILES, $lid;

Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

        //busca id do user logado
        $uid = $xoopsUser->getVar('uid');

$uid is not used, you could remove the assignment.

        $lid = $_POST['lid'];
        //create a hash so it does not erase another file
        $hash1 = time();
        $hash  = substr($hash1, 0, 4);

$hash is not used, you could remove the assignment.

        // mimetypes and settings put this in admin part later
        $allowed_mimetypes = array('image/jpeg', 'image/gif');
        $maxfilesize       = $maxfilebytes;
        // create the object to upload
        $uploader = new XoopsMediaUploader($path_upload, $allowed_mimetypes, $maxfilesize, $maxfilewidth, $maxfileheight);
        // fetch the media
        if ($uploader->fetchMedia($_POST['xoops_upload_file'][0])) {
            //lets create a name for it
            $uploader->setPrefix('pic_' . $lid . '_');
            //now let s upload the file
            if (!$uploader->upload()) {
                // if there are errors lets return them
                echo "<div style=\"color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center\"><p>" .
                     $uploader->getErrors() .
                     '</p></div>';

                return false;
            } else {
                // now let s create a new object picture and set its variables
                $picture = $this->create();
                $url     = $uploader->getSavedFileName();
                $picture->setVar('url', $url);
                $picture->setVar('title', $title);
                $uid = $xoopsUser->getVar('uid');
                $lid = $lid;

Why assign $lid to itself?

                $picture->setVar('lid', $lid);
                $picture->setVar('uid_owner', $uid);
                $this->insert($picture);
                $saved_destination = $uploader->getSavedDestination();
                $this->resizeImage($saved_destination, $thumbwidth, $thumbheight, $pictwidth, $pictheight, $path_upload);
            }
        } else {
            echo "<div style=\"color:#FF0000; background-color:#FFEAF4; border-color:#FF0000; border-width:thick; border-style:solid; text-align:center\"><p>" . $uploader->getErrors() . '</p></div>';

            return false;
        }

        return true;
    }