GD

Complexity

Total Complexity

24

Size/Duplication

Total Lines	164
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
C	make_color()	0	24	9
B	__construct()	0	24	5
A	resize()	0	20	2
A	add_border()	0	20	2
A	add_text()	0	13	3
A	add_ttf_text()	0	10	2
A	save()	0	5	1

<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : adslight.translate@gmail.com
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : pascal.e-xoops@perso-search.com
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

/**
 * Class GD
 */
class GD

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $image;
    public $width;
    public $height;

    /**
     * @param $location
     */
    public function __construct($location)
    {
        $imageinfo = @getimagesize($location) || exit('Unknown picture');

The method __construct() contains an exit expression.

        $this->width  = $imageinfo['0'];
        $this->height = $imageinfo['1'];

        switch ($imageinfo['2']) {
            case '1':
                $this->image = imagecreatefromgif($location);
                break;

            case '2':
                $this->image = imagecreatefromjpeg($location);
                break;

            case '3':
                $this->image = imagecreatefrompng($location);
                break;

            default:
                exit('Unknown file format');

The method __construct() contains an exit expression.

        }
    }

    /**
     * @param $sizex
     * @param $sizey
     */
    public function resize($sizex, $sizey)
    {
        $org = round($this->width / $this->height, 2);
        $new = round($sizex / $sizey, 2);

        if ($new > $org) {
            $sizex = round($this->width / ($this->height / $sizey), 0);
            $sizey = $sizey;

Why assign $sizey to itself?

        } else {
            $sizex = $sizex;

Why assign $sizex to itself?

            $sizey = round($this->height / ($this->width / $sizex), 0);
        }

        $resized = imagecreatetruecolor($sizex, $sizey);
        imagecopyresampled($resized, $this->image, 0, 0, 0, 0, $sizex, $sizey, $this->width, $this->height);

        $this->image  = $resized;
        $this->width  = $sizex;
        $this->height = $sizey;
    }

    /**
     * @param $color
     *
     * @return array

Should the return type not be null|array?

     */
    public function make_color($color)
    {
        $rgb = array();

        if (is_array($color) && count($color) == '3') {
            $rgb['r'] = $color['0'];
            $rgb['g'] = $color['1'];
            $rgb['b'] = $color['2'];
        } elseif (preg_match('/^#?([a-f0-9]{2})([a-f0-9]{2})([a-f0-9]{2})$/i', $color, $results)) {
            $rgb['r'] = hexdec($results['1']);
            $rgb['g'] = hexdec($results['2']);
            $rgb['b'] = hexdec($results['3']);
        } else {
            exit('Unknown color');

The method make_color() contains an exit expression.

        }

        foreach (array('r', 'g', 'b') as $value) {
            if (!array_key_exists($value, $rgb) || $rgb[$value] < 0 || $rgb[$value] > 255 || !is_numeric($rgb[$value])) {
                exit('Wrong color');

The method make_color() contains an exit expression.

            }
        }

        return $rgb;
    }

    /**
     * @param $width
     * @param $color
     */
    public function add_border($width, $color)
    {
        $rgb      = $this->make_color($color);
        $allocate = imagecolorallocate($this->image, $rgb['r'], $rgb['g'], $rgb['b']);

        if ($width < 1) {
            exit('Wrong frame width');

The method add_border() contains an exit expression.

        }

        $sizex     = $this->width + (2 * $width);
        $sizey     = $this->height + (2 * $width);
        $new_image = imagecreatetruecolor($sizex, $sizey);

        imagefill($new_image, 0, 0, $allocate);
        imagecopyresampled($new_image, $this->image, $width, $width, 0, 0, $this->width, $this->height, $this->width, $this->height);

        $this->image  = $new_image;
        $this->width  = $sizex;
        $this->height = $sizey;
    }

    /**
     * @param $text
     * @param $font
     * @param $color
     * @param $x
     * @param $y
     */
    public function add_text($text, $font, $color, $x, $y)

The parameter $x is not used and could be removed.

The parameter $y is not used and could be removed.

    {
        if ($font < 1 || $font > 5) {
            exit('Wrong font');

The method add_text() contains an exit expression.

        }

        $rgb         = $this->make_color($color);
        $allocate    = imagecolorallocate($this->image, $rgb['r'], $rgb['g'], $rgb['b']);

$allocate is not used, you could remove the assignment.

        $text_width  = imagefontwidth($font) * strlen($text);

$text_width is not used, you could remove the assignment.

        $text_height = imagefontheight($font);

$text_height is not used, you could remove the assignment.

        //Dokoncaj
    }

    /**
     * @param        $text
     * @param        $size
     * @param        $color
     * @param        $x
     * @param        $y
     * @param string $font
     */
    public function add_ttf_text($text, $size, $color, $x, $y, $font = './tahoma.ttf')
    {
        if (!is_file($font)) {
            exit('Unknown font');

The method add_ttf_text() contains an exit expression.

        }

        $rgb      = $this->make_color($color);
        $allocate = imagecolorallocate($this->image, $rgb['r'], $rgb['g'], $rgb['b']);
        imagettftext($this->image, $size, 0, $x, $y, $allocate, $font, $text);
    }

    /**
     * @param        $location
     * @param string $quality
     */
    public function save($location, $quality = '80')
    {
        imagejpeg($this->image, $location, $quality);
        imagedestroy($this->image);
    }
}