mambax7 / adslight

rate-item.php

<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : adslight.translate@gmail.com
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : pascal.e-xoops@perso-search.com
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';
include_once XOOPS_ROOT_PATH."/class/module.errorhandler.php";
$myts =& MyTextSanitizer::getInstance(); // MyTextSanitizer object
include_once XOOPS_ROOT_PATH."/modules/adslight/include/functions.php";
if (!empty($HTTP_POST_VARS['submit'])) {
    $eh = new ErrorHandler; //ErrorHandler object
    if (empty($xoopsUser)) {
        $ratinguser = 0;
    } else {
        $ratinguser = $xoopsUser->getVar('uid');
    }

       //Make sure only 1 anonymous from an IP in a single day.
       $anonwaitdays = 1;
       $ip = getenv("REMOTE_ADDR");
    //$lid = intval($_POST['lid']);

67% of this comment could be valid code. Did you maybe forget this after debugging?

    if (isset($_POST['lid']) ) {
    $lid = intval($_POST['lid']);
} else {
    $lid = 0;
}
    $rating = intval($_POST['rating']);

       // Check if Rating is Null
       if ($rating=="--") {

This code seems to be duplicated across your project.

        redirect_header("rate-item.php?lid=".$lid."",4,constant("_ADSLIGHT_NORATING"));
        exit();
       }

       // Check if Link POSTER is voting (UNLESS Anonymous users allowed to post)
       if ($ratinguser != 0) {
           $result=$xoopsDB->query("select submitter from ".$xoopsDB->prefix("adslight_listing")." where lid=".mysql_real_escape_string($lid)."");
           while (list($ratinguserDB) = $xoopsDB->fetchRow($result)) {
               if ($ratinguserDB == $ratinguser) {
                redirect_header("viewads.php?lid=".$lid."",4,constant("_ADSLIGHT_CANTVOTEOWN"));
                exit();
              }
           }

        // Check if REG user is trying to vote twice.
           $result=$xoopsDB->query("select ratinguser from ".$xoopsDB->prefix("adslight_item_votedata")." where lid=".mysql_real_escape_string($lid)."");
           while (list($ratinguserDB) = $xoopsDB->fetchRow($result)) {
               if ($ratinguserDB == $ratinguser) {
                redirect_header("viewads.php?lid=".$lid."",4,constant("_ADSLIGHT_VOTEONCE2"));
                exit();
               }
          }

       } else {

This code seems to be duplicated across your project.

           // Check if ANONYMOUS user is trying to vote more than once per day.
        $yesterday = (time()-(86400 * $anonwaitdays));
           $result=$xoopsDB->query("select count(*) FROM ".$xoopsDB->prefix("adslight_item_votedata")." WHERE lid=".mysql_real_escape_string($lid)." AND ratinguser=0 AND ratinghostname = '$ip' AND ratingtimestamp > $yesterday");
           list($anonvotecount) = $xoopsDB->fetchRow($result);
           if ($anonvotecount > 0) {
            redirect_header("viewads.php?lid=".$lid."",4,constant("_ADSLIGHT_VOTEONCE2"));
            exit();
           }
       }
    if ($rating > 10) {
        $rating = 10;
    }

    //All is well.  Add to Line Item Rate to DB.
    $newid = $xoopsDB->genId($xoopsDB->prefix("adslight_item_votedata")."_ratingid_seq");
    $datetime = time();
    $sql = sprintf("INSERT INTO %s (ratingid, lid, ratinguser, rating, ratinghostname, ratingtimestamp) VALUES (%u, %u, %u, %u, '%s', %u)", $xoopsDB->prefix("adslight_item_votedata"), $newid, $lid, $ratinguser, $rating, $ip, $datetime);
    $xoopsDB->query($sql) || $eh->show("0013");

    //All is well.  Calculate Score & Add to Summary (for quick retrieval & sorting) to DB.
    updateIrating($lid);
    $ratemessage = constant("_ADSLIGHT_VOTEAPPRE")."<br />".sprintf(constant("_ADSLIGHT_THANKURATEITEM"),$xoopsConfig['sitename']);
    redirect_header("viewads.php?lid=".$lid."",3,$ratemessage);
    exit();

} else {

This code seems to be duplicated across your project.

    $xoopsOption['template_main'] = "adslight_rate_item.tpl";
    include XOOPS_ROOT_PATH."/header.php";
    //$lid = intval($_GET['lid']);

67% of this comment could be valid code. Did you maybe forget this after debugging?

    if (isset($_GET['lid']) ) {
    $lid = intval($_GET['lid']);
} else {
    $lid = 0;
}
    $result=$xoopsDB->query("select lid, title from ".$xoopsDB->prefix("adslight_listing")." where lid=".mysql_real_escape_string($lid)."");
    list($lid, $title) = $xoopsDB->fetchRow($result);
    $xoopsTpl->assign('link', array('lid' => $lid, 'title' => $myts->htmlSpecialChars($title)));
    $xoopsTpl->assign('lang_voteonce', constant("_ADSLIGHT_VOTEONCE"));
    $xoopsTpl->assign('lang_ratingscale', constant("_ADSLIGHT_RATINGSCALE"));
    $xoopsTpl->assign('lang_beobjective', constant("_ADSLIGHT_BEOBJECTIVE"));
    $xoopsTpl->assign('lang_donotvote', constant("_ADSLIGHT_DONOTVOTE"));
    $xoopsTpl->assign('lang_rateit', constant("_ADSLIGHT_RATEIT"));
    $xoopsTpl->assign('lang_cancel', _CANCEL);
    $xoopsTpl->assign('mydirname', $moduleDirName);
    include XOOPS_ROOT_PATH.'/footer.php';
}