Issues in display-image.php - All Issues - Inspection of "XOOPS 2.5.8, PHP7" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0424ea...923121 )

by Michael

created 2016-04-29 08:04 UTC

display-image.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/header.php';

if (isset($_GET['cod_img'])) {
    $cod_img = (int)$_GET['cod_img'];
} else {
    redirect_header('index.php', 1, _ADSLIGHT_VALIDATE_FAILED);
}
xoops_header();

global $xoopsUser, $xoopsConfig, $xoopsTheme, $xoopsDB, $xoops_footer, $xoopsLogger;
function myFunction($a, $b) {
    // Do something
}
$currenttheme = getTheme();

$result      = $xoopsDB->query('select url FROM ' . $xoopsDB->prefix('adslight_picture') . ' WHERE cod_img = ' . $xoopsDB->escape($cod_img) . '');
$recordexist = $xoopsDB->getRowsNum($result);

if ($recordexist) {
    list($url) = $xoopsDB->fetchRow($result);
    echo "<br><br><center><img class=\"thumb\" src=\"photo/$url\" border=0></center>";
}

echo "<table><tr><td><center><a href=#  onClick='window.close()'>" . _ADSLIGHT_CLOSEF . '</a></center></td></tr></table>';

xoops_footer();


Push — master ( 0424ea...923121 )

display-image.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2			/*
3			-------------------------------------------------------------------------
4			ADSLIGHT 2 : Module for Xoops
5
6			Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7			Started with the Classifieds module and made MANY changes
8			Website : http://www.luc-bizet.fr
9			Contact : [email protected]
10			-------------------------------------------------------------------------
11			Original credits below Version History
12			##########################################################################
13			# Classified Module for Xoops #
14			# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15			# Started with the MyAds module and made MANY changes #
16			##########################################################################
17			Original Author: Pascal Le Boustouller
18			Author Website : [email protected]
19			Licence Type : GPL
20			-------------------------------------------------------------------------
21			*/
22
23			include_once __DIR__ . '/header.php';
24
25			if (isset($_GET['cod_img'])) {
26			$cod_img = (int)$_GET['cod_img'];
27			} else {
28			redirect_header('index.php', 1, _ADSLIGHT_VALIDATE_FAILED);
29			}
30			xoops_header();
31
32			global $xoopsUser, $xoopsConfig, $xoopsTheme, $xoopsDB, $xoops_footer, $xoopsLogger;
			1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
33			$currenttheme = getTheme();
34
35			$result = $xoopsDB->query('select url FROM ' . $xoopsDB->prefix('adslight_picture') . ' WHERE cod_img = ' . $xoopsDB->escape($cod_img) . '');
36			$recordexist = $xoopsDB->getRowsNum($result);
37
38			if ($recordexist) {
39			list($url) = $xoopsDB->fetchRow($result);
40			echo "<br><br><center><img class=\"thumb\" src=\"photo/$url\" border=0></center>";
41			}
42
43			echo "<table><tr><td><center><a href=# onClick='window.close()'>" . _ADSLIGHT_CLOSEF . '</a></center></td></tr></table>';
44
45			xoops_footer();
46

mambax7 / adslight

Push — master ( 0424ea...923121 )

display-image.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like