+global\AdslightPicturesHandler::renderFormEdit()

Complexity

Conditions	3
Paths	4

Size

Total Lines	49
Code Lines	25

Duplication

Lines	5
Ratio	10.2 %

Importance

Changes

0

<?php
    public function renderFormEdit($caption, $cod_img, $filename)
    {
        global $moduleDirName, $main_lang;

        $form       = new XoopsThemeForm(_ADSLIGHT_EDIT_CAPTION, 'form_picture', 'editdesc.php', 'post', true);
        $field_desc = new XoopsFormText($caption, 'caption', 35, 55);
        $form->setExtra('enctype="multipart/form-data"');
        $button_send = new XoopsFormButton(_ADSLIGHT_EDIT, 'submit_button', _SUBMIT, 'submit');
        //@todo - replace alt with language string
        $field_warning = new XoopsFormLabel("<img src='{$filename}' alt='sssss'>");
        $field_cod_img = new XoopsFormHidden('cod_img', $cod_img);
        //    $field_lid = new XoopsFormHidden('lid', $lid);

54% of this comment could be valid code. Did you maybe forget this after debugging?

        $field_marker = new XoopsFormHidden('marker', 1);

        /**
         * Check if using Xoops or XoopsCube (by jlm69)
         * Right now Xoops does not have a directory called preload, Xoops Cube does.
         * If this finds a diectory called preload in the Xoops Root folder $xCube=true.
         * This could change if Xoops adds a Directory called preload
         */

        $xCube   = false;

$xCube is not used, you could remove the assignment.

        $preload = XOOPS_ROOT_PATH . '/preload';
        if (is_dir($preload)) {
            $xCube = true;

$xCube is not used, you could remove the assignment.

        }

        /**
         * Verify Ticket (by jlm69)
         * If your site is XoopsCube it uses $xoopsGTicket for the token.
         * If your site is Xoops it uses xoopsSecurity for the token.
         */

        if ($xCube = true) {

$xCube is not used, you could remove the assignment.

            $GLOBALS['xoopsGTicket']->addTicketXoopsFormElement($form, __LINE__, 1800, 'token');
        } else {
            $field_token = $GLOBALS['xoopsSecurity']->getTokenHTML();
        }

        $form->addElement($field_warning);
        $form->addElement($field_desc);
        $form->addElement($field_cod_img);
        $form->addElement($field_marker);
        $form->addElement($field_token);

The variable $field_token does not seem to be defined for all execution paths leading up to this point.

        $form->addElement($button_send);
        $form->display();

        return true;
    }