Completed
Push — master ( 923121...f83415 )
by Michael
02:52
created

viewads.php ➔ viewads()   F

Complexity

Conditions 46
Paths > 20000

Size

Total Lines 458
Code Lines 336

Duplication

Lines 34
Ratio 7.42 %

Importance

Changes 0
Metric Value
cc 46
eloc 336
nc 4294967295
nop 1
dl 34
loc 458
rs 2
c 0
b 0
f 0

How to fix   Long Method    Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
0 ignored issues
show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 59 and the first side effect is on line 23.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2
/*
3
-------------------------------------------------------------------------
4
                     ADSLIGHT 2 : Module for Xoops
5
6
        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7
        Started with the Classifieds module and made MANY changes
8
        Website : http://www.luc-bizet.fr
9
        Contact : [email protected]
10
-------------------------------------------------------------------------
11
             Original credits below Version History
12
##########################################################################
13
#                    Classified Module for Xoops                         #
14
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
15
#      Started with the MyAds module and made MANY changes               #
16
##########################################################################
17
 Original Author: Pascal Le Boustouller
18
 Author Website : [email protected]
19
 Licence Type   : GPL
20
-------------------------------------------------------------------------
21
*/
22
23
include_once __DIR__ . '/header.php';
24
require_once XOOPS_ROOT_PATH . '/modules/adslight/include/gtickets.php';
25
xoops_load('XoopsLocal');
26
$myts      = MyTextSanitizer::getInstance();
27
$module_id = $xoopsModule->getVar('mid');
28
29
if (is_object($xoopsUser)) {
30
    $groups = $xoopsUser->getGroups();
31
} else {
32
    $groups = XOOPS_GROUP_ANONYMOUS;
33
}
34
$gperm_handler = xoops_getHandler('groupperm');
35
if (isset($_POST['item_id'])) {
36
    $perm_itemid = (int)$_POST['item_id'];
37
} else {
38
    $perm_itemid = 0;
39
}
40
//If no access
41 View Code Duplication
if (!$gperm_handler->checkRight('adslight_view', $perm_itemid, $groups, $module_id)) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
42
    redirect_header(XOOPS_URL . '/index.php', 3, _NOPERM);
43
}
44
if (!$gperm_handler->checkRight('adslight_premium', $perm_itemid, $groups, $module_id)) {
45
    $prem_perm = '0';
46
} else {
47
    $prem_perm = '1';
48
}
49
50
include XOOPS_ROOT_PATH . '/modules/adslight/class/classifiedstree.php';
51
include XOOPS_ROOT_PATH . '/modules/adslight/include/functions.php';
52
$mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
53
54
#  function viewads
55
#####################################################
56
/**
57
 * @param int $lid
58
 */
59
function viewads($lid = 0)
1 ignored issue
show
Coding Style introduced by
viewads uses the super-global variable $GLOBALS which is generally not recommended.

Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable:

// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
Loading history...
60
{
61
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $xoopsTpl, $xoopsUser, $myts, $meta, $moduleDirName, $main_lang, $prem_perm, $xoopsModule;
1 ignored issue
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
62
    $pathIcon16 = $xoopsModule->getInfo('icons16');
63
64
    $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';
65
    include XOOPS_ROOT_PATH . '/header.php';
66
    include XOOPS_ROOT_PATH . '/include/comment_view.php';
67
    $lid  = ((int)$lid > 0) ? (int)$lid : 0;
68
    $rate = ($xoopsModuleConfig['adslight_rate_item'] == '1') ? '1' : '0';
69
    $xoopsTpl->assign('rate', $rate);
70
    $xoopsTpl->assign('xmid', $xoopsModule->getVar('mid'));
71
    $xoopsTpl->assign('adslight_logolink', _ADSLIGHT_LOGOLINK);
72
73
    // Hack redirection erreur 404  si lid=null
74 View Code Duplication
    if ($lid == '') {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
75
        header('Status: 301 Moved Permanently', false, 301);
76
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
0 ignored issues
show
Unused Code Comprehensibility introduced by
50% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
77
        //        exit();
78
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
79
    }
80
81
    $xoopsTpl->assign('adslight_active_bookmark', $xoopsModuleConfig['adslight_active_bookmark']);
82
    $xoopsTpl->assign('adslight_style_bookmark', $xoopsModuleConfig['adslight_style_bookmark']);
83
    $xoopsTpl->assign('adslight_active_xpayement', $xoopsModuleConfig['adslight_active_xpayment']);
84
85
    // adslight 2
86
    $xoopsTpl->assign('adslight_active_menu', $xoopsModuleConfig['adslight_active_menu']);
87
    $xoopsTpl->assign('adslight_active_rss', $xoopsModuleConfig['adslight_active_rss']);
88
89
    if ($xoopsUser) {
90
        $member_usid = $xoopsUser->getVar('uid');
91
        if ($usid = $member_usid) {
92
            $xoopsTpl->assign('istheirs', true);
93
94
            if (strlen($xoopsUser->getVar('name'))) {
95
                $xoopsTpl->assign('user_name', $xoopsUser->getVar('name') . ' (' . $xoopsUser->getVar('uname') . ')');
96
            } else {
97
                $xoopsTpl->assign('user_name', $xoopsUser->getVar('uname'));
98
            }
99
100
            $xoopsTpl->assign('user_email', $xoopsUser->getVar('email'));
101
102
            list($show_user) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE usid=$member_usid"));
103
104
            $xoopsTpl->assign('show_user', $show_user);
105
            $xoopsTpl->assign('show_user_link', 'members.php?usid=' . $member_usid . '');
106
        }
107
    }
108
109
    if ($xoopsUser) {
110
        $currentid = $xoopsUser->getVar('uid', 'E');
0 ignored issues
show
Unused Code introduced by
$currentid is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
111
    }
112
113
    $cat_perms  = '';
114
    $categories = adslight_MygetItemIds('adslight_view');
115
    if (is_array($categories) && count($categories) > 0) {
116
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
117
    }
118
119
    $result      = $xoopsDB->query('SELECT l.lid, l.cid, l.title, l.status, l.expire, l.type, l.desctext, l.tel, l.price, l.typeprice, l.typeusure, l.date, l.email, l.submitter, l.usid, l.town, l.country, l.contactby, l.premium, l.valid, l.photo, l.hits, l.item_rating, l.item_votes, l.user_rating, l.user_votes, l.comments, p.cod_img, p.lid, p.uid_owner, p.url FROM '
120
                                   . $xoopsDB->prefix('adslight_listing')
121
                                   . ' l LEFT JOIN '
122
                                   . $xoopsDB->prefix('adslight_pictures')
123
                                   . " p ON l.lid=p.lid  WHERE l.valid='Yes' AND l.lid = "
124
                                   . $xoopsDB->escape($lid)
125
                                   . " and l.status!='1' $cat_perms");
126
    $recordexist = $xoopsDB->getRowsNum($result);
127
128
    // Hack redirection erreur 404  si recordexist=null
129 View Code Duplication
    if ($recordexist == '') {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
130
        header('Status: 301 Moved Permanently', false, 301);
131
        //        header('Location: '.XOOPS_URL.'/modules/adslight/404.php');
0 ignored issues
show
Unused Code Comprehensibility introduced by
50% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
132
        //        exit();
133
        redirect_header(XOOPS_URL . '/modules/adslight/404.php', 1);
134
    }
135
136
    if ($recordexist) {
137
        list($lid, $cid, $title, $status, $expire, $type, $desctext, $tel, $price, $typeprice, $typeusure, $date, $email, $submitter, $usid, $town, $country, $contactby, $premium, $valid, $photo, $hits, $item_rating, $item_votes, $user_rating, $user_votes, $comments, $cod_img, $pic_lid, $uid_owner, $url) = $xoopsDB->fetchRow($result);
0 ignored issues
show
Unused Code introduced by
The assignment to $email is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $valid is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $user_rating is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $user_votes is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $comments is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $cod_img is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
Unused Code introduced by
The assignment to $url is unused. Consider omitting it like so list($first,,$third).

This checks looks for assignemnts to variables using the list(...) function, where not all assigned variables are subsequently used.

Consider the following code example.

<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

Only the variables $a and $c are used. There was no need to assign $b.

Instead, the list call could have been.

list($a,, $c) = returnThreeValues();
Loading history...
138
139
        $newcount  = $xoopsModuleConfig['adslight_countday'];
140
        $startdate = (time() - (86400 * $newcount));
141
        if ($startdate < $date) {
142
            $newitem = '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
143
            $xoopsTpl->assign('new', $newitem);
144
        }
145
146
        $updir = $xoopsModuleConfig['adslight_link_upload'];
0 ignored issues
show
Unused Code introduced by
$updir is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
147
        $xoopsTpl->assign('add_from', _ADSLIGHT_ADDFROM . ' ' . $xoopsConfig['sitename']);
148
        $xoopsTpl->assign('add_from_title', _ADSLIGHT_ADDFROM);
149
        $xoopsTpl->assign('add_from_sitename', $xoopsConfig['sitename']);
150
        $xoopsTpl->assign('ad_exists', $recordexist);
151
        $xoopsTpl->assign('mydirname', $moduleDirName);
152
153
        $count = 0;
0 ignored issues
show
Unused Code introduced by
$count is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
154
        $x     = 0;
155
        $i     = 0;
0 ignored issues
show
Unused Code introduced by
$i is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
156
157
        $result3 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE  cid=' . $xoopsDB->escape($cid) . '');
158
        list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result3);
159
160
        $xoopsTpl->assign('category_title', $ctitle);
161
162
        $module_id = $xoopsModule->getVar('mid');
163
        if (is_object($xoopsUser)) {
164
            $groups = $xoopsUser->getGroups();
165
        } else {
166
            $groups = XOOPS_GROUP_ANONYMOUS;
167
        }
168
        $gperm_handler = xoops_getHandler('groupperm');
169
        $xoopsTpl->assign('purchasable', $gperm_handler->checkRight('adslight_purchase', $cid, $groups, $module_id));
170
171
        $ctitle     = $myts->htmlSpecialChars($ctitle);
172
        $varid[$x]  = $ccid;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$varid was never initialized. Although not strictly required by PHP, it is generally a good practice to add $varid = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
173
        $varnom[$x] = $ctitle;
0 ignored issues
show
Coding Style Comprehensibility introduced by
$varnom was never initialized. Although not strictly required by PHP, it is generally a good practice to add $varnom = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
174
175
        list($nbe) = $xoopsDB->fetchRow($xoopsDB->query('SELECT COUNT(*) FROM ' . $xoopsDB->prefix('adslight_listing') . ' WHERE valid="Yes" AND cid=' . $xoopsDB->escape($cid) . ' AND status!="1"'));
176
177
        if ($pid != 0) {
178
            $x = 1;
179
            while ($pid != 0) {
180
                $result4 = $xoopsDB->query('SELECT cid, pid, title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($pid) . '');
181
                list($ccid, $pid, $ctitle) = $xoopsDB->fetchRow($result4);
182
183
                $ctitle     = $myts->htmlSpecialChars($ctitle);
184
                $varid[$x]  = $ccid;
185
                $varnom[$x] = $ctitle;
186
                ++$x;
187
            }
188
            --$x;
189
        }
190
        $subcats = '';
191
        $arrow   = '&nbsp;<img src="' . XOOPS_URL . '/modules/adslight/assets/images/arrow.gif" alt="&raquo;" />';
192
        while ($x != -1) {
193
            $subcats .= ' ' . $arrow . ' <a href="viewcats.php?cid=' . $varid[$x] . '">' . $varnom[$x] . '</a>';
194
            --$x;
195
        }
196
        $xoopsTpl->assign('nav_main', '<a href="index.php">' . _ADSLIGHT_MAIN . '</a>');
197
        $xoopsTpl->assign('nav_sub', $subcats);
198
        $xoopsTpl->assign('nav_subcount', $nbe);
199
        $viewcount_judge = true;
200
        $useroffset      = '';
201
        if ($xoopsUser) {
202
            $timezone = $xoopsUser->timezone();
203
            if (isset($timezone)) {
204
                $useroffset = $xoopsUser->timezone();
205
            } else {
206
                $useroffset = $xoopsConfig['default_TZ'];
207
            }
208
            if ($xoopsUser->isAdmin()) {
209
                $adslight_admin = true;
0 ignored issues
show
Unused Code introduced by
$adslight_admin is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
210
            } else {
211
                $adslight_admin = false;
0 ignored issues
show
Unused Code introduced by
$adslight_admin is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
212
            }
213
214
            if (($adslight_admin = true) || ($xoopsUser->getVar('uid') == $usid)) {
215
                $viewcount_judge = false;
216
            }
217
218
            $contact_pm = '<a href="' . XOOPS_URL . '/pmlite.php?send2=1&amp;to_userid=' . addslashes($usid) . '">&nbsp;' . _ADSLIGHT_CONTACT_BY_PM . '</a>';
219
        }
220
        if ($viewcount_judge == true) {
0 ignored issues
show
Coding Style Best Practice introduced by
It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

When comparing two booleans, it is generally considered safer to use the strict comparison operator.

Loading history...
221
            $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_listing') . ' SET hits=hits+1 WHERE lid = ' . $xoopsDB->escape($lid) . '');
222
        }
223
        if ($item_votes == 1) {
224
            $votestring = _ADSLIGHT_ONEVOTE;
225
        } else {
226
            $votestring = sprintf(_ADSLIGHT_NUMVOTES, $item_votes);
227
        }
228
        $date     = ($useroffset * 3600) + $date;
229
        $date2    = $date + ($expire * 86400);
230
        $date     = formatTimestamp($date, 's');
231
        $date2    = formatTimestamp($date2, 's');
232
        $title    = $myts->htmlSpecialChars($title);
233
        $status   = $myts->htmlSpecialChars($status);
234
        $expire   = $myts->htmlSpecialChars($expire);
0 ignored issues
show
Unused Code introduced by
$expire is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
235
        $type     = $myts->htmlSpecialChars($type);
236
        $desctext = $myts->displayTarea($desctext, 1, 1, 1);
237
        $tel      = $myts->htmlSpecialChars($tel);
238
        //      $price = XoopsLocal::number_format($price, 2, ',', ' ');
0 ignored issues
show
Unused Code Comprehensibility introduced by
58% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
239
        $typeprice = $myts->htmlSpecialChars($typeprice);
240
        $typeusure = $myts->htmlSpecialChars($typeusure);
241
        $submitter = $myts->htmlSpecialChars($submitter);
242
        $usid      = $myts->htmlSpecialChars($usid);
243
        $town      = $myts->htmlSpecialChars($town);
244
        $country   = $myts->htmlSpecialChars($country);
245
        $contactby = $myts->htmlSpecialChars($contactby);
246
        $premium   = $myts->htmlSpecialChars($premium);
247
248
        if ($status == 2) {
249
            $sold = _ADSLIGHT_RESERVED;
250
        } else {
251
            $sold = '';
252
        }
253
254
        $xoopsTpl->assign('printA', '<a href="print.php?op=PrintAd&amp;lid=' . $lid . '" ><img src="assets/images/print.gif" border=0 alt="' . _ADSLIGHT_PRINT . '" /></a>&nbsp;');
255
256
        if ($usid > 0) {
257
            $xoopsTpl->assign('submitter', '<img src="assets/images/lesannonces.png" border="0" alt="'
258
                                           . _ADSLIGHT_VIEW_MY_ADS
259
                                           . '" />&nbsp;&nbsp;<a href="members.php?usid='
260
                                           . addslashes($usid)
261
                                           . '" />'
262
                                           . _ADSLIGHT_VIEW_MY_ADS
263
                                           . ' '
264
                                           . $submitter
265
                                           . '</a>');
266
        } else {
267
            $xoopsTpl->assign('submitter', _ADSLIGHT_VIEW_MY_ADS . ' $submitter');
268
        }
269
        $xoopsTpl->assign('lid', $lid);
270
        $xoopsTpl->assign('read', "$hits " . _ADSLIGHT_VIEW2);
271
        $xoopsTpl->assign('rating', XoopsLocal::number_format($item_rating, 2));
272
        $xoopsTpl->assign('votes', $votestring);
273
        $xoopsTpl->assign('lang_rating', _ADSLIGHT_RATINGC);
274
        $xoopsTpl->assign('lang_ratethisitem', _ADSLIGHT_RATETHISITEM);
275
        $xoopsTpl->assign('xoop_user', false);
276
        $isOwner = '';
0 ignored issues
show
Unused Code introduced by
$isOwner is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
277
        if ($xoopsUser) {
278
            $xoopsTpl->assign('xoop_user', true);
279
            $currentid = $xoopsUser->getVar('uid', 'E');
280
            if ($usid == $currentid) {
281
                $xoopsTpl->assign('modifyads', '<img src='
282
                                               . $pathIcon16
283
                                               . '/edit.png border="0" alt="'
284
                                               . _ADSLIGHT_MODIFANN
285
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ModAd&amp;lid='
286
                                               . $lid
287
                                               . '">'
288
                                               . _ADSLIGHT_MODIFANN
289
                                               . '</a>');
290
                $xoopsTpl->assign('deleteads', '<img src='
291
                                               . $pathIcon16
292
                                               . '/delete.png  border="0" alt="'
293
                                               . _ADSLIGHT_SUPPRANN
294
                                               . '" />&nbsp;&nbsp;<a href="modify.php?op=ListingDel&amp;lid='
295
                                               . $lid
296
                                               . '">'
297
                                               . _ADSLIGHT_SUPPRANN
298
                                               . '</a>');
299
                $xoopsTpl->assign('add_photos', '<img src="assets/images/shape_square_add.png" border="0" alt="'
300
                                                . _ADSLIGHT_SUPPRANN
301
                                                . '" />&nbsp;&nbsp;<a href="view_photos.php?lid='
302
                                                . $lid
303
                                                . '&uid='
304
                                                . $usid
305
                                                . '">'
306
                                                . _ADSLIGHT_ADD_PHOTOS
307
                                                . '</a>');
308
309
                $isOwner = true;
310
                $xoopsTpl->assign('isOwner', $isOwner);
311
            }
312 View Code Duplication
            if ($xoopsUser->isAdmin()) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
313
                $xoopsTpl->assign('admin', '<a href="'
314
                                           . XOOPS_URL
315
                                           . '/modules/adslight/admin/modify_ads.php?op=ModifyAds&amp;lid='
316
                                           . $lid
317
                                           . '"><img src='
318
                                           . $pathIcon16
319
                                           . '/edit.png  border=0 alt="'
320
                                           . _ADSLIGHT_MODADMIN
321
                                           . '" /></a>');
322
            }
323
        }
324
325
        $result7 = $xoopsDB->query('SELECT nom_type FROM ' . $xoopsDB->prefix('adslight_type') . ' WHERE id_type=' . $xoopsDB->escape($type) . '');
326
        list($nom_type) = $xoopsDB->fetchRow($result7);
327
328
        $result8 = $xoopsDB->query('SELECT nom_price FROM ' . $xoopsDB->prefix('adslight_price') . ' WHERE id_price=' . $xoopsDB->escape($typeprice) . '');
329
        list($nom_price) = $xoopsDB->fetchRow($result8);
330
331
        $result9 = $xoopsDB->query('SELECT nom_usure FROM ' . $xoopsDB->prefix('adslight_usure') . ' WHERE id_usure=' . $xoopsDB->escape($typeusure) . '');
332
        list($nom_usure) = $xoopsDB->fetchRow($result9);
333
334
        $xoopsTpl->assign('type', $myts->htmlSpecialChars($nom_type));
335
        $xoopsTpl->assign('title', $title);
336
        $xoopsTpl->assign('status', $status);
337
        $xoopsTpl->assign('desctext', $desctext);
338
        $xoopsTpl->assign('xoops_pagetitle', $title . ' - ' . $town . ': ' . $country . ' - ' . $ctitle);
339
340
        // meta description tags for ads
341
        $desctextclean = strip_tags($desctext, '<font><img><strong><i><u>');
342
        $xoTheme->addMeta('meta', 'description', "$title - " . substr($desctextclean, 0, 150));
0 ignored issues
show
Bug introduced by
The variable $xoTheme does not exist. Did you forget to declare it?

This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug.

Loading history...
343
344
        if ($price > 0) {
345
            $xoopsTpl->assign('price', '<strong>' . _ADSLIGHT_PRICE2 . '</strong>' . $price . ' ' . $xoopsModuleConfig['adslight_money'] . ' - ' . $typeprice);
346
            $xoopsTpl->assign('price_head', _ADSLIGHT_PRICE2);
347
            //      $xoopsTpl->assign('price_price', $price.' '.$xoopsModuleConfig['adslight_money'].' ');
0 ignored issues
show
Unused Code Comprehensibility introduced by
70% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
348
349
            $xoopsTpl->assign('price_price', XoopsLocal::money_format('%.2n', $price));
350
351
            $xoopsTpl->assign('price_typeprice', $myts->htmlSpecialChars($nom_price));
352
            $xoopsTpl->assign('price_currency', $xoopsModuleConfig['adslight_currency']);
353
            $xoopsTpl->assign('price_amount', $price);
354
        }
355
356
        $xoopsTpl->assign('usure_typeusure', $nom_usure);
357
        $xoopsTpl->assign('premium', $premium);
358
359
        // $xoopsTpl->assign('mustlogin', _ADSLIGHT_MUSTLOGIN);
0 ignored issues
show
Unused Code Comprehensibility introduced by
64% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
360
        $xoopsTpl->assign('redirect', '' . '?xoops_redirect=/modules/adslight/index.php');
361
362
        if ($town) {
363
            $xoopsTpl->assign('local_town', $town);
364
        }
365
        if ($xoopsModuleConfig['adslight_use_country'] == 1) {
366
            if ($country) {
367
                $xoopsTpl->assign('local_country', $country);
368
                $xoopsTpl->assign('country_head', '<img src="assets/images/world_go.png" border="0" alt="country" />&nbsp;&nbsp;' . _ADSLIGHT_COUNTRY);
369
            }
370
        }
371
372
        $tphon = '';
373
        if ($tel) {
374
            $tphon = '<br>' . _ADSLIGHT_ORBY . '&nbsp;<strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
375
        }
376
377
        if ($contactby == 1) {
378
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '';
379
        }
380
        if ($contactby == 2) {
381
            $contact = $contact_pm . '' . $tphon;
0 ignored issues
show
Bug introduced by
The variable $contact_pm does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
382
        }
383
        if ($contactby == 3) {
384
            $contact = '<a rel="nofollow" href="contact.php?lid=' . $lid . '">' . _ADSLIGHT_BYMAIL2 . '</a>' . $tphon . '<br>' . _ADSLIGHT_ORBY . '' . $contact_pm;
385
        }
386
        if ($contactby == 4) {
387
            $contact = '<br><strong>' . _ADSLIGHT_TEL . '</strong> ' . $tel;
388
        }
389
        // $xoopsTpl->assign('contact', $contact);
0 ignored issues
show
Unused Code Comprehensibility introduced by
73% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
390
        $xoopsTpl->assign('local_head', '<img src="assets/images/house.png" border="0" alt="local_head" />&nbsp;&nbsp;' . _ADSLIGHT_LOCAL);
391
392
        if ($lid) {
393
            if ($sold) {
394
                $xoopsTpl->assign('bullinfotext', $sold);
395
            } else {
396
                if ($xoopsUser) {
397
                    $xoopsTpl->assign('bullinfotext', _ADSLIGHT_CONTACT_SUBMITTER . ' ' . $submitter . ' ' . _ADSLIGHT_CONTACTBY2 . ' ' . $contact);
0 ignored issues
show
Bug introduced by
The variable $contact does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
398
                } else {
399
                    $xoopsTpl->assign('bullinfotext', '<font color="#de090e"><b>' . _ADSLIGHT_MUSTLOGIN . '</b></font>');
400
                }
401
            }
402
        }
403
404
        $user_profile = XoopsUser::getUnameFromId($usid);
405
        $xoopsTpl->assign('user_profile', '<img src="assets/images/profil.png" border="0" alt="'
406
                                          . _ADSLIGHT_PROFILE
407
                                          . '" />&nbsp;&nbsp;<a rel="nofollow" href="'
408
                                          . XOOPS_URL
409
                                          . '/user.php?usid='
410
                                          . addslashes($usid)
411
                                          . '">'
412
                                          . _ADSLIGHT_PROFILE
413
                                          . ' '
414
                                          . $user_profile
415
                                          . '</a>');
416
417
        if ($photo != '') {
418
            include_once __DIR__ . '/class/pictures.php';
419
420
            $criteria_lid          = new criteria('lid', $lid);
421
            $criteria_uid          = new criteria('uid', $usid);
422
            $album_factory         = new Xoopsjlm_picturesHandler($xoopsDB);
423
            $pictures_object_array = $album_factory->getObjects($criteria_lid, $criteria_uid);
424
            $pictures_number       = $album_factory->getCount($criteria_lid, $criteria_uid);
425 View Code Duplication
            if ($pictures_number == 0) {
1 ignored issue
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
426
                $nopicturesyet = _ADSLIGHT_NOTHINGYET;
427
                $xoopsTpl->assign('lang_nopicyet', $nopicturesyet);
428
            } else {
429
430
                /**
431
                 * Lets populate an array with the data from the pictures
432
                 */
433
                $i = 0;
434
                foreach ($pictures_object_array as $picture) {
435
                    $pictures_array[$i]['url']     = $picture->getVar('url', 's');
0 ignored issues
show
Coding Style Comprehensibility introduced by
$pictures_array was never initialized. Although not strictly required by PHP, it is generally a good practice to add $pictures_array = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
436
                    $pictures_array[$i]['desc']    = $picture->getVar('title', 's');
0 ignored issues
show
Bug introduced by
The variable $pictures_array does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
437
                    $pictures_array[$i]['cod_img'] = $picture->getVar('cod_img', 's');
438
                    $pictures_array[$i]['lid']     = $picture->getVar('lid', 's');
439
                    $xoopsTpl->assign('pics_array', $pictures_array);
440
441
                    ++$i;
442
                }
443
            }
444
            $owner      = new XoopsUser();
445
            $identifier = $owner->getUnameFromId($usid);
0 ignored issues
show
Unused Code introduced by
$identifier is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
446
            if ($xoopsModuleConfig['adslight_lightbox'] == 1) {
447
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/style/adslight.css" type="text/css" media="all" />
448
<script type="text/javascript" src="assets/lightbox/js/jquery-1.7.2.min.js"></script>
449
<script type="text/javascript" src="assets/lightbox/js/jquery-ui-1.8.18.custom.min"></script>
450
<script type="text/javascript" src="assets/lightbox/js/jquery.smooth-scroll.min.js"></script>
451
<script type="text/javascript" src="assets/lightbox/js/lightbox.js"></script>
452
<link rel="stylesheet" href="style/galery.css" type="text/css" media="screen" />
453
<link rel="stylesheet" type="text/css" media="screen" href="assets/lightbox/css/lightbox.css"></link>';
454
            } else {
455
                $header_lightbox = '<link rel="stylesheet" href="' . XOOPS_URL . '/modules/adslight/style/adslight.css" type="text/css" media="all" />
456
<link rel="stylesheet" href="style/galery.css" type="text/css" media="screen" />';
457
            }
458
459
            $xoopsTpl->assign('path_uploads', $xoopsModuleConfig['adslight_link_upload']);
460
461
            $xoopsTpl->assign('permit', $prem_perm);
462
463
            if ($xoopsModuleConfig['active_rewriteurl'] > 0) {
464
                /*  ici le meta Canonicale pour le Rewrite */
465
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
466
            } else {
467
                $xoopsTpl->assign('xoops_module_header', $header_lightbox);
468
            }
469
            $xoopsTpl->assign('photo', $photo);
470
            $xoopsTpl->assign('pic_lid', $pic_lid);
471
            $xoopsTpl->assign('pic_owner', $uid_owner);
472
        } else {
473
            $xoopsTpl->assign('photo', '');
474
        }
475
        $xoopsTpl->assign('date', '<img alt="date" border="0" src="assets/images/date.png" />&nbsp;&nbsp;<strong>'
476
                                  . _ADSLIGHT_DATE2
477
                                  . ':</strong> '
478
                                  . $date
479
                                  . '<br><img alt="date_error" border="0" src="assets/images/date_error.png" />&nbsp;&nbsp;<strong>'
480
                                  . _ADSLIGHT_DISPO
481
                                  . ':</strong> '
482
                                  . $date2
483
                                  . '');
484
    } else {
485
        $xoopsTpl->assign('no_ad', _ADSLIGHT_NOCLAS);
486
    }
487
    $result8 = $xoopsDB->query('SELECT title FROM ' . $xoopsDB->prefix('adslight_categories') . ' WHERE cid=' . $xoopsDB->escape($cid) . '');
0 ignored issues
show
Bug introduced by
The variable $cid does not seem to be defined for all execution paths leading up to this point.

If you define a variable conditionally, it can happen that it is not defined for all execution paths.

Let’s take a look at an example:

function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

In the above example, the variable $x is defined if you pass “foo” or “bar” as argument for $a. However, since the switch statement has no default case statement, if you pass any other value, the variable $x would be undefined.

Available Fixes

  1. Check for existence of the variable explicitly:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        if (isset($x)) { // Make sure it's always set.
            echo $x;
        }
    }
    
  2. Define a default value for the variable:

    function myFunction($a) {
        $x = ''; // Set a default which gets overridden for certain paths.
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
        }
    
        echo $x;
    }
    
  3. Add a value for the missing path:

    function myFunction($a) {
        switch ($a) {
            case 'foo':
                $x = 1;
                break;
    
            case 'bar':
                $x = 2;
                break;
    
            // We add support for the missing case.
            default:
                $x = '';
                break;
        }
    
        echo $x;
    }
    
Loading history...
488
489
    list($ctitle) = $xoopsDB->fetchRow($result8);
490
    $xoopsTpl->assign('friend', '<img src="assets/images/friend.gif" border="0" alt="'
491
                                . _ADSLIGHT_SENDFRIENDS
492
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="sendfriend.php?op=SendFriend&amp;lid='
493
                                . $lid
494
                                . '">'
495
                                . _ADSLIGHT_SENDFRIENDS
496
                                . '</a>');
497
498
    $xoopsTpl->assign('alerteabus', '<img src="assets/images/error.png" border="0" alt="'
499
                                    . _ADSLIGHT_ALERTEABUS
500
                                    . '" />&nbsp;&nbsp;<a rel="nofollow" href="report-abuse.php?op=ReportAbuse&amp;lid='
501
                                    . $lid
502
                                    . '">'
503
                                    . _ADSLIGHT_ALERTEABUS
504
                                    . '</a>');
505
506
    $xoopsTpl->assign('link_main', '<a href="../adslight/">' . _ADSLIGHT_MAIN . '</a>');
507
    $xoopsTpl->assign('link_cat', '<a href="viewcats.php?cid=' . addslashes($cid) . '">' . _ADSLIGHT_GORUB . ' ' . $ctitle . '</a>');
508
509
    $xoopsTpl->assign('printA', '<img src="assets/images/print.gif" border="0" alt="'
510
                                . _ADSLIGHT_PRINT
511
                                . '" />&nbsp;&nbsp;<a rel="nofollow" href="print.php?op=PrintAd&amp;lid='
512
                                . $lid
513
                                . '">'
514
                                . _ADSLIGHT_PRINT
515
                                . '</a>');
516
}
517
518
#  function categorynewgraphic
519
#####################################################
520
/**
521
 * @param $cid
522
 *
523
 * @return string
0 ignored issues
show
Documentation introduced by
Should the return type not be null?

This check compares the return type specified in the @return annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch.

Loading history...
524
 */
525
function categorynewgraphic($cid)
0 ignored issues
show
Best Practice introduced by
The function categorynewgraphic() has been defined more than once; this definition is ignored, only the first definition in index.php (L375-378) is considered.

This check looks for functions that have already been defined in other files.

Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the @ignore annotation.

/**
 * @ignore
 */
function getUser() {

}

function getUser($id, $realm) {

}

See also the PhpDoc documentation for @ignore.

Loading history...
526
{
527
    global $xoopsDB, $xoopsModuleConfig;
1 ignored issue
show
Compatibility Best Practice introduced by
Use of global functionality is not recommended; it makes your code harder to test, and less reusable.

Instead of relying on global state, we recommend one of these alternatives:

1. Pass all data via parameters

function myFunction($a, $b) {
    // Do something
}

2. Create a class that maintains your state

class MyClass {
    private $a;
    private $b;

    public function __construct($a, $b) {
        $this->a = $a;
        $this->b = $b;
    }

    public function myFunction() {
        // Do something
    }
}
Loading history...
528
529
    $cat_perms  = '';
530
    $categories = adslight_MygetItemIds('adslight_view');
531
    if (is_array($categories) && count($categories) > 0) {
532
        $cat_perms .= ' AND cid IN (' . implode(',', $categories) . ') ';
533
    }
534
535
    $newresult = $xoopsDB->query('SELECT date FROM '
536
                                 . $xoopsDB->prefix('adslight_listing')
537
                                 . ' WHERE cid='
538
                                 . $xoopsDB->escape($cid)
539
                                 . ' AND valid = "Yes" '
540
                                 . $cat_perms
541
                                 . ' ORDER BY date desc limit 1');
542
    list($date) = $xoopsDB->fetchRow($newresult);
543
544
    $newcount  = $xoopsModuleConfig['adslight_countday'];
545
    $startdate = (time() - (86400 * $newcount));
546
    if ($startdate < $date) {
547
        return '<img src="' . XOOPS_URL . '/modules/adslight/assets/images/newred.gif" alt="new" />';
548
    }
549
}
550
551
######################################################
552
553
$pa      = !isset($_GET['pa']) ? null : $_GET['pa'];
554
$lid     = !isset($_GET['lid']) ? null : $_GET['lid'];
555
$cid     = !isset($_GET['cid']) ? null : $_GET['cid'];
556
$usid    = isset($_GET['usid']) ? $_GET['usid'] : '';
557
$min     = !isset($_GET['min']) ? null : $_GET['min'];
558
$show    = !isset($_GET['show']) ? null : $_GET['show'];
559
$orderby = !isset($_GET['orderby']) ? null : $_GET['orderby'];
560
561
switch ($pa) {
562
563
    default:
564
        $GLOBALS['xoopsOption']['template_main'] = 'adslight_item.tpl';
565
566
        viewads($lid);
567
        break;
568
}
569
include XOOPS_ROOT_PATH . '/footer.php';
570