category.php ➔ AdsModCat() - Code Metrics - Inspection of "2.2 Beta 3" - mambax7/adslight - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 923121...f83415 )

by Michael

created 2016-09-28 07:08 UTC

category.php ➔ AdsModCat() F

↳ Parent: Project

Complexity

Conditions	15
Paths	2560

Size

Total Lines	122
Code Lines	88

Duplication

Lines	22
Ratio	18.03 %

Importance

Changes

Metric	Value
cc	15
eloc	88
nc	2560
nop	1
dl	22
loc	122
rs	2
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

/*
-------------------------------------------------------------------------
                     ADSLIGHT 2 : Module for Xoops

        Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
        Started with the Classifieds module and made MANY changes
        Website : http://www.luc-bizet.fr
        Contact : [email protected]
-------------------------------------------------------------------------
             Original credits below Version History
##########################################################################
#                    Classified Module for Xoops                         #
#  By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com         #
#      Started with the MyAds module and made MANY changes               #
##########################################################################
 Original Author: Pascal Le Boustouller
 Author Website : [email protected]
 Licence Type   : GPL
-------------------------------------------------------------------------
*/

include_once __DIR__ . '/admin_header.php';
xoops_cp_header();

$op = XoopsRequest::getCmd('op', 'liste');

#  function AdsNewCat
#####################################################
/**
 * @param $cat
 */
function AdsNewCat($cat)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $myts, $moduleDirName;
function myFunction($a, $b) {
    // Do something
}

    $mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

    include_once __DIR__ . '/header.php';

    //    loadModuleAdminMenu(1, "");

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_ADDSUBCAT . '</legend>';
    ShowImg();

    echo "<form method=\"post\" action=\"category.php\" name=\"imcat\"><input type=\"hidden\" name=\"op\" value=\"AdsAddCat\"></font><br><br>
        <table class=\"outer\" border=0>
    <tr>
      <td class=\"even\">" . _AM_ADSLIGHT_CATNAME . " </td><td class=\"odd\" colspan=2><input type=\"text\" name=\"title\" size=\"50\" maxlength=\"100\">&nbsp; " . _AM_ADSLIGHT_IN . ' &nbsp;';

    $cid = XoopsRequest::getInt('cid', 0, 'GET');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    $result = $xoopsDB->query('SELECT cid, pid, title, cat_desc, cat_keywords, img, ordre, affprice, cat_moderate, moderate_subcat FROM '
                              . $xoopsDB->prefix('adslight_categories')
                              . " WHERE cid=$cat");
    list($cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $ordre, $affprice, $cat_moderate, $moderate_subcat) = $xoopsDB->fetchRow($result);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
    $mytree->makeMySelBox('title', 'title', $cat, 1);
    echo '</td>
    </tr>';
    $cat_desc     = '';
    $cat_keywords = '';

    if ('1' == $xoopsModuleConfig['adslight_cat_desc']) {

        echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_CAT_META_DESCRIPTION . " </td><td class=\"odd\" colspan=2>";
        echo "<input type=\"text\" name=\"cat_desc\" value=\"$cat_desc\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';

        echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_CAT_META_KEYWORDS . " </td><td class=\"odd\" colspan=2>";
        echo "<input type=\"text\" name=\"cat_keywords\" value=\"$cat_keywords\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';
    }

    echo "<tr>
      <td class=\"even\">" . _AM_ADSLIGHT_IMGCAT . "  </td><td class=\"odd\" colspan=2><select name=\"img\" onChange=\"showimage()\">";

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    }
    asort($filelist);
    while (list($key, $file) = each($filelist)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ($file === '.' || $file === '..') {
                $a = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        } else {
            if ($file === 'default.png') {
                echo "<option value=$file selected>$file</option>";
            } else {
                echo "<option value=$file>$file</option>";
            }
        }
    }
    echo "</select>&nbsp;&nbsp;<img src=\""
         . XOOPS_URL
         . "/modules/adslight/assets/images/img_cat/default.png\" name=\"avatar\" align=\"absmiddle\"><br><b>"
         . _AM_ADSLIGHT_REPIMGCAT
         . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';

    echo "<tr><td class=\"even\">"
         . _AM_ADSLIGHT_DISPLPRICE2
         . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"affprice\" value=\"1\" checked>"
         . _AM_ADSLIGHT_OUI
         . "&nbsp;&nbsp; <input type=\"radio\" name=\"affprice\" value=\"0\">"
         . _AM_ADSLIGHT_NON
         . ' ('
         . _AM_ADSLIGHT_INTHISCAT
         . ')</td></tr>';

    echo "<tr><td class=\"even\">"
         . _AM_ADSLIGHT_MODERATE_CAT
         . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"cat_moderate\" value=\"1\"checked>"
         . _AM_ADSLIGHT_OUI
         . "&nbsp;&nbsp; <input type=\"radio\" name=\"cat_moderate\" value=\"0\">"
         . _AM_ADSLIGHT_NON
         . '</td></tr>';

    echo "<tr><td class=\"even\">"
         . _AM_ADSLIGHT_MODERATE_SUBCATS
         . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"moderate_subcat\" value=\"1\"checked>"
         . _AM_ADSLIGHT_OUI
         . "&nbsp;&nbsp; <input type=\"radio\" name=\"moderate_subcat\" value=\"0\">"
         . _AM_ADSLIGHT_NON
         . '</td></tr>';

    if ($xoopsModuleConfig['adslight_csortorder'] !== 'title') {
        echo '<tr><td>'
             . _AM_ADSLIGHT_ORDRE
             . " </td><td><input type=\"text\" name=\"ordre\" size=\"4\" value=\"0\" /></td><td class=\"foot\"><input type=\"submit\" value=\""
             . _AM_ADSLIGHT_ADD
             . "\" /></td></tr>";
    } else {
        $ordre = (int)$ordre;
        echo "<input type=\"hidden\" name=\"ordre\" value=\"$ordre\">";
        echo "<tr><td class=\"foot\" colspan=3><input type=\"submit\" value=\"" . _AM_ADSLIGHT_ADD . "\" /></td></tr>";
    }

    echo '</table>
        </form>';
    echo '<br>';

    echo '</fieldset><br>';
    xoops_cp_footer();
}

#  function AdsModCat
#####################################################
/**
 * @param $cid
 */
function AdsModCat($cid)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $myts, $moduleDirName;
function myFunction($a, $b) {
    // Do something
}

    $mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');

    include_once __DIR__ . '/header.php';

    //    loadModuleAdminMenu(1, "");

    echo "<fieldset><legend style='font-weight: bold; color: #900;'>" . _AM_ADSLIGHT_MODIFCAT . '</legend>';
    ShowImg();

    $result = $xoopsDB->query('SELECT cid, pid, title, cat_desc, cat_keywords, img, ordre, affprice, cat_moderate, moderate_subcat FROM '
                              . $xoopsDB->prefix('adslight_categories')
                              . " WHERE cid=$cid");
    list($cat_id, $pid, $title, $cat_desc, $cat_keywords, $imgs, $ordre, $affprice, $cat_moderate, $moderate_subcat) = $xoopsDB->fetchRow($result);
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;

    $title    = $myts->htmlSpecialChars($title);
    $cat_desc = $myts->addSlashes($cat_desc);
    echo "<form action=\"category.php\" method=\"post\" name=\"imcat\">
        <table class=\"outer\" border=\"0\"><tr>
    <td class=\"even\">"
         . _AM_ADSLIGHT_CATNAME
         . "   </td><td class=\"odd\"><input type=\"text\" name=\"title\" value=\"$title\" size=\"50\" maxlength=\"100\" />&nbsp; "
         . _AM_ADSLIGHT_IN
         . ' &nbsp;';
    $mytree->makeMySelBox('title', 'title', $pid, 1);
    echo '</td></tr>';

    if ($xoopsModuleConfig['adslight_cat_desc'] = '1') {

        echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_CAT_META_DESCRIPTION . " </td><td class=\"odd\" colspan=2>";
        echo "<input type=\"text\" name=\"cat_desc\" value=\"$cat_desc\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';

        echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_CAT_META_KEYWORDS . " </td><td class=\"odd\" colspan=2>";
        echo "<input type=\"text\" name=\"cat_keywords\" value=\"$cat_keywords\" size=\"80\" maxlength=\"200\">";
        echo '</td></tr>';
    }

    echo "<tr>
    <td class=\"even\">" . _AM_ADSLIGHT_IMGCAT . "  </td><td class=\"odd\"><select name=\"img\" onChange=\"showimage()\">";

    $rep    = XOOPS_ROOT_PATH . '/modules/adslight/assets/images/img_cat';
    $handle = opendir($rep);
    while ($file = readdir($handle)) {
        $filelist[] = $file;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
    }
    asort($filelist);
    while (list($key, $file) = each($filelist)) {
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
        if (!preg_match('`gif$|jpg$|png$`i', $file)) {
            if ($file === '.' || $file === '..') {
                $a = 1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            }
        } else {
            if ($file == $imgs) {
                echo "<option value=$file selected>$file</option>";
            } else {
                echo "<option value=$file>$file</option>";
            }
        }
    }
    echo "</select>&nbsp;&nbsp;<img src=\""
         . XOOPS_URL
         . "/modules/adslight/assets/images/img_cat/$imgs\" name=\"avatar\" align=\"absmiddle\"><br><b>"
         . _AM_ADSLIGHT_REPIMGCAT
         . '</b><br>../modules/adslight/assets/images/img_cat/..</td></tr>';

    echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_DISPLPRICE2 . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"affprice\" value=\"1\"";
    if ($affprice == '1') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_OUI . "&nbsp;&nbsp; <input type=\"radio\" name=\"affprice\" value=\"0\"";
    if ($affprice == '0') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_NON . ' (' . _AM_ADSLIGHT_INTHISCAT . ')</td></tr>';

    echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_MODERATE_CAT . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"cat_moderate\" value=\"1\"";
    if ($cat_moderate == '1') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_OUI . "&nbsp;&nbsp; <input type=\"radio\" name=\"cat_moderate\" value=\"0\"";
    if ($cat_moderate == '0') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_NON . '</td></tr>';

    echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_MODERATE_SUBCATS . " </td><td class=\"odd\" colspan=2><input type=\"radio\" name=\"moderate_subcat\" value=\"1\"";
    if ($moderate_subcat == '1') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_OUI . "&nbsp;&nbsp; <input type=\"radio\" name=\"moderate_subcat\" value=\"0\"";
    if ($moderate_subcat == '0') {
        echo 'checked';
    }
    echo '>' . _AM_ADSLIGHT_NON . '</td></tr>';

    if ($xoopsModuleConfig['adslight_csortorder'] !== 'title') {
        echo "<tr><td class=\"even\">" . _AM_ADSLIGHT_ORDRE . " </td><td class=\"odd\"><input type=\"text\" name=\"ordre\" size=\"4\" value=\"$ordre\"></td></tr>";
    } else {
        $ordre = (int)$ordre;
        echo "<input type=\"hidden\" name=\"ordre\" value=\"$ordre\">";
    }

    echo '</table>';

    echo "<input type=\"hidden\" name=\"cidd\" value=\"$cid\">"
         . "<input type=\"hidden\" name=\"op\" value=\"AdsModCatS\">"
         . "<table class=\"foot\" border=\"0\"><tr><td width=\"20%\"><br>"

         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_SAVMOD
         . "\"></form></td><td><br>"
         . "<form action=\"category.php\" method=\"post\">"
         . "<input type=\"hidden\" name=\"cid\" value=\"$cid\">"
         . "<input type=\"hidden\" name=\"op\" value=\"AdsDelCat\">"
         . "<input type=\"submit\" value=\""
         . _AM_ADSLIGHT_DEL
         . "\"></form></td></tr></table>";
    echo '</fieldset><br>';
    xoops_cp_footer();
}

#  function AdsModCatS
#####################################################
/**
 * @param $cidd
 * @param $cid
 * @param $img
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $ordre
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function AdsModCatS(
    $cidd,
    $cid,
    $img,
    $title,
    $cat_desc,
    $cat_keywords,
    $ordre,
    $affprice,
    $cat_moderate,
    $moderate_subcat
) {
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName;
function myFunction($a, $b) {
    // Do something
}

    $title = $myts->htmlSpecialChars($title);
    $cidd  = (int)$cidd;

    $xoopsDB->query('UPDATE '
                    . $xoopsDB->prefix('adslight_categories')
                    . " SET title='$title', cat_desc='$cat_desc', cat_keywords='$cat_keywords', pid='$cid', img='$img', ordre='$ordre', affprice='$affprice', cat_moderate='$cat_moderate', moderate_subcat='$moderate_subcat' WHERE cid=$cidd");

    if ($moderate_subcat != 1) {

        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0, moderate_subcat=0 WHERE pid = ' . $xoopsDB->escape($cidd) . '');
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=1, moderate_subcat=1 WHERE pid = ' . $xoopsDB->escape($cidd) . '');
    }

    redirect_header('map.php', 10, _AM_ADSLIGHT_CATSMOD);
}

#  function AdsAddCat
#####################################################
/**
 * @param $title
 * @param $cat_desc
 * @param $cat_keywords
 * @param $cid
 * @param $img
 * @param $ordre
 * @param $affprice
 * @param $cat_moderate
 * @param $moderate_subcat
 */
function AdsAddCat($title, $cat_desc, $cat_keywords, $cid, $img, $ordre, $affprice, $cat_moderate, $moderate_subcat)
{
    global $xoopsDB, $xoopsConfig, $myts, $moduleDirName;
function myFunction($a, $b) {
    // Do something
}

    $title           = $myts->htmlSpecialChars($title);
    $moderate_subcat = (int)$moderate_subcat;
    if ($title == '') {
        $title = '! ! ? ! !';
    }

    $xoopsDB->query('insert into '
                    . $xoopsDB->prefix('adslight_categories')
                    . " values (NULL, '$cid', '$title', '$cat_desc', '$cat_keywords', '$img', '$ordre', '$affprice', '$cat_moderate', '$moderate_subcat')");

    if ($moderate_subcat = 1) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=1 WHERE pid = ' . $xoopsDB->escape($cid) . '');
    } else {
        $xoopsDB->queryF('UPDATE ' . $xoopsDB->prefix('adslight_categories') . ' SET cat_moderate=0 WHERE pid = ' . $xoopsDB->escape($cid) . '');
    }

    redirect_header('map.php', 3, _AM_ADSLIGHT_CATADD);
}

#  function AdsDelCat
#####################################################
/**
 * @param     $cid
 * @param int $ok
 */
function AdsDelCat($cid, $ok = 0)
{
    global $xoopsDB, $xoopsConfig, $xoopsModule, $moduleDirName;
function myFunction($a, $b) {
    // Do something
}

    if ((int)$ok == 1) {
        $xoopsDB = XoopsDatabaseFactory::getDatabaseConnection();
        $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_categories') . " WHERE cid=$cid or pid=$cid");
        $xoopsDB->queryF('DELETE FROM ' . $xoopsDB->prefix('adslight_listing') . " WHERE cid=$cid");

        redirect_header('map.php', 1, _AM_ADSLIGHT_CATDEL);
    } else {
        include_once __DIR__ . '/header.php';
        //        loadModuleAdminMenu(1, "");


        OpenTable();
        echo '<br><center><b>' . _AM_ADSLIGHT_SURDELCAT . '</b><br><br>';
        echo "[ <a href=\"category.php?op=AdsDelCat&cid=$cid&ok=1\">" . _AM_ADSLIGHT_OUI . "</a> | <a href=\"map.php\">" . _AM_ADSLIGHT_NON . '</a> ]<br><br>';
        CloseTable();
        xoops_cp_footer();
    }
}

#####################################################
//@todo REMOVE THIS ASAP!  This code is extremely unsafe
foreach ($_POST as $k => $v) {
    ${$k} = $v;
}

$ok  = XoopsRequest::getString('ok', '', 'GET');
$cid = XoopsRequest::getInt('cid', 0);
$op  = XoopsRequest::getCmd('op', '');

switch ($op) {

    case 'AdsNewCat':
        AdsNewCat($cid);
        break;

    case 'AdsAddCat':
        AdsAddCat($title, $cat_desc, $cat_keywords, $cid, $img, $ordre, $affprice, $cat_moderate, $moderate_subcat);
        break;

    case 'AdsDelCat':
        AdsDelCat($cid, $ok);
        break;

    case 'AdsModCat':
        AdsModCat($cid);
        break;

    case 'AdsModCatS':
        AdsModCatS($cidd, $cid, $img, $title, $cat_desc, $cat_keywords, $ordre, $affprice, $cat_moderate, $moderate_subcat);
        break;

    default:
        Index();
        break;

}


Push — master ( 923121...f83415 )

category.php ➔ AdsModCat() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-04-29 08:07 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 33 and the first side effect is on line 23. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			/*
3			-------------------------------------------------------------------------
4			ADSLIGHT 2 : Module for Xoops
5
6			Redesigned and ameliorate By Luc Bizet user at www.frxoops.org
7			Started with the Classifieds module and made MANY changes
8			Website : http://www.luc-bizet.fr
9			Contact : [email protected]
10			-------------------------------------------------------------------------
11			Original credits below Version History
12			##########################################################################
13			# Classified Module for Xoops #
14			# By John Mordo user jlm69 at www.xoops.org and www.jlmzone.com #
15			# Started with the MyAds module and made MANY changes #
16			##########################################################################
17			Original Author: Pascal Le Boustouller
18			Author Website : [email protected]
19			Licence Type : GPL
20			-------------------------------------------------------------------------
21			*/
22
23			include_once __DIR__ . '/admin_header.php';
24			xoops_cp_header();
25
26			$op = XoopsRequest::getCmd('op', 'liste');
27
28			# function AdsNewCat
29			#####################################################
30			/**
31			* @param $cat
32			*/
33			function AdsNewCat($cat)
34			{
35			global $xoopsDB, $xoopsConfig, $xoopsModule, $xoopsModuleConfig, $myts, $moduleDirName;
			1 ignored issue – show Compatibility Best Practice introduced 2016-01-18 09:35 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
36
37			$mytree = new ClassifiedsTree($xoopsDB->prefix('adslight_categories'), 'cid', 'pid');
38

mambax7 / adslight

Push — master ( 923121...f83415 )

category.php ➔ AdsModCat() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like